Checkmk git commits January 2019

checkmk-commits@lists.checkmk.com

15 participants
490 discussions

6958 FIX Check_MK Check: Don't crash upon keepalive timeout

by Moritz Kiemer

Module: check_mk Branch: master Commit: 1519896b2a1ee46626676c965213c7c0e75a6a53 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1519896b2a1ee4… Author: Moritz Kiemer <mo(a)mathias-kettner.de> Date: Fri Jan 18 07:57:34 2019 +0100 6958 FIX Check_MK Check: Don't crash upon keepalive timeout MKException no longer produces a crash when the __str__ method of an exception instanciated without arguments is called. This could obfuscate the actual Traceback. Change-Id: I82872a162f0c5a24b615a608dcf92920c5557a76 --- .werks/6958 | 9 +++++++++ cmk/utils/exceptions.py | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/.werks/6958 b/.werks/6958 new file mode 100644 index 0000000..a0b3492 --- /dev/null +++ b/.werks/6958 @@ -0,0 +1,9 @@ +Title: Check_MK Check: Don't crash upon keepalive timeout +Level: 1 +Component: checks +Compatible: compat +Edition: cee +Version: 1.6.0i1 +Date: 1547794513 +Class: fix + diff --git a/cmk/utils/exceptions.py b/cmk/utils/exceptions.py index 3273e5c..edaa9cd 100644 --- a/cmk/utils/exceptions.py +++ b/cmk/utils/exceptions.py @@ -43,7 +43,7 @@ class MKException(Exception): # have this variable set. self.args[0] seems to be the most portable # way at the moment. def __str__(self): - return self.args[0] + return self.args[0] if self.args else '' class MKGeneralException(MKException):

5 years, 8 months

Fixed side effect of local_test_host fixture breaking test_get_graph_api test

by Lars Michelsen

Module: check_mk Branch: master Commit: 455193d206e72bf72f580aef9ed71c1f2929084f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=455193d206e72b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 18 09:02:51 2019 +0100 Fixed side effect of local_test_host fixture breaking test_get_graph_api test Change-Id: I7a91dfe427b9fff0f0d59b3a092e19052d85552c --- tests/integration/cmk/gui/test_webapi.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/integration/cmk/gui/test_webapi.py b/tests/integration/cmk/gui/test_webapi.py index 83f6e5e..64e9fdf 100644 --- a/tests/integration/cmk/gui/test_webapi.py +++ b/tests/integration/cmk/gui/test_webapi.py @@ -24,7 +24,8 @@ def local_test_host(web, site): site.write_file( "etc/check_mk/conf.d/test-host.mk", - "datasource_programs.append(('cat ~/var/check_mk/agent_output/<HOST>', [], ALL_HOSTS))\n") + "datasource_programs.append(('cat ~/var/check_mk/agent_output/<HOST>', [], ['test-host']))\n" + ) site.makedirs("var/check_mk/agent_output/") site.write_file( @@ -33,6 +34,7 @@ def local_test_host(web, site): yield web.delete_host("test-host") + site.delete_file("etc/check_mk/conf.d/test-host.mk") def test_global_settings(site, web):

5 years, 8 months

k8s_pods_cm: don't import parse_frac_prefix from cmk module

by Tom Baerwinkel

Module: check_mk Branch: master Commit: 1558783f2fad1698e8ab1a7c90c31e8dd558cd80 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1558783f2fad16… Author: Tom Baerwinkel <tb(a)mathias-kettner.de> Date: Thu Jan 17 18:09:27 2019 +0100 k8s_pods_cm: don't import parse_frac_prefix from cmk module Change-Id: Ifa7dee608451811719797d96b1572294fa7a2a89 --- checks/k8s_pods_cm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/checks/k8s_pods_cm b/checks/k8s_pods_cm index 037969e..2ceb085 100644 --- a/checks/k8s_pods_cm +++ b/checks/k8s_pods_cm @@ -24,7 +24,12 @@ # to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, # Boston, MA 02110-1301 USA. -from cmk.special_agents.agent_kubernetes import parse_frac_prefix + +def parse_frac_prefix(value): + # type: (str) -> float + if value.endswith('m'): + return 0.001 * float(value[:-1]) + return float(value) def parse_mul_prefix(value):

5 years, 8 months

Reserved 20 Werk IDS

by Simon Betz

Module: check_mk Branch: master Commit: 3bc97ecb14af41727a41c9f9ab285b7c3026faa5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3bc97ecb14af41… Author: Simon Betz <si(a)mathias-kettner.de> Date: Thu Jan 17 17:19:11 2019 +0100 Reserved 20 Werk IDS Change-Id: Ib7418067944aa17f07804ff64b962dfde04181db --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index 1c0e343..64aee72 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -7091 +7111

5 years, 8 months

Moved bulk discovery logic to watolib

by Lars Michelsen

Module: check_mk Branch: master Commit: 03f5a5314be5462853b890efaa011df6ec4e2c52 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=03f5a5314be546… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jan 16 17:49:17 2019 +0100 Moved bulk discovery logic to watolib * BulkDiscoveryBackgroundJob * vs_bulk_discovery Change-Id: I1febede36c375ff28b56782fc1187cac80311db2 --- cmk/gui/plugins/wato/__init__.py | 1 - cmk/gui/plugins/wato/check_mk_configuration.py | 2 +- cmk/gui/plugins/wato/utils/__init__.py | 53 ------ cmk/gui/wato/pages/bulk_discovery.py | 153 ++--------------- cmk/gui/watolib/bulk_discovery.py | 221 +++++++++++++++++++++++++ 5 files changed, 235 insertions(+), 195 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=03f5a5314b…

5 years, 8 months

7073 New API call to control bulk discovery

by Lars Michelsen

Module: check_mk Branch: master Commit: d7302d02a6e10d16bce7b62345aa32a12752384a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d7302d02a6e10d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jan 17 09:02:35 2019 +0100 7073 New API call to control bulk discovery Two new web API calls have been added for the bulk discovery. The call <tt>bulk_discovery_start</tt> has been added to start a bulk discovery for a collection of hosts which will be executed asynchronously. The call <tt>bulk_discovery_status</tt> can be used to get the status of such a job. The <tt>bulk_discovery_start</tt> call requires the <tt>hostnames</tt> parameter to be a list of host names to execute the discovery for. It accepts the following optional keys: <ul> <li>mode (default: "new")</li> <li>use_cache (default: True)</li> <li>do_scan (default: True)</li> <li>bulk_size (default: 10)</li> <li>ignore_single_check_errors (default: True)</li> </ul> The defaults may be customized using the global setting <i>Bulk discovery</i>. The global setting also describes the possible options in detail. The <tt>bulk_discovery_status</tt> call does not accept any parameter. Change-Id: I7e01458246a5abc68026a7330a202f19ec1ca093 --- .werks/7073 | 31 +++++++ cmk/gui/plugins/webapi/bulk_discovery.py | 141 +++++++++++++++++++++++++++++++ cmk/gui/wato/pages/bulk_discovery.py | 31 ++----- cmk/gui/watolib/bulk_discovery.py | 34 ++++++-- tests/integration/cmk/gui/test_webapi.py | 81 +++++++++++++++++- tests/testlib/__init__.py | 14 +++ tests/unit/cmk/gui/test_webapi_unit.py | 2 + 7 files changed, 304 insertions(+), 30 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=d7302d02a6…

5 years, 8 months

7072 Availability: Plugin output can now be hidden from availability timeline

by Lars Michelsen

Module: check_mk Branch: master Commit: bfa148ae3764ce6f5c0f2a395524cb81a72de038 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bfa148ae3764ce… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Jan 16 15:14:13 2019 +0100 7072 Availability: Plugin output can now be hidden from availability timeline The last known plugin output column can now be hidden from the availability timeline view and report to make the report show a bit less detailed information. CMK-921 Change-Id: I12ad7596949755aafe340f5e15acd32d75be9599 --- .werks/7072 | 11 +++++++++++ cmk/gui/availability.py | 1 + cmk/gui/plugins/views/availability.py | 4 +++- 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/.werks/7072 b/.werks/7072 new file mode 100644 index 0000000..73c814b --- /dev/null +++ b/.werks/7072 @@ -0,0 +1,11 @@ +Title: Availability: Plugin output can now be hidden from availability timeline +Level: 1 +Component: multisite +Compatible: compat +Edition: cre +Version: 1.6.0i1 +Date: 1547647999 +Class: feature + +The last known plugin output column can now be hidden from the availability timeline +view and report to make the report show a bit less detailed information. diff --git a/cmk/gui/availability.py b/cmk/gui/availability.py index 4810d6d..13f02f8 100644 --- a/cmk/gui/availability.py +++ b/cmk/gui/availability.py @@ -165,6 +165,7 @@ def get_av_display_options(what): ("show_alias", _("Display the host alias")), ("use_display_name", _("Use alternative display name for services")), ("omit_buttons", _("Do not display icons for history and timeline")), + ("omit_timeline_plugin_output", _("Do not display plugin output in timeline")), ("display_timeline_legend", _("Display legend for timeline")), ("omit_av_levels", _("Do not display legend for availability levels")), ])), diff --git a/cmk/gui/plugins/views/availability.py b/cmk/gui/plugins/views/availability.py index f458d01..466032c 100644 --- a/cmk/gui/plugins/views/availability.py +++ b/cmk/gui/plugins/views/availability.py @@ -418,7 +418,9 @@ def render_availability_timeline(what, av_entry, avoptions): table.cell(_("Until"), row["until_text"], css="nobr narrow") table.cell(_("Duration"), row["duration_text"], css="narrow number") table.cell(_("State"), row["state_name"], css=row["css"] + " state narrow") - table.cell(_("Last Known Plugin Output"), row.get("log_output", "")) + + if "omit_timeline_plugin_output" not in avoptions["labelling"]: + table.cell(_("Last Known Plugin Output"), row.get("log_output", "")) # Legend for timeline if "display_timeline_legend" in avoptions["labelling"]:

5 years, 8 months

Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393)

by Kenneth Okoh

Module: check_mk Branch: master Commit: c16e3471c1abd6d9fb6e564403de9a59c91d9654 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c16e3471c1abd6… Author: Kenneth Okoh <ko(a)mathias-kettner.de> Date: Fri Jan 11 17:55:38 2019 +0100 Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393) Change-Id: I71e503a89f7682286a375da6476dd34232104711 --- .../wato/check_parameters/esx_host_memory.py | 49 ++++ .../wato/check_parameters/esx_vsphere_objects.py | 89 +++++++ .../check_parameters/esx_vsphere_objects_count.py | 65 +++++ .../wato/check_parameters/services_summary.py | 62 +++++ .../check_parameters/solaris_services_summary.py | 47 ++++ cmk/gui/plugins/wato/check_parameters/unsorted.py | 277 --------------------- .../wato/check_parameters/vm_guest_tools.py | 67 +++++ .../plugins/wato/check_parameters/vm_heartbeat.py | 71 ++++++ .../check_parameters/windows_printer_queues.py | 116 +++++++++ 9 files changed, 566 insertions(+), 277 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=c16e3471c1…

5 years, 8 months

Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393)

by Kenneth Okoh

Module: check_mk Branch: master Commit: d5eaaa818ff56a2b94829dbe3a87ed01a7ce7b9b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d5eaaa818ff56a… Author: Kenneth Okoh <ko(a)mathias-kettner.de> Date: Fri Jan 11 14:30:58 2019 +0100 Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393) Change-Id: Iea507b61ef359c509f6a7520c0f3fe4a07b5dc21 --- .../plugins/wato/check_parameters/apache_status.py | 65 ++++ cmk/gui/plugins/wato/check_parameters/apc_power.py | 60 +++ .../wato/check_parameters/fileinfo-groups.py | 181 +++++++++ cmk/gui/plugins/wato/check_parameters/fileinfo.py | 84 ++++ .../wato/check_parameters/memory_pagefile_win.py | 114 ++++++ .../wato/check_parameters/netapp_fcportio.py | 59 +++ .../plugins/wato/check_parameters/nginx_status.py | 56 +++ .../plugins/wato/check_parameters/sap_dialog.py | 72 ++++ .../wato/check_parameters/saprouter_cert_age.py | 53 +++ cmk/gui/plugins/wato/check_parameters/unsorted.py | 421 --------------------- cmk/gui/plugins/wato/check_parameters/ups_test.py | 56 +++ 11 files changed, 800 insertions(+), 421 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=d5eaaa818f…

5 years, 8 months

Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393)

by Kenneth Okoh

Module: check_mk Branch: master Commit: 434f436adf01423436585eeb167f2e961684b34b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=434f436adf0142… Author: Kenneth Okoh <ko(a)mathias-kettner.de> Date: Fri Jan 11 16:21:44 2019 +0100 Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393) Change-Id: I980192061fc7d6d6f36c905f21aa9f513d0de6f2 --- .../check_parameters/docsis_channels_downstream.py | 51 ++++ .../check_parameters/docsis_channels_upstream.py | 65 +++++ .../wato/check_parameters/docsis_cm_status.py | 74 ++++++ .../wato/check_parameters/enterasys_powersupply.py | 55 +++++ .../wato/check_parameters/hivemanager_devices.py | 89 +++++++ .../check_parameters/hivemanager_ng_devices.py | 55 +++++ cmk/gui/plugins/wato/check_parameters/lsnat.py | 51 ++++ .../plugins/wato/check_parameters/sles_license.py | 71 ++++++ cmk/gui/plugins/wato/check_parameters/unsorted.py | 275 --------------------- .../wato/check_parameters/viprinet_router.py | 55 +++++ .../plugins/wato/check_parameters/vpn_tunnel.py | 84 +++++++ 11 files changed, 650 insertions(+), 275 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=434f436adf…

5 years, 8 months

← Newer
1
...
19
20
21
22
23
24
25
...
49
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2019