Checkmk git commits September 2011

checkmk-commits@lists.checkmk.com

3 participants
125 discussions

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 07e7bda728b3a9462deb079904fffeb233134db2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=07e7bda728b3a9… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Sep 29 16:00:08 2011 +0200 Updated bug entries --- .bugs/393 | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/.bugs/393 b/.bugs/393 new file mode 100644 index 0000000..3c4e699 --- /dev/null +++ b/.bugs/393 @@ -0,0 +1,10 @@ +Title: Page about configvars misses inventory checks +Component: doku +Benefit: 1 +State: open +Cost: 1 +Date: 2011-09-29 15:59:32 +Class: cleanup + +Add the two variables with a small text and a link to the +article about inventory checks.

12 years, 10 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 4e9412e2ac9deff32f51049c0b1d540ffeacc91b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4e9412e2ac9def… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Sep 23 16:32:56 2011 +0200 Updated bug entries --- .bugs/391 | 11 +++++++++++ .bugs/392 | 10 ++++++++++ 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/.bugs/391 b/.bugs/391 new file mode 100644 index 0000000..c0f7eee --- /dev/null +++ b/.bugs/391 @@ -0,0 +1,11 @@ +Title: livestatus: Segfault on invalid log files? +Component: livestatus +Benefit: 1 +State: open +Cost: 1 +Date: 2011-09-23 16:31:10 +Class: bug + +At one installation it happened that - as a result of +a full disk - Nagios log files had been truncated. In +that case Livestatus seems to segfault. diff --git a/.bugs/392 b/.bugs/392 new file mode 100644 index 0000000..01be137 --- /dev/null +++ b/.bugs/392 @@ -0,0 +1,10 @@ +Title: non-Ascii-Characters in host aliases via WATO make Check_MK murk +Component: wato +Benefit: 1 +State: open +Cost: 1 +Date: 2011-09-23 16:32:10 +Class: bug + +In some cases non-Ascii characters in WATO data make +Check_MK when it creates the configuration

12 years, 10 months

Check_MK Git: check_mk: Reserved 20 bug IDS

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 4ee13100d1419830abbc55a08705f2147a4008ee URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4ee13100d14198… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Sep 23 16:31:05 2011 +0200 Reserved 20 bug IDS --- .bugs/first_free | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/.bugs/first_free b/.bugs/first_free index b570ddb..617de7e 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -391 +411

12 years, 10 months

Check_MK Git: check_mk: FIX: mk_oracle: fix cache file handling

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 0feaa4ade065c6493a694e1e96ba736a81e2163f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0feaa4ade065c6… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Sep 21 13:53:12 2011 +0200 FIX: mk_oracle: fix cache file handling --- ChangeLog | 5 ++++- agents/plugins/mk_oracle | 8 +++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index f58ccab..0e4a5eb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -3,11 +3,14 @@ * FIX: fix cmk -D on cluster hosts Checks & Agents: - * FIX: j4p_performance: fix inventory functions + * FIX: j4p_performance: fix inventory functions + * FIX: mk_oracle: fix race condition in cache file handling (agent data + was missing sections in certain situations) * mrpe: make check cluster-aware and work as clustered_service * cups_queues: Run agent part only on directly on CUPS servers, not on clients + Multisite: * FIX: fix rescheduling of host check * FIX: fix exception when using status_host while local site is offline diff --git a/agents/plugins/mk_oracle b/agents/plugins/mk_oracle index ad0f114..98890fb 100755 --- a/agents/plugins/mk_oracle +++ b/agents/plugins/mk_oracle @@ -80,7 +80,11 @@ for SID in $SIDS; do fi fi - # Outputs the contents of the cache file when it exists and is recent enough. + # If the cache file exists, output it, regardless of its age. If it's outdated + # then it will be recreated *asynchronously*, we the new contents will not + # be available here anyway. + if [ -s "$CACHE_FILE" ] ; then cat "$CACHE_FILE" ; fi + # When not it checks if there is another task to update the cache is running # at the moment (*.new) file present. # When the cache is old and there is no *new file present, then start a query @@ -117,7 +121,5 @@ EOF fi } > $CACHE_FILE.new && mv $CACHE_FILE.new $CACHE_FILE || rm -f $CACHE_FILE* " - else - cat "$CACHE_FILE" fi done

12 years, 10 months

Check_MK Git: check_mk: <<<cups_queue>>>: run agent section only on CUPS servers

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 1984d1e45044dfda19e71b01f8370567050cb3e6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1984d1e45044df… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Sep 20 08:37:09 2011 +0200 <<<cups_queue>>>: run agent section only on CUPS servers --- ChangeLog | 2 ++ agents/check_mk_agent.linux | 14 +++++++------- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index e88f145..f58ccab 100644 --- a/ChangeLog +++ b/ChangeLog @@ -5,6 +5,8 @@ Checks & Agents: * FIX: j4p_performance: fix inventory functions * mrpe: make check cluster-aware and work as clustered_service + * cups_queues: Run agent part only on directly on CUPS servers, + not on clients Multisite: * FIX: fix rescheduling of host check diff --git a/agents/check_mk_agent.linux b/agents/check_mk_agent.linux index b08b1f8..a985ff4 100755 --- a/agents/check_mk_agent.linux +++ b/agents/check_mk_agent.linux @@ -316,14 +316,14 @@ if [ -e /proc/drbd ]; then cat /proc/drbd fi -# Checks for cups monitoring +# Status of CUPS printer queues if which lpstat > /dev/null 2>&1; then - echo '<<<cups_queues>>>' - waitmax 3 lpstat -p - echo '---' - for i in $(waitmax 3 lpstat -p | grep -E "^(printer|Drucker)" | awk '{print $2}' | grep -v "@"); do - waitmax 3 lpstat -o "$i" - done + if pgrep cups > /dev/null 2>&1; then + echo '<<<cups_queues>>>' + waitmax 3 lpstat -p + echo '---' + waitmax 3 lpstat -o|sort + fi fi # Heartbeat monitoring

12 years, 10 months

Check_MK Git: check_mk: Added new bug entry

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: e22e261eea9072ec0e58df037b77ac87dd492d12 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e22e261eea9072… Author: Florian Heigl <fh(a)mathias-kettner.de> Date: Mon Sep 19 09:47:08 2011 +0300 Added new bug entry --- .bugs/319 | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/.bugs/319 b/.bugs/319 new file mode 100644 index 0000000..f737e45 --- /dev/null +++ b/.bugs/319 @@ -0,0 +1,9 @@ +Title: meinberg refclock reporting 44k ms offset instead of 44ms +Component: checks +Benefit: 6 +State: open +Cost: 3 +Date: 2011-09-19 09:45:55 +Class: bug + +The reference clock check seems to be off by a factor of 1000.

12 years, 10 months

Check_MK Git: check_mk: FIX: fix cmk -D on cluster hosts

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: d2b93aba6624779aae3a1b9a6abe13ed62a81bb6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d2b93aba662477… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Sep 16 11:05:03 2011 +0200 FIX: fix cmk -D on cluster hosts --- ChangeLog | 3 +++ modules/check_mk.py | 4 ++++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index d3c66bd..e88f145 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,7 @@ 1.1.12b1: + Core, Setup, etc.: + * FIX: fix cmk -D on cluster hosts + Checks & Agents: * FIX: j4p_performance: fix inventory functions * mrpe: make check cluster-aware and work as clustered_service diff --git a/modules/check_mk.py b/modules/check_mk.py index d69efe2..a6bb428 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -3137,6 +3137,10 @@ def dump_host(hostname): if is_cluster(hostname): color = tty_bgmagenta add_txt = " (cluster of " + (",".join(nodes_of(hostname))) + ")" + try: + ipaddress = lookup_ipaddress(hostname) + except: + ipaddress = "0.0.0.0" else: color = tty_bgblue try:

12 years, 10 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 37b60e0ddb4fa7549e47bc9941a3957dd1a2aa98 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=37b60e0ddb4fa7… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Sep 16 09:36:28 2011 +0200 Updated bug entries --- .bugs/375 | 29 +++++++++++++++++++++++++++++ 1 files changed, 29 insertions(+), 0 deletions(-) diff --git a/.bugs/375 b/.bugs/375 new file mode 100644 index 0000000..e689505 --- /dev/null +++ b/.bugs/375 @@ -0,0 +1,29 @@ +Title: Clusterchecks: make host name available to check +Component: core +Benefit: 2 +State: open +Cost: 2 +Date: 2011-09-16 09:31:24 +Class: feature + +Problem: When using cluster checks, the check itself has no +information, on which node of the cluster a certain check item +has been found. If we would have that information, we could +output something like "OK - running on node zbghora10". + +We could extend the API for checks in a way, that the check +can *declare* that it always wants the name of the host as +an additional (first) column in the info table. This can +be done with the new dictionary. Checks that are cluster +aware (ps, df, services) can then use that information and +display the node (maybe on a configurable basis). Maybe +we can use None as host name in case the check is not a cluster +check. That way we omit useless data on non-clustered checks. + +Check_MK need then internally to conserve that information +in case of cluster checks. The logic for the non-cluster-checks +must not be changed or be degraded in performance. + +==> That way the API for the checks keeps compatible and +we have the "running on" information, which is also usefull +for BI.

12 years, 10 months

Check_MK Git: check_mk: mrpe: make check cluster-aware and work as clustered_service

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: c57a8b1ee6ced657ba334ce35f2620a683d31ede URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c57a8b1ee6ced6… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Sep 16 09:55:56 2011 +0200 mrpe: make check cluster-aware and work as clustered_service --- ChangeLog | 1 + checkman/mrpe | 8 ++++++++ checks/mrpe | 18 ++++++++++++++++-- 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index ba572e7..d3c66bd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,7 @@ 1.1.12b1: Checks & Agents: * FIX: j4p_performance: fix inventory functions + * mrpe: make check cluster-aware and work as clustered_service Multisite: * FIX: fix rescheduling of host check diff --git a/checkman/mrpe b/checkman/mrpe index bfbcf6b..640bb11 100644 --- a/checkman/mrpe +++ b/checkman/mrpe @@ -16,6 +16,14 @@ description: no parameters are needed here. Please refer to the online documentation on how to configure the agent. + The current version of the {mrpe} check is now cluster-aware + and works well as a {clustered_service} (see article about + Check_MK cluster monitoring). If an MRPE check is found on + more than one node, then the best status of the checks is + being used. So if the check is critical on one of the nodes + and OK on another then the status, output and performance + data of the OK check is being used as the gross result of the check. + item: The service description of the check as configured in {mrpe.cfg} on the target host. diff --git a/checks/mrpe b/checks/mrpe index ce6a618..a79eff5 100644 --- a/checks/mrpe +++ b/checks/mrpe @@ -38,6 +38,12 @@ def inventory_mrpe(info): def check_mrpe(item, params, info): + # This check is cluster-aware. An item might be found + # more than once. In that case we use the best of the + # multiple statuses. + + best_state = None + for line in info: if line[0].startswith("("): check_name = line[0][1:-1] @@ -65,8 +71,16 @@ def check_mrpe(item, params, info): # name of check command needed for PNP to choose the correct template if check_name: perfdata.append(check_name) - return (state, output, perfdata) - return (3, "Check output not found in local checks") + + if best_state in [ None, 2 ] \ + or (state < best_state and state != 2): + best_result = state, output, perfdata + best_state = state + + if best_state == None: + return (3, "Check output not found in local checks") + else: + return best_result check_info['mrpe'] = (

12 years, 10 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 936206789c6a82c37b20e576497005eb68d6be9f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=936206789c6a82… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Sep 15 17:08:30 2011 +0200 Updated bug entries --- .bugs/374 | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/.bugs/374 b/.bugs/374 index 67d53cd..72cc862 100644 --- a/.bugs/374 +++ b/.bugs/374 @@ -9,3 +9,6 @@ Class: cleanup The documentation article about SNMP does not explain how to setup SNMPv2C (bulkwalk_hosts). This is important! Refer also to if64 and netapp(without 32). + +Also the configvars page say that bulkwalk is the default. +That is wrong!

12 years, 10 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2011