Checkmk git commits October 2022

checkmk-commits@lists.checkmk.com

1 participants
575 discussions

[tribe29/checkmk] 51f36e: 13431 FIX Fix async checks blocked by realtime checks

by Moritz

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 51f36e57fc8ad762fccde5383408dd3dca65609f https://github.com/tribe29/checkmk/commit/51f36e57fc8ad762fccde5383408dd3dc… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: A .werks/13431 M agents/check_mk_agent.linux Log Message: ----------- 13431 FIX Fix async checks blocked by realtime checks When realtime checks were configured, async checks were not executed. Closes #522. Change-Id: I50f489a0fb7d73f4b56c47460b3abcb92db194da

1 year, 10 months

[tribe29/checkmk] 084067: Revert "Remove unused msi file"

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 084067355cdde99b87ea4f4ec6b6fda538cf216c https://github.com/tribe29/checkmk/commit/084067355cdde99b87ea4f4ec6b6fda53… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: A omd/packages/msitools/baked_container.msi Log Message: ----------- Revert "Remove unused msi file" It breaks our builds because: install -m 644 omd/packages/msitools/*.msi omd/build/intermediate_install/msitools-0.94/share/check_mk/agents/windows install: cannot stat 'omd/packages/msitools/*.msi': No such file or directory Investigate this in CMK-11592 This reverts commit c29e7bf5796e33a5fbd421496f8b35e378dbb010.

1 year, 10 months

[tribe29/checkmk] 09c3d3: Fix endless waiting for `omd-config-change`

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 09c3d357074169464f802e646f63c87c17b8957d https://github.com/tribe29/checkmk/commit/09c3d357074169464f802e646f63c87c1… Author: Maximilian Wirtz <maximilian.wirtz(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M cmk/gui/watolib/activate_changes.py Log Message: ----------- Fix endless waiting for `omd-config-change` The central site waits for a omd-config-change job, but the job is never started when the settings are empty. Change-Id: I3dabf207c40789bfcd0f6e8ba47b01af3b55b912 Commit: 761035ec3271b3c3f21864be386445a60d5bbcbd https://github.com/tribe29/checkmk/commit/761035ec3271b3c3f21864be386445a60… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M livestatus/src/DynamicEventConsoleReplicationColumn.cc M livestatus/src/Store.cc M livestatus/src/Store.h Log Message: ----------- Unify EC communication code a little bit. Change-Id: I3e902acfedf272ddc1cbb7bea82eb8a2ea692834 Compare: https://github.com/tribe29/checkmk/compare/bdc0dee66e9f...761035ec3271

1 year, 10 months

[tribe29/checkmk] bdc0de: 14686 FIX Added timeout to event console communica...

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: bdc0dee66e9f7a564c422a973c09de6c1edfa0e3 https://github.com/tribe29/checkmk/commit/bdc0dee66e9f7a564c422a973c09de6c1… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: A .werks/14686 M livestatus/src/EventConsoleConnection.cc Log Message: ----------- 14686 FIX Added timeout to event console communication An unresponsive event console could eat up Livestatus connections and even cause a deadlock during the shutdown of the monitoring core. Now there is timeout of 10s, after that you get a timeout error for the Livestatus query or action. Change-Id: Id2f4c1c0e2e146ded29217fc1482110ad1981a20

1 year, 10 months

[tribe29/checkmk] fe16cc: Remove HostConfig dep from error_handling

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: fe16cc87f17926e6d45b0bf159db63eb347bbf94 https://github.com/tribe29/checkmk/commit/fe16cc87f17926e6d45b0bf159db63eb3… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M cmk/base/agent_based/checking/active.py M cmk/base/agent_based/checking/commandline.py M cmk/base/agent_based/discovery/active.py M cmk/base/agent_based/discovery/commandline.py M cmk/base/agent_based/error_handling.py M cmk/base/agent_based/inventory/active.py M tests/unit/cmk/base/agent_based/test_error_handling.py Log Message: ----------- Remove HostConfig dep from error_handling CMK-10515 Change-Id: Ia0fc6ae1218cf0bebdfed075f7ba314ee44e01ba Commit: 58604c592dee3c2534466cb25e44c7386dd4bf9c https://github.com/tribe29/checkmk/commit/58604c592dee3c2534466cb25e44c7386… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M cmk/base/agent_based/error_handling.py Log Message: ----------- Remove base deps from error_handling CMK-10515 Change-Id: I8c8b17e9c160d24ae46dbdae6b4640298743f311 Commit: 4b46e75007afa45f5f2641057548db455fc8fcc9 https://github.com/tribe29/checkmk/commit/4b46e75007afa45f5f2641057548db455… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M cmk/base/agent_based/checking/_checking.py M cmk/base/config.py M tests/unit/cmk/base/agent_based/checking/test_checking.py M tests/unit/cmk/base/test_config.py Log Message: ----------- Move `get_clustered_service_node_keys()` to its single caller The function was on ConfigCache but had a single call-site. This patch moves the function where it's actually needed. This improves the cohesion of `agent_based`. Also, the `HostKey` type is now only used in `agent_based`. CMK-10515 Change-Id: Ie404877d28431d69722d0c27ef7664ac15e77c18 Compare: https://github.com/tribe29/checkmk/compare/b981b97cc86f...4b46e75007af

1 year, 10 months

[tribe29/checkmk] b981b9: inventory: Minor cleanup

by Simon

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b981b97cc86fab3458cf8ad977240399e3da8b13 https://github.com/tribe29/checkmk/commit/b981b97cc86fab3458cf8ad977240399e… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M cmk/base/agent_based/inventory/_tree_aggregator.py M tests/unit/cmk/base/agent_based/test_base_inventory.py Log Message: ----------- inventory: Minor cleanup Change-Id: I06e4ff80cc4e8a907a993894d3955ca240997a91

1 year, 10 months

[tribe29/checkmk] e7a850: Revert "Remove unused msi file"

by Timotheus Bachinger

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: e7a850ef7395fca9bd9f0423b4997805f87b06b6 https://github.com/tribe29/checkmk/commit/e7a850ef7395fca9bd9f0423b4997805f… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: A omd/packages/msitools/baked_container.msi Log Message: ----------- Revert "Remove unused msi file" It breaks the testbuild. This reverts commit 0b801b3ff010f90f6b2bb77f028b086b1d57e201.

1 year, 10 months

[tribe29/checkmk] 76cbbb: 14919 SEC Do not log host secret (2)

by Maximilian

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 76cbbba5482442d6bd85844b95075f566fb0efa6 https://github.com/tribe29/checkmk/commit/76cbbba5482442d6bd85844b95075f566… Author: Maximilian Wirtz <maximilian.wirtz(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: A .werks/14919 Log Message: ----------- 14919 SEC Do not log host secret (2) Unfortunately Werk #14916 was insufficient. Therefore the vulnerability still exists. This Werk fixes the problem. When using the <i>Agent updater</i> the Checkmk server needs a secret in order to allow the agent to download new agents. For security reasons this secret is unique for each host and generated with the <tt>cmk-update-agent register</tt> command. Unfortunately the generated host secret was written to the cmk-update-agent.log. This logfile is not protected and usually world-readable. With this secret one can download the current agent from the Checkmk server. Included in that agent package are the plugin configs which can contain other secrets. (e.g. database credentials) Mitigations without updating: LI: Reregister the agent-updater. Then sanitize the cmk-update-agent.log files. LI: If you cannot rule out that any unauthorized user read <tt>/var/lib/check_mk_agent/cmk-update-agent.log</tt> respectively <tt>C:\ProgramData\checkmk\agent\log\cmk-update-agent.log</tt> you should rotate all secrets that might be or were included in the agent configurations. Steps needed with the update: LI: Update your agent. LI: Reregister the agent-updater. All versions including 1.5 are subject to this vulnerability. We found this vulnerability internally and have no indication of any exploitation. We calculated a CVSS 3.1 score of 6.5 (Medium) with the following vector: CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:C/C:H/I:N/A:N Change-Id: I0451ef054f04ca77257ca8d46bd1cb1c6d87acfe

1 year, 10 months

[tribe29/checkmk] 999632: crash reporting: Remove useless indirection

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 99963257896903a6340079725242bbd44d2cfbf5 https://github.com/tribe29/checkmk/commit/99963257896903a6340079725242bbd44… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M cmk/base/crash_reporting.py M tests/unit/cmk/base/test_base_crash_reporting.py Log Message: ----------- crash reporting: Remove useless indirection This also lets us remove tautological tests. Change-Id: If4aacec59af722e3ddbf08c4b84677e511140cc3 Commit: 0c0ef73fb3cd47cb7a022d6c92d95866557e9e17 https://github.com/tribe29/checkmk/commit/0c0ef73fb3cd47cb7a022d6c92d958665… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M cmk/base/agent_based/checking/_checking.py M cmk/base/agent_based/error_handling.py M cmk/base/crash_reporting.py Log Message: ----------- Remove HostConfig/base dep from crash_reporting CMK-10515 Change-Id: I80e4b403b5671a31aa286988ca07e4f11ab7df77 Commit: dfa299b7fbeb9a91c8e86a87e40510e0d413a2bb https://github.com/tribe29/checkmk/commit/dfa299b7fbeb9a91c8e86a87e40510e0d… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: M buildscripts/infrastructure/build-nodes/sles-15sp4/Dockerfile Log Message: ----------- Add missing bison to sles-15sp4 node Change-Id: Ic14f216108702dfcfc89d4b043b6c4b5e5db998e Compare: https://github.com/tribe29/checkmk/compare/8fd4db3c8c64...dfa299b7fbeb

1 year, 10 months

[tribe29/checkmk] 95d3f0: 14919 SEC Do not log host secret (2)

by Maximilian

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 95d3f06ae22181d5cf52baf6ad2ec10e0e3fdc41 https://github.com/tribe29/checkmk/commit/95d3f06ae22181d5cf52baf6ad2ec10e0… Author: Maximilian Wirtz <maximilian.wirtz(a)tribe29.com> Date: 2022-10-31 (Mon, 31 Oct 2022) Changed paths: A .werks/14919 Log Message: ----------- 14919 SEC Do not log host secret (2) Unfortunately Werk #14916 was insufficient. Therefore the vulnerability still exists. This Werk fixes the problem. When using the <i>Agent updater</i> the Checkmk server needs a secret in order to allow the agent to download new agents. For security reasons this secret is unique for each host and generated with the <tt>cmk-update-agent register</tt> command. Unfortunately the generated host secret was written to the cmk-update-agent.log. This logfile is not protected and usually world-readable. With this secret one can download the current agent from the Checkmk server. Included in that agent package are the plugin configs which can contain other secrets. (e.g. database credentials) Mitigations without updating: LI: Reregister the agent-updater. Then sanitize the cmk-update-agent.log files. LI: If you cannot rule out that any unauthorized user read <tt>/var/lib/check_mk_agent/cmk-update-agent.log</tt> respectively <tt>C:\ProgramData\checkmk\agent\log\cmk-update-agent.log</tt> you should rotate all secrets that might be or were included in the agent configurations. Steps needed with the update: LI: Update your agent. LI: Reregister the agent-updater. All versions including 1.5 are subject to this vulnerability. We found this vulnerability internally and have no indication of any exploitation. We calculated a CVSS 3.1 score of 6.5 (Medium) with the following vector: CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:C/C:H/I:N/A:N Change-Id: I0451ef054f04ca77257ca8d46bd1cb1c6d87acfe

1 year, 10 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2022