Checkmk git commits February 2023

checkmk-commits@lists.checkmk.com

1 participants
433 discussions

[tribe29/checkmk] 686cb3: Skip test_bake_and_sign on Firefox engine

by rseltmann

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 686cb3b6dfbd3037224be29e1889e096b8832c42 https://github.com/tribe29/checkmk/commit/686cb3b6dfbd3037224be29e1889e096b… Author: Matteo Stifano <matteo.stifano(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M tests/gui_e2e/test_signature_keys_for_signing_agents.py Log Message: ----------- Skip test_bake_and_sign on Firefox engine Such test function is currently showing a flaky behavior on the Firefox engine. We here skip it on such engine. Change-Id: Ief9bf058a441874b9121bb148e734917d8b9f21b Commit: bfc314154de9dd17ff83ad84b2dbf106a5cc7749 https://github.com/tribe29/checkmk/commit/bfc314154de9dd17ff83ad84b2dbf106a… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M cmk/gui/htmllib/top_heading.py M cmk/gui/wato/pages/activate_changes.py M cmk/gui/watolib/activate_changes.py Log Message: ----------- Licensing: Enable enforcement only for cloud edition CMK-12296 Change-Id: I4df408b50afde53588464a52f13dac726d1e07c1 Compare: https://github.com/tribe29/checkmk/compare/556127db7a05...bfc314154de9

1 year, 6 months

[tribe29/checkmk] 18fa18: extension packages: add more paths to PathConfig

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 18fa184bf17fb2c2719f486004b2ad3aa657be2d https://github.com/tribe29/checkmk/commit/18fa184bf17fb2c2719f486004b2ad3aa… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M bin/mkp M cmk/gui/watolib/activate_changes.py M cmk/update_config/plugins/pre_actions/utils.py M cmk/utils/packaging/_parts.py M cmk/utils/packaging/cli.py M tests/unit/cmk/utils/packaging/test_packaging.py Log Message: ----------- extension packages: add more paths to PathConfig Change-Id: Ie891fd3b919e1c3daa0c4487298d036c6aa6c708 Commit: 556127db7a05be28db00f069d6fa7d1847364166 https://github.com/tribe29/checkmk/commit/556127db7a05be28db00f069d6fa7d184… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M cmk/utils/packaging/cli.py Log Message: ----------- extension packages: do not depend on utils.tty Change-Id: I3173ff3ba6fbdc41bf9ff378c45cf826668eb9b7 Compare: https://github.com/tribe29/checkmk/compare/efcf801a9315...556127db7a05

1 year, 6 months

[tribe29/checkmk] 4acc54: 15253 FIX Abort CMC startup if state file could no...

by Sven Panne

Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: 4acc548565cf29728606f1019fd8b91cb8ff3633 https://github.com/tribe29/checkmk/commit/4acc548565cf29728606f1019fd8b91cb… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: A .werks/15253 Log Message: ----------- 15253 FIX Abort CMC startup if state file could not be read or parsed This avoids simply continuing and creating a new state file, which loses all comments, ad hoc downtimes, acknowledgements, etc. Note that it is still OK when there is no state file at all, which is e.g. the case when the CMC starts for the first time. Change-Id: I4a5b4bee2a4cef11940c36f93792e6a24bfe721b

1 year, 6 months

[tribe29/checkmk] 46292d: 15253 FIX Abort CMC startup if state file could no...

by scolakovic

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 46292d0dc2a99db06a6b76c2e93a770bbd66d502 https://github.com/tribe29/checkmk/commit/46292d0dc2a99db06a6b76c2e93a770bb… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: A .werks/15253 Log Message: ----------- 15253 FIX Abort CMC startup if state file could not be read or parsed This avoids simply continuing and creating a new state file, which loses all comments, ad hoc downtimes, acknowledgements, etc. Note that it is still OK when there is no state file at all, which is e.g. the case when the CMC starts for the first time. Change-Id: I4a5b4bee2a4cef11940c36f93792e6a24bfe721b Commit: efcf801a9315864eaad107963bff8f010dc12c80 https://github.com/tribe29/checkmk/commit/efcf801a9315864eaad107963bff8f010… Author: Sofia Colakovic <sofia.colakovic(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: A .werks/15149 M cmk/special_agents/agent_azure.py A tests/unit/cmk/special_agents/agent_azure/test_agent_azure_mgmt_api_client.py Log Message: ----------- 15149 FIX agent_azure: Fix crash if the metric isn't found The Azure agent would crash if the metric wasn't available for a resource. Now, the agent doesn't crash and retries to fetch available metrics. Change-Id: I908960320047a011a6a3eb478e301a9f6f4df9b9 Compare: https://github.com/tribe29/checkmk/compare/3283c59a089a...efcf801a9315

1 year, 6 months

[tribe29/checkmk] bb46bb: Improve `params` type for special agents

by rseltmann

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: bb46bb25151c5051ced864d0a4509637f015896f https://github.com/tribe29/checkmk/commit/bb46bb25151c5051ced864d0a4509637f… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M cmk/base/config.py M cmk/base/core_config.py Log Message: ----------- Improve `params` type for special agents Change-Id: Ib96eb5121473ddad76790bbfeea15c17e3fb0f33 Commit: 048d87da68e8847546443b60214de5ea22d3ce10 https://github.com/tribe29/checkmk/commit/048d87da68e8847546443b60214de5ea2… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/config.py M cmk/base/sources.py M tests/unit/cmk/base/test_core_config.py Log Message: ----------- Remove ProgramFetcher factory This reduces the scope of the code that may raise, which is not the factory itself but only the `cmdline` part. This is also consistent with the special agent code. Change-Id: Ie955d7aad1b1a15dce252532224710b563d55e9e Commit: 5ee284a561e43a7a12a569f133074cd24d84e12f https://github.com/tribe29/checkmk/commit/5ee284a561e43a7a12a569f133074cd24… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: A cmk/base/_sources.py M cmk/base/sources.py Log Message: ----------- Use abstract factory pattern in make_sources This removes some copy and paste and helps splitting the source selection logic from the instantiation. Several bugs have been recently reported and the code is hard to maintain, so let's improve it a bit. Change-Id: Iaa61515d1556fac1420e17203c808c754dce9444 Commit: a379e0691929d573fc81ac6c43cc6b921b050cd4 https://github.com/tribe29/checkmk/commit/a379e0691929d573fc81ac6c43cc6b921… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M cmk/base/sources.py Log Message: ----------- Remove unnecessary args from source _Builder Change-Id: I8554e58bc619fe9c4ae77def5ffd1b2e6f9621d2 Commit: 8b87cbbdaa8cbee98d580cf624d6edadad419a13 https://github.com/tribe29/checkmk/commit/8b87cbbdaa8cbee98d580cf624d6edada… Author: Sofia Colakovic <sofia.colakovic(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M cmk/base/plugins/agent_based/azure_virtual_network_gateways.py M tests/unit/cmk/base/plugins/agent_based/test_azure_virtual_network_gateways.py Log Message: ----------- azure_virtual_network_gateway: fix crash if peering addresses are missing Vnet gateways don't always return all types of peering addresses. Previously, that led to a crash in parsing agent output. Change-Id: I253426f1e7e2058c60352459d98d21c6a93950ed Commit: 4743a7aa3e4494f31d81861a138978d90e1bd6aa https://github.com/tribe29/checkmk/commit/4743a7aa3e4494f31d81861a138978d90… Author: Sofia Colakovic <sofia.colakovic(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M cmk/special_agents/agent_azure.py Log Message: ----------- agent_azure: fix message parsing for ApiError After introducing ApiErrorFactory, ApiError messages were no longer in the right format Change-Id: I7d0e20c76cd05133805e3b6691ed54f65b062cb9 Commit: cb732be9e2bc953dbed2b757fce7aeb8ea3e2d38 https://github.com/tribe29/checkmk/commit/cb732be9e2bc953dbed2b757fce7aeb8e… Author: Frans Fürst <frans.fuerst(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M omd/WORKSPACE A omd/packages/monitoring-plugins/BUILD A omd/packages/monitoring-plugins/BUILD.monitoring-plugins.bazel R omd/packages/monitoring-plugins/monitoring-plugins-2.3.2.tar.gz A omd/packages/monitoring-plugins/monitoring-plugins.bzl M omd/packages/monitoring-plugins/monitoring-plugins.make M tests/integration/omd/test_monitoring_plugins.py Log Message: ----------- Adds Bazel configuration for nagios-plugins, Take #2 + modifies tests to not assume check plugins we failed to remove before to be present Change-Id: I42c20944a2c22d0a35dcb755af0c4e108531b672 Commit: 3283c59a089a65fdde10084bbc3998bf0cadf1e1 https://github.com/tribe29/checkmk/commit/3283c59a089a65fdde10084bbc3998bf0… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M scripts/check-licence Log Message: ----------- Fix license header check for long-form folders Change-Id: I7f54247558704846cce8e5014a56eeb10a77aa55 Compare: https://github.com/tribe29/checkmk/compare/a66166185db3...3283c59a089a

1 year, 6 months

[tribe29/checkmk] 148840: 15238 FIX Too restrictive permission checking in s...

by Moritz

Branch: refs/heads/2.2.0 Home: https://github.com/tribe29/checkmk Commit: 148840e24ba0c16cc2c9d92633e5b9204d7df4cd https://github.com/tribe29/checkmk/commit/148840e24ba0c16cc2c9d92633e5b9204… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: A .werks/15238 M cmk/gui/plugins/openapi/endpoints/service_discovery.py M cmk/gui/wato/pages/services.py M cmk/gui/watolib/services.py Log Message: ----------- 15238 FIX Too restrictive permission checking in service discovery Change-Id: Iacfd1914fea54e3e29e7c6a1b6f5924f587b2e3b

1 year, 6 months

[tribe29/checkmk] 4fc9fb: improve formatting

by Moritz

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 4fc9fbc2472bfeed7b752bbb1e7f34f031abc5ea https://github.com/tribe29/checkmk/commit/4fc9fbc2472bfeed7b752bbb1e7f34f03… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M cmk/gui/wato/pages/services.py Log Message: ----------- improve formatting Change-Id: Id1b0fc72f6c18ae9f56ab4bf44da56d2d66c0de1

1 year, 6 months

[tribe29/checkmk] 5510ed: 15238 FIX Too restrictive permission checking in s...

by anthonyh209

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5510ed5c64547fe7b090b4e54d5f7b8aff82402c https://github.com/tribe29/checkmk/commit/5510ed5c64547fe7b090b4e54d5f7b8af… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: A .werks/15238 M cmk/gui/plugins/openapi/endpoints/service_discovery.py M cmk/gui/wato/pages/services.py M cmk/gui/watolib/services.py Log Message: ----------- 15238 FIX Too restrictive permission checking in service discovery Change-Id: Iacfd1914fea54e3e29e7c6a1b6f5924f587b2e3b Commit: 4a53cbc7c48d2b73d29b0992a060ba48d8003d07 https://github.com/tribe29/checkmk/commit/4a53cbc7c48d2b73d29b0992a060ba48d… Author: Rebekka Seltmann <rebekka.seltmann(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M tests/unit/cmk/gui/test_gui_config.py Log Message: ----------- Add section on license settings page to configure notifications CMK-12296 Change-Id: Iac3a6713f8287e0cae07295feff20f734d1976aa Commit: a66166185db32949945df4d33c8217ba07600684 https://github.com/tribe29/checkmk/commit/a66166185db32949945df4d33c8217ba0… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: A .werks/15384 M agents/check_mk_agent.aix M agents/check_mk_agent.freebsd M agents/check_mk_agent.linux M agents/check_mk_agent.openwrt M agents/check_mk_agent.solaris Log Message: ----------- 15384 FIX check_mk_agent: handle tabs when reading definitions from mrpe.cfg Prior to this werk, the Checkmk agent for linux, solaris and aix was not able to handle tabs in the service definitions in the mrpe.cfg file. This werk resolves this issue and correctly identifies the service description, command and optionally the time interval Change-Id: I898f4011357b3fdb943a19b4e594d9cff57e82a2 Compare: https://github.com/tribe29/checkmk/compare/8765e1b91dd6...a66166185db3

1 year, 6 months

[tribe29/checkmk] e7bbd7: 15238 FIX Too restrictive permission checking in s...

by Moritz

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: e7bbd7cef53a0f835b2fe28bdc7c18ef219aefd2 https://github.com/tribe29/checkmk/commit/e7bbd7cef53a0f835b2fe28bdc7c18ef2… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: A .werks/15238 M cmk/gui/plugins/openapi/endpoints/service_discovery.py M cmk/gui/wato/pages/services.py M cmk/gui/watolib/services.py Log Message: ----------- 15238 FIX Too restrictive permission checking in service discovery Change-Id: Iacfd1914fea54e3e29e7c6a1b6f5924f587b2e3b

1 year, 6 months

[tribe29/checkmk] b04f20: Initial scaffold of update test suite

by Matteo Stifano

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b04f2013cc06bf35cf0700784a00c7a560e63b2e https://github.com/tribe29/checkmk/commit/b04f2013cc06bf35cf0700784a00c7a56… Author: René Slowenski <rene.slowenski(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M tests/conftest.py M tests/testlib/site.py A tests/update/__init__.py A tests/update/conftest.py A tests/update/test_update.py Log Message: ----------- Initial scaffold of update test suite Change-Id: I6ce7bd066c9fd998389640e54e7cab5598ff637e Commit: 8685f39f3b049334ba2bf52c8c7832715be80aec https://github.com/tribe29/checkmk/commit/8685f39f3b049334ba2bf52c8c7832715… Author: Matteo Stifano <matteo.stifano(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M tests/update/conftest.py M tests/update/test_update.py Log Message: ----------- Parametrize cmk base version in test_update We here retrieve the test site via a pytest fixture and we parametrize such fixture with the cmk base version. In this way, it will be easy to extend the cmk-base-versions list to be used in the test. Change-Id: Ibd1fcac87921f0dc5c1632737e094fb7920eddcc Commit: ccb9b310c77b3155fad5367de4d69c1d9f59ff9d https://github.com/tribe29/checkmk/commit/ccb9b310c77b3155fad5367de4d69c1d9… Author: Matteo Stifano <matteo.stifano(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: M tests/update/conftest.py M tests/update/test_update.py Log Message: ----------- Implement test-site update in test_update Change-Id: I416bf883b1001e8d4c701eeb1bd58ebd15fe062b Commit: 8765e1b91dd69f12a9c525f82c05335567b85ce1 https://github.com/tribe29/checkmk/commit/8765e1b91dd69f12a9c525f82c0533556… Author: Matteo Stifano <matteo.stifano(a)tribe29.com> Date: 2023-02-28 (Tue, 28 Feb 2023) Changed paths: A buildscripts/scripts/utils/test-update.groovy M tests/Makefile Log Message: ----------- Dockerize test_update Inside the repo root folder, you can now run the dockerized test_update via: make -C tests test-update-docker Change-Id: I4de5b24a49da8e149d9ae0052171903ee4426bee Compare: https://github.com/tribe29/checkmk/compare/c9664c178bf1...8765e1b91dd6

1 year, 6 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2023