Checkmk git commits January 2019

checkmk-commits@lists.checkmk.com

15 participants
490 discussions

by Simon Betz

Module: check_mk Branch: master Commit: d16ccbb638df13645d0e9fd9a591ea548ef6ae31 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d16ccbb638df13… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Jan 7 10:07:45 2019 +0100 4411 New special agent for NAS DBs Change-Id: I09a3bcae1eb4bf7eef5941b621d96d858d741d88 --- .werks/4411 | 11 ++ agents/special/agent_vnx_quotas | 109 ++++++++++++++ checkman/vnx_quotas | 15 ++ checkman/vnx_version | 11 ++ checks/agent_vnx_quotas | 46 ++++++ checks/vnx_quotas | 160 +++++++++++++++++++++ checks/vnx_version | 41 ++++++ cmk/gui/plugins/metrics/check_mk.py | 1 + .../plugins/wato/check_parameters/vnx_quotas.py | 73 ++++++++++ cmk/gui/plugins/wato/datasource_programs.py | 17 +++ cmk/utils/man_pages.py | 1 + tests/unit/cmk/gui/test_watolib.py | 2 + 12 files changed, 487 insertions(+) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=d16ccbb638…

5 years, 8 months

minor performance improvement with redundant tags_of_host call

by Andreas Boesl

Module: check_mk Branch: master Commit: 9ebd8370c25085a59304604672d781517e298015 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9ebd8370c25085… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Jan 16 10:12:49 2019 +0100 minor performance improvement with redundant tags_of_host call Change-Id: Ie081dd4983c24b14522344f3d2eb274278d6e078 --- cmk_base/config.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmk_base/config.py b/cmk_base/config.py index 01adf15..9c800a0 100644 --- a/cmk_base/config.py +++ b/cmk_base/config.py @@ -1949,6 +1949,7 @@ def in_binary_hostlist(hostname, conf): cache[cache_id] = result else: for entry in conf: + actual_host_tags = tags_of_host(hostname) entry, rule_options = get_rule_options(entry) if rule_options.get("disabled"): continue @@ -1973,7 +1974,7 @@ def in_binary_hostlist(hostname, conf): else: tags, hostlist = entry - if hosttags_match_taglist(tags_of_host(hostname), tags) and \ + if hosttags_match_taglist(actual_host_tags, tags) and \ in_extraconf_hostlist(hostlist, hostname): cache[cache_id] = not negate break

5 years, 8 months

Refreshed Pipfile.lock.

by Sven Panne

Module: check_mk Branch: master Commit: 5274b3095aeca07f916d277b7330fa0a7b090b84 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5274b3095aeca0… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Wed Jan 16 08:16:33 2019 +0100 Refreshed Pipfile.lock. Change-Id: Ic5c7d4778f409e1573221e06dd427d35f3fc9c95 --- Pipfile.lock | 125 ++++++++++++++++++++++++++++++----------------------------- 1 file changed, 64 insertions(+), 61 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=5274b3095a…

5 years, 8 months

Make test_registered_api_call_collections always load and expect the CEE call

by Lars Michelsen

Module: check_mk Branch: master Commit: 9de25b5d9753c88cfed97ca602936e66ed8a3c38 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9de25b5d9753c8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jan 15 17:41:50 2019 +0100 Make test_registered_api_call_collections always load and expect the CEE call Change-Id: I0f4259a614d059f2ce0a7b40daffdcd32dec5e7b --- tests/unit/cmk/gui/test_webapi_unit.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/unit/cmk/gui/test_webapi_unit.py b/tests/unit/cmk/gui/test_webapi_unit.py index ea1dad0..6b5ad6d 100644 --- a/tests/unit/cmk/gui/test_webapi_unit.py +++ b/tests/unit/cmk/gui/test_webapi_unit.py @@ -1,3 +1,6 @@ +# Needed to make the test load all webapi plugins (incl. CEE) +import cmk.gui.webapi # pylint: disable=unused-import + from cmk.gui.plugins.webapi.utils import api_call_collection_registry @@ -14,6 +17,7 @@ def test_registered_api_call_collections(): 'add_hosts', 'add_servicegroup', 'add_users', + 'bake_agents', 'delete_contactgroup', 'delete_folder', 'delete_host', @@ -39,11 +43,13 @@ def test_registered_api_call_collections(): 'get_all_users', 'get_bi_aggregations', 'get_folder', + 'get_graph', 'get_host', 'get_hosttags', 'get_ruleset', 'get_rulesets_info', 'get_site', + 'get_sla', 'login_site', 'logout_site', 'set_all_sites',

5 years, 8 months

Fixed validation error when cloning uncheckedsvc view

by Lars Michelsen

Module: check_mk Branch: master Commit: 5f17d7049319959a0c8d31113662289328aa104a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5f17d704931995… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jan 15 15:28:36 2019 +0100 Fixed validation error when cloning uncheckedsvc view An invalid default value in the builtin view lead to the validation error. Change-Id: Ic3477fbb34ebb63c68065908f0b427c0c9ca5f64 --- cmk/gui/plugins/views/builtin.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmk/gui/plugins/views/builtin.py b/cmk/gui/plugins/views/builtin.py index 825d3c6..e985fa7 100644 --- a/cmk/gui/plugins/views/builtin.py +++ b/cmk/gui/plugins/views/builtin.py @@ -2029,7 +2029,7 @@ multisite_builtin_views.update({ 'description': _( 'Services that have not been checked for too long according to their configured check intervals.' ), - 'group_painters': [('host', 'host', '')], + 'group_painters': [('host', 'host')], 'hard_filters': [ 'service_staleness', 'service_scheduled_downtime_depth',

5 years, 8 months

lnx_thermal: Add generic data regression test

by Florian Kromer

Module: check_mk Branch: master Commit: 7435d681af04876d5eb0a5d2c3df0ba35a6a4abf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7435d681af0487… Author: Florian Kromer <fk(a)mathias-kettner.de> Date: Fri Jan 11 17:04:31 2019 +0100 lnx_thermal: Add generic data regression test CMK-1506 Change-Id: I224739a5cf3519e26124538a843150d4072ce5a0 --- .../checks/generictests/datasets/lnx_thermal.py | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/tests/unit/checks/generictests/datasets/lnx_thermal.py b/tests/unit/checks/generictests/datasets/lnx_thermal.py new file mode 100644 index 0000000..a8838ce --- /dev/null +++ b/tests/unit/checks/generictests/datasets/lnx_thermal.py @@ -0,0 +1,22 @@ +checkname = 'lnx_thermal' + +info = [['thermal_zone0', 'enabled', 'acpitz', '57000', '127000', 'critical'], + ['thermal_zone1', 'enabled', 'acpitz', '65000', '100000', 'critical', '95500', 'passive'], + ['thermal_zone2', 'pkg-temp-0', '44000', '0', 'passive', '0', 'passive']] + +discovery = {'': [('Zone 0', {}), ('Zone 1', {}), ('Zone 2', {})]} + +checks = { + '': [('Zone 0', { + 'device_levels_handling': 'devdefault', + 'levels': (70.0, 80.0) + }, [(0, u'57.0 \xb0C', [('temp', 57.0, 127.0, 127.0, None, None)])]), + ('Zone 1', { + 'device_levels_handling': 'devdefault', + 'levels': (70.0, 80.0) + }, [(0, u'65.0 \xb0C', [('temp', 65.0, 95.5, 100.0, None, None)])]), + ('Zone 2', { + 'device_levels_handling': 'devdefault', + 'levels': (70.0, 80.0) + }, [(0, u'44.0 \xb0C', [('temp', 44.0, 70.0, 80.0, None, None)])])] +}

5 years, 8 months

Removed invalid column service_description from host view

by Lars Michelsen

Module: check_mk Branch: master Commit: 7c3ef8496c656a769c02dd31d9ccc49fd7956200 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7c3ef8496c656a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jan 15 17:29:47 2019 +0100 Removed invalid column service_description from host view This was simply a copy/paste error only leading to view edit errors when cloning the "hostevents" view. Change-Id: Ia94e8716f16fae51c6c6a6c5e19d5e49f88426ae --- cmk/gui/plugins/views/builtin.py | 1 - 1 file changed, 1 deletion(-) diff --git a/cmk/gui/plugins/views/builtin.py b/cmk/gui/plugins/views/builtin.py index 14e7ab8..825d3c6 100644 --- a/cmk/gui/plugins/views/builtin.py +++ b/cmk/gui/plugins/views/builtin.py @@ -2170,7 +2170,6 @@ multisite_builtin_views.update({ ('log_icon', None), ('log_time', None), ('log_type', None), - ('service_description', 'svcevents'), ('log_state_type', None), ('log_plugin_output', None), ],

5 years, 8 months

7071 FIX Fixed missing form error highlighting for cascaded dropdown fields

by Lars Michelsen

Module: check_mk Branch: master Commit: d6fd5f703e1cc81153483f58eac7ccfeb8cd2efb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d6fd5f703e1cc8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jan 15 17:28:59 2019 +0100 7071 FIX Fixed missing form error highlighting for cascaded dropdown fields Some dropdown fields were not highlighted in case there are input validation errors detected during form submit. This made it hard for the user to find the field that needs to be corrected. Change-Id: I6174434b506e6e3371410e5677ce25d741115b4c --- .werks/7071 | 13 +++++++++++++ cmk/gui/valuespec.py | 6 +++--- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/.werks/7071 b/.werks/7071 new file mode 100644 index 0000000..9183310 --- /dev/null +++ b/.werks/7071 @@ -0,0 +1,13 @@ +Title: Fixed missing form error highlighting for cascaded dropdown fields +Level: 1 +Component: multisite +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.6.0i1 +Date: 1547561948 + +Some dropdown fields were not highlighted in case there are input validation +errors detected during form submit. This made it hard for the user to find +the field that needs to be corrected. diff --git a/cmk/gui/valuespec.py b/cmk/gui/valuespec.py index d7f0f8a..c5b853d 100644 --- a/cmk/gui/valuespec.py +++ b/cmk/gui/valuespec.py @@ -2053,11 +2053,11 @@ class CascadingDropdown(ValueSpec): self._encoding_type.__name__) vs.validate_datatype(value[1], varprefix + "_%d" % nr) return - raise MKUserError(varprefix, _("Value %r is not allowed here.") % value) + raise MKUserError(varprefix + "_sel", _("Value %r is not allowed here.") % value) def validate_value(self, value, varprefix): if self._no_preselect and value == self._no_preselect_value: - raise MKUserError(varprefix, self._no_preselect_error) + raise MKUserError(varprefix + "_sel", self._no_preselect_error) choices = self.choices() for nr, (val, _title, vs) in enumerate(choices): @@ -2066,7 +2066,7 @@ class CascadingDropdown(ValueSpec): vs.validate_value(value[1], varprefix + "_%d" % nr) ValueSpec.custom_validate(self, value, varprefix) return - raise MKUserError(varprefix, _("Value %r is not allowed here.") % (value,)) + raise MKUserError(varprefix + "_sel", _("Value %r is not allowed here.") % (value,)) # The same logic as the dropdown choice, but rendered

5 years, 8 months

7030 FIX Fixed baking of solaris packages with custom package names containing "_"

by Lars Michelsen

Module: check_mk Branch: master Commit: f7819d36121d5d09714a1d62b20c7513de38c772 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f7819d36121d5d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jan 15 16:33:36 2019 +0100 7030 FIX Fixed baking of solaris packages with custom package names containing "_" The ruleset "Name of agent packages (Linux/UNIX)" allows customizing the name of the RPM, DEB, PKG packages. Previous versions allowed to use underscores as parts of the package names which broke building Solaris PKGs. Underscores are now disallowed by the ruleset. CMK-1533 Change-Id: I64c547f9bd2e5fe76786758030fa73b85519fa36 --- .werks/7030 | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.werks/7030 b/.werks/7030 new file mode 100644 index 0000000..4e3a716 --- /dev/null +++ b/.werks/7030 @@ -0,0 +1,14 @@ +Title: Fixed baking of solaris packages with custom package names containing "_" +Level: 1 +Component: agents +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.6.0i1 +Date: 1547560141 + +The ruleset "Name of agent packages (Linux/UNIX)" allows customizing the name of the +RPM, DEB, PKG packages. Previous versions allowed to use underscores as parts of the +package names which broke building Solaris PKGs. Underscores are now disallowed by +the ruleset.

5 years, 8 months

Fixed recently introduced issue with get_checkbox()

by Lars Michelsen

Module: check_mk Branch: master Commit: b15011a31735bcd834be0a0f5c10c02d717587a6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b15011a31735bc… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Jan 15 16:33:55 2019 +0100 Fixed recently introduced issue with get_checkbox() Change-Id: I6b5a58a783dcde416c27d2905e008f2a70de41c5 --- cmk/gui/htmllib.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmk/gui/htmllib.py b/cmk/gui/htmllib.py index f6f2cf7..989c613 100644 --- a/cmk/gui/htmllib.py +++ b/cmk/gui/htmllib.py @@ -1922,6 +1922,8 @@ class html(HTMLGenerator): # the form a second time while showing value typed in at the first # time and complaining about invalid user input) def form_submitted(self, form_name=None): + if form_name is None: + return self.request.has_var("filled_in") return self.request.var("filled_in") == form_name # Get value of checkbox. Return True, False or None. None means

5 years, 8 months

← Newer
1
...
22
23
24
25
26
27
28
...
49
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2019