Branch: refs/heads/1.5.0
Home: https://github.com/tribe29/checkmk
Commit: ef6ff835d0482fdbaf2500612905007f94f77410
https://github.com/tribe29/checkmk/commit/ef6ff835d0482fdbaf2500612905007f9…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
A .werks/10267
M checks/dell_compellent_disks
M tests/unit/checks/generictests/datasets/dell_compellent_controller_regression.py
M tests/unit/checks/generictests/datasets/dell_compellent_disks_regression.py
M tests/unit/checks/generictests/datasets/dell_compellent_enclosure_regression.py
Log Message:
-----------
10267 FIX dell_compellent_disks would not see more than 9 disks
The dell_compellent_disks check was using the the inventory function
from `dell_compellent.include`. However, this inventory function
expects a list where `parse_dell_compellent_disks` builds a dict. This
resulted in the inventory function returning the first letter of every
key from the parse function, that is, disk #7, would be correctly
inventoried as #7 but disk #42 would be inventoried as #4. The
inventory function would also never see more than 9 disks with no
guarantee that it would always see the same 9 disks.
This patch fixes the inventory function to dell_compellent_disks
and test that the error is not present in the other Compellent checks.
This fixes FEED-4283.
Change-Id: I16cfd52f220b7cc2625443ed8bf4f1ee2a748451
Branch: refs/heads/1.6.0
Home: https://github.com/tribe29/checkmk
Commit: 2094b493aed8c64fcf06fa10df8b4dc2e1f96d7e
https://github.com/tribe29/checkmk/commit/2094b493aed8c64fcf06fa10df8b4dc2e…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
A .werks/10267
M checks/dell_compellent_disks
M tests/unit/checks/generictests/datasets/dell_compellent_controller_regression.py
M tests/unit/checks/generictests/datasets/dell_compellent_disks_regression.py
M tests/unit/checks/generictests/datasets/dell_compellent_enclosure_regression.py
Log Message:
-----------
10267 FIX dell_compellent_disks would not see more than 9 disks
The dell_compellent_disks check was using the the inventory function
from `dell_compellent.include`. However, this inventory function
expects a list where `parse_dell_compellent_disks` builds a dict. This
resulted in the inventory function returning the first letter of every
key from the parse function, that is, disk #7, would be correctly
inventoried as #7 but disk #42 would be inventoried as #4. The
inventory function would also never see more than 9 disks with no
guarantee that it would always see the same 9 disks.
This patch fixes the inventory function to dell_compellent_disks
and test that the error is not present in the other Compellent checks.
This fixes FEED-4283.
Change-Id: I16cfd52f220b7cc2625443ed8bf4f1ee2a748451
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 5fa4d17a1a028fa4ad5643df842a0e8e61b8bf9d
https://github.com/tribe29/checkmk/commit/5fa4d17a1a028fa4ad5643df842a0e8e6…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M cmk/gui/plugins/wato/check_mk_configuration.py
Log Message:
-----------
Extract valuespecs to reduce nesting levels
Change-Id: I6c6ac8c15a83f3f5802ef4f9e5174b13a009c6dd
Commit: 03a0eac8de4c56de68d7134044c0ae4a035cc741
https://github.com/tribe29/checkmk/commit/03a0eac8de4c56de68d7134044c0ae4a0…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
A .werks/10243
M cmk/gui/plugins/wato/check_mk_configuration.py
Log Message:
-----------
10243 FIX Periodic service discovery: Set minimum group time to 5 minutes
The cron job is executed every 5 minutes, a lower grouping value does not
make sense.
Change-Id: I560e2ff197d3a42a0304d50ce0d961874e519c17
Commit: a4a43113e3ea0ff387c522a19e46196dabf9f268
https://github.com/tribe29/checkmk/commit/a4a43113e3ea0ff387c522a19e46196da…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
A .werks/10244
M cmk/utils/paths.py
M cmk_base/config.py
M cmk_base/discovery.py
Log Message:
-----------
10244 FIX Periodic service discovery was not correctly activating changes
When the automatic update of the service configuration is enabled, the periodic
service discovery was applying service discovery changes, but was not
activating them when configured to do so.
The services appeared as discovered on the discovery page in WATO, but they were
not activated. After activating a change in the GUI, the services were finally
activated.
Change-Id: Ic4902ceb7a2fe1fb216ed438ed40b30417d8eef9
Compare: https://github.com/tribe29/checkmk/compare/0c464bb8ef95...a4a43113e3ea
Branch: refs/heads/1.6.0
Home: https://github.com/tribe29/checkmk
Commit: 3739083f39212983c5bd870f82906418cb932b1a
https://github.com/tribe29/checkmk/commit/3739083f39212983c5bd870f82906418c…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
M cmk/gui/plugins/wato/check_mk_configuration.py
Log Message:
-----------
Extract valuespecs to reduce nesting levels
Change-Id: I6c6ac8c15a83f3f5802ef4f9e5174b13a009c6dd
Commit: 1025b08f7d15299f8ef8bdf6e3b75b81fc8417a6
https://github.com/tribe29/checkmk/commit/1025b08f7d15299f8ef8bdf6e3b75b81f…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
A .werks/10243
M cmk/gui/plugins/wato/check_mk_configuration.py
Log Message:
-----------
10243 FIX Periodic service discovery: Set minimum group time to 5 minutes
The cron job is executed every 5 minutes, a lower grouping value does not
make sense.
Change-Id: I560e2ff197d3a42a0304d50ce0d961874e519c17
Commit: bc12d7278f772471926c9c881c912a8d62a3860d
https://github.com/tribe29/checkmk/commit/bc12d7278f772471926c9c881c912a8d6…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2019-09-30 (Mon, 30 Sep 2019)
Changed paths:
A .werks/10244
M cmk/utils/paths.py
M cmk_base/config.py
M cmk_base/discovery.py
Log Message:
-----------
10244 FIX Periodic service discovery was not correctly activating changes
When the automatic update of the service configuration is enabled, the periodic
service discovery was applying service discovery changes, but was not
activating them when configured to do so.
The services appeared as discovered on the discovery page in WATO, but they were
not activated. After activating a change in the GUI, the services were finally
activated.
Change-Id: Ic4902ceb7a2fe1fb216ed438ed40b30417d8eef9
Compare: https://github.com/tribe29/checkmk/compare/636bbd9fb944...bc12d7278f77