Checkmk git commits May 2017

checkmk-commits@lists.checkmk.com

12 participants
254 discussions

4745 FIX multipath: Fixed crash on Dell devices if a colon is on uuid

by Marcel Arentz

Module: check_mk Branch: master Commit: 5dda2e4af0fc92be5dbcfea2996e03c402712908 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5dda2e4af0fc92… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Wed May 31 17:09:30 2017 +0200 4745 FIX multipath: Fixed crash on Dell devices if a colon is on uuid Change-Id: I735a7221615eede699cdfdefb0961e8dd5d92d0e --- .werks/4745 | 10 ++++++++++ checks/multipath | 8 +++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/.werks/4745 b/.werks/4745 new file mode 100644 index 0000000..ac2b9ca --- /dev/null +++ b/.werks/4745 @@ -0,0 +1,10 @@ +Title: multipath: Fixed crash on Dell devices if a colon is on uuid +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1496243300 +Class: fix + + diff --git a/checks/multipath b/checks/multipath index 08119b2..9e68d0f 100644 --- a/checks/multipath +++ b/checks/multipath @@ -142,6 +142,12 @@ inventory_multipath_rules = [] # `-+- policy='round-robin 0' prio=0 status=enabled # `- 20:0:0:1 sdi 8:128 active undef running +# Here another one from Dell +# Dell_Internal_Dual_SD_0123456789AB-0:0 dm-2 Dell ,Internal Dual SD +# size=972M features='0' hwhandler='0' wp=rw +# `-+- policy='service-time 0' prio=0 status=active +# `- 1:0:0:0 sdb 8:16 active undef running + # And a completely new situation: # <<<multipath>>> # Nov 05 17:17:03 | DM multipath kernel driver not loaded @@ -166,7 +172,7 @@ def parse_multipath(info): (regex(r"^[a-zA-Z0-9_]+$"), 0, None, None), # 3. (regex(r"^([0-9a-z]{33}|[0-9a-z]{49})\s?(dm.[0-9]+).*$"), 1, None, 2), # 4. (regex(r"^[a-zA-Z0-9_]+(dm-[0-9]+).*$"), 0, None, 1), # 5. Remove this line in 1.2.0 - (regex(r"^([-a-zA-Z0-9_ ]+)\s?(dm-[0-9]+).*$"), 1, None, 2), # 6. and 7. + (regex(r"^([-a-zA-Z0-9_ :]+)\s?(dm-[0-9]+).*$"), 1, None, 2), # 6. and 7. ] reg_prio = regex("[[ ]prio=")

7 years, 1 month

4752 FIX MKP manager: Fixed creating packages for 1.4.0i* releases

by Lars Michelsen

Module: check_mk Branch: master Commit: 2b633933b373cad6c2689973fa4f19ea35f4641c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2b633933b373ca… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed May 31 16:25:45 2017 +0200 4752 FIX MKP manager: Fixed creating packages for 1.4.0i* releases Change-Id: I45e1c0ac81d7d4dc5fb785f3d1cc496e184cf4a5 --- .werks/4752 | 11 +++++++++++ web/htdocs/valuespec.py | 4 +--- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/.werks/4752 b/.werks/4752 new file mode 100644 index 0000000..65fa2f9 --- /dev/null +++ b/.werks/4752 @@ -0,0 +1,11 @@ +Title: MKP manager: Fixed creating packages for 1.4.0i* releases +Level: 1 +Component: wato +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.5.0i1 +Date: 1496240716 + + diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index 55d2010..b7886e8 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -968,9 +968,7 @@ class HTTPUrl(TextAscii): def CheckMKVersion(**args): args = args.copy() - regex_unstable = "(1\.[1234]\.(1|3|5|7|9|11|13|15)i[1-9](p[0-9]+)?)" - regex_stable = "(1\.[1234]\.(0|2|4|6|8|10|12|14)([bp][1-9]?[0-9]+)?)" - args["regex"] = "(" + regex_unstable + "|" + regex_stable + ")$" + args["regex"] = "[0-9]+\.[0-9]+\.[0-9]+([bpi][0-9]+|i[0-9]+p[0-9]+)?$" args["regex_error"] = _("This is not a valid Check_MK version number") return TextAscii(**args)

7 years, 1 month

4703 FIX Business intelligence: fixed various display and navigation bugs in timelines page

by Andreas Boesl

Module: check_mk Branch: master Commit: 3a8b06976fb2bd26d66d6491dedc1a5bfdf79fd8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3a8b06976fb2bd… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed May 31 15:59:38 2017 +0200 4703 FIX Business intelligence: fixed various display and navigation bugs in timelines page <ul> <li>Fixed from/until computation error</li> <li>No longer hiding timewarped aggregations (BI aggregations at selected timestamps)</li> <li>Fixed missing/redundant navigation arrows in the timeline selection</li> <li>Disabled support for multiple BI aggregations in timeline page. This feature will be redesigned later on</li> </ul> Change-Id: I249221c1900eaf8b16c9b87f914c401ebb4a7e40 --- .werks/4703 | 18 ++++++++++++++++++ web/htdocs/availability.py | 8 ++++---- web/plugins/views/availability.py | 25 ++++++++++++++----------- 3 files changed, 36 insertions(+), 15 deletions(-) diff --git a/.werks/4703 b/.werks/4703 new file mode 100644 index 0000000..e1bf8bf --- /dev/null +++ b/.werks/4703 @@ -0,0 +1,18 @@ +Title: Business intelligence: fixed various display and navigation bugs in timelines page +Level: 2 +Component: bi +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1496238693 +Class: fix + + +<ul> +<li>Fixed from/until computation error</li> +<li>No longer hiding timewarped aggregations (BI aggregations at selected timestamps)</li> +<li>Fixed missing/redundant navigation arrows in the timeline selection</li> +<li>Disabled support for multiple BI aggregations in timeline page. This feature will be redesigned later on</li> +</ul> + + diff --git a/web/htdocs/availability.py b/web/htdocs/availability.py index a7696ac..0e02842 100644 --- a/web/htdocs/availability.py +++ b/web/htdocs/availability.py @@ -1277,7 +1277,7 @@ def layout_availability_table(what, group_title, availability_table, avoptions): ("av_host", host), ("av_service", service)]) else: - timeline_url = html.makeuri([("av_mode", "timeline"), ("av_aggr_group", host), ("av_aggr_name", service)]) + timeline_url = html.makeuri([("av_mode", "timeline"), ("av_aggr_group", host), ("aggr_name", service), ("view_name", "aggr_single")]) urls.append(( "timeline", _("Timeline"), timeline_url )) if what != "bi": urls.append(("history", _("Event History"), history_url_of((site, host, service), time_range))) @@ -1805,9 +1805,9 @@ def compute_bi_timelines(timeline_containers, time_range, timewarp, phases_list) timeline_container.tree_state)) timeline_container.tree_state = next_tree_state - timeline_container.tree_time = tree_time - if timewarp == tree_time: - timeline_container.timewarp_state = tree_state + timeline_container.tree_time = from_time + if timewarp == timeline_container.tree_time: + timeline_container.timewarp_state = timeline_container.tree_state diff --git a/web/plugins/views/availability.py b/web/plugins/views/availability.py index f89d1ef..b7e3cb5 100644 --- a/web/plugins/views/availability.py +++ b/web/plugins/views/availability.py @@ -273,7 +273,6 @@ def do_render_availability(what, av_rawdata, av_data, av_mode, av_object, avopti def render_availability_tables(availability_tables, what, avoptions): - if not availability_tables: html.message(_("No matching hosts/services.")) return @@ -384,7 +383,6 @@ def render_timeline_legend(what): def render_availability_table(group_title, availability_table, what, avoptions): - av_table = availability.layout_availability_table(what, group_title, availability_table, avoptions) # TODO: If summary line is activated, then sorting should now move that line to the @@ -547,8 +545,8 @@ def render_bi_availability(title, aggr_rows): has_reached_logrow_limit = False timeline_containers, fetched_rows = availability.get_timeline_containers(aggr_rows, avoptions, - livestatus_limit, - timewarp) + timewarp, + livestatus_limit) if livestatus_limit and fetched_rows > livestatus_limit: has_reached_logrow_limit = True @@ -558,7 +556,6 @@ def render_bi_availability(title, aggr_rows): these_spans = timeline_container.timeline timewarp_tree_state = timeline_container.timewarp_state - spans += these_spans # render selected time warp for the corresponding aggregation row (should be matched by only one) @@ -588,18 +585,24 @@ def render_bi_availability(title, aggr_rows): html.open_h3() # render icons for back and forth + button_back_shown = False + button_forth_shown = False if int(these_spans[0]["from"]) == timewarp: html.disabled_icon_button("back_off") - have_forth = False + button_back_shown = True + previous_span = None for span in these_spans: - if int(span["from"]) == timewarp and previous_span != None: + if not button_back_shown and int(span["from"]) == timewarp and previous_span != None: html.icon_button(html.makeuri([("timewarp", str(int(previous_span["from"])))]), _("Jump one phase back"), "back") - elif previous_span and int(previous_span["from"]) == timewarp and span != these_spans[-1]: + button_back_shown = True + # Multiple followup spans can have the same "from" time + # We only show one forth-arrow with an actual time difference + elif not button_forth_shown and previous_span and int(previous_span["from"]) == timewarp and int(span["from"]) != timewarp: html.icon_button(html.makeuri([("timewarp", str(int(span["from"])))]), _("Jump one phase forth"), "forth") - have_forth = True + button_forth_shown = True previous_span = span - if not have_forth: + if not button_forth_shown: html.disabled_icon_button("forth_off") html.write_text("   ") @@ -615,7 +618,7 @@ def render_bi_availability(title, aggr_rows): html.close_tr() html.close_table() - timewarpcode = html.drain() + timewarpcode += html.drain() # Note: 'spans_by_object' returns two arguments which are used by # all availability views but not by BI. There we have to take

7 years, 1 month

Added some debug output to site creation during tests

by Lars Michelsen

Module: check_mk Branch: master Commit: aa62a9534556f35eb4fba3d9fac83bf14784a3d4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=aa62a9534556f3… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed May 31 15:24:21 2017 +0200 Added some debug output to site creation during tests Change-Id: Id1718516a5b9f74ca1197adeba9a33dcd89fe28a --- tests/testlib/__init__.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/testlib/__init__.py b/tests/testlib/__init__.py index e48d3e4..274aabd 100644 --- a/tests/testlib/__init__.py +++ b/tests/testlib/__init__.py @@ -304,12 +304,15 @@ class Site(object): raise Exception("The site %s already exists." % self.id) if not self.exists(): + print("[%0.2f] Creating site '%s'" % (time.time(), self.id)) p = subprocess.Popen(["/usr/bin/sudo", "/usr/bin/omd", "-V", self.version.version_directory(), "create", "--admin-password", "cmk", "--apache-reload", self.id]) - assert p.wait() == 0 + exit_code = p.wait() + print("[%0.2f] Executed create command" % time.time()) + assert exit_code == 0 assert os.path.exists("/omd/sites/%s" % self.id) if self.update_with_git:

7 years, 1 month

4744 FIX msexch_rpcclientaccess: Fixed discovery failure because of an non existing item

by Marcel Arentz

Module: check_mk Branch: master Commit: 363e2fd5df396b5f8b152efe462a8325381770b2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=363e2fd5df396b… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Wed May 31 15:10:41 2017 +0200 4744 FIX msexch_rpcclientaccess: Fixed discovery failure because of an non existing item The checkplugin expected an item for the service description but will never get one as only one service will be created. Change-Id: I0f072b1536aae5734ae82f12c08b07c6b799ac84 --- .werks/4744 | 11 +++++++++++ checks/msexch_rpcclientaccess | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/4744 b/.werks/4744 new file mode 100644 index 0000000..946a44c --- /dev/null +++ b/.werks/4744 @@ -0,0 +1,11 @@ +Title: msexch_rpcclientaccess: Fixed discovery failure because of an non existing item +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1496236131 +Class: fix + +The checkplugin expected an item for the service description but will never +get one as only one service will be created. diff --git a/checks/msexch_rpcclientaccess b/checks/msexch_rpcclientaccess index 4db5c84..7e0b713 100644 --- a/checks/msexch_rpcclientaccess +++ b/checks/msexch_rpcclientaccess @@ -57,7 +57,7 @@ check_info['msexch_rpcclientaccess'] = { 'check_function' : check_msexch_rpcclientaccess, 'parse_function' : parse_wmi_table, 'has_perfdata' : True, - 'service_description' : "Exchange RPC Client Access %s", + 'service_description' : "Exchange RPC Client Access", 'includes' : ['wmi.include'], 'group' : 'msx_rpcclientaccess', 'default_levels_variable' : 'msexch_rpcclientaccess_defaultlevels'

7 years, 1 month

4665 mail, asciimail: Added subject for bulk notifications

by Simon Betz

Module: check_mk Branch: master Commit: a8f7258ece79ebd94315d6ade73cd1ff46dcf71c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a8f7258ece79eb… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon May 29 17:07:49 2017 +0200 4665 mail, asciimail: Added subject for bulk notifications Change-Id: I4adef18679f88b00aa706091d8da2b187dabcd1a --- .werks/4665 | 13 +++++++++++++ modules/notify.py | 3 +++ notifications/asciimail | 28 ++++++++++++++++------------ notifications/mail | 24 ++++++++++++++---------- web/htdocs/wato.py | 9 ++++++++- 5 files changed, 54 insertions(+), 23 deletions(-) diff --git a/.werks/4665 b/.werks/4665 new file mode 100644 index 0000000..3da43c2 --- /dev/null +++ b/.werks/4665 @@ -0,0 +1,13 @@ +Title: mail, asciimail: Added subject for bulk notifications +Level: 1 +Component: notifications +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1496070439 +Class: feature + +With this new configuration option you can now customize +the subject for bulk notifications and overwrite default +subject 'Check_MK: X notifications for HOST' resp. +'Check_MK: X notifications for Y hosts'. diff --git a/modules/notify.py b/modules/notify.py index a8f2f38..2b8d67d 100644 --- a/modules/notify.py +++ b/modules/notify.py @@ -1316,6 +1316,9 @@ def do_bulk_notify(contact, plugin, params, plugin_context, bulk): ec_contact = plugin_context.get("EC_CONTACT", "") bulk_path += ("ec_contact", ec_contact) + if "bulk_subject" in bulk: + plugin_context["PARAMETER_BULK_SUBJECT"] = bulk["bulk_subject"] + # User might have specified _FOO instead of FOO bulkby_custom = bulk.get("groupby_custom", []) for macroname in bulkby_custom: diff --git a/notifications/asciimail b/notifications/asciimail index 618d0af..8ee4b2e 100755 --- a/notifications/asciimail +++ b/notifications/asciimail @@ -193,7 +193,6 @@ def read_bulk_contexts(): # First comes a section with global variables for line in sys.stdin: line = line.strip() - if not line: in_params = False context = {} @@ -213,6 +212,20 @@ def read_bulk_contexts(): return parameters, contexts + +def get_bulk_notification_subject(parameters, contexts, hosts): + if parameters.get("PARAMETER_BULK_SUBJECT"): + return parameters["PARAMETER_BULK_SUBJECT"] + + else: + hosts = list(hosts) + if len(hosts) == 1: + return "Check_MK: %d notifications for %s" % (len(contexts), hosts[0]) + else: + return "Check_MK: %d notifications for %d hosts" % \ + (len(contexts), len(hosts)) + + def main(): if bulk_mode: content_txt = "" @@ -220,20 +233,11 @@ def main(): hosts = set([]) for context in contexts: context.update(parameters) - txt = construct_content(context) - content_txt += txt + content_txt += construct_content(context) mailto = context['CONTACTEMAIL'] # Assume the same in each context subject = context['SUBJECT'] hosts.add(context["HOSTNAME"]) - - # Create a useful subject - hosts = list(hosts) - if len(contexts) > 1: - if len(hosts) == 1: - subject = "Check_MK: %d notifications for %s" % (len(contexts), hosts[0]) - else: - subject = "Check_MK: %d notifications for %d hosts" % ( - len(contexts), len(hosts)) + subject = get_bulk_notification_subject(parameters, contexts, hosts) else: # gather all options from env diff --git a/notifications/mail b/notifications/mail index 4d2f3b8..532d959 100755 --- a/notifications/mail +++ b/notifications/mail @@ -867,7 +867,6 @@ def read_bulk_contexts(): # First comes a section with global variables for line in sys.stdin: line = line.strip() - if not line: in_params = False context = {} @@ -882,6 +881,19 @@ def read_bulk_contexts(): return parameters, contexts + +def get_bulk_notification_subject(parameters, contexts, hosts): + if parameters.get("PARAMETER_BULK_SUBJECT"): + return parameters["PARAMETER_BULK_SUBJECT"] + + else: + hosts = list(hosts) + if len(hosts) == 1: + return "Check_MK: %d notifications for %s" % (len(contexts), hosts[0]) + else: + return "Check_MK: %d notifications for %d hosts" % \ + (len(contexts), len(hosts)) + def main(): if bulk_mode: attachments = [] @@ -898,15 +910,7 @@ def main(): mailto = context['CONTACTEMAIL'] # Assume the same in each context subject = context['SUBJECT'] hosts.add(context["HOSTNAME"]) - - # Create a useful subject - hosts = list(hosts) - if len(contexts) > 1: - if len(hosts) == 1: - subject = "Check_MK: %d notifications for %s" % (len(contexts), hosts[0]) - else: - subject = "Check_MK: %d notifications for %d hosts" % ( - len(contexts), len(hosts)) + subject = get_bulk_notification_subject(parameters, contexts, hosts) else: # gather all options from env diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index c23bb2b..b7d7fd9 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -7634,9 +7634,16 @@ def vs_notification_rule(userid = None): "macro is <tt>_FOO</tt> then you need to add the variables <tt>NOTIFY_HOST_FOO</tt> and " "<tt>NOTIFY_SERVICE_FOO</tt>."), )), + ( "bulk_subject", TextAscii( + title = _("Subject for bulk notifications"), + help = _("Customize the subject for bulk notifications and overwrite " + "default subject 'Check_MK: X notifications for HOST' resp. " + "'Check_MK: X notifications for Y hosts'."), + size = 80, + )), ], columns = 1, - optional_keys = False, + optional_keys = ["bulk_subject"], ), ),

7 years, 1 month

4751 FIX Fixed "dragging not defined" javascript error on dashboards

by Lars Michelsen

Module: check_mk Branch: master Commit: 6f6390c931d5cb243b5a1b426d90012431057a96 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6f6390c931d5cb… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed May 31 11:55:41 2017 +0200 4751 FIX Fixed "dragging not defined" javascript error on dashboards Change-Id: I25c022cb765e364fa667afb71a413e3dc72573a3 --- .werks/4751 | 11 +++++++++++ web/htdocs/js/checkmk.js | 26 +++++++++++++------------- 2 files changed, 24 insertions(+), 13 deletions(-) diff --git a/.werks/4751 b/.werks/4751 new file mode 100644 index 0000000..5857f2e --- /dev/null +++ b/.werks/4751 @@ -0,0 +1,11 @@ +Title: Fixed "dragging not defined" javascript error on dashboards +Level: 1 +Component: multisite +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1496224515 + + diff --git a/web/htdocs/js/checkmk.js b/web/htdocs/js/checkmk.js index addb563..18c59ba 100644 --- a/web/htdocs/js/checkmk.js +++ b/web/htdocs/js/checkmk.js @@ -1710,7 +1710,7 @@ function init_rowselect() { //# | On dropping, the page is being reloaded for persisting the move. | //# '-------------------------------------------------------------------- -var g_dragging = null; +var g_element_dragging = null; function element_drag_start(event, dragger, dragging_tag, base_url) { @@ -1720,7 +1720,7 @@ function element_drag_start(event, dragger, dragging_tag, base_url) var button = getButton(event); // Skip calls when already dragging or other button than left mouse - if (g_dragging !== null || button != 'LEFT') + if (g_element_dragging !== null || button != 'LEFT') return true; // Find the first parent of the given tag type @@ -1733,7 +1733,7 @@ function element_drag_start(event, dragger, dragging_tag, base_url) add_class(dragging, "dragging"); - g_dragging = { + g_element_dragging = { "dragging" : dragging, "moved" : false, "base_url" : base_url, @@ -1747,7 +1747,7 @@ function element_dragging(event) if (!event) event = window.event; - if (g_dragging === null) + if (g_element_dragging === null) return true; position_dragging_object(event); @@ -1755,8 +1755,8 @@ function element_dragging(event) function position_dragging_object(event) { - var dragging = g_dragging.dragging, - container = dragging.parentNode; + var dragging = g_element_dragging.dragging, + container = g_element_dragging.dragging.parentNode; var get_previous = function(node) { var previous = node.previousElementSibling; @@ -1776,7 +1776,7 @@ function position_dragging_object(event) // Move it up? var previous = get_previous(dragging); while (previous && mouse_offset_to_middle(previous, event).y < 0) { - g_dragging.moved = true; + g_element_dragging.moved = true; container.insertBefore(dragging, previous); previous = get_previous(dragging); } @@ -1784,7 +1784,7 @@ function position_dragging_object(event) // Move it down? var next = get_next(dragging); while (next && mouse_offset_to_middle(next, event).y > 0) { - g_dragging.moved = true; + g_element_dragging.moved = true; container.insertBefore(dragging, next.nextElementSibling); next = get_next(dragging); } @@ -1795,21 +1795,21 @@ function element_drag_stop(event) if (!event) event = window.event; - if (g_dragging === null) + if (g_element_dragging === null) return true; finalize_dragging(); - g_dragging = null; + g_element_dragging = null; return prevent_default_events(event); } function finalize_dragging() { - var dragging = g_dragging.dragging; + var dragging = g_element_dragging.dragging; remove_class(dragging, "dragging"); - if (!g_dragging.moved) + if (!g_element_dragging.moved) return; // Nothing changed. Fine. var elements = dragging.parentNode.children; @@ -1826,7 +1826,7 @@ function finalize_dragging() if (has_header) index -= 1; - var url = g_dragging.base_url + "&_index="+encodeURIComponent(index); + var url = g_element_dragging.base_url + "&_index="+encodeURIComponent(index); location.href = url;

7 years, 1 month

New bug for agent updater

by Sven Rueß

Module: check_mk Branch: master Commit: 5ba90b2970e8bd3a7e2f06cd8657432d5788f5d4 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5ba90b2970e8bd… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Wed May 31 11:32:20 2017 +0200 New bug for agent updater Change-Id: I49933519d63f7ae92f554eee80ca7064836728d7 --- .bugs/2924 | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.bugs/2924 b/.bugs/2924 new file mode 100644 index 0000000..25c5d2f --- /dev/null +++ b/.bugs/2924 @@ -0,0 +1,9 @@ +Title: Agent Updater: Break down by validating certs with SHA-1 +Component: checks +State: open +Date: 2017-05-31 11:29:57 +Targetversion: 1.4.0 +Class: bug + +If a certificate with SHA-1 is used, the agent updater breaks down during validation +of this certificate.

7 years, 1 month

Updated bug entries #2901

by Andreas Boesl

Module: check_mk Branch: master Commit: 77f03238be582df1dffa93bc26001d32351f4db5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=77f03238be582d… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed May 31 11:31:20 2017 +0200 Updated bug entries #2901 Change-Id: I2bc7e78f59d433b69b60d59ac7412812f8d9f98a --- .bugs/2901 | 52 ++++++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 44 insertions(+), 8 deletions(-) diff --git a/.bugs/2901 b/.bugs/2901 index 28460da..e214937 100644 --- a/.bugs/2901 +++ b/.bugs/2901 @@ -1,13 +1,49 @@ -Title: WATO rule edit/delete: Rules are referenced by list index (can delete/edit wrong rule) +Title: ActivateChangesManager: is_running fails if last known process id is used by another process Component: wato State: open -Date: 2017-05-09 16:06:49 -Targetversion: 1.5.0 +Date: 2017-05-31 11:26:15 +Targetversion: 1.4.0 Class: bug -When multiple users edit the same ruleset for example by moving deleting rules they can edit wrong rules -by accident. This can happen because the rules are identified by their position in the ruleset list which -is really bad when doing actions with an outdated view. -We either need to store a hash/token of the previous configuration, send it with the edit action and -compare it when applying a new change or we need to add some permanent identity to the rules. +The activation folder seems to include some status files for each site. + +OMD[heute]:~/tmp/check_mk/wato/activation$ ll +total 0 +drwxr-xr-x 2 heute heute 80 Mai 31 11:19 9595279f-5c40-436f-930e-42c014f0c002/ +drwxrwxr-x 2 heute heute 80 Mai 31 11:17 9c00befe-14d9-4d9c-abb5-88f0f49a5acb/ +drwxr-xr-x 2 heute heute 60 Mai 30 09:54 bb4f92ae-514c-480b-b55e-b2585be0459a/ + + +OMD[heute]:~/tmp/check_mk/wato/activation/9595279f-5c40-436f-930e-42c014f0c002$ cat site_heute.mk +{'_expected_duration': 10.0, + '_phase': 'done', + '_pid': 18761, + '_site_id': 'heute', + '_state': 'success', + '_status_details': 'Started at: 10:56:46. Finished at: 10:56:47.', + '_status_text': 'Success', + '_time_ended': 1496134607.148224, + '_time_started': 1496134606.458821, + '_time_updated': 1496134607.148224, + '_warnings': []} + + + +If the pid mentioned in this file was already reused by another process, the is_running(...) call fails +This may happen on "Activate changes", which shows an "[Errno 1] Operation not permitted" error box. + +2017-05-31 11:17:39,030 [40] [cmk.web 32556] /heute/check_mk/ajax_start_activation.py Internal error: Traceback (most recent call last): + File "/omd/sites/heute/share/check_mk/web/htdocs/wato.py", line 399, in handle_page + action_response = self.page() + File "/omd/sites/heute/share/check_mk/web/htdocs/wato.py", line 5616, in page + activation_id = manager.start(affected_sites, activate_until, comment, activate_foreign) + File "/omd/sites/heute/share/check_mk/web/htdocs/watolib.py", line 4520, in start + self._do_housekeeping() + File "/omd/sites/heute/share/check_mk/web/htdocs/watolib.py", line 4826, in _do_housekeeping + delete = not manager.is_running() + File "/omd/sites/heute/share/check_mk/web/htdocs/watolib.py", line 4559, in is_running + os.kill(site_state["_pid"], 0) +OSError: [Errno 1] Operation not permitted + +

7 years, 1 month

Reserved 1 bug IDS

by Sven Rueß

Module: check_mk Branch: master Commit: 34f6765c9921754dc381f58beeff4d490dad6cef URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=34f6765c992175… Author: Sven Rueß <sr(a)mathias-kettner.de> Date: Wed May 31 11:29:39 2017 +0200 Reserved 1 bug IDS Change-Id: Id3a72596882068a6fdc4f083f85b8b4f1e22088a --- .bugs/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bugs/first_free b/.bugs/first_free index c272068..5afe26c 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -2924 +2925

7 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits May 2017