Checkmk git commits January 2019

checkmk-commits@lists.checkmk.com

15 participants
490 discussions

by Lars Michelsen

Module: check_mk Branch: master Commit: 645e8380847d7ef458def58c1da7f63a3908c9bf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=645e8380847d7e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 18 19:48:15 2019 +0100 Fixed left over comma after refactoring Change-Id: If4ccfcd6b4562a9bf1c80277ecab457b623702c9 --- cmk/gui/plugins/views/mkeventd.py | 2 +- tests/unit/cmk/gui/test_gui_config.py | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/cmk/gui/plugins/views/mkeventd.py b/cmk/gui/plugins/views/mkeventd.py index b74b343..7c45230 100644 --- a/cmk/gui/plugins/views/mkeventd.py +++ b/cmk/gui/plugins/views/mkeventd.py @@ -639,7 +639,7 @@ class PermissionECUpdateEvent(Permission): @property def description(self): - return _("Needed for acknowledging and changing the comment and contact of an event"), + return _("Needed for acknowledging and changing the comment and contact of an event") @property def defaults(self): diff --git a/tests/unit/cmk/gui/test_gui_config.py b/tests/unit/cmk/gui/test_gui_config.py index c591d5c..0fdd340 100644 --- a/tests/unit/cmk/gui/test_gui_config.py +++ b/tests/unit/cmk/gui/test_gui_config.py @@ -1,3 +1,4 @@ +import six import pytest from pathlib2 import Path @@ -488,6 +489,12 @@ def test_registered_permissions(): assert sorted(expected_permissions) == sorted(permission_registry.keys()) + for perm_class in permission_registry.values(): + perm = perm_class() + assert isinstance(perm.description, six.string_types) + assert isinstance(perm.title, six.string_types) + assert isinstance(perm.defaults, list) + def test_declare_permission_section(monkeypatch): monkeypatch.setattr(permissions, "permission_section_registry",

5 years, 8 months

Removed unused wato.extra_buttons

by Lars Michelsen

Module: check_mk Branch: master Commit: 1aaaca61e6ae56f57207b1630896ad1b96cceee7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1aaaca61e6ae56… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jan 17 21:49:44 2019 +0100 Removed unused wato.extra_buttons Change-Id: I2ac2d9ba19b1db65535b7cbae2e637e74c526688 --- cmk/gui/wato/__init__.py | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/cmk/gui/wato/__init__.py b/cmk/gui/wato/__init__.py index 5f8e87c..87319ee 100644 --- a/cmk/gui/wato/__init__.py +++ b/cmk/gui/wato/__init__.py @@ -520,17 +520,6 @@ def _wato_page_handler(current_mode, mode_permissions, mode_class): # Show contexts buttons html.begin_context_buttons() mode.buttons() - for inmode, buttontext, target in extra_buttons: - if inmode == current_mode: - if hasattr(target, '__call__'): - target = target() - if not target: - continue - if target[0] == '/' or target.startswith('../') or '://' in target: - html.context_button(buttontext, target) - else: - html.context_button(buttontext, - watolib.folder_preserving_link([("mode", target)])) html.end_context_buttons() if not html.is_transaction() or (cmk.gui.watolib.read_only.is_enabled() and @@ -893,8 +882,6 @@ def save_network_scan_result(folder, result): # '----------------------------------------------------------------------' modes = {} -# TODO: Drop this and probably replace with a hook at button rendering? -extra_buttons = [] loaded_with_language = False @@ -904,9 +891,6 @@ def load_plugins(force): if loaded_with_language == cmk.gui.i18n.get_current_language() and not force: return - # Reset global vars - del extra_buttons[:] - # Initialize watolib things which are needed before loading the WATO plugins. # This also loads the watolib plugins. watolib.load_watolib_plugins()

5 years, 8 months

EC: Register EC related things independent of the EC enabling

by Lars Michelsen

Module: check_mk Branch: master Commit: 2947b584b74a678f05bd42122588a12c970ff520 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2947b584b74a67… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 18 10:08:34 2019 +0100 EC: Register EC related things independent of the EC enabling Change-Id: Id51f28ce672424084edafd2108a3c1c5029f5e52 --- cmk/gui/plugins/views/mkeventd.py | 2315 +++++++++++++++++++------------------ 1 file changed, 1173 insertions(+), 1142 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=2947b584b7…

5 years, 8 months

Refactored painter options to plugin registry

by Lars Michelsen

Module: check_mk Branch: master Commit: 58e6da2f5ba7624b72c7b779b636ee1fddddd209 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=58e6da2f5ba762… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 18 13:17:36 2019 +0100 Refactored painter options to plugin registry Change-Id: If2be1ea2ba0d2b7e68ccc128a74c5ad23d07c519 --- cmk/gui/plugins/views/__init__.py | 3 +- cmk/gui/plugins/views/bi.py | 120 ++++++++++++++++++++++++------------- cmk/gui/plugins/views/inventory.py | 24 +++++--- cmk/gui/plugins/views/painters.py | 98 +++++++++++++++++++----------- cmk/gui/plugins/views/utils.py | 38 +++++++++--- cmk/gui/views.py | 33 ++++++---- tests/unit/cmk/gui/test_views.py | 27 +++++++++ 7 files changed, 241 insertions(+), 102 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=58e6da2f5b…

5 years, 8 months

Refactored config.declare_permissions() call sites to plugin registry

by Lars Michelsen

Module: check_mk Branch: master Commit: 17de00c27bdebdde50cf08beca6d61810bd4b490 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=17de00c27bdebd… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Jan 17 21:47:43 2019 +0100 Refactored config.declare_permissions() call sites to plugin registry Change-Id: I50d59c3f9b571cf3b6e81f73a9e2d041483add67 --- cmk/gui/bi.py | 41 +- cmk/gui/dashboard.py | 5 +- cmk/gui/default_permissions.py | 814 ++++++++++++------ cmk/gui/gui_background_job.py | 190 +++-- cmk/gui/notifications.py | 5 +- cmk/gui/notify.py | 37 +- cmk/gui/pagetypes.py | 24 +- cmk/gui/plugins/sidebar/utils.py | 3 +- cmk/gui/plugins/views/commands.py | 314 +++++-- cmk/gui/plugins/views/mkeventd.py | 309 +++++-- cmk/gui/plugins/wato/bi.py | 59 +- cmk/gui/plugins/wato/nagvis_auth.py | 226 +++-- cmk/gui/views.py | 7 +- cmk/gui/visuals.py | 59 +- cmk/gui/wato/__init__.py | 1545 ++++++++++++++++++++++++++--------- cmk/gui/wato/mkeventd.py | 126 ++- cmk/gui/webapi.py | 34 +- 17 files changed, 2841 insertions(+), 957 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=17de00c27b…

5 years, 8 months

Refactoring: Moved last check parameters from unsorted.py to dedicated modules ( CMK-1393)

by Kenneth Okoh

Module: check_mk Branch: master Commit: 54a98e8ae8d4e7986e9bae24e194344c981ba012 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=54a98e8ae8d4e7… Author: Kenneth Okoh <ko(a)mathias-kettner.de> Date: Fri Jan 18 12:20:35 2019 +0100 Refactoring: Moved last check parameters from unsorted.py to dedicated modules (CMK-1393) Change-Id: Ief3a578e7f29d93dce658f140de9f87c7fac3013 --- .../wato/check_parameters/bossock_fibers.py | 45 +++ .../wato/check_parameters/carbon_monoxide.py | 48 +++ .../wato/check_parameters/domino_mailqueues.py | 66 +++++ .../plugins/wato/check_parameters/domino_tasks.py | 108 +++++++ .../wato/check_parameters/domino_transactions.py | 49 +++ .../plugins/wato/check_parameters/domino_users.py | 49 +++ .../check_parameters/heartbeat_crm_resources.py | 50 ++++ .../wato/check_parameters/netscaler_dnsrates.py | 65 ++++ .../wato/check_parameters/netscaler_sslcerts.py | 57 ++++ .../wato/check_parameters/netscaler_tcp_conns.py | 72 +++++ .../wato/check_parameters/siemens_plc_counter.py | 64 ++++ .../wato/check_parameters/siemens_plc_duration.py | 64 ++++ .../wato/check_parameters/siemens_plc_flag.py | 57 ++++ cmk/gui/plugins/wato/check_parameters/unsorted.py | 327 --------------------- 14 files changed, 794 insertions(+), 327 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=54a98e8ae8…

5 years, 8 months

Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393)

by Kenneth Okoh

Module: check_mk Branch: master Commit: 7b8a099e764be1592ad5aedd0fc6422c3930e078 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7b8a099e764be1… Author: Kenneth Okoh <ko(a)mathias-kettner.de> Date: Fri Jan 18 12:17:09 2019 +0100 Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393) Change-Id: Ic790d053426a618b57d41eab2e937918e67fc995 --- .../check_parameters/docker_node_containers.py | 101 ++++ .../check_parameters/docker_node_disk_usage.py | 80 ++++ cmk/gui/plugins/wato/check_parameters/fc_port.py | 169 +++++++ .../plugins/wato/check_parameters/heartbeat_crm.py | 68 +++ .../wato/check_parameters/hp_msa_psu_voltage.py | 88 ++++ cmk/gui/plugins/wato/check_parameters/jvm_gc.py | 72 +++ cmk/gui/plugins/wato/check_parameters/jvm_tp.py | 72 +++ .../plugins/wato/check_parameters/plug_count.py | 47 ++ .../wato/check_parameters/steelhead_connections.py | 103 +++++ .../ucs_bladecenter_chassis_voltage.py | 73 +++ cmk/gui/plugins/wato/check_parameters/unsorted.py | 506 --------------------- 11 files changed, 873 insertions(+), 506 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=7b8a099e76…

5 years, 8 months

Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393)

by Kenneth Okoh

Module: check_mk Branch: master Commit: 70ad6e2c78b88363515e0de66e0ee061795aef54 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=70ad6e2c78b883… Author: Kenneth Okoh <ko(a)mathias-kettner.de> Date: Fri Jan 18 12:13:13 2019 +0100 Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393) Change-Id: Icb16750e9ea04be57da2f99786d55d00a0b07f53 --- cmk/gui/plugins/wato/check_parameters/adva_ifs.py | 59 +++++ .../wato/check_parameters/airflow_deviation.py | 47 ++++ cmk/gui/plugins/wato/check_parameters/apt.py | 55 +++++ .../check_parameters/bluecat_command_server.py | 68 ++++++ .../plugins/wato/check_parameters/bluecat_dhcp.py | 68 ++++++ .../plugins/wato/check_parameters/bluecat_dns.py | 68 ++++++ .../plugins/wato/check_parameters/bluecat_ha.py | 82 +++++++ .../plugins/wato/check_parameters/bluecat_ntp.py | 81 +++++++ .../plugins/wato/check_parameters/citrix_load.py | 53 ++++ cmk/gui/plugins/wato/check_parameters/unsorted.py | 268 --------------------- cmk/gui/plugins/wato/check_parameters/zypper.py | 40 +++ 11 files changed, 621 insertions(+), 268 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=70ad6e2c78…

5 years, 8 months

Refactoring: Moved rules from unsorted.py to matching modules (CMK-1393)

by Kenneth Okoh

Module: check_mk Branch: master Commit: 0d8592a4e9f2532a517ba237e4c99abe0f3f960c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0d8592a4e9f253… Author: Kenneth Okoh <ko(a)mathias-kettner.de> Date: Thu Jan 17 15:56:35 2019 +0100 Refactoring: Moved rules from unsorted.py to matching modules (CMK-1393) Change-Id: Ia51b2587f6919305f9d560719f19800842f8cb99 --- .../wato/check_parameters/brocade_fcport.py | 94 +++++ cmk/gui/plugins/wato/check_parameters/ewon.py | 21 + cmk/gui/plugins/wato/check_parameters/if.py | 127 ++++++ cmk/gui/plugins/wato/check_parameters/ipmi.py | 50 +++ .../plugins/wato/check_parameters/mssql_backup.py | 20 + .../wato/check_parameters/mssql_counters_locks.py | 15 + .../wato/check_parameters/mssql_transactionlogs.py | 23 ++ cmk/gui/plugins/wato/check_parameters/services.py | 47 +++ .../wato/check_parameters/solaris_services.py | 47 +++ .../wato/check_parameters/systemd_services.py | 31 ++ cmk/gui/plugins/wato/check_parameters/unsorted.py | 456 --------------------- .../wato/check_parameters/win_dhcp_pools.py | 18 + 12 files changed, 493 insertions(+), 456 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=0d8592a4e9…

5 years, 8 months

Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393)

by Kenneth Okoh

Module: check_mk Branch: master Commit: e88acc8c0425824607335e2fcbf2ead076407017 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e88acc8c042582… Author: Kenneth Okoh <ko(a)mathias-kettner.de> Date: Thu Jan 17 15:20:57 2019 +0100 Refactoring: Moved check parameters from unsorted.py to dedicated modules (CMK-1393) Change-Id: I2035da05e858cffc608069758dafa0811ab31fad --- cmk/gui/plugins/wato/check_parameters/drbd.py | 129 +++++ .../wato/check_parameters/hpux_multipath.py | 49 ++ .../wato/check_parameters/multipath_count.py | 75 +++ .../plugins/wato/check_parameters/netapp_disks.py | 79 +++ .../plugins/wato/check_parameters/netapp_luns.py | 149 +++++ .../wato/check_parameters/netapp_snapshots.py | 57 ++ .../wato/check_parameters/netapp_volumes.py | 212 +++++++ cmk/gui/plugins/wato/check_parameters/services.py | 109 ++++ cmk/gui/plugins/wato/check_parameters/snapvault.py | 79 +++ .../wato/check_parameters/solaris_services.py | 91 +++ cmk/gui/plugins/wato/check_parameters/unsorted.py | 620 --------------------- 11 files changed, 1029 insertions(+), 620 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=e88acc8c04…

5 years, 8 months

← Newer
1
...
16
17
18
19
20
21
22
...
49
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2019