Module: check_mk
Branch: master
Commit: b5da11177dc3b9d286b1b9bd4a613a9c0322b4ae
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b5da11177dc3b9…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Fri Jan 30 17:36:13 2015 +0100
Fixed some English texts
---
web/plugins/wato/active_checks.py | 2 +-
web/plugins/wato/check_mk_configuration.py | 9 ++++++---
web/plugins/wato/check_parameters.py | 12 ++++++------
3 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/web/plugins/wato/active_checks.py b/web/plugins/wato/active_checks.py
index d8a7206..1488d43 100644
--- a/web/plugins/wato/active_checks.py
+++ b/web/plugins/wato/active_checks.py
@@ -1380,7 +1380,7 @@ register_rule(group,
elements = [
TextAscii(
title = _("Base URL (OMD Site)"),
- help = _("The base URL to the monitoring instance. For example <tt>http://<hostname>/<siteid></tt>. You can use "
+ help = _("The base URL to the monitoring instance. For example <tt>http://mycheckmk01/mysite</tt>. You can use "
"macros like <tt>$HOSTADDRESS$</tt> and <tt>$HOSTNAME$</tt> within this URL to make them be replaced by "
"the hosts values."),
size = 60,
diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py
index ce8c924..6d825cb 100644
--- a/web/plugins/wato/check_mk_configuration.py
+++ b/web/plugins/wato/check_mk_configuration.py
@@ -986,10 +986,13 @@ register_configvar(group,
('num_groups', Integer(
title = _("Number of character groups to use"),
minvalue = 1,
- help = _("Make the user choose the password from this number of character groups. "
- "Character groups are: <ul><li>lowercase letters</li>"
+ maxvalue = 4,
+ help = _("Force the user to choose a password that contains characters from at least "
+ "this number of different character groups. "
+ "Character groups are: <ul>"
+ "<li>lowercase letters</li>"
"<li>uppercase letters</li>"
- "<li>numbers</li>"
+ "<li>digits</li>"
"<li>special characters such as an underscore or dash</li>"
"</ul>"),
)),
diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py
index aa2d69f..d12a487 100644
--- a/web/plugins/wato/check_parameters.py
+++ b/web/plugins/wato/check_parameters.py
@@ -528,9 +528,9 @@ register_rule(group + '/' + subgroup_inventory,
Dictionary(
title = _("Default parameters for detected services"),
help = _("Here you can select default parameters that are being set "
- "few detected services. Note: the preferred way is to use "
+ "for detected services. Note: the preferred way for setting parameters is to use "
"the rule set <a href='wato.py?varname=checkgroup_parameters%3Apsmode=edit_ruleset'> "
- "State and Count of Processes</a> instead for setting parameters. "
+ "State and Count of Processes</a> instead. "
"A change there will immediately be active, while a change in this rule "
"requires a re-discovery of the services."),
elements = process_level_elements,
@@ -3693,9 +3693,9 @@ register_check_parameters(
"oracle_dataguard_stats",
_("Oracle Data-Guard Stats"),
Dictionary(
- help = _("The Data-Guard are availible in Oracle Enterprise Edition with enabled Data-Guard. "
- "The init.ora Parameter dg_broker_start must be TRUE for this check. The apply and "
- "transport lag could be configured with this rule."),
+ help = _("The Data-Guard statistics are available in Oracle Enterprise Edition with enabled Data-Guard. "
+ "The <tt>init.ora</tt> parameter <tt>dg_broker_start</tt> must be <tt>TRUE</tt> for this check. "
+ "The apply and transport lag can be configured with this rule."),
elements = [
( "apply_lag",
Tuple(
@@ -4812,7 +4812,7 @@ register_rule(group + '/' + subgroup_inventory,
),
Integer(
title = _("Offset"),
- help = _("The Offset of the information relative to counter base"),
+ help = _("The offset of the information relative to counter base"),
allow_empty = False,
),
]),
Module: check_mk
Branch: master
Commit: 3223e5a4a51e5ead02c1e029b9b4302a2a63b601
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3223e5a4a51e5e…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Fri Jan 30 16:08:00 2015 +0100
#1971 FIX printer_input/printer_output: Discovery is using name field when available no
The service discovery of the printer_input/printer_output checks were always using
the index of the unit instead of the name. We have fixed this now.
You don't have to take an immediate action, because already discovered checks will
continue working. But your "Check_MK Discovery" service will report new services
and when you do a re-discovery, the new services will be found.
---
.werks/1971 | 15 +++++++++++++++
ChangeLog | 2 ++
checks/printer_io.include | 6 ++----
3 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/.werks/1971 b/.werks/1971
new file mode 100644
index 0000000..a4e2107
--- /dev/null
+++ b/.werks/1971
@@ -0,0 +1,15 @@
+Title: printer_input/printer_output: Discovery is using name field when available no
+Level: 1
+Component: checks
+Class: fix
+Compatible: incomp
+State: unknown
+Version: 1.2.7i1
+Date: 1422630051
+
+The service discovery of the printer_input/printer_output checks were always using
+the index of the unit instead of the name. We have fixed this now.
+
+You don't have to take an immediate action, because already discovered checks will
+continue working. But your "Check_MK Discovery" service will report new services
+and when you do a re-discovery, the new services will be found.
diff --git a/ChangeLog b/ChangeLog
index 6d1e1ce..6cce05e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -131,6 +131,8 @@
* 1969 FIX: apc_symmetra: Fix wrong critical state "0 batteries need replacement"
* 1926 FIX: ps: reenable compatiblity with existing configurations...
* 1970 FIX: lparstat_aix: Made the check compatible to different kind of lparstat output...
+ * 1971 FIX: printer_input/printer_output: Discovery is using name field when available no...
+ NOTE: Please refer to the migration notes!
Multisite:
* 1758 Improved exception hander: Shows details without additional debug request, added mailto link for error report...
diff --git a/checks/printer_io.include b/checks/printer_io.include
index 15ec0d1..f52dbf3 100644
--- a/checks/printer_io.include
+++ b/checks/printer_io.include
@@ -83,10 +83,8 @@ def inventory_printer_io(info):
# When no name is set
# a) try to use the description
# b) try to use the type otherwise use the index
- if not name and descr:
- name = descr
- else:
- name = index.split('.')[-1]
+ if not name:
+ name = descr and descr or index.split('.')[-1]
yield (name, {})
Module: check_mk
Branch: master
Commit: 7f30f6947df6df1fd40cc02fa71c93475c6ec461
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7f30f6947df6df…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Fri Jan 30 15:26:42 2015 +0100
Fixed last commit
---
checks/lparstat_aix | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/checks/lparstat_aix b/checks/lparstat_aix
index 732d5ce..30927bb 100644
--- a/checks/lparstat_aix
+++ b/checks/lparstat_aix
@@ -49,7 +49,7 @@
lparstat_default_levels = (5, 10)
def inventory_lparstat(info):
- if len(info) >= 1 and len(info[2]) >= 5:
+ if len(info) >= 1 and len(info[-1]) >= 5:
return [(None, "", "lparstat_default_levels")]
def check_lparstat(item, params, info):
@@ -72,9 +72,9 @@ def check_lparstat(item, params, info):
return 3, "Invalid output from agent"
else:
# The new agent provides three lines, the title line, spacer line and the values
- cols = [ c.replace('%', '') for c in info[0] ]
- uom = [ '%' in c and '%' or '' for c in info[0] ]
- values = info[2]
+ cols = [ c.replace('%', '') for c in info[-3] ]
+ uom = [ '%' in c and '%' or '' for c in info[-3] ]
+ values = info[-1]
perfdata = [ (cols[i], val+uom[i]) for i, val in enumerate(values) ]
output = ', '.join([ cols[i].title()+': '+val+uom[i] for i, val in enumerate(values) ])
@@ -92,14 +92,14 @@ check_info["lparstat_aix"] = {
kernel_util_default_levels = None
def inventory_lparstat_aix_cpu(info):
- if len(info) >= 1 and len(info[2]) >= 4:
+ if len(info) >= 1 and len(info[-1]) >= 4:
return [(None, "kernel_util_default_levels")]
def check_lparstat_aix_cpu(_no_item, params, info):
if len(info) == 1:
line = info[0] # old (single line) agent output
else:
- line = info[2]
+ line = info[-1]
user, system, wait, idle = map(float, line[:4])
perfdata = [
( "user", "%.3f" % user ),