Checkmk git commits December 2017

checkmk-commits@lists.checkmk.com

10 participants
219 discussions

Automatic clang-tidy fix for modernize-use-noexcept.

by Sven Panne

Module: check_mk Branch: master Commit: 961585118684f1f20de8f25d7a7e2a6c7cd75faa URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=961585118684f1… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 13:43:16 2017 +0100 Automatic clang-tidy fix for modernize-use-noexcept. Change-Id: I2977dbfed339091f323c959d92e990c869365d11 --- .clang-tidy | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 8926a2b..b40ec82 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -43,11 +43,10 @@ # * modernize-pass-by-value # * modernize-use-default-member-init # * modernize-use-equals-delete -# * modernize-use-noexcept # * performance-unnecessary-value-param # * readability-named-parameter # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-explicit-constructor,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-deprecated-headers,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-modernize-use-noexcept,-performance-unnecessary-value-param,-readability-named-parameter' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-explicit-constructor,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-deprecated-headers,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param,-readability-named-parameter' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1'

6 years, 7 months

Added missing dependency (for fresh checkout).

by Sven Panne

Module: check_mk Branch: master Commit: ce8eecf3e1c8a2e7499d7329619281b576a50415 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ce8eecf3e1c8a2… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 12:51:07 2017 +0100 Added missing dependency (for fresh checkout). Change-Id: I70d6dc8c0187e9fe55b60931c3affd1ef57f8139 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 2afb60b..a653da8 100644 --- a/Makefile +++ b/Makefile @@ -484,7 +484,7 @@ ifeq ($(ENTERPRISE),yes) $(MAKE) -C enterprise/core -j4 endif -tidy: +tidy: config.h $(MAKE) -C livestatus/src tidy ifeq ($(ENTERPRISE),yes) $(MAKE) -C enterprise/core/src tidy

6 years, 7 months

Overhaul clang-tidy handling.

by Sven Panne

Module: check_mk Branch: master Commit: 38820f099fc5fbc3c3db062fc3ca3b8b08617b30 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=38820f099fc5fb… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 11:33:11 2017 +0100 Overhaul clang-tidy handling. * Use local compilation databases. * Run clang-tidy via wrapper in parallel, speeding things up tremendously. * Temporarily disable a few checs, we will re-enable them soon. Change-Id: Icce5368a4c8ff88b075ffae3caab7719c0e6806d --- .clang-tidy | 21 ++++++++++++++++++++- Makefile | 10 +++++++--- configure.ac | 2 +- livestatus/src/Makefile.am | 13 +++++++++++++ 4 files changed, 41 insertions(+), 5 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 46467a1..bea4985 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -30,7 +30,26 @@ # * cppcoreguidelines-pro-type-union-access ("do not access members of unions; use (boost::)variant instead") # * modernize-use-bool-literals ("converting integer literal to bool, use bool literal instead") Incorrectly triggered by e.g. FD_ZERO # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals' +# * temporarily disabled: +# * clang-analyzer-optin.performance.Padding +# * cppcoreguidelines-special-member-functions +# * google-build-using-namespace +# * google-explicit-constructor +# * google-readability-todo +# * hicpp-explicit-conversions +# * hicpp-use-equals-delete +# * hicpp-special-member-functions +# * modernize-deprecated-headers +# * modernize-pass-by-value +# * modernize-use-default-member-init +# * modernize-use-equals-delete +# * modernize-use-noexcept +# * performance-unnecessary-value-param +# * readability-avoid-const-params-in-decls +# * readability-implicit-bool-cast +# * readability-named-parameter +# +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-explicit-constructor,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-deprecated-headers,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-modernize-use-noexcept,-performance-unnecessary-value-param,-readability-avoid-const-params-in-decls,-readability-implicit-bool-cast,-readability-named-parameter' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1' diff --git a/Makefile b/Makefile index 2ebb43b..2afb60b 100644 --- a/Makefile +++ b/Makefile @@ -70,6 +70,7 @@ CXX_FLAGS += -std=c++14 CLANG_VERSION := 5.0 CLANG_FORMAT := clang-format-$(CLANG_VERSION) CLANG_TIDY := clang-tidy-$(CLANG_VERSION) +export RUN_CLANG_TIDY := run-clang-tidy-$(CLANG_VERSION).py SCAN_BUILD := scan-build-$(CLANG_VERSION) CPPCHECK := cppcheck DOXYGEN := doxygen @@ -91,7 +92,7 @@ IWYU_TOOL := iwyu_tool # git clone https://github.com/rizsotto/Bear.git && cd Bear && git checkout 2.2.0 && cmake -DCMAKE_INSTALL_PREFIX=$HOME/local/Bear-2.2.0 && make install # and put $HOME/local/Bear-2.2.0/bin into your PATH or set the make variable # below accordingly. -BEAR := bear +export BEAR := bear M4_DEPS := $(wildcard m4/*) configure.ac CONFIGURE_DEPS := $(M4_DEPS) aclocal.m4 @@ -483,8 +484,11 @@ ifeq ($(ENTERPRISE),yes) $(MAKE) -C enterprise/core -j4 endif -tidy: compile_commands.json - @scripts/compiled_sources | xargs $(CLANG_TIDY) --extra-arg=-D__clang_analyzer__ +tidy: + $(MAKE) -C livestatus/src tidy +ifeq ($(ENTERPRISE),yes) + $(MAKE) -C enterprise/core/src tidy +endif # Not really perfect rules, but better than nothing iwyu: compile_commands.json diff --git a/configure.ac b/configure.ac index bdd8d5d..c30008d 100644 --- a/configure.ac +++ b/configure.ac @@ -26,7 +26,7 @@ AC_PREREQ(2.61) AC_INIT([MK Livestatus], [1.5.0i2], [mk(a)mathias-kettner.de]) -AM_INIT_AUTOMAKE([-Wall foreign]) +AM_INIT_AUTOMAKE([-Wall -Wno-portability foreign]) AC_CONFIG_MACRO_DIR([m4]) AC_CONFIG_SRCDIR([config.h.in]) AC_CONFIG_HEADER([config.h]) diff --git a/livestatus/src/Makefile.am b/livestatus/src/Makefile.am index 79a7227..9639f3d 100644 --- a/livestatus/src/Makefile.am +++ b/livestatus/src/Makefile.am @@ -22,6 +22,10 @@ # to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, # Boston, MA 02110-1301 USA. +CLANG_VERSION ?= 5.0 +RUN_CLANG_TIDY ?= run-clang-tidy-$(CLANG_VERSION).py +BEAR ?= bear + bin_PROGRAMS = unixcat unixcat_SOURCES = unixcat.cc @@ -149,6 +153,8 @@ liblivestatus_a_SOURCES = \ pnp4nagios.cc \ strutil.cc +.PHONY: tidy + liblivestatus_a_CPPFLAGS = -I.. @BOOST_CPPFLAGS@ liblivestatus_a_CXXFLAGS = -fPIC @@ -160,6 +166,13 @@ livestatus.o: $(liblivestatus_a_OBJECTS) $(CXX) $(liblivestatus_a_CXXFLAGS) $(CXXFLAGS) NagiosMockup.o $@ -o NagiosMockup $(RM) NagiosMockup +compile_commands.json: Makefile $(wildcard *.cc *.h) + $(MAKE) clean + $(BEAR) $(MAKE) -j4 + +tidy: compile_commands.json + $(RUN_CLANG_TIDY) -quiet -j6 + all-local: livestatus.o install-data-local:

6 years, 7 months

Skip omd/packages when indexing.

by Sven Panne

Module: check_mk Branch: master Commit: ee7a64184fc5d7893099bb23a0067838d0d141f6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ee7a64184fc5d7… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 11:09:50 2017 +0100 Skip omd/packages when indexing. Change-Id: I5b52917b29c890dfc0e230155c1dcb35183e3a33 --- gtags.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtags.conf b/gtags.conf index 636f776..f90830d 100644 --- a/gtags.conf +++ b/gtags.conf @@ -1,3 +1,3 @@ default:\ - :skip=/doc/treasures/,/livestatus/api/,/agents/windows/msibuild/,/enterprise/core/src/livestatus/upstream/,HTML/,HTML.pub/,tags,TAGS,ID,y.tab.c,y.tab.h,gtags.files,cscope.files,cscope.out,cscope.po.out,cscope.in.out,SCCS/,RCS/,CVS/,CVSROOT/,{arch}/,autom4te.cache/,*.orig,*.rej,*.bak,*~,#*#,*.swp,*.tmp,*_flymake.*,*_flymake:\ + :skip=/doc/treasures/,/livestatus/api/,/agents/windows/msibuild/,/enterprise/core/src/livestatus/upstream/,/omd/packages/,HTML/,HTML.pub/,tags,TAGS,ID,y.tab.c,y.tab.h,gtags.files,cscope.files,cscope.out,cscope.po.out,cscope.in.out,SCCS/,RCS/,CVS/,CVSROOT/,{arch}/,autom4te.cache/,*.orig,*.rej,*.bak,*~,#*#,*.swp,*.tmp,*_flymake.*,*_flymake:\ :langmap=c\:.c,yacc\:.y,asm\:.s.S,java\:.java,cpp\:.c++.cc.hh.cpp.cxx.hxx.hpp.C.H.h,php\:.php.php3.phtml:

6 years, 7 months

Small IWYU tweaks.

by Sven Panne

Module: check_mk Branch: master Commit: 987dce81e9aae59ea053b16109636496ff4336e7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=987dce81e9aae5… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 10:36:52 2017 +0100 Small IWYU tweaks. Change-Id: I66d2513b9b35227d3cb007ed2a80c487b737ad39 --- livestatus/src/TableStateHistory.cc | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/livestatus/src/TableStateHistory.cc b/livestatus/src/TableStateHistory.cc index d2a3ae7..b4a1621 100644 --- a/livestatus/src/TableStateHistory.cc +++ b/livestatus/src/TableStateHistory.cc @@ -54,8 +54,10 @@ class AndingFilter; class OringFilter; #ifdef CMC -#include "Host.h" -#include "Service.h" +// This seems to be an IWYU bug: If we remove the includes as suggested, we +// would do a member access on an incomplete type. +#include "Host.h" // IWYU pragma: keep +#include "Service.h" // IWYU pragma: keep #include "Timeperiod.h" #include "cmc.h" #define STATE_OK 0

6 years, 7 months

5568 FIX Fixed breaking report elements when reloading edit page

by Lars Michelsen

Module: check_mk Branch: master Commit: 5ae73cb25dbf16be8f56c96d36721ff72fef4baf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5ae73cb25dbf16… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Dec 7 16:32:40 2017 +0100 5568 FIX Fixed breaking report elements when reloading edit page When opening a report element for editing which e.g. has a context configured and reloading the page multiple times, the conditions may be modified which leads to issues when trying to save the element. e.g. a service could change from "Check_MK" to "{'service': u'Check_MK'}". Change-Id: I9c7310d008df09525ca39c91fd6515b8983cf4c9 --- .werks/5568 | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.werks/5568 b/.werks/5568 new file mode 100644 index 0000000..e4d69ac --- /dev/null +++ b/.werks/5568 @@ -0,0 +1,15 @@ +Title: Fixed breaking report elements when reloading edit page +Level: 1 +Component: reporting +Class: fix +Compatible: compat +Edition: cee +State: unknown +Version: 1.5.0i2 +Date: 1512660674 + +When opening a report element for editing which e.g. has a context configured +and reloading the page multiple times, the conditions may be modified which +leads to issues when trying to save the element. + +e.g. a service could change from "Check_MK" to "{'service': u'Check_MK'}".

6 years, 7 months

Automatic clang-tidy fix for modernize-use-using.

by Sven Panne

Module: check_mk Branch: master Commit: f8549085627fdda513ed5267d9a80b0ae2577daf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f8549085627fdd… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Dec 7 22:06:01 2017 +0100 Automatic clang-tidy fix for modernize-use-using. Change-Id: Ia7de50fb0b3fbeb7df045bd3f383672b75403ed7 --- livestatus/src/HostServiceState.h | 4 ++-- livestatus/src/TableEventConsole.h | 2 +- livestatus/src/contact_fwd.h | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/livestatus/src/HostServiceState.h b/livestatus/src/HostServiceState.h index 0782647..88a8b2c 100644 --- a/livestatus/src/HostServiceState.h +++ b/livestatus/src/HostServiceState.h @@ -39,9 +39,9 @@ class HostServiceState; #include "nagios.h" #endif -typedef std::vector<HostServiceState *> HostServices; +using HostServices = std::vector<HostServiceState *>; -typedef void *HostServiceKey; +using HostServiceKey = void *; class HostServiceState { public: diff --git a/livestatus/src/TableEventConsole.h b/livestatus/src/TableEventConsole.h index a333319..3af1d39 100644 --- a/livestatus/src/TableEventConsole.h +++ b/livestatus/src/TableEventConsole.h @@ -142,7 +142,7 @@ protected: }; class ListEventConsoleColumn : public ListColumn { - typedef std::vector<std::string> _column_t; + using _column_t = std::vector<std::string>; EventConsoleColumn<_column_t> _ecc; public: diff --git a/livestatus/src/contact_fwd.h b/livestatus/src/contact_fwd.h index 3cf0d03..a6a7869 100644 --- a/livestatus/src/contact_fwd.h +++ b/livestatus/src/contact_fwd.h @@ -27,11 +27,11 @@ #if defined(CMC) class Contact; -typedef Contact contact; +using contact = Contact; #elif defined(NAGIOS4) typedef struct contact contact; #else -typedef struct contact_struct contact; +using contact = struct contact_struct; #endif #endif // contact_fwd_h

6 years, 7 months

Automatic clang-tidy fix for modernize-use-equals-default.

by Sven Panne

Module: check_mk Branch: master Commit: cef483db47699569fa43bf4010f3c24dd5c6df78 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cef483db476995… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Dec 7 22:15:23 2017 +0100 Automatic clang-tidy fix for modernize-use-equals-default. Change-Id: I993ac0fcfcaae2f895963bd0a95ce0899ef4d449 --- livestatus/src/Column.h | 2 +- livestatus/src/DynamicLogwatchFileColumn.h | 2 +- livestatus/src/FilterVisitor.h | 2 +- livestatus/src/Logger.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/livestatus/src/Column.h b/livestatus/src/Column.h index 4098c44..fcead0b 100644 --- a/livestatus/src/Column.h +++ b/livestatus/src/Column.h @@ -54,7 +54,7 @@ class Column { public: Column(std::string name, std::string description, int indirect_offset, int extra_offset, int extra_extra_offset, int offset); - virtual ~Column() {} + virtual ~Column() = default; std::string name() const { return _name; } std::string description() const { return _description; } diff --git a/livestatus/src/DynamicLogwatchFileColumn.h b/livestatus/src/DynamicLogwatchFileColumn.h index c5063e3..e071935 100644 --- a/livestatus/src/DynamicLogwatchFileColumn.h +++ b/livestatus/src/DynamicLogwatchFileColumn.h @@ -42,7 +42,7 @@ public: : DynamicColumn(name, description, logger, indirect_offset, extra_offset, extra_extra_offset) , _mc(mc) {} - ~DynamicLogwatchFileColumn() override {} + ~DynamicLogwatchFileColumn() override = default; std::unique_ptr<Column> createColumn(const std::string &name, const std::string &arguments) override; diff --git a/livestatus/src/FilterVisitor.h b/livestatus/src/FilterVisitor.h index 6028b8c..cc82d84 100644 --- a/livestatus/src/FilterVisitor.h +++ b/livestatus/src/FilterVisitor.h @@ -32,7 +32,7 @@ class OringFilter; class FilterVisitor { public: - virtual ~FilterVisitor() {} + virtual ~FilterVisitor() = default; virtual void visit(const ColumnFilter &) = 0; virtual void visit(const AndingFilter &) = 0; virtual void visit(const OringFilter &) = 0; diff --git a/livestatus/src/Logger.h b/livestatus/src/Logger.h index f97c6b4..df378b1 100644 --- a/livestatus/src/Logger.h +++ b/livestatus/src/Logger.h @@ -62,7 +62,7 @@ public: : _level(level) , _message(message) , _time_point(std::chrono::system_clock::now()) {} - virtual ~LogRecord() {} + virtual ~LogRecord() = default; LogLevel getLevel() const { return _level; } void setLevel(LogLevel level) { _level = level; }

6 years, 7 months

Exclude llvm-header-guard check for now.

by Sven Panne

Module: check_mk Branch: master Commit: 6d856f301c06f7d00212ba143c21e73101270f80 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6d856f301c06f7… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Dec 7 22:19:15 2017 +0100 Exclude llvm-header-guard check for now. Change-Id: Ia8f9a2f0c873585e204657ca6b6cc55b9df5b728 --- .clang-tidy | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.clang-tidy b/.clang-tidy index aeabfec..46467a1 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -23,13 +23,14 @@ # * cppcoreguidelines-pro-type-reinterpret-cast ("do not use reinterpret_cast") # * cppcoreguidelines-pro-type-vararg ("do not call c-style vararg functions") # * hicpp-member-init: alias for cppcoreguidelines-pro-type-member-init +# * llvm-header-guard ("header guard does not follow preferred style") tricky to get right with the current bear/clang-tidy/symlink situation # # * desirable checks, but some places need to be suppressed: # * cppcoreguidelines-pro-type-const-cast ("do not use const_cast") # * cppcoreguidelines-pro-type-union-access ("do not access members of unions; use (boost::)variant instead") # * modernize-use-bool-literals ("converting integer literal to bool, use bool literal instead") Incorrectly triggered by e.g. FD_ZERO # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-include-order,-modernize-use-bool-literals' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1'

6 years, 7 months

Automatic clang-tidy fix for modernize-use-override.

by Sven Panne

Module: check_mk Branch: master Commit: 350af53624be980257d225bbfbbf4080fd02aed0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=350af53624be98… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Thu Dec 7 22:11:18 2017 +0100 Automatic clang-tidy fix for modernize-use-override. Change-Id: I012e26b4d9bd1450fa461fe08a306bbe0e9222ac --- livestatus/src/DynamicLogwatchFileColumn.h | 2 +- livestatus/src/Logger.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/livestatus/src/DynamicLogwatchFileColumn.h b/livestatus/src/DynamicLogwatchFileColumn.h index 152660b..c5063e3 100644 --- a/livestatus/src/DynamicLogwatchFileColumn.h +++ b/livestatus/src/DynamicLogwatchFileColumn.h @@ -42,7 +42,7 @@ public: : DynamicColumn(name, description, logger, indirect_offset, extra_offset, extra_extra_offset) , _mc(mc) {} - virtual ~DynamicLogwatchFileColumn() {} + ~DynamicLogwatchFileColumn() override {} std::unique_ptr<Column> createColumn(const std::string &name, const std::string &arguments) override; diff --git a/livestatus/src/Logger.h b/livestatus/src/Logger.h index 5fcc56a..f97c6b4 100644 --- a/livestatus/src/Logger.h +++ b/livestatus/src/Logger.h @@ -176,7 +176,7 @@ public: class ConcreteLogger : public Logger { public: ConcreteLogger(const std::string &name, Logger *parent); - ~ConcreteLogger(); + ~ConcreteLogger() override; std::string getName() const override;

6 years, 7 months

← Newer
1
...
12
13
14
15
16
17
18
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits December 2017