Checkmk git commits December 2017

checkmk-commits@lists.checkmk.com

10 participants
219 discussions

Standardized show_title/title_format render options

by Lars Michelsen

Module: check_mk Branch: master Commit: 4f54026c9a9a20d3d7906673ce4f2cbfc997ca3f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4f54026c9a9a20… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Dec 8 08:54:20 2017 +0100 Standardized show_title/title_format render options Change-Id: I6dcdf1cc608d14ac481c88d666dae451c9eb3fd8 --- web/htdocs/metrics.py | 3 ++- web/plugins/dashboard/dashlets.py | 8 +++++++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/web/htdocs/metrics.py b/web/htdocs/metrics.py index 038d199..358648a 100644 --- a/web/htdocs/metrics.py +++ b/web/htdocs/metrics.py @@ -1544,7 +1544,8 @@ def host_service_graph_popup_pnp(site, host_name, service_description): default_dashlet_graph_render_options = { "font_size" : 8, "show_legend" : False, - "show_service" : True, + "title_format" : ("add_title_infos", [ "add_host_name", + "add_service_description" ]), "show_controls" : False, "resizable" : False, "show_time_range_previews" : False, diff --git a/web/plugins/dashboard/dashlets.py b/web/plugins/dashboard/dashlets.py index 4db7889..cdc007a 100644 --- a/web/plugins/dashboard/dashlets.py +++ b/web/plugins/dashboard/dashlets.py @@ -366,9 +366,15 @@ def dashlet_graph(nr, dashlet): def dashlet_graph_reload_js(nr, dashlet): # Be compatible to pre 1.5.0i2 format if "graph_render_options" not in dashlet: + if dashlet.pop("show_service", True): + title_format = ("add_title_infos", ["add_host_name", + "add_service_description"]) + else: + title_format = ("plain", []) + dashlet["graph_render_options"] = { "show_legend" : dashlet.pop("show_legend", False), - "show_service" : dashlet.pop("show_service", True), + "title_format" : title_format, } host = dashlet['context'].get('host', html.var("host"))

6 years, 6 months

Fixed painter "Graph with timeranges"

by Lars Michelsen

Module: check_mk Branch: master Commit: 8f65a3353ed728688b607de3ec3e114d7b68fab9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8f65a3353ed728… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Dec 12 11:17:24 2017 +0100 Fixed painter "Graph with timeranges" Change-Id: I82c38dbf34f4c6b22f41b80d2252c61a8bf164d8 --- web/plugins/views/painters.py | 42 +++++++----------------------------------- 1 file changed, 7 insertions(+), 35 deletions(-) diff --git a/web/plugins/views/painters.py b/web/plugins/views/painters.py index 5618784..083c03a 100644 --- a/web/plugins/views/painters.py +++ b/web/plugins/views/painters.py @@ -1000,40 +1000,7 @@ def paint_time_graph(row, cell): return paint_time_graph_pnp(row) -def time_graph_params(): - if not metrics.cmk_graphs_possible(): - return # The method is only available in CEE - - elements = [ - ("set_default_time_range", DropdownChoice( - title = _("Set default time range"), - choices = [ (entry["duration"], entry["title"]) - for entry in config.graph_timeranges ], - )), - ("graph_render_options", metrics.vs_graph_render_options()) - ] - - return Transform( - Dictionary( - elements=elements, - optional_keys=[], - ), - forth=_transform_old_graph_render_options, - ) - -def _transform_old_graph_render_options(value): - # Be compatible to pre 1.5.0i2 format - if "graph_render_options" not in value: - value = copy.deepcopy(value) - value["graph_render_options"] = { - "show_legend" : value.pop("show_legend", True), - "show_controls" : value.pop("show_controls", True), - "show_time_range_previews" : value.pop("show_time_range_previews", True), - } - return value - - -def paint_time_graph_cmk(row, cell): +def paint_time_graph_cmk(row, cell, override_graph_render_options=None): graph_identification = ( "template", { "site" : row["site"], @@ -1054,12 +1021,17 @@ def paint_time_graph_cmk(row, cell): if options != None: graph_render_options.update(options) + if override_graph_render_options != None: + graph_render_options.update(override_graph_render_options) + graph_data_range = {} + now = time.time() if "set_default_time_range" in painter_params: duration = painter_params["set_default_time_range"] - now = time.time() graph_data_range["time_range"] = now - duration, now + else: + graph_data_range["time_range"] = now - 3600*4, now # Load timerange from painter option (overrides the defaults, if set by the user) painter_option_pnp_timerange = painter_options.get_without_default("pnp_timerange")

6 years, 6 months

5569 Graph layout is now more customizable

by Lars Michelsen

Module: check_mk Branch: master Commit: b1e91b67a4944451ef4817a4e65f684aa64e8c9e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b1e91b67a49444… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Dec 12 08:22:05 2017 +0100 5569 Graph layout is now more customizable The styling of the Check_MK graphs has now been unified for the most places where the graphs are rendered: <ul> <li>Regular graph dashlets</li> <li>Custom graph dashlets</li> <li>Graphs in views</li> <li>Graphs in reports</li> </ul> These standard render options are now available: <ul> <li>Font size</li> <li>Title (Show, show inline, hide)</li> <li>Add host/service information to title</li> <li>Show time range of graph (top right)</li> <li>Show margin round the graph</li> <li>Show graph legend</li> <li>Show vertical axis</li> <li>Show time axis</li> <li>Show graph controls</li> <li>Show pin</li> <li>Show previews</li> </ul> Some of these options are specific for the medium they are rendered on. For example the graph controls are not available in graphs rendered in reports. These options are hidden from the configuration. Change-Id: I700ae5784fc1ab1b38b26d2d2d07d98ab42b04d1 --- .werks/5569 | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/.werks/5569 b/.werks/5569 new file mode 100644 index 0000000..92fd8b2 --- /dev/null +++ b/.werks/5569 @@ -0,0 +1,39 @@ +Title: Graph layout is now more customizable +Level: 2 +Component: metrics +Compatible: compat +Edition: cee +Version: 1.5.0i2 +Date: 1513062793 +Class: feature + +The styling of the Check_MK graphs has now been unified for the most +places where the graphs are rendered: + +<ul> +<li>Regular graph dashlets</li> +<li>Custom graph dashlets</li> +<li>Graphs in views</li> +<li>Graphs in reports</li> +</ul> + +These standard render options are now available: + +<ul> +<li>Font size</li> +<li>Title (Show, show inline, hide)</li> +<li>Add host/service information to title</li> +<li>Show time range of graph (top right)</li> +<li>Show margin round the graph</li> +<li>Show graph legend</li> +<li>Show vertical axis</li> +<li>Show time axis</li> +<li>Show graph controls</li> +<li>Show pin</li> +<li>Show previews</li> +<li>Colors (Background, foreground, canvas)</li> +</ul> + +Some of these options are specific for the medium they are rendered +on. For example the graph controls are not available in graphs rendered +in reports. These options are hidden from the configuration.

6 years, 6 months

Custom graph dashlets now also use standard graph render options

by Lars Michelsen

Module: check_mk Branch: master Commit: e316b9a9677af07d58869840e18244aae515d1b2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e316b9a9677af0… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 11 10:16:11 2017 +0100 Custom graph dashlets now also use standard graph render options Change-Id: I145c91615837e6653689e533d938cd21a296d3b8 --- web/htdocs/dashboard.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/dashboard.py b/web/htdocs/dashboard.py index b2aba17..b6543d3 100644 --- a/web/htdocs/dashboard.py +++ b/web/htdocs/dashboard.py @@ -1102,7 +1102,7 @@ def page_edit_dashlet(): elements = params, ) - elif isinstance(params, Dictionary): + elif isinstance(params, Dictionary) or isinstance(params, Transform): vs_type = params elif type(params) == type(lambda x: x):

6 years, 6 months

HTML graphs: Made spacing sizes relative to font size

by Lars Michelsen

Module: check_mk Branch: master Commit: 842292b69e8bde8a66c392b4d70613d6b36b844a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=842292b69e8bde… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 11 16:41:58 2017 +0100 HTML graphs: Made spacing sizes relative to font size Change-Id: Ib043b88ff023731186534bf5b57c26e570e44fdb --- web/htdocs/metrics.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/htdocs/metrics.py b/web/htdocs/metrics.py index 195dca8..63ccf59 100644 --- a/web/htdocs/metrics.py +++ b/web/htdocs/metrics.py @@ -1579,8 +1579,8 @@ def host_service_graph_dashlet_cmk(graph_identification, custom_graph_render_opt int(float(html.var("height"))/html_size_per_ex)) height -= _graph_title_height_ex(graph_render_options) - height -= (_graph_top_margin_px(graph_render_options) + _graph_bottom_margin_px(graph_render_options)) / html_size_per_ex - width -= (_graph_left_margin_px(graph_render_options) + _graph_right_margin_px(graph_render_options)) / html_size_per_ex + height -= _graph_top_margin_ex(graph_render_options) + _graph_bottom_margin_ex(graph_render_options) + width -= _graph_left_margin_ex(graph_render_options) + _graph_right_margin_ex(graph_render_options) graph_render_options["size"] = (width, height)

6 years, 6 months

Add option to show/hide the graph margin space

by Lars Michelsen

Module: check_mk Branch: master Commit: d2556b9f1e58e039f7eeb41effe1f2fb38ca6a40 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d2556b9f1e58e0… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Dec 11 13:38:35 2017 +0100 Add option to show/hide the graph margin space Change-Id: Idaa7f6ada2adfcf85e16bf1d1bf1bd54477ef67f --- web/htdocs/metrics.py | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/web/htdocs/metrics.py b/web/htdocs/metrics.py index 358648a..195dca8 100644 --- a/web/htdocs/metrics.py +++ b/web/htdocs/metrics.py @@ -1571,13 +1571,19 @@ def page_graph_dashlet(): def host_service_graph_dashlet_cmk(graph_identification, custom_graph_render_options): - size = (int(((float(html.var("width")) - 25)/html_size_per_ex)), - int((float(html.var("height")) - 18)/html_size_per_ex)) - graph_render_options = default_dashlet_graph_render_options.copy() - graph_render_options["size"] = size + graph_render_options = add_default_render_options(graph_render_options) graph_render_options.update(custom_graph_render_options) + width, height = (int((float(html.var("width"))/html_size_per_ex)), + int(float(html.var("height"))/html_size_per_ex)) + + height -= _graph_title_height_ex(graph_render_options) + height -= (_graph_top_margin_px(graph_render_options) + _graph_bottom_margin_px(graph_render_options)) / html_size_per_ex + width -= (_graph_left_margin_px(graph_render_options) + _graph_right_margin_px(graph_render_options)) / html_size_per_ex + + graph_render_options["size"] = (width, height) + # The timerange is specified in PNP like manner. range_secs = { "0" : 4 * 3600, @@ -1613,7 +1619,10 @@ def host_service_graph_dashlet_cmk(graph_identification, custom_graph_render_opt if graph_render_options["show_legend"]: # TODO FIXME: This graph artwork is calulated twice. Once here and once in render_graphs_from_specification_html() graph_artwork = compute_graph_artwork(graph_recipe, graph_data_range, graph_render_options) - graph_render_options["size"] = (size[0], size[1] - graph_legend_height_ex(graph_render_options, graph_artwork)) + graph_render_options["size"] = ( + graph_render_options["size"][0], + graph_render_options["size"][1] - graph_legend_height_ex(graph_render_options, graph_artwork) + ) html_code = render_graphs_from_definitions([graph_recipe], graph_data_range, graph_render_options, render_async=False) html.write(html_code)

6 years, 6 months

Unified default graph layout parameters for views

by Lars Michelsen

Module: check_mk Branch: master Commit: 315466e64e6c0d1d4547e255a28fcd3b9b2d9e35 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=315466e64e6c0d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Dec 7 15:49:48 2017 +0100 Unified default graph layout parameters for views Change-Id: I2605d29e326dc8c31097f54f9cb702c7e66d60c6 --- web/htdocs/dashboard.py | 4 +++ web/plugins/dashboard/dashlets.py | 76 +++++++++++++++++++++++---------------- web/plugins/views/painters.py | 52 ++++++++++++++++++++------- 3 files changed, 90 insertions(+), 42 deletions(-) diff --git a/web/htdocs/dashboard.py b/web/htdocs/dashboard.py index 8389e33..b2aba17 100644 --- a/web/htdocs/dashboard.py +++ b/web/htdocs/dashboard.py @@ -1101,6 +1101,10 @@ def page_edit_dashlet(): validate = dashlet_type.get('validate_params'), elements = params, ) + + elif isinstance(params, Dictionary): + vs_type = params + elif type(params) == type(lambda x: x): # It's a tuple of functions which should be used to render and parse the params render_input_func, handle_input_func = params() diff --git a/web/plugins/dashboard/dashlets.py b/web/plugins/dashboard/dashlets.py index 9e0f7d8..ae45110 100644 --- a/web/plugins/dashboard/dashlets.py +++ b/web/plugins/dashboard/dashlets.py @@ -364,6 +364,13 @@ def dashlet_graph(nr, dashlet): def dashlet_graph_reload_js(nr, dashlet): + # Be compatible to pre 1.5.0i2 format + if "graph_render_options" not in dashlet: + dashlet["graph_render_options"] = { + "show_legend" : dashlet.pop("show_legend", False), + "show_service" : dashlet.pop("show_service", True), + } + host = dashlet['context'].get('host', html.var("host")) if not host: raise MKUserError('host', _('Missing needed host parameter.')) @@ -396,27 +403,16 @@ def dashlet_graph_reload_js(nr, dashlet): "service_description" : service, "graph_index" : dashlet["source"] -1, }) - graph_render_options = { - "show_legend": dashlet.get("show_legend", False), - "show_service" : dashlet.get("show_service", True), - } + + graph_render_options = dashlet["graph_render_options"] return "dashboard_render_graph(%d, %s, %s, '%s')" % \ (nr, json.dumps(graph_identification), json.dumps(graph_render_options), timerange) -dashlet_types["pnpgraph"] = { - "title" : _("Performance Graph"), - "sort_index" : 20, - "description" : _("Displays a performance graph of a host or service."), - "render" : dashlet_graph, - "refresh" : 60, - "size" : (60, 21), - "allowed" : config.builtin_role_ids, - "infos" : ["service", "host"], - "single_infos" : ["service", "host"], - "parameters" : [ - # Cleanup: switch to generic Timerange() valuespec! +def pnpgraph_parameters(): + elements = [ + # TODO: Cleanup: switch to generic Timerange() valuespec! ("timerange", DropdownChoice( title = _('Timerange'), default_value = '1', @@ -431,20 +427,40 @@ dashlet_types["pnpgraph"] = { default_value = 1, minvalue = 1, )), - ("show_legend", Checkbox( - title = _("Show Legend"), - label = _("Show the legend area of the graph"), - help = _("This option controls whether or not the legend below the graph " - "area should be shown. This option is only used by the new Check_MK " - "graphs which are only available in the Check_MK Enterprise Edition."), - default_value = False, - )), - ("show_service", Checkbox( - title = _("Show host/service name in title"), - label = _("Add the host/service to the graph title"), - default_value = True, - )), - ], + ] + + import metrics + if metrics.cmk_graphs_possible(): + elements += [ + ("graph_render_options", metrics.vs_graph_render_options( + default_values={ + "show_service": True, + }, + exclude=[ + "show_time_range_previews", + ], + )), + ] + + return elements + + +dashlet_types["pnpgraph"] = { + "title" : _("Performance Graph"), + "sort_index" : 20, + "description" : _("Displays a performance graph of a host or service."), + "render" : dashlet_graph, + "refresh" : 60, + "size" : (60, 21), + "allowed" : config.builtin_role_ids, + "infos" : ["service", "host"], + "single_infos" : ["service", "host"], + "parameters" : Dictionary( + title = _('Properties'), + render = 'form', + optional_keys = [], + elements = pnpgraph_parameters, + ), "styles": """ .dashlet.pnpgraph .dashlet_inner { background-color: #f8f4f0; diff --git a/web/plugins/views/painters.py b/web/plugins/views/painters.py index be8c166..5618784 100644 --- a/web/plugins/views/painters.py +++ b/web/plugins/views/painters.py @@ -63,6 +63,7 @@ # change in future. import traceback +import copy import bi # Needed for BI Icon. For arkane reasons (ask htdocs/module.py) this # cannot be imported in views.py directly. @@ -1000,13 +1001,39 @@ def paint_time_graph(row, cell): def time_graph_params(): - try: - return metrics.vs_graph_render_options() - except AttributeError: - return None # The method is only available in CEE + if not metrics.cmk_graphs_possible(): + return # The method is only available in CEE + + elements = [ + ("set_default_time_range", DropdownChoice( + title = _("Set default time range"), + choices = [ (entry["duration"], entry["title"]) + for entry in config.graph_timeranges ], + )), + ("graph_render_options", metrics.vs_graph_render_options()) + ] + + return Transform( + Dictionary( + elements=elements, + optional_keys=[], + ), + forth=_transform_old_graph_render_options, + ) + +def _transform_old_graph_render_options(value): + # Be compatible to pre 1.5.0i2 format + if "graph_render_options" not in value: + value = copy.deepcopy(value) + value["graph_render_options"] = { + "show_legend" : value.pop("show_legend", True), + "show_controls" : value.pop("show_controls", True), + "show_time_range_previews" : value.pop("show_time_range_previews", True), + } + return value -def paint_time_graph_cmk(row, cell, show_timeranges=False): +def paint_time_graph_cmk(row, cell): graph_identification = ( "template", { "site" : row["site"], @@ -1017,19 +1044,20 @@ def paint_time_graph_cmk(row, cell, show_timeranges=False): # Load the graph render options from # a) the painter parameters configured in the view # b) the painter options set per user and view - graph_render_options = cell.painter_parameters().copy() - graph_data_range = {} - graph_render_options["show_time_range_previews"] = show_timeranges + painter_params = cell.painter_parameters() + painter_params = _transform_old_graph_render_options(painter_params) + + graph_render_options = painter_params["graph_render_options"] options = painter_options.get_without_default("graph_render_options") if options != None: graph_render_options.update(options) - # Do not load this setting form the painter options - del graph_render_options["set_default_time_range"] - if "set_default_time_range" in graph_render_options: - duration = graph_render_options["set_default_time_range"] + graph_data_range = {} + + if "set_default_time_range" in painter_params: + duration = painter_params["set_default_time_range"] now = time.time() graph_data_range["time_range"] = now - duration, now

6 years, 6 months

Allow also methods to be used as Dictionary() element generators

by Lars Michelsen

Module: check_mk Branch: master Commit: e48edb351936fa7fbdf5261bbcdee395fac5f4cf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e48edb351936fa… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Dec 7 16:44:14 2017 +0100 Allow also methods to be used as Dictionary() element generators Change-Id: Iad3d8a7af26b8294fcf385d073191d165bae70c0 --- web/htdocs/valuespec.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index 047d1c5..6f55971 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -3388,7 +3388,7 @@ class Dictionary(ValueSpec): return value def _get_elements(self): - if type(self._elements) == type(lambda: None): + if type(self._elements) == type(lambda: None) or isinstance(self._elements, types.MethodType): return self._elements() elif type(self._elements) == list: return self._elements

6 years, 6 months

AC tests: Links in details are underlined again

by Lars Michelsen

Module: check_mk Branch: master Commit: 15058ecc534fa8a0fd587b665f2eba464ad20c94 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=15058ecc534fa8… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Dec 8 10:16:04 2017 +0100 AC tests: Links in details are underlined again Change-Id: Ifc316fe6db83a14624f1b82bfef9f314b6639ebe --- web/htdocs/wato.css | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/web/htdocs/wato.css b/web/htdocs/wato.css index 76eef84..a3f4c45 100644 --- a/web/htdocs/wato.css +++ b/web/htdocs/wato.css @@ -1409,14 +1409,10 @@ table.nform.rulesettings td.legend div.title { background-repeat: repeat; } -.wato table.data.analyze_config td.title a { +.wato table.data.analyze_config tr.ac_test_details td a { text-decoration: underline; } -.wato table.data.analyze_config td.title a:hover { +.wato table.data.analyze_config tr.ac_test_details td a:hover { text-decoration: none; } - -.wato table.data.analyze_config td.result { - vertical-align: top; -}

6 years, 6 months

Use standard graph render options also for reports

by Lars Michelsen

Module: check_mk Branch: master Commit: cd187d9e2c43c13bdc6b4a548481474ec2f41e7e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cd187d9e2c43c1… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Dec 7 17:06:52 2017 +0100 Use standard graph render options also for reports font_size is now available as standard render option Change-Id: I0b81a2a816c4e09b164e2ff677c36680083374f3 --- web/htdocs/metrics.py | 19 +++++++++++-------- web/htdocs/valuespec.py | 11 +++++++++++ web/plugins/dashboard/dashlets.py | 4 +--- 3 files changed, 23 insertions(+), 11 deletions(-) diff --git a/web/htdocs/metrics.py b/web/htdocs/metrics.py index 9a2acd6..038d199 100644 --- a/web/htdocs/metrics.py +++ b/web/htdocs/metrics.py @@ -1541,6 +1541,15 @@ def host_service_graph_popup_pnp(site, host_name, service_description): # | This page handler is called by graphs embedded in a dashboard. | # '----------------------------------------------------------------------' +default_dashlet_graph_render_options = { + "font_size" : 8, + "show_legend" : False, + "show_service" : True, + "show_controls" : False, + "resizable" : False, + "show_time_range_previews" : False, +} + def page_graph_dashlet(): spec = html.var("spec") if not spec: @@ -1564,14 +1573,8 @@ def host_service_graph_dashlet_cmk(graph_identification, custom_graph_render_opt size = (int(((float(html.var("width")) - 25)/html_size_per_ex)), int((float(html.var("height")) - 18)/html_size_per_ex)) - graph_render_options = { - "size" : size, - "font_size" : 8, - "show_legend" : False, - "show_controls" : False, - "resizable" : False, - "show_time_range_previews" : False, - } + graph_render_options = default_dashlet_graph_render_options.copy() + graph_render_options["size"] = size graph_render_options.update(custom_graph_render_options) # The timerange is specified in PNP like manner. diff --git a/web/htdocs/valuespec.py b/web/htdocs/valuespec.py index 6f55971..0f3cea0 100644 --- a/web/htdocs/valuespec.py +++ b/web/htdocs/valuespec.py @@ -4350,6 +4350,17 @@ class TimeofdayRanges(Transform): ) + +class Fontsize(Float): + def __init__(self, **kwargs): + kwargs.setdefault("title", _("Font size")) + kwargs.setdefault("default_value", 10) + kwargs["size"] = 5 + kwargs["unit"] = _("pt") + super(Fontsize, self).__init__(**kwargs) + + + class Color(ValueSpec): def __init__(self, **kwargs): kwargs["regex"] = "#[0-9]{3,6}" diff --git a/web/plugins/dashboard/dashlets.py b/web/plugins/dashboard/dashlets.py index ae45110..4db7889 100644 --- a/web/plugins/dashboard/dashlets.py +++ b/web/plugins/dashboard/dashlets.py @@ -433,9 +433,7 @@ def pnpgraph_parameters(): if metrics.cmk_graphs_possible(): elements += [ ("graph_render_options", metrics.vs_graph_render_options( - default_values={ - "show_service": True, - }, + default_values=metrics.default_dashlet_graph_render_options, exclude=[ "show_time_range_previews", ],

6 years, 6 months

← Newer
1
...
9
10
11
12
13
14
15
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits December 2017