Checkmk git commits December 2017

checkmk-commits@lists.checkmk.com

10 participants
219 discussions

Automatic clang-tidy fix for performance-unnecessary-value-param.

by Sven Panne

Module: check_mk Branch: master Commit: 9f936f37861077cd8ecf4c393fb663dfad30e29e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9f936f37861077… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 15:05:33 2017 +0100 Automatic clang-tidy fix for performance-unnecessary-value-param. Change-Id: Ic5c06990ed4c257ef380cd020335738634a495d0 --- .clang-tidy | 3 +-- livestatus/src/CustomVarsDictColumn.h | 5 +++-- livestatus/src/DoubleAggregator.h | 3 ++- livestatus/src/IntAggregator.h | 2 +- livestatus/src/Renderer.h | 5 +++-- livestatus/src/TimeAggregator.h | 2 +- 6 files changed, 11 insertions(+), 9 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index ef8ae85..44a6a7d 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -35,9 +35,8 @@ # * cppcoreguidelines-special-member-functions # * hicpp-special-member-functions # * modernize-use-default-member-init -# * performance-unnecessary-value-param # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-hicpp-special-member-functions,-modernize-use-default-member-init,-performance-unnecessary-value-param' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-hicpp-special-member-functions,-modernize-use-default-member-init' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1' diff --git a/livestatus/src/CustomVarsDictColumn.h b/livestatus/src/CustomVarsDictColumn.h index 1807387..fb0e529 100644 --- a/livestatus/src/CustomVarsDictColumn.h +++ b/livestatus/src/CustomVarsDictColumn.h @@ -30,6 +30,7 @@ #include <memory> #include <string> #include <unordered_map> +#include <utility> #include "Column.h" #include "contact_fwd.h" #include "opids.h" @@ -43,8 +44,8 @@ public: CustomVarsDictColumn(std::string name, std::string description, int indirect_offset, int extra_offset, int extra_extra_offset, int offset) - : Column(name, description, indirect_offset, extra_offset, - extra_extra_offset, offset) {} + : Column(std::move(name), std::move(description), indirect_offset, + extra_offset, extra_extra_offset, offset) {} ColumnType type() const override { return ColumnType::dict; }; diff --git a/livestatus/src/DoubleAggregator.h b/livestatus/src/DoubleAggregator.h index fd8b106..45649e7 100644 --- a/livestatus/src/DoubleAggregator.h +++ b/livestatus/src/DoubleAggregator.h @@ -35,7 +35,8 @@ class RowRenderer; class DoubleAggregator : public Aggregator { public: - DoubleAggregator(AggregationFactory factory, const DoubleColumn *column) + DoubleAggregator(const AggregationFactory &factory, + const DoubleColumn *column) : _aggregation(factory()), _column(column) {} void consume(Row row, const contact * /*contact*/, diff --git a/livestatus/src/IntAggregator.h b/livestatus/src/IntAggregator.h index 33b9038..d162f28 100644 --- a/livestatus/src/IntAggregator.h +++ b/livestatus/src/IntAggregator.h @@ -35,7 +35,7 @@ class RowRenderer; class IntAggregator : public Aggregator { public: - IntAggregator(AggregationFactory factory, const IntColumn *column) + IntAggregator(const AggregationFactory &factory, const IntColumn *column) : _aggregation(factory()), _column(column) {} void consume(Row row, const contact *auth_user, diff --git a/livestatus/src/Renderer.h b/livestatus/src/Renderer.h index 8f312d6..624e1d7 100644 --- a/livestatus/src/Renderer.h +++ b/livestatus/src/Renderer.h @@ -30,6 +30,7 @@ #include <iosfwd> #include <memory> #include <string> +#include <utility> #include <vector> #include "data_encoding.h" class CSVSeparators; @@ -202,7 +203,7 @@ public: void output(RowFragment value) { separate(); - renderer().output(value); + renderer().output(std::move(value)); } template <typename T> @@ -324,7 +325,7 @@ public: Renderer &renderer() const { return _row.renderer(); } - void output(std::string key, std::string value) { + void output(const std::string &key, const std::string &value) { BeginEnd be(*this); renderer().output(key); renderer().separateDictKeyValue(); diff --git a/livestatus/src/TimeAggregator.h b/livestatus/src/TimeAggregator.h index 8fe615f..d1d2d90 100644 --- a/livestatus/src/TimeAggregator.h +++ b/livestatus/src/TimeAggregator.h @@ -35,7 +35,7 @@ class RowRenderer; class TimeAggregator : public Aggregator { public: - TimeAggregator(AggregationFactory factory, const TimeColumn *column) + TimeAggregator(const AggregationFactory &factory, const TimeColumn *column) : _aggregation(factory()), _column(column) {} void consume(Row row, const contact * /*auth_user*/,

6 years, 7 months

hicpp-explicit-conversions has already been fixed.

by Sven Panne

Module: check_mk Branch: master Commit: 43f7460d64ea8153742935d95656d42c1d2b6f1a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=43f7460d64ea81… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 14:28:21 2017 +0100 hicpp-explicit-conversions has already been fixed. Change-Id: Ic361d532c712df6ea8362da65424123d03ab9aa6 --- .clang-tidy | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 4af2fb3..f9472b5 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -33,7 +33,6 @@ # * temporarily disabled: # * clang-analyzer-optin.performance.Padding # * cppcoreguidelines-special-member-functions -# * hicpp-explicit-conversions # * hicpp-use-equals-delete # * hicpp-special-member-functions # * modernize-pass-by-value @@ -41,7 +40,7 @@ # * modernize-use-equals-delete # * performance-unnecessary-value-param # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1'

6 years, 7 months

Fix for modernize-use-equals-delete/hicpp-use-equals-delete.

by Sven Panne

Module: check_mk Branch: master Commit: 82bb0a3af8e8794b25f04b2219cc03f12f512047 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=82bb0a3af8e879… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 14:35:18 2017 +0100 Fix for modernize-use-equals-delete/hicpp-use-equals-delete. Change-Id: Ie0edece06908d7cd5e7f65725234e506561680ca --- .clang-tidy | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index f9472b5..06beaa7 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -33,14 +33,12 @@ # * temporarily disabled: # * clang-analyzer-optin.performance.Padding # * cppcoreguidelines-special-member-functions -# * hicpp-use-equals-delete # * hicpp-special-member-functions # * modernize-pass-by-value # * modernize-use-default-member-init -# * modernize-use-equals-delete # * performance-unnecessary-value-param # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-hicpp-special-member-functions,-modernize-pass-by-value,-modernize-use-default-member-init,-performance-unnecessary-value-param' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1'

6 years, 7 months

Semi-automatic clang-tidy fix for readability-named-parameter.

by Sven Panne

Module: check_mk Branch: master Commit: 45eaa0cbbfd7bc8807bebdd2ac877ce80a34a960 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=45eaa0cbbfd7bc… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 14:18:36 2017 +0100 Semi-automatic clang-tidy fix for readability-named-parameter. Change-Id: I70e43a1067018977273244aaf1ee188ea01f2f08 --- .clang-tidy | 3 +-- livestatus/src/AttributeListAsIntColumn.h | 4 ++-- livestatus/src/ClientQueue.h | 2 +- livestatus/src/DoublePointerColumn.h | 2 +- livestatus/src/Logfile.h | 12 ++++++------ livestatus/src/Logger.h | 4 ++-- livestatus/src/Query.h | 5 +++-- livestatus/src/Store.h | 15 ++++++++------- livestatus/src/StringPointerColumn.h | 2 +- livestatus/src/TableComments.h | 2 +- livestatus/src/TableContacts.h | 2 +- livestatus/src/TableDowntimes.h | 2 +- livestatus/src/TableEventConsole.h | 2 +- livestatus/src/TableHostGroups.h | 4 ++-- livestatus/src/TableServiceGroups.h | 4 ++-- livestatus/src/TableServices.h | 4 ++-- livestatus/src/TableServicesByGroup.h | 4 ++-- livestatus/src/TableServicesByHostGroup.h | 4 ++-- 18 files changed, 39 insertions(+), 38 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=45eaa0cbbf…

6 years, 7 months

Automatic clang-tidy fix for google-readability-todo.

by Sven Panne

Module: check_mk Branch: master Commit: 680407bcf5c12424d61867f896ed3f6715c6637b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=680407bcf5c124… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 13:58:36 2017 +0100 Automatic clang-tidy fix for google-readability-todo. Change-Id: I17e0bbbee46d17bea37de3add520f39fae3e016f --- .clang-tidy | 3 +-- livestatus/src/LogEntry.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 124bc8f..a5e699f 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -33,7 +33,6 @@ # * temporarily disabled: # * clang-analyzer-optin.performance.Padding # * cppcoreguidelines-special-member-functions -# * google-readability-todo # * hicpp-explicit-conversions # * hicpp-use-equals-delete # * hicpp-special-member-functions @@ -43,7 +42,7 @@ # * performance-unnecessary-value-param # * readability-named-parameter # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param,-readability-named-parameter' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param,-readability-named-parameter' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1' diff --git a/livestatus/src/LogEntry.h b/livestatus/src/LogEntry.h index 1d46973..bff1c4b 100644 --- a/livestatus/src/LogEntry.h +++ b/livestatus/src/LogEntry.h @@ -97,7 +97,7 @@ public: text = 7, // specific text passages alert_handlers = 8, // Started and stopped alert handlers - // TODO: This class sets different logclasses on match -> fix this + // TODO(sp): This class sets different logclasses on match -> fix this invalid = 0x7fffffff // never stored }; static constexpr uint32_t all_classes = 0xffffu;

6 years, 7 months

Fix for google-build-using-namespace.

by Sven Panne

Module: check_mk Branch: master Commit: 3ef1c189c2ceca1f842c3b7662bc95cc94705e16 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3ef1c189c2ceca… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 13:56:38 2017 +0100 Fix for google-build-using-namespace. Change-Id: I2a9efbde10fb4eaf3903465b4a092318ecd6aea9 --- .clang-tidy | 3 +-- livestatus/src/ChronoUtils.h | 15 ++++++++------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 6996c81..124bc8f 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -33,7 +33,6 @@ # * temporarily disabled: # * clang-analyzer-optin.performance.Padding # * cppcoreguidelines-special-member-functions -# * google-build-using-namespace # * google-readability-todo # * hicpp-explicit-conversions # * hicpp-use-equals-delete @@ -44,7 +43,7 @@ # * performance-unnecessary-value-param # * readability-named-parameter # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param,-readability-named-parameter' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param,-readability-named-parameter' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1' diff --git a/livestatus/src/ChronoUtils.h b/livestatus/src/ChronoUtils.h index 58e2e91..95f7727 100644 --- a/livestatus/src/ChronoUtils.h +++ b/livestatus/src/ChronoUtils.h @@ -36,9 +36,9 @@ using minutes_d = std::chrono::duration<double, std::ratio<60>>; inline double elapsed_ms_since(std::chrono::steady_clock::time_point then) { - using namespace std::chrono; - return duration_cast<duration<double, std::milli>>(steady_clock::now() - - then) + return std::chrono::duration_cast< + std::chrono::duration<double, std::milli>>( + std::chrono::steady_clock::now() - then) .count(); } @@ -79,17 +79,18 @@ inline std::chrono::system_clock::time_point from_tm(tm tp) { template <typename Rep, typename Period> inline timeval to_timeval(std::chrono::duration<Rep, Period> dur) { - using namespace std::chrono; timeval tv; // NOTE: The static_casts below are needed to avoid warning on e.g. some // 32bit platforms, because the underlying types might be larger than the // timeval fields. We can't use the correct POSIX types time_t and // suseconds_t because of the broken MinGW cross compiler, so we revert to // decltype. - tv.tv_sec = - static_cast<decltype(tv.tv_sec)>(duration_cast<seconds>(dur).count()); + tv.tv_sec = static_cast<decltype(tv.tv_sec)>( + std::chrono::duration_cast<std::chrono::seconds>(dur).count()); tv.tv_usec = static_cast<decltype(tv.tv_usec)>( - duration_cast<microseconds>(dur % seconds(1)).count()); + std::chrono::duration_cast<std::chrono::microseconds>( + dur % std::chrono::seconds(1)) + .count()); return tv; }

6 years, 7 months

Automatic clang-tidy fix for readability-avoid-const-params-in-decls.

by Sven Panne

Module: check_mk Branch: master Commit: a946adf34ba750124b882f748ccbb4a7ac8cfc29 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a946adf34ba750… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 13:39:14 2017 +0100 Automatic clang-tidy fix for readability-avoid-const-params-in-decls. Change-Id: I9af03eb4f834edbeed87141ee69d1a13cd75f247 --- .clang-tidy | 3 +-- livestatus/src/TableStateHistory.h | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index bea4985..82e717d 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -45,11 +45,10 @@ # * modernize-use-equals-delete # * modernize-use-noexcept # * performance-unnecessary-value-param -# * readability-avoid-const-params-in-decls # * readability-implicit-bool-cast # * readability-named-parameter # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-explicit-constructor,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-deprecated-headers,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-modernize-use-noexcept,-performance-unnecessary-value-param,-readability-avoid-const-params-in-decls,-readability-implicit-bool-cast,-readability-named-parameter' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-explicit-constructor,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-deprecated-headers,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-modernize-use-noexcept,-performance-unnecessary-value-param,-readability-implicit-bool-cast,-readability-named-parameter' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1' diff --git a/livestatus/src/TableStateHistory.h b/livestatus/src/TableStateHistory.h index 3f1a3da..db8d4b0 100644 --- a/livestatus/src/TableStateHistory.h +++ b/livestatus/src/TableStateHistory.h @@ -78,8 +78,7 @@ private: LogEntry *getNextLogentry(); void process(Query *query, HostServiceState *hs_state); int updateHostServiceState(Query *query, const LogEntry *entry, - HostServiceState *hs_state, - const bool only_update); + HostServiceState *hs_state, bool only_update); }; #endif // TableStateHistory_h

6 years, 7 months

Automatic clang-tidy fix for readability-implicit-bool-cast.

by Sven Panne

Module: check_mk Branch: master Commit: 9f727693ebf8aa144ce3bd99d459c23a9c655726 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9f727693ebf8aa… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 13:41:20 2017 +0100 Automatic clang-tidy fix for readability-implicit-bool-cast. Change-Id: I8165c950c1fc8158388eec8c2564dba45b846e15 --- .clang-tidy | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 82e717d..8926a2b 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -45,10 +45,9 @@ # * modernize-use-equals-delete # * modernize-use-noexcept # * performance-unnecessary-value-param -# * readability-implicit-bool-cast # * readability-named-parameter # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-explicit-constructor,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-deprecated-headers,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-modernize-use-noexcept,-performance-unnecessary-value-param,-readability-implicit-bool-cast,-readability-named-parameter' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-explicit-constructor,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-deprecated-headers,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-modernize-use-noexcept,-performance-unnecessary-value-param,-readability-named-parameter' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1'

6 years, 7 months

Automatic clang-tidy fix for google-explicit-constructor.

by Sven Panne

Module: check_mk Branch: master Commit: 7baaf29c2c6035acf5f4e634e20698e1e7191547 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7baaf29c2c6035… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 13:48:07 2017 +0100 Automatic clang-tidy fix for google-explicit-constructor. Change-Id: I3228cec384c35082da04a09005aac98ad845c4d0 --- .clang-tidy | 3 +-- livestatus/src/ChronoUtils.h | 7 ++++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index b40ec82..455e845 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -34,7 +34,6 @@ # * clang-analyzer-optin.performance.Padding # * cppcoreguidelines-special-member-functions # * google-build-using-namespace -# * google-explicit-constructor # * google-readability-todo # * hicpp-explicit-conversions # * hicpp-use-equals-delete @@ -46,7 +45,7 @@ # * performance-unnecessary-value-param # * readability-named-parameter # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-explicit-constructor,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-deprecated-headers,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param,-readability-named-parameter' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-deprecated-headers,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param,-readability-named-parameter' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1' diff --git a/livestatus/src/ChronoUtils.h b/livestatus/src/ChronoUtils.h index b823c37..9ea061a 100644 --- a/livestatus/src/ChronoUtils.h +++ b/livestatus/src/ChronoUtils.h @@ -113,10 +113,11 @@ typename Dur::rep time_point_part(std::chrono::system_clock::time_point &tp) { class FormattedTimePoint { public: - FormattedTimePoint(std::chrono::system_clock::time_point tp, - const std::string &format = default_format) + explicit FormattedTimePoint(std::chrono::system_clock::time_point tp, + const std::string &format = default_format) : _tp(tp), _format(format) {} - FormattedTimePoint(time_t t, const std::string &format = default_format) + explicit FormattedTimePoint(time_t t, + const std::string &format = default_format) : _tp(std::chrono::system_clock::from_time_t(t)), _format(format) {} friend std::ostream &operator<<(std::ostream &os,

6 years, 7 months

Automatic clang-tidy fix for modernize-deprecated-headers.

by Sven Panne

Module: check_mk Branch: master Commit: 64c4228302abab1d1021217ed634894e25b2d898 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=64c4228302abab… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Fri Dec 8 13:51:03 2017 +0100 Automatic clang-tidy fix for modernize-deprecated-headers. Change-Id: I559a4b283a528967382c955c298412389c7714b9 --- .clang-tidy | 3 +-- livestatus/src/ChronoUtils.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 455e845..6996c81 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -38,14 +38,13 @@ # * hicpp-explicit-conversions # * hicpp-use-equals-delete # * hicpp-special-member-functions -# * modernize-deprecated-headers # * modernize-pass-by-value # * modernize-use-default-member-init # * modernize-use-equals-delete # * performance-unnecessary-value-param # * readability-named-parameter # -Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-deprecated-headers,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param,-readability-named-parameter' +Checks: '*,-android-cloexec-fopen,-android-cloexec-open,-cert-env33-c,-cert-err34-c,-cert-err58-cpp,-clang-analyzer-alpha*,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-const-cast,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-static-cast-downcast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-google-runtime-int,-google-runtime-references,-hicpp-member-init,-hicpp-no-assembler,-llvm-header-guard,-llvm-include-order,-modernize-use-bool-literals,-clang-analyzer-optin.performance.Padding,-cppcoreguidelines-special-member-functions,-google-build-using-namespace,-google-readability-todo,-hicpp-explicit-conversions,-hicpp-use-equals-delete,-hicpp-special-member-functions,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-delete,-performance-unnecessary-value-param,-readability-named-parameter' CheckOptions: - key: google-readability-namespace-comments.SpacesBeforeComments value: '1' diff --git a/livestatus/src/ChronoUtils.h b/livestatus/src/ChronoUtils.h index 9ea061a..58e2e91 100644 --- a/livestatus/src/ChronoUtils.h +++ b/livestatus/src/ChronoUtils.h @@ -26,7 +26,6 @@ #define ChronoUtils_h #include "config.h" // IWYU pragma: keep -#include <time.h> #include <chrono> #include <cstdlib> #include <ctime>

6 years, 7 months

← Newer
1
...
11
12
13
14
15
16
17
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits December 2017