Module: check_mk
Branch: master
Commit: 51efbd33397c19b165f18cbd1e3fae72d7e46b4b
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=51efbd33397c19…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Fri Feb 11 11:20:24 2011 +0100
Updated bug entries
---
.bugs/131 | 19 +++++++++++++++++++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/.bugs/131 b/.bugs/131
new file mode 100644
index 0000000..cba5966
--- /dev/null
+++ b/.bugs/131
@@ -0,0 +1,19 @@
+Title: if checks: Add 0 prefix on port numbers below 10
+Component: core
+Benefit: 3
+State: open
+Cost: 5
+Date: 2011-02-11 11:17:50
+Class: todo
+
+When monitoring switches the services are ordered as follows:
+
+1
+10
+11
+12
+..
+2
+20
+
+It would be good to cleanup such interface names by adding a leading zero to the numbers to have a proper sorting of the elements.
Module: check_mk
Branch: master
Commit: 4f59acb912eb79deac4f891718e1814eb080b5f8
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=4f59acb912eb79…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Mon Feb 7 11:01:49 2011 +0100
heartbeat_nodes: Fixed error handling when node is active but at least one link is dead
---
ChangeLog | 3 +++
checks/heartbeat_nodes | 9 ++++++---
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index dfa1fbf..6412443 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -3,6 +3,9 @@
* Bugfix: Servicegroups can be searched with the quicksearch snapin using
the 'sg:' prefix again
+ Checks & Agents:
+ * heartbeat_nodes: Fixed error handling when node is active but at least one link is dead
+
1.1.9i7:
Core, Setup, etc.:
* Fix crash on Python 2.4 (e.g. RedHat) with fake_file
diff --git a/checks/heartbeat_nodes b/checks/heartbeat_nodes
index c940aba..ab59ba2 100644
--- a/checks/heartbeat_nodes
+++ b/checks/heartbeat_nodes
@@ -45,19 +45,22 @@ def check_heartbeat_nodes(item, params, info):
linkOutput = ''
for link, state in nodeLinks:
+ state_txt = ''
if state != 'up':
status = 2
- linkOutput += ' %s: %s, ' % (link, state)
+ state_txt = ' (CRIT)'
+ linkOutput += '%s: %s%s, ' % (link, state, state_txt)
linkOutput = linkOutput.rstrip(', ')
if nodeStatus in [ 'active', 'up', 'ping' ] and status <= 0:
status = 0
elif nodeStatus == 'dead' and status <= 2:
status = 2
- else:
+
+ if not nodeStatus in [ 'active', 'up', 'ping', 'dead' ]:
return (3, "UNKNOWN - Node %s has an unhandled state: %s" % (line[0], nodeStatus))
- return (status, '%s - Node %s is in state "%s". Links:%s' % (nagios_state_names[status], line[0], nodeStatus, linkOutput))
+ return (status, '%s - Node %s is in state "%s". Links: %s' % (nagios_state_names[status], line[0], nodeStatus, linkOutput))
return (3, "UNKNOWN - Node is not present anymore")
Module: check_mk
Branch: master
Commit: c3f9158378fd1d13ee75541ee6239ad623c3822d
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c3f9158378fd1d…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Thu Feb 10 09:47:44 2011 +0100
Updated bug entries
---
.bugs/127 | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/.bugs/127 b/.bugs/127
new file mode 100644
index 0000000..c955f96
--- /dev/null
+++ b/.bugs/127
@@ -0,0 +1,9 @@
+Title: df trends: Peak values after changing the levels_range param
+Component: checks
+Benefit: 5
+State: open
+Cost: 4
+Date: 2011-02-10 09:45:24
+Class: bug
+
+After changing the trend_range to a larger time the check reports a peak value which is wrong. It might be needed to detect such a change and reset the values.