Checkmk git commits February 2011

checkmk-commits@lists.checkmk.com

3 participants
186 discussions

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 36c0aec3de00bfe8a8126fcf00ebb6faabaea237 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=36c0aec3de00bf… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Feb 18 11:03:04 2011 +0100 Updated bug entries --- .bugs/150 | 13 +++++++++++++ .bugs/151 | 13 +++++++++++++ .bugs/152 | 20 ++++++++++++++++++++ 3 files changed, 46 insertions(+), 0 deletions(-) diff --git a/.bugs/150 b/.bugs/150 new file mode 100644 index 0000000..e0d0cff --- /dev/null +++ b/.bugs/150 @@ -0,0 +1,13 @@ +Title: Display options show wrong value at start +Component: multisite +Benefit: 1 +State: open +Cost: 1 +Date: 2011-02-18 09:44:34 +Class: bug + +When you enter a view where the display options for the PNP timerange +had been set to 4 hours (which is persistet), then the graphs are +showing 4 hours. Good. But when you open the tab "Display Options", +the dropdown is preset to 25h (which is the default), rather then +to 4h (which is the current setting). diff --git a/.bugs/151 b/.bugs/151 new file mode 100644 index 0000000..f722057 --- /dev/null +++ b/.bugs/151 @@ -0,0 +1,13 @@ +Title: --snmpwalk garbles HEX strings +Component: core +Benefit: 1 +State: open +Cost: 2 +Date: 2011-02-18 09:58:05 +Class: bug + +When doing a --snmpwalk if the target machine outputs multiline +HEX strings, the trailing spaces are stripped and thus hex codes +are glued together (202E instead of 20 2E). That way, the hex +string detection fails. This is probably in line 2731 of main.py: +the strip() should only strip trailing LF/CR, not spaces. diff --git a/.bugs/152 b/.bugs/152 new file mode 100644 index 0000000..6730f8b --- /dev/null +++ b/.bugs/152 @@ -0,0 +1,20 @@ +Title: Windows inventory - make service inventory more flexible +Component: checks +Benefit: 2 +State: open +Cost: 2 +Date: 2011-02-18 10:52:33 +Class: feature + +Example for possible configuration: + +inventory_services = [ + "HirnTest", # aufnehmen, falls running + "TapiSrv:running", # wie jetziger Default + "TermService:auto", # aufnehmen, falls Startart auto (egal ob running) + "BackupSrv:auto,running", # nur aufnehmen, wenn Startart auto *UND* running + "Backup.*:auto,running", # alle aufnehmen die passen, als Einzelservices + ( [ "termserver" ] , ALL_HOSTS, [ "HirnTest:running", "Sppoller:auto" ] ), + ( [ "backup" ], ALL_HOSTS, [ "Backup.*" ] ), +] +

13 years, 4 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 7809c515b82918f2ab62e0c811838391b9f1583b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7809c515b82918… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Feb 18 11:03:08 2011 +0100 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

13 years, 4 months

Check_MK Git: check_mk: df pnp-template: Fixed newline when no thresholds are given

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: e816f019fed741a60ff8e405f5ebe962b4d6d1d0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e816f019fed741… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 17 17:56:00 2011 +0100 df pnp-template: Fixed newline when no thresholds are given Signed-off-by: Lars Michelsen <lm(a)mathias-kettner.de> --- pnp-templates/check_mk-df.php | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pnp-templates/check_mk-df.php b/pnp-templates/check_mk-df.php index afd8276..4c44a97 100644 --- a/pnp-templates/check_mk-df.php +++ b/pnp-templates/check_mk-df.php @@ -53,14 +53,13 @@ $def[1] .= "AREA:var1#00ffc6:\"used space on $fsname\\n\" "; $def[1] .= "LINE1:var1#226600: "; $def[1] .= "HRULE:$maxgb#003300:\"Size ($sizegb GB) \" "; $def[1] .= "HRULE:$warngb#ffff00:\"Warning at $warngbtxt GB \" "; -$def[1] .= "HRULE:$critgb#ff0000:\"Critical at $critgbtxt GB \\n\" "; +$def[1] .= "HRULE:$critgb#ff0000:\"Critical at $critgbtxt GB \\n\" "; $def[1] .= "GPRINT:var1:LAST:\"current\: %6.2lf GB\" "; $def[1] .= "GPRINT:var1:MAX:\"max\: %6.2lf GB \" "; $def[1] .= "GPRINT:var1:AVERAGE:\"avg\: %6.2lf GB\" "; # Second graph is optional and shows trend if (isset($DS[2])) { - $size_mb_per_hours = floatval($MAX[3]); // this is size_mb / range(hours) $size_mb = floatval($MAX[1]); $hours = 1.0 / ($size_mb_per_hours / $size_mb); @@ -78,7 +77,8 @@ if (isset($DS[2])) { if ($WARN[3]) $def[2] .= "LINE1:$WARN[3]#ffff00:\"Warning at $WARN[3]MB/$range\" "; if ($CRIT[3]) - $def[2] .= "LINE1:$CRIT[3]#ff0000:\"Critical at $CRIT[3]MB/$range\\n\" "; + $def[2] .= "LINE1:$CRIT[3]#ff0000:\"Critical at $CRIT[3]MB/$range\" "; + $def[2] .= "COMMENT:\"\\n\" "; $def[2] .= "GPRINT:growth:LAST:\"Current\: %+9.2lf MB/$range\" "; $def[2] .= "GPRINT:trend:LAST:\" Trend\: %+7.2lf MB/$range\\n\" "; }

13 years, 4 months

Check_MK Git: check_mk: df trend: Initializing trend with zero

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: eba9fefde0f6a4c898752e870b4dc3ed40ce1d55 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=eba9fefde0f6a4… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 17 21:48:03 2011 +0100 df trend: Initializing trend with zero Initializing the trend with a value of zero to prevent strange random behaviour until the first full time intervall has passed. Signed-off-by: Lars Michelsen <lm(a)mathias-kettner.de> --- checks/df.include | 14 ++++++++------ modules/check_mk_base.py | 4 +++- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/checks/df.include b/checks/df.include index 2d5658f..a34054e 100644 --- a/checks/df.include +++ b/checks/df.include @@ -157,14 +157,16 @@ def df_check_filesystem(hostname, mountpoint, size_mb, avail_mb, params): range = levels["trend_range"] # in hours range_sec = range * 3600.0 this_time = time.time() - timdif, rate = get_counter("df.%s.delta" % mountpoint, this_time, used_mb, True) # rate in MB/s, allow negative + # rate in MB/s, allow negative + timdif, rate = get_counter("df.%s.delta" % mountpoint, this_time, used_mb, True) perfdata.append(("growth", rate * range_sec)) - timedif, rate_avg = get_average("df.%s.trend" % mountpoint, this_time, rate, range_sec) - - # rate_avg is groth in MB/sec + # average trend, initialize with zero + timedif, rate_avg = get_average("df.%s.trend" % mountpoint, this_time, rate, range_sec, True) + + # rate_avg is groth in MB/sec trend = rate_avg * range_sec sign = trend > 0 and "+" or "" - infotext += ", trend: %s%s / %g hours" % (sign, get_bytes_human_readable(trend * MB), range) + infotext += ", trend: %s%s / %g hours" % (sign, get_bytes_human_readable(trend * MB), range) # apply levels for absolute growth in MB / interval trend_mb = levels.get("trend_mb") @@ -211,7 +213,7 @@ def df_check_filesystem(hostname, mountpoint, size_mb, avail_mb, params): problems.append("only %.1fh until disk full!" % hours_left) elif hours_left <= wa * 2: problems.append("time left: %.1fh" % hours_left) - + except MKCounterWrapped: # need more data for computing a trend diff --git a/modules/check_mk_base.py b/modules/check_mk_base.py index f3f2241..7bf3e35 100755 --- a/modules/check_mk_base.py +++ b/modules/check_mk_base.py @@ -636,10 +636,12 @@ def get_counter(countername, this_time, this_val, allow_negative=False): return timedif, per_sec -def get_average(itemname, this_time, this_val, backlog): +def get_average(itemname, this_time, this_val, backlog, initialize_zero = True): # first call: take current value as average if not itemname in g_counters: + if initialize_zero: + this_val = 0 g_counters[itemname] = (this_time, this_val) return 1.0, this_val

13 years, 4 months

Check_MK Git: check_mk: Added helper file for pnp-templates

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: f812c0aba7c491500ad4a340f26054fd1a0fc045 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f812c0aba7c491… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 17 21:51:20 2011 +0100 Added helper file for pnp-templates --- pnp-templates/.f12 | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/pnp-templates/.f12 b/pnp-templates/.f12 new file mode 100644 index 0000000..b36e05f --- /dev/null +++ b/pnp-templates/.f12 @@ -0,0 +1,2 @@ +sudo cp * /omd/versions/default/share/check_mk/pnp-templates +

13 years, 4 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: f480d2c45b388791a5c88b7fe88046886f10bdee URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f480d2c45b3887… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 17 17:17:14 2011 +0100 Updated bug entries --- .bugs/149 | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/.bugs/149 b/.bugs/149 new file mode 100644 index 0000000..48a46fd --- /dev/null +++ b/.bugs/149 @@ -0,0 +1,9 @@ +Title: Logfile Acknowledge: rename button to Delete? +Component: checks +Benefit: 1 +State: open +Cost: 1 +Date: 2011-02-17 15:02:35 +Class: cleanup + +For some people this is confusing...

13 years, 4 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 2b7f516ee7ebac691580bb1be1a9ac209416b05c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2b7f516ee7ebac… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 17 13:48:52 2011 +0100 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

13 years, 4 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 24d45a8e4600838ec07a19c71e0adbe07181361e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=24d45a8e460083… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 17 13:48:49 2011 +0100 Updated bug entries --- .bugs/148 | 10 ++++++++++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/.bugs/148 b/.bugs/148 new file mode 100644 index 0000000..08c404a --- /dev/null +++ b/.bugs/148 @@ -0,0 +1,10 @@ +Title: cmk -M: nasty white lines in parameters section +Component: core +Benefit: 1 +State: open +Cost: 1 +Date: 2011-02-17 13:47:36 +Class: cleanup + +The the section CHECK PARAMETERS the empty lines between the subsections +must be filled with the background color until the line end.

13 years, 4 months

Check_MK Git: check_mk: Improved 3ware_units check

by lm＠mathias-kettner.de

Module: check_mk Branch: master Commit: 3a75b3c98d4574f5756664131615025a0d1b7624 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3a75b3c98d4574… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Thu Feb 17 12:13:04 2011 +0100 Improved 3ware_units check * 3ware_units: Handling INITIALIZING state as warning now * 3ware_units: Better handling of outputs from different tw_cli versions now Thanks to Matthias Henze <lists(a)mhcsoftware.de> for reporting and the original patch. Signed-off-by: Lars Michelsen <lm(a)mathias-kettner.de> --- ChangeLog | 2 ++ checks/3ware_units | 28 +++++++++++++++++++++++++--- 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 8afea28..25c8098 100644 --- a/ChangeLog +++ b/ChangeLog @@ -21,6 +21,8 @@ * df, df_netapp, df_netapp32, hr_fs, vms_df: all filesystem checks now support trends. Please look at check manpage of df for details. * FIX: heartbeat_nodes: Fixed error handling when node is active but at least one link is dead + * 3ware_units: Handling INITIALIZING state as warning now + * 3ware_units: Better handling of outputs from different tw_cli versions now Multisite: * FIX: fix "too many values to unpack" when editing views in single layout diff --git a/checks/3ware_units b/checks/3ware_units index f6e38eb..1b0cd4d 100644 --- a/checks/3ware_units +++ b/checks/3ware_units @@ -29,6 +29,14 @@ # u0 RAID-5 OK - - 64K 1788.08 ON OFF # u1 RAID-5 INOPERABLE - - 64K 1788.08 OFF OFF +# Different versions of tw_cli have different outputs. This means the size column +# used by this check is in different places. Here is a an example: +# +# Unit UnitType Status %Cmpl Stripe Size(GB) Cache AVerify IgnECC +# u0 RAID-5 INITIALIZING 84 64K 1396.95 ON ON OFF +# +# Unit UnitType Status %RCmpl %V/I/M Stripe Size(GB) Cache AVrfy +# u0 RAID-5 OK - - 64K 1396.95 ON ON # inventory def inventory_3ware_units(checkname, info): @@ -42,12 +50,26 @@ def inventory_3ware_units(checkname, info): def check_3ware_units(item, param, info): for line in info: if line[0] == item: - status = line[2] unit_type = line[1] - size = line[6] - infotext = "%s (type: %s, size: %s GB)" % (status, unit_type, size) + status = line[2] + complete = line[3] + + # Handle different outputs of tw_cli + try: + size = float(line[6]) + except ValueError: + size = float(line[5]) + + complete_txt = '' + if complete != '-': + complete_txt = ' complete: %s%%' % complete + + infotext = "%s (type: %s, size: %sGB%s)" % (status, unit_type, size, complete_txt) + if status == "OK": return (0, "OK - unit status is " + infotext) + elif status == "INITIALIZING": + return (1, "WARNING - unit status is " + infotext) else: return (2, "CRITICAL - unit status is " + infotext) return (3, "UNKNOWN - unit %s not found in agent output" % item)

13 years, 4 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 7d66acbde283a1c92ba63b9fbeb446835ca05dcb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7d66acbde283a1… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Feb 17 11:44:59 2011 +0100 Updated bug entries --- .bugs/147 | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/.bugs/147 b/.bugs/147 new file mode 100644 index 0000000..aba2141 --- /dev/null +++ b/.bugs/147 @@ -0,0 +1,12 @@ +Title: New config option snmp_options +Component: core +Benefit: 2 +State: open +Cost: 1 +Date: 2011-02-17 11:43:29 +Class: feature + +With the new config variable snmp_options one could add custom +options for the snmpget/walk command line. That way one could +e.g. add a -Cc for certain devices (see docu of snmpwalk). +Adding -Cc generally might be dangerous.

13 years, 4 months

← Newer
1
...
8
9
10
11
12
13
14
...
19
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2011