Checkmk git commits February 2011

checkmk-commits@lists.checkmk.com

3 participants
186 discussions

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 1a7322db9f1cbf520ac8a1172f3d0a294513158a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1a7322db9f1cbf… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Wed Feb 16 10:19:15 2011 +0100 Updated bug entries --- .bugs/140 | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/.bugs/140 b/.bugs/140 new file mode 100644 index 0000000..fc18009 --- /dev/null +++ b/.bugs/140 @@ -0,0 +1,9 @@ +Title: Perf-O-Meter in single datasetlayout has wrong height +Component: multisite +Benefit: 1 +State: open +Cost: 1 +Date: 2011-02-16 10:18:38 +Class: bug + +Just try ist out. Height is too low.

13 years, 4 months

Check_MK Git: check_mk: Fix perf-O-meters

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: a9aea45c4920821608fa50e5b2b9269b5cc84fb5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a9aea45c492082… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Feb 15 16:47:42 2011 +0100 Fix perf-O-meters --- web/plugins/views/perfometer.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/web/plugins/views/perfometer.py b/web/plugins/views/perfometer.py index ac5e4c1..122c598 100644 --- a/web/plugins/views/perfometer.py +++ b/web/plugins/views/perfometer.py @@ -122,7 +122,7 @@ def paint_perfometer(row): title, h = perf_painter(row, check_command, perf_data) content = "<div class=title>%s</div>%s" % (title, h) if 'X' in html.display_options: - return "perfometer", ('<a href="%s">%s</a>' % (pnp_url(row), content)) + return "perfometer", ('<a href="%s">%s</a>' % (pnp_url(row, "service"), content)) else: return "perfometer", content

13 years, 4 months

Check_MK Git: check_mk: FIX: read .include before checks

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: d560c4169c621c14a24dd7b87c39b64fe2006bce URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d560c4169c621c… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Feb 15 16:44:04 2011 +0100 FIX: read .include before checks --- ChangeLog | 2 ++ modules/check_mk.py | 3 +++ 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog index b390c1c..e9433df 100644 --- a/ChangeLog +++ b/ChangeLog @@ -9,6 +9,8 @@ Core, Setup, etc.: * FIX: check_mk_templates.cfg: add missing check_period for hosts (needed for Shinken) + * FIX: read *.include files before checks. Fixes df_netapp not finding + its check function Checks & Agents: * ucd_cpu_load: new check for CPU load via UCD SNMP agent diff --git a/modules/check_mk.py b/modules/check_mk.py index e6bd72e..ff165dd 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -350,6 +350,9 @@ if __name__ == "__main__": filelist = glob.glob(checks_dir + "/*") if local_checks_dir: filelist += glob.glob(local_checks_dir + "/*") + # read include files first! + filelist = [ f for f in filelist if f.endswith(".include") ] + \ + [ f for f in filelist if not f.endswith(".include") ] for f in filelist: if not f.endswith("~"): # ignore emacs-like backup files try:

13 years, 4 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 14c0a2fadf1400450011a28f7d37097aee522510 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=14c0a2fadf1400… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Feb 15 16:40:46 2011 +0100 Updated bug entries --- .bugs/137 | 10 ++++++++++ .bugs/138 | 11 +++++++++++ .bugs/139 | 11 +++++++++++ 3 files changed, 32 insertions(+), 0 deletions(-) diff --git a/.bugs/137 b/.bugs/137 new file mode 100644 index 0000000..948f1a0 --- /dev/null +++ b/.bugs/137 @@ -0,0 +1,10 @@ +Title: HREF target customizable for bookmarks and custom links +Component: multisite +Benefit: 2 +State: open +Cost: 2 +Date: 2011-02-15 15:11:36 +Class: feature + +We could have bookmarks and custom links make the target customizable +Currently it's "main". It could also be "blank" or ? diff --git a/.bugs/138 b/.bugs/138 new file mode 100644 index 0000000..f3c4e14 --- /dev/null +++ b/.bugs/138 @@ -0,0 +1,11 @@ +Title: define_host/servicegroups per default True +Component: core +Benefit: 1 +State: open +Cost: 1 +Date: 2011-02-15 15:14:53 +Class: feature + +Incompatible change: make define_servicegroups and define_hostgroups +True per Default. Mixed users can set this to False. Our Check_MK only +preferred users get this easier that way. diff --git a/.bugs/139 b/.bugs/139 new file mode 100644 index 0000000..7b490e3 --- /dev/null +++ b/.bugs/139 @@ -0,0 +1,11 @@ +Title: Painters for contacts and contactgroups a object is in +Component: multisite +Benefit: 2 +State: open +Cost: 2 +Date: 2011-02-15 16:24:49 +Class: feature + +We should introduce new columns for that and update the service +and host detail view. That way the admin can check the contact +assignment of hosts and services.

13 years, 4 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 3925bcc34eaa9a23a94cec3a6af8b49aa84c782e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3925bcc34eaa9a… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Feb 15 14:27:13 2011 +0100 Updated bug entries --- .bugs/135 | 10 ++++++++++ .bugs/136 | 10 ++++++++++ 2 files changed, 20 insertions(+), 0 deletions(-) diff --git a/.bugs/135 b/.bugs/135 new file mode 100644 index 0000000..be65c0a --- /dev/null +++ b/.bugs/135 @@ -0,0 +1,10 @@ +Title: No config check on --help +Component: core +Benefit: 1 +State: open +Cost: 1 +Date: 2011-02-15 10:02:09 +Class: cleanup + +When calling check_mk --help the config check should +be skipped. diff --git a/.bugs/136 b/.bugs/136 new file mode 100644 index 0000000..928a721 --- /dev/null +++ b/.bugs/136 @@ -0,0 +1,10 @@ +Title: Sort servicedescriptions and hostname numerically +Component: multisite +Benefit: 3 +State: open +Cost: 3 +Date: 2011-02-15 10:25:37 +Class: feature + +It could be possible to write a sorter that automatically +sorts host7 before host10.

13 years, 4 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: ed230299b48378ea8570870d66b1508be762a22f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ed230299b48378… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Feb 14 10:03:34 2011 +0100 Updated bug entries --- .bugs/134 | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/.bugs/134 b/.bugs/134 new file mode 100644 index 0000000..058df15 --- /dev/null +++ b/.bugs/134 @@ -0,0 +1,13 @@ +Title: Reschedule could spread checks over time +Component: multisite +Benefit: 3 +State: open +Cost: 2 +Date: 2011-02-14 10:02:18 +Class: feature + +When rescheduling a greater number of services you can kill your +Nagios, because all checks start at the same time. + +We could add an input field, where one could specify a inter-check +delay, that is used the spread the checks.

13 years, 4 months

Check_MK Git: check_mk: Multisite: fix host pnp icons in service views

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: afa0e29be89f63dedf96ec3d9e738abd7df0ef21 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=afa0e29be89f63… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Feb 13 19:38:08 2011 +0100 Multisite: fix host pnp icons in service views --- ChangeLog | 2 ++ web/plugins/views/painters.py | 19 +++++++++++-------- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 63f08d9..b390c1c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -22,6 +22,8 @@ Multisite: * FIX: fix "too many values to unpack" when editing views in single layout mode (such as host or service detail) + * FIX: fix PNP icon in cases where host and service icons are displayed in + same view (found by Wolfgang Barth) 1.1.9i8: Multisite: diff --git a/web/plugins/views/painters.py b/web/plugins/views/painters.py index c2e826d..0831b53 100644 --- a/web/plugins/views/painters.py +++ b/web/plugins/views/painters.py @@ -120,19 +120,22 @@ def pnp_cleanup(s): .replace('/', '_') \ .replace('\\', '_') -def pnp_url(row, what = 'graph'): +def pnp_url(row, what, how = 'graph'): sitename = row["site"] host = pnp_cleanup(row["host_name"]) - svc = pnp_cleanup(row.get("service_description", "_HOST_")) + if what == "host": + svc = "_HOST_" + else: + svc = pnp_cleanup(row["service_description"]) site = html.site_status[sitename]["site"] url = site["url_prefix"] + ("pnp4nagios/index.php/%s?host=%s&srv=%s" % \ - (what, htmllib.urlencode(host), htmllib.urlencode(svc))) - if what == 'graph': + (how, htmllib.urlencode(host), htmllib.urlencode(svc))) + if how == 'graph': url += "&theme=multisite&baseurl=%scheck_mk/" % htmllib.urlencode(site["url_prefix"]) return url -def pnp_popup_url(row): - return pnp_url(row, 'popup') +def pnp_popup_url(row, what): + return pnp_url(row, what, 'popup') def logwatch_url(sitename, notes_url): i = notes_url.index("/check_mk/logwatch.py") @@ -185,11 +188,11 @@ def paint_icons(what, row): # what is "host" or "service" pnpgraph_present = row[prefix + "pnpgraph_present"] if pnpgraph_present == 1: if 'X' in html.display_options: - url = pnp_url(row) + url = pnp_url(row, what) else: url = "" output += '<a href="%s" onmouseover="displayHoverMenu(event, get_url_sync(\'%s\'))" onmouseout="hoverHide()">' \ - '<img class=icon src="images/icon_pnp.png"></a>' % (url, pnp_popup_url(row)) + '<img class=icon src="images/icon_pnp.png"></a>' % (url, pnp_popup_url(row, what)) if 'X' in html.display_options: # action_url (only, if not a PNP-URL and pnp_graph is working!)

13 years, 4 months

Check_MK Git: check_mk: Updated bug entries

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 17b1bdbc1e0fe5ccd2c72b9d74fede5fd45dde87 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=17b1bdbc1e0fe5… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Feb 13 19:00:01 2011 +0100 Updated bug entries --- .bugs/132 | 12 ++++++++++++ .bugs/133 | 10 ++++++++++ 2 files changed, 22 insertions(+), 0 deletions(-) diff --git a/.bugs/132 b/.bugs/132 new file mode 100644 index 0000000..9e001fe --- /dev/null +++ b/.bugs/132 @@ -0,0 +1,12 @@ +Title: WATO misses some Windows services +Component: wato +Benefit: 3 +State: open +Cost: 1 +Date: 2011-02-13 18:31:09 +Class: bug + +It seems that WATO is dropping some service when inventorizing +Windows hosts. Of course the problem is not Windows-related. But +it seems that services containing special characters, like ':' +could make the difference. diff --git a/.bugs/133 b/.bugs/133 new file mode 100644 index 0000000..98dae2c --- /dev/null +++ b/.bugs/133 @@ -0,0 +1,10 @@ +Title: remove direct RRD updates from code and docu +Component: core +Benefit: 1 +State: open +Cost: 1 +Date: 2011-02-13 18:59:18 +Class: cleanup + +They are not longer neccessary since we have rrdcached. And +they break perf-o-meters and other nice things.

13 years, 4 months

Check_MK Git: check_mk: Fix too many values to unpack in Multisite

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 2d060712d8063e080944671dc0d69eb8efd7ba9f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2d060712d8063e… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Feb 13 18:16:54 2011 +0100 Fix too many values to unpack in Multisite --- ChangeLog | 8 ++++++-- web/plugins/views/layouts.py | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index d289d30..63f08d9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -7,7 +7,7 @@ are very usefull, however... Core, Setup, etc.: - * check_mk_templates.cfg: add missing check_period for hosts + * FIX: check_mk_templates.cfg: add missing check_period for hosts (needed for Shinken) Checks & Agents: @@ -17,7 +17,11 @@ * steelhead_connections: new check for Riverbed Steelhead connections * df, df_netapp, df_netapp32, hr_fs, vms_df: all filesystem checks now support trends. Please look at check manpage of df for details. - * heartbeat_nodes: Fixed error handling when node is active but at least one link is dead + * FIX: heartbeat_nodes: Fixed error handling when node is active but at least one link is dead + + Multisite: + * FIX: fix "too many values to unpack" when editing views in single layout + mode (such as host or service detail) 1.1.9i8: Multisite: diff --git a/web/plugins/views/layouts.py b/web/plugins/views/layouts.py index 83c0ea4..135b1ed 100644 --- a/web/plugins/views/layouts.py +++ b/web/plugins/views/layouts.py @@ -45,7 +45,7 @@ def render_single_dataset(data, view, group_painters, painters, num_columns): html.write("<tr class=gap><td class=gap colspan=%d></td></tr>\n" % (1 + num_columns)) thispart = rows[rownum:rownum + num_columns] for p in painters: - painter, link = p + painter, link = p[0:2] html.write("<tr class=data><td class=left>%s</td>" % painter["title"]) for row in thispart: paint(p, row)

13 years, 4 months

Check_MK Git: check_mk: Merge branch 'master' of ssh://mathias-kettner.de/ check_mk

by git＠mathias-kettner.de

Module: check_mk Branch: master Commit: 448f34a4626322052bdabb2550c7a5f1888b9c0a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=448f34a4626322… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Feb 13 18:16:57 2011 +0100 Merge branch 'master' of ssh://mathias-kettner.de/check_mk ---

13 years, 4 months

← Newer
1
...
10
11
12
13
14
15
16
...
19
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2011