Module: check_mk
Branch: master
Commit: 36c0aec3de00bfe8a8126fcf00ebb6faabaea237
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=36c0aec3de00bf…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Fri Feb 18 11:03:04 2011 +0100
Updated bug entries
---
.bugs/150 | 13 +++++++++++++
.bugs/151 | 13 +++++++++++++
.bugs/152 | 20 ++++++++++++++++++++
3 files changed, 46 insertions(+), 0 deletions(-)
diff --git a/.bugs/150 b/.bugs/150
new file mode 100644
index 0000000..e0d0cff
--- /dev/null
+++ b/.bugs/150
@@ -0,0 +1,13 @@
+Title: Display options show wrong value at start
+Component: multisite
+Benefit: 1
+State: open
+Cost: 1
+Date: 2011-02-18 09:44:34
+Class: bug
+
+When you enter a view where the display options for the PNP timerange
+had been set to 4 hours (which is persistet), then the graphs are
+showing 4 hours. Good. But when you open the tab "Display Options",
+the dropdown is preset to 25h (which is the default), rather then
+to 4h (which is the current setting).
diff --git a/.bugs/151 b/.bugs/151
new file mode 100644
index 0000000..f722057
--- /dev/null
+++ b/.bugs/151
@@ -0,0 +1,13 @@
+Title: --snmpwalk garbles HEX strings
+Component: core
+Benefit: 1
+State: open
+Cost: 2
+Date: 2011-02-18 09:58:05
+Class: bug
+
+When doing a --snmpwalk if the target machine outputs multiline
+HEX strings, the trailing spaces are stripped and thus hex codes
+are glued together (202E instead of 20 2E). That way, the hex
+string detection fails. This is probably in line 2731 of main.py:
+the strip() should only strip trailing LF/CR, not spaces.
diff --git a/.bugs/152 b/.bugs/152
new file mode 100644
index 0000000..6730f8b
--- /dev/null
+++ b/.bugs/152
@@ -0,0 +1,20 @@
+Title: Windows inventory - make service inventory more flexible
+Component: checks
+Benefit: 2
+State: open
+Cost: 2
+Date: 2011-02-18 10:52:33
+Class: feature
+
+Example for possible configuration:
+
+inventory_services = [
+ "HirnTest", # aufnehmen, falls running
+ "TapiSrv:running", # wie jetziger Default
+ "TermService:auto", # aufnehmen, falls Startart auto (egal ob running)
+ "BackupSrv:auto,running", # nur aufnehmen, wenn Startart auto *UND* running
+ "Backup.*:auto,running", # alle aufnehmen die passen, als Einzelservices
+ ( [ "termserver" ] , ALL_HOSTS, [ "HirnTest:running", "Sppoller:auto" ] ),
+ ( [ "backup" ], ALL_HOSTS, [ "Backup.*" ] ),
+]
+
Module: check_mk
Branch: master
Commit: 3a75b3c98d4574f5756664131615025a0d1b7624
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3a75b3c98d4574…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Thu Feb 17 12:13:04 2011 +0100
Improved 3ware_units check
* 3ware_units: Handling INITIALIZING state as warning now
* 3ware_units: Better handling of outputs from different tw_cli versions now
Thanks to Matthias Henze <lists(a)mhcsoftware.de> for reporting and the
original patch.
Signed-off-by: Lars Michelsen <lm(a)mathias-kettner.de>
---
ChangeLog | 2 ++
checks/3ware_units | 28 +++++++++++++++++++++++++---
2 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 8afea28..25c8098 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -21,6 +21,8 @@
* df, df_netapp, df_netapp32, hr_fs, vms_df: all filesystem checks now support
trends. Please look at check manpage of df for details.
* FIX: heartbeat_nodes: Fixed error handling when node is active but at least one link is dead
+ * 3ware_units: Handling INITIALIZING state as warning now
+ * 3ware_units: Better handling of outputs from different tw_cli versions now
Multisite:
* FIX: fix "too many values to unpack" when editing views in single layout
diff --git a/checks/3ware_units b/checks/3ware_units
index f6e38eb..1b0cd4d 100644
--- a/checks/3ware_units
+++ b/checks/3ware_units
@@ -29,6 +29,14 @@
# u0 RAID-5 OK - - 64K 1788.08 ON OFF
# u1 RAID-5 INOPERABLE - - 64K 1788.08 OFF OFF
+# Different versions of tw_cli have different outputs. This means the size column
+# used by this check is in different places. Here is a an example:
+#
+# Unit UnitType Status %Cmpl Stripe Size(GB) Cache AVerify IgnECC
+# u0 RAID-5 INITIALIZING 84 64K 1396.95 ON ON OFF
+#
+# Unit UnitType Status %RCmpl %V/I/M Stripe Size(GB) Cache AVrfy
+# u0 RAID-5 OK - - 64K 1396.95 ON ON
# inventory
def inventory_3ware_units(checkname, info):
@@ -42,12 +50,26 @@ def inventory_3ware_units(checkname, info):
def check_3ware_units(item, param, info):
for line in info:
if line[0] == item:
- status = line[2]
unit_type = line[1]
- size = line[6]
- infotext = "%s (type: %s, size: %s GB)" % (status, unit_type, size)
+ status = line[2]
+ complete = line[3]
+
+ # Handle different outputs of tw_cli
+ try:
+ size = float(line[6])
+ except ValueError:
+ size = float(line[5])
+
+ complete_txt = ''
+ if complete != '-':
+ complete_txt = ' complete: %s%%' % complete
+
+ infotext = "%s (type: %s, size: %sGB%s)" % (status, unit_type, size, complete_txt)
+
if status == "OK":
return (0, "OK - unit status is " + infotext)
+ elif status == "INITIALIZING":
+ return (1, "WARNING - unit status is " + infotext)
else:
return (2, "CRITICAL - unit status is " + infotext)
return (3, "UNKNOWN - unit %s not found in agent output" % item)
Module: check_mk
Branch: master
Commit: 7d66acbde283a1c92ba63b9fbeb446835ca05dcb
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7d66acbde283a1…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Thu Feb 17 11:44:59 2011 +0100
Updated bug entries
---
.bugs/147 | 12 ++++++++++++
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/.bugs/147 b/.bugs/147
new file mode 100644
index 0000000..aba2141
--- /dev/null
+++ b/.bugs/147
@@ -0,0 +1,12 @@
+Title: New config option snmp_options
+Component: core
+Benefit: 2
+State: open
+Cost: 1
+Date: 2011-02-17 11:43:29
+Class: feature
+
+With the new config variable snmp_options one could add custom
+options for the snmpget/walk command line. That way one could
+e.g. add a -Cc for certain devices (see docu of snmpwalk).
+Adding -Cc generally might be dangerous.