Module: check_mk
Branch: master
Commit: 5cbe4bec2c45217aa20a499ed0b2e821bd46f335
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5cbe4bec2c4521…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Thu Feb 24 16:27:31 2011 +0100
df&friends: disable trend perfdata per default
---
ChangeLog | 7 -------
checkman/df | 20 ++++++++++----------
checks/df.include | 10 ++++++++--
3 files changed, 18 insertions(+), 19 deletions(-)
diff --git a/ChangeLog b/ChangeLog
index 6a42a02..6a57a57 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,11 +1,4 @@
1.1.9i9:
- INCOMPATIBLE CHANGES:
- * All filesystem checks now have trends enabled per default. The checks
- output now three performance values instead of one. This can break
- updates of PNP graphs. Either delete all PNP graphs of {fs_} checks
- or switch off trend reporting in order for your graphs to work. Trends
- are very usefull, however...
-
Core, Setup, etc.:
* FIX: check_mk_templates.cfg: add missing check_period for hosts
(needed for Shinken)
diff --git a/checkman/df b/checkman/df
index 7050794..7f26520 100644
--- a/checkman/df
+++ b/checkman/df
@@ -22,7 +22,7 @@ description:
a logarithmic average that weights the more recent time more than time
farer away. Also data beyond the 24 hours will to some small degree be
reflected in the computation. The advantage of this algorithm is a more
- precise predection and a simpler implementation, which does not need any
+ precise prediction and a simpler implementation, which does not need any
access to any RRDs or similar storage.
Please note, that when a filesystem is started being monitored, then
@@ -30,14 +30,6 @@ description:
that it will take at least one trend range of time until the trend approximately
reflects the reality.
- Please note that after an update to {1.1.9i9} the output of the performance
- data is not compatible with older versions any longer since it outputs two
- additional values. If you use PNP in {MULTIPLE} mode then this should not be
- a problem. If you use PNP in {SINGLE} mode - which still is the default
- - then you either have to {(1)} delete your RRD files beginning with {fs_}
- or {(2)} switch off trend computing by setting
- {filesystem_default_levels["trend_range"] = None}.
-
item:
The mount point of the filesystem (UNIX) or the drive
letter in upper case followed by a colon (Windows).
@@ -89,11 +81,16 @@ examples:
perfdata:
One or three values: The first value is the used space of the filesystem
in MB. Also the minimum (0 MB), maximum (size of the filesystem) and the warning and critical
- levels in MB are provided. If {trend_range} is set (the default), then
+ levels in MB are provided. If you set {filesystem_trend_perfdata = True}, then
two additional values are output: the change of the usage in MB per range
since the last check (e.g. in MB per 24 hours) and the averaged change (so called trend),
also in MB per range.
+ Please note, that - until you use the storage type {MULTIPLE} in PNP4Nagios -
+ changing the setting of {filesystem_trend_perfdata} will stop all updates to
+ your existing filesystem RRDs. You need either to delete or convert your RRDs
+ if you want to change.
+
inventory:
df supports inventory. All filesystem the agent reports
will be inventorized except mount points listed in
@@ -164,3 +161,6 @@ inventory_df_exclude_mountpoints (list of strings): List of mount points to excl
filesystem_default_levels: Default levels for filesystem detected by inventory.
This variable is preset to {{ "levels" : (80, 90), "magic_normsize" : 20,
"levels_low" : (50, 60), "trend_range" : 24 }}
+filesystem_trend_perfdata (boolean): Whether or not to output trend performance data. This is
+ preset to {False} so that no trend performance data is output. If you change this setting you
+ need to convert or delete all RRD databases of filesystems.
diff --git a/checks/df.include b/checks/df.include
index a34054e..b2f3699 100644
--- a/checks/df.include
+++ b/checks/df.include
@@ -58,6 +58,10 @@ filesystem_default_levels = {
# Users might have set filesystem_default_levels to old format like (80, 90)
+# Turn off trend perfdata per default in order to keep
+# compatible to existing RRDs
+filesystem_trend_perfdata = False
+
# needed by df, df_netapp and vms_df and maybe others in future:
# compute warning and critical levels. Takes into account the size of
@@ -159,7 +163,8 @@ def df_check_filesystem(hostname, mountpoint, size_mb, avail_mb, params):
this_time = time.time()
# rate in MB/s, allow negative
timdif, rate = get_counter("df.%s.delta" % mountpoint, this_time, used_mb, True)
- perfdata.append(("growth", rate * range_sec))
+ if filesystem_trend_perfdata:
+ perfdata.append(("growth", rate * range_sec))
# average trend, initialize with zero
timedif, rate_avg = get_average("df.%s.trend" % mountpoint, this_time, rate, range_sec, True)
@@ -196,7 +201,8 @@ def df_check_filesystem(hostname, mountpoint, size_mb, avail_mb, params):
status = 2
problems[-1] += "!"
- perfdata.append(("trend", trend, wa, cr, 0, size_mb / range))
+ if filesystem_trend_perfdata:
+ perfdata.append(("trend", trend, wa, cr, 0, size_mb / range))
# compute time until filesystem is full (only for positive trend, of course)
if trend > 0:
Module: check_mk
Branch: master
Commit: 8f4d40ffed7c5961f2e40c6f6cc152a1a223503e
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8f4d40ffed7c59…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Mon Feb 21 15:57:57 2011 +0100
read in local.mk as last file, sort conf.d files
---
.bugs/33 | 10 +++++++---
ChangeLog | 3 +++
modules/check_mk.py | 13 ++++++++++---
3 files changed, 20 insertions(+), 6 deletions(-)
diff --git a/.bugs/33 b/.bugs/33
index cceb386..f39be6c 100644
--- a/.bugs/33
+++ b/.bugs/33
@@ -1,10 +1,14 @@
Title: Datei local.mk, die nicht gebackupt wird
Component: core
+State: done
+Class: feature
+Date: 2010-12-21 20:50:02
Benefit: 1
-State: open
Cost: 1
-Date: 2010-12-21 20:50:02
-Class: feature
+Fun: 0
Analog zu final, kommt noch nach final und wird von backup/restore
nicht angefasst.
+
+2011-02-21 15:57:37: changed state open -> done
+Is done. View updated docu for details.
diff --git a/ChangeLog b/ChangeLog
index fbf282d..672143f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -12,6 +12,9 @@
* FIX: read *.include files before checks. Fixes df_netapp not finding
its check function
* FIX: inventory checks on SNMP+TCP hosts ignored new TCP checks
+ * local.mk: This file is read after final.mk and *not* backup up
+ or restored
+ * read all files in conf.d/*.mk in alphabetical order now.
Checks & Agents:
* ucd_cpu_load: new check for CPU load via UCD SNMP agent
diff --git a/modules/check_mk.py b/modules/check_mk.py
index a98a40d..c3acd35 100755
--- a/modules/check_mk.py
+++ b/modules/check_mk.py
@@ -3756,13 +3756,20 @@ def do_automation(cmd, args):
def all_nonfunction_vars():
return set([ name for name,value in globals().items() if name[0] != '_' and type(value) != type(lambda:0) ])
-vars_before_config = all_nonfunction_vars()
-list_of_files = [ check_mk_configfile ] + glob.glob(check_mk_configdir + '/*.mk')
+# Create list of all files to be included
+list_of_files = glob.glob(check_mk_configdir + '/*.mk')
+list_of_files.sort()
+list_of_files = [ check_mk_configfile ] + list_of_files
final_mk = check_mk_basedir + "/final.mk"
if os.path.exists(final_mk):
list_of_files.append(final_mk)
+local_mk = check_mk_basedir + "/local.mk"
+if os.path.exists(local_mk):
+ list_of_files.append(local_mk)
+
+vars_before_config = all_nonfunction_vars()
for _f in list_of_files:
# Hack: during parent scan mode we must not read in old version of parents.mk!
if '--scan-parents' in sys.argv and _f.endswith("/parents.mk"):
@@ -3840,7 +3847,7 @@ if __name__ == "__main__":
checks = autochecks + checks
vars_after_config = all_nonfunction_vars()
-ignored_variables = set(['vars_before_config', 'rrdtool', 'final_mk', 'list_of_files', 'autochecks',
+ignored_variables = set(['vars_before_config', 'rrdtool', 'autochecks',
'parts' ,'hosttags' ,'seen_hostnames' ,'all_hosts_untagged' ,'taggedhost' ,'hostname'])
errors = 0
for name in vars_after_config:
Module: check_mk
Branch: master
Commit: 2c46afb3f2cd18e683681941c789b22eaf2e0f96
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2c46afb3f2cd18…
Author: Mathias Kettner <mk(a)mathias-kettner.de>
Date: Mon Feb 21 10:14:34 2011 +0100
Updated man page of df
---
checkman/df | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/checkman/df b/checkman/df
index 8a57dba..7050794 100644
--- a/checkman/df
+++ b/checkman/df
@@ -25,12 +25,18 @@ description:
precise predection and a simpler implementation, which does not need any
access to any RRDs or similar storage.
- Please note that after an update to {1.1.9i1} the output of the performance
+ Please note, that when a filesystem is started being monitored, then
+ the trend of the past is unknown and will be assumed to be {zero}. That means
+ that it will take at least one trend range of time until the trend approximately
+ reflects the reality.
+
+ Please note that after an update to {1.1.9i9} the output of the performance
data is not compatible with older versions any longer since it outputs two
additional values. If you use PNP in {MULTIPLE} mode then this should not be
a problem. If you use PNP in {SINGLE} mode - which still is the default
- then you either have to {(1)} delete your RRD files beginning with {fs_}
- or {(2)} switch off trend computing by setting {filesystem_default_levels["trend_rangE"] = None}.
+ or {(2)} switch off trend computing by setting
+ {filesystem_default_levels["trend_range"] = None}.
item:
The mount point of the filesystem (UNIX) or the drive