Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64676 discussions

Check_MK Git: check_mk: Wato: Changed edit_dashboard form to post

by Bastian Kuhn

Module: check_mk Branch: master Commit: 97b2aa227eb01b8da676f6c6c6715baf2ac7f899 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=97b2aa227eb01b… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Fri Nov 7 13:45:24 2014 +0100 Wato: Changed edit_dashboard form to post --- web/htdocs/dashboard.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/dashboard.py b/web/htdocs/dashboard.py index ad5fcdb..20abdf6 100644 --- a/web/htdocs/dashboard.py +++ b/web/htdocs/dashboard.py @@ -925,7 +925,7 @@ def page_edit_dashlet(): html.write("<div class=error>%s</div>\n" % e.message) html.add_user_error(e.varname, e.message) - html.begin_form("dashlet") + html.begin_form("dashlet", method="POST") vs_general.render_input("general", dashlet) if vs_type:

9 years, 11 months

Check_MK Git: check_mk: #1495 Most WATO tables can now be sorted ( where useful)

by Lars Michelsen

Module: check_mk Branch: master Commit: 8925bab1c1834b20daa1e83e725b055e77466744 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8925bab1c1834b… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Nov 7 12:10:32 2014 +0100 #1495 Most WATO tables can now be sorted (where useful) Most of the data tables in WATO can now be used. Some of the tables which have a defined order, like the rules within a ruleset can not be sorted using the new sort mechanism. At the moment the host table is not sortable, but this will be added soon. --- .werks/1495 | 14 ++++++ ChangeLog | 1 + mkeventd/web/plugins/wato/mkeventd.py | 2 +- web/htdocs/lib.py | 2 +- web/htdocs/pages.css | 3 ++ web/htdocs/table.py | 84 ++++++++++++++++++++++++--------- web/htdocs/wato.py | 6 +-- 7 files changed, 84 insertions(+), 28 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=8925bab1c1…

9 years, 11 months

Check_MK Git: check_mk: #1494 FIX Fixed error in NagVis Maps snapin when some users had no contact groups assigned

by Lars Michelsen

Module: check_mk Branch: master Commit: 438f086fb17757061ff1fe7a5003b78b7c6c31bd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=438f086fb17757… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Nov 7 10:40:00 2014 +0100 #1494 FIX Fixed error in NagVis Maps snapin when some users had no contact groups assigned --- .werks/1494 | 10 ++++++++++ ChangeLog | 1 + web/plugins/userdb/hook_auth.py | 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/1494 b/.werks/1494 new file mode 100644 index 0000000..708bb2c --- /dev/null +++ b/.werks/1494 @@ -0,0 +1,10 @@ +Title: Fixed error in NagVis Maps snapin when some users had no contact groups assigned +Level: 1 +Component: multisite +Class: fix +Compatible: compat +State: unknown +Version: 1.2.5i7 +Date: 1415353168 + + diff --git a/ChangeLog b/ChangeLog index bcc24d6..1d10f66 100644 --- a/ChangeLog +++ b/ChangeLog @@ -37,6 +37,7 @@ * 1487 FIX: Fixed exception in Web GUI "Internal error:: name 'Filter' is not defined" in manual setups (using setup.py)... * 1488 FIX: Fixed wrong information showing up on "Host Group" and "Service Group" views... * 1433 FIX: Quicksearch: no longer shows an invalid search result when looking for multiple hosts... + * 1494 FIX: Fixed error in NagVis Maps snapin when some users had no contact groups assigned WATO: * 1170 Added buttons to move rules to top/bottom of the list to ruleset edit dialog diff --git a/web/plugins/userdb/hook_auth.py b/web/plugins/userdb/hook_auth.py index 0f2f70f..fc34447 100644 --- a/web/plugins/userdb/hook_auth.py +++ b/web/plugins/userdb/hook_auth.py @@ -142,7 +142,7 @@ function user_roles($username) { function user_groups($username) { global $mk_users; - if(!isset($mk_users[$username])) + if(!isset($mk_users[$username]) || !isset($mk_users[$username]['contactgroups'])) return array(); else return $mk_users[$username]['contactgroups'];

9 years, 11 months

Check_MK Git: check_mk: domino_info: service discovery of the check now works for windows and linux hosts the notes server is running on

by Goetz Golla

Module: check_mk Branch: master Commit: f2bcee490f0959a97914d2e2b33258d1724f1a35 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f2bcee490f0959… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Fri Nov 7 09:36:51 2014 +0100 domino_info: service discovery of the check now works for windows and linux hosts the notes server is running on --- checks/domino_info | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/checks/domino_info b/checks/domino_info index 8754b0a..ed89b9e 100644 --- a/checks/domino_info +++ b/checks/domino_info @@ -64,7 +64,8 @@ check_info['domino_info'] = { "inventory_function" : inventory_domino_info, "has_perfdata" : False, "service_description" : "Domino Info", - "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0") == ".1.3.6.1.4.1.311.1.1.3.1.2", + "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0").startswith(".1.3.6.1.4.1.311.1.1.3") or \ + oid(".1.3.6.1.2.1.1.2.0").startswith(".1.3.6.1.4.1.8072.3.1.10"), "snmp_info" : [ [ ".1.3.6.1.4.1.334.72.2", [ 2 ] ], # lnNotesServerState [ ".1.3.6.1.4.1.334.72.1.1.4", [ 8 ] ], # lnMailDomain

9 years, 11 months

Check_MK Git: check_mk: #1448 domino_info: check is extended to also show and monitor the lnNotesServerState

by Goetz Golla

Module: check_mk Branch: master Commit: 5ca1f935c6b7d231cd9115746d946b92375a50f9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5ca1f935c6b7d2… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Fri Nov 7 09:03:13 2014 +0100 #1448 domino_info: check is extended to also show and monitor the lnNotesServerState --- .werks/1448 | 9 +++++++++ ChangeLog | 1 + checkman/domino_info | 15 +++++++++++---- checks/domino_info | 28 +++++++++++++++++++++++----- 4 files changed, 44 insertions(+), 9 deletions(-) diff --git a/.werks/1448 b/.werks/1448 new file mode 100644 index 0000000..c83b530 --- /dev/null +++ b/.werks/1448 @@ -0,0 +1,9 @@ +Title: domino_info: check is extended to also show and monitor the lnNotesServerState +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.5i7 +Date: 1415347315 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index bd15e6a..eb99d58 100644 --- a/ChangeLog +++ b/ChangeLog @@ -19,6 +19,7 @@ * 1432 agent_vsphere: now able to monitor virtual machines snapshots... * 1507 New optional parse_function for check API... * 1445 quantum_libsmall_door, quantum_libsmall_status: Two new checks for monitoring small Quantum tape libraries + * 1448 domino_info: check is extended to also show and monitor the lnNotesServerState * 1478 FIX: kernel.util, statgrab_cpu: fix computation of utilization... * 1480 FIX: brocade_vdx_status: disable check on some devices that do not support it... * 1485 FIX: dell_om_disks, dell_om_esmlog, dell_om_mem, dell_om_processors, dell_om_sensors: detect more devices... diff --git a/checkman/domino_info b/checkman/domino_info index 6464205..d790d22 100644 --- a/checkman/domino_info +++ b/checkman/domino_info @@ -4,7 +4,14 @@ catalog: app/lotusnotes license: GPL distribution: check_mk description: - This check uses snmp to extract the following informational data about a - Lotus Notes Server: {lnServerName} the server name, {lnMailDomain} the server - domain, {lnServerNotesVersion} the Lotus Notes version. No configuration and - no limits can be set in this check. + + This check uses snmp to extract the following information about a Lotus + Domino Server from the Notes-MIB: {lnNotesServerState} the overall + state, {lnServerName} the server name, {lnMailDomain} the server domain, + {lnServerNotesVersion} the Lotus Domino version. + + The state of the check is determined from the {lnNotesServerState}. A state of + 1:{up} leads to an OK state, states 2-4:{down, not_responding, crashed} + lead to a critical state, otherwise the state is warning. + + No configuration and no limits can be set in this check. diff --git a/checks/domino_info b/checks/domino_info index 4055dbc..8754b0a 100644 --- a/checks/domino_info +++ b/checks/domino_info @@ -27,20 +27,37 @@ # Example SNMP walk: # +# .1.3.6.1.4.1.334.72.2.2.0 1 # .1.3.6.1.4.1.334.72.1.1.4.8.0 MEDEMA # .1.3.6.1.4.1.334.72.1.1.6.2.1.0 CN=HH-BK4/OU=SRV/O=MEDEMA/C=DE # .1.3.6.1.4.1.334.72.1.1.6.2.4.0 Release 8.5.3FP5 HF89 +domino_info_states = { + '1' : 'up', + '2' : 'down', + '3' : 'not-responding', + '4' : 'crashed', + '5' : 'unknown' +} + def inventory_domino_info(info): - if info and len(info) == 3: + if info and len(info[0]) != 0: yield None, None def check_domino_info(_no_item, _no_params, info): - if len(info) == 3: - domain, name, release = info - infotext = "Name: %s, Domain: %s, %s" % ( domain[0][0], name[0][0], release[0][0] ) - yield 0, infotext + serverstate, domain, name, release = info + if int(serverstate[0][0]) > 4: + state = 1 + infotext = "Server is %s" % ( domino_info_states[serverstate[0][0]] ) + elif int(serverstate[0][0]) > 1: + state = 2 + infotext = "Server is %s" % ( domino_info_states[serverstate[0][0]] ) + else: + state = 0 + infotext = "Server is %s. Domain: %s, Name: %s, %s" \ + % ( domino_info_states[serverstate[0][0]], domain[0][0], name[0][0], release[0][0] ) + yield state, infotext check_info['domino_info'] = { "check_function" : check_domino_info, @@ -49,6 +66,7 @@ check_info['domino_info'] = { "service_description" : "Domino Info", "snmp_scan_function" : lambda oid: oid(".1.3.6.1.2.1.1.2.0") == ".1.3.6.1.4.1.311.1.1.3.1.2", "snmp_info" : [ + [ ".1.3.6.1.4.1.334.72.2", [ 2 ] ], # lnNotesServerState [ ".1.3.6.1.4.1.334.72.1.1.4", [ 8 ] ], # lnMailDomain [ ".1.3.6.1.4.1.334.72.1.1.6.2", [ 1 ] ], # lnServerName [ ".1.3.6.1.4.1.334.72.1.1.6.2", [ 4 ] ], # lnServerNotesVersion

9 years, 11 months

Check_MK Git: check_mk: esx_vsphere_vm.snapshots: removed inventory condition, fixed copy/paste error...

by Andreas Boesl

Module: check_mk Branch: master Commit: 53aa02627079966ac49321a57ae649211d80aa2a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=53aa0262707996… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Nov 7 06:57:05 2014 +0100 esx_vsphere_vm.snapshots: removed inventory condition, fixed copy/paste error... --- checks/esx_vsphere_vm | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/checks/esx_vsphere_vm b/checks/esx_vsphere_vm index da7ed31..da3532b 100644 --- a/checks/esx_vsphere_vm +++ b/checks/esx_vsphere_vm @@ -365,12 +365,10 @@ check_info['esx_vsphere_vm.cpu'] = { # snapshot.rootSnapshotList 1 1363596734 poweredOff 20130318_105600_snapshot_LinuxI|2 1413977827 poweredOn LinuxI Testsnapshot -def inventory_esx_vsphere_vm_cpu(info): - data = esx_vsphere_vm_convert(info) - if 'snapshot.rootSnapshotList' in data: - return [(None, {})] +def inventory_esx_vsphere_vm_snapshots(info): + return [(None, {})] -def check_esx_vsphere_vm_cpu(_no_item, params, info): +def check_esx_vsphere_vm_snapshots(_no_item, params, info): data = esx_vsphere_vm_convert(info) if 'snapshot.rootSnapshotList' not in data: @@ -412,8 +410,8 @@ def check_esx_vsphere_vm_cpu(_no_item, params, info): check_info['esx_vsphere_vm.snapshots'] = { - "inventory_function" : inventory_esx_vsphere_vm_cpu, - "check_function" : check_esx_vsphere_vm_cpu, + "inventory_function" : inventory_esx_vsphere_vm_snapshots, + "check_function" : check_esx_vsphere_vm_snapshots, "service_description" : "ESX Snapshots", "group" : "vm_snapshots", "has_perfdata" : True,

9 years, 11 months

Check_MK Git: check_mk: #1433 FIX Quicksearch: no longer shows an invalid search result when looking for multiple hosts

by Andreas Boesl

Module: check_mk Branch: master Commit: 1f7a4b3546377aa43af743eb33ff0766d2735b59 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1f7a4b3546377a… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Nov 6 09:54:09 2014 +0100 #1433 FIX Quicksearch: no longer shows an invalid search result when looking for multiple hosts The quicksearch used the wrong search filter for the given pattern: <i>host</i> instead of <i>host_regex</i> --- .werks/1433 | 10 ++++++++++ ChangeLog | 1 + web/htdocs/sidebar.py | 2 +- web/plugins/sidebar/search.py | 2 +- 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/.werks/1433 b/.werks/1433 new file mode 100644 index 0000000..5f85ad6 --- /dev/null +++ b/.werks/1433 @@ -0,0 +1,10 @@ +Title: Quicksearch: no longer shows an invalid search result when looking for multiple hosts +Level: 2 +Component: multisite +Compatible: compat +Version: 1.2.5i7 +Date: 1415263841 +Class: fix + +The quicksearch used the wrong search filter for the given pattern: <i>host</i> +instead of <i>host_regex</i> diff --git a/ChangeLog b/ChangeLog index 38274fb..36ec748 100644 --- a/ChangeLog +++ b/ChangeLog @@ -31,6 +31,7 @@ * 1482 FIX: Fix exception when editing a visual of type single host group... * 1487 FIX: Fixed exception in Web GUI "Internal error:: name 'Filter' is not defined" in manual setups (using setup.py)... * 1488 FIX: Fixed wrong information showing up on "Host Group" and "Service Group" views... + * 1433 FIX: Quicksearch: no longer shows an invalid search result when looking for multiple hosts... WATO: * 1170 Added buttons to move rules to top/bottom of the list to ruleset edit dialog diff --git a/web/htdocs/sidebar.py b/web/htdocs/sidebar.py index ea9682c..a262c43 100644 --- a/web/htdocs/sidebar.py +++ b/web/htdocs/sidebar.py @@ -781,7 +781,7 @@ def search_url_tmpl(used_filters, row, exact = True): # Default search templates ty = plugin.get("dftl_url_tmpl", plugin.get("id")) if ty == 'hosts': - return 'view.py?view_name=searchhost&host=%(name)s&filled_in=filter' + return 'view.py?view_name=searchhost&host_regex=%(name)s&filled_in=filter' elif ty == 'hostgroups': return 'view.py?view_name=hostgroups&hostgroup_name=%(name)s&site=%(site)s' elif ty == 'servicegroups': diff --git a/web/plugins/sidebar/search.py b/web/plugins/sidebar/search.py index 41b3976..2762fdb 100644 --- a/web/plugins/sidebar/search.py +++ b/web/plugins/sidebar/search.py @@ -175,7 +175,7 @@ def search_hosts_filter(filters, host_is_ip = False): return lq_filter def search_hosts_url_tmpl(used_filters, data, host_is_ip = False): - filter_field = host_is_ip and "host_address=(%s)" or "host=(%s)" % "|".join(map(lambda x: x[1], used_filters)) + filter_field = host_is_ip and "host_address=(%s)" or "host_regex=(%s)" % "|".join(map(lambda x: x[1], used_filters)) return 'view.py?view_name=searchhost&filled_in=filter&' + filter_field def search_host_service_filter(filters, host_is_ip = False):

9 years, 11 months

Check_MK Git: check_mk: Updated bug entries #1011

by Goetz Golla

Module: check_mk Branch: master Commit: 7f60654e4d11e5bc5fad5515e531d630d1c783c9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=7f60654e4d11e5… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Thu Nov 6 17:32:54 2014 +0100 Updated bug entries #1011 --- .bugs/1011 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.bugs/1011 b/.bugs/1011 index acb15f4..916b26d 100644 --- a/.bugs/1011 +++ b/.bugs/1011 @@ -5,6 +5,7 @@ Date: 2014-11-05 22:49:22 Targetversion: future Class: nastiness -logging behaviour can be configured in several places in wato (e.g. global settings), however it is neven mentioned where the actual logfiles can be found, and +logging behaviour can be configured in several places in wato (e.g. global settings), +however it is often not mentioned where the actual logfiles can be found, and paths are not at all intuitive. It would be of great benefit to the users to mention the location of the log whenever logging behaviour can be configured.

9 years, 11 months

Check_MK Git: check_mk: Updated bug entries #1014

by Goetz Golla

Module: check_mk Branch: master Commit: bf031c0bf4980c0c6ba4c2d8e3894ef433140a32 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bf031c0bf4980c… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Thu Nov 6 17:31:19 2014 +0100 Updated bug entries #1014 --- .bugs/1014 | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.bugs/1014 b/.bugs/1014 new file mode 100644 index 0000000..e080d40 --- /dev/null +++ b/.bugs/1014 @@ -0,0 +1,9 @@ +Title: some global settings show a help text when hovering over them, some dont +Component: wato +State: open +Date: 2014-11-06 17:28:13 +Targetversion: future +Class: nastiness + +most of the global settings show a help text when clicking on the settings line, however only some of these +also show the help text when hovering over the line. hovering should work for all the global settings.

9 years, 11 months

Check_MK Git: check_mk: Updated bug entries #1012, #1013

by Goetz Golla

Module: check_mk Branch: master Commit: 18edaf3e80936ec35a1f7b1338ea2baf46797fe1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=18edaf3e80936e… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Thu Nov 6 17:14:08 2014 +0100 Updated bug entries #1012, #1013 --- .bugs/1012 | 9 +++++++++ .bugs/1013 | 8 ++++++++ 2 files changed, 17 insertions(+) diff --git a/.bugs/1012 b/.bugs/1012 new file mode 100644 index 0000000..4a765fa --- /dev/null +++ b/.bugs/1012 @@ -0,0 +1,9 @@ +Title: wato list of rules: display used rulesets in different color +Component: wato +State: open +Date: 2014-11-06 17:04:46 +Targetversion: future +Class: feature + +In the various rule listings it would be extremly useful if used rules sets +are shown in a different color than unused rulesets. diff --git a/.bugs/1013 b/.bugs/1013 new file mode 100644 index 0000000..87a85d2 --- /dev/null +++ b/.bugs/1013 @@ -0,0 +1,8 @@ +Title: make search in global settings possible +Component: wato +State: open +Date: 2014-11-06 17:12:22 +Targetversion: future +Class: feature + +a search feature for global settings would be very helpful

9 years, 11 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits