Module: check_mk
Branch: master
Commit: e6db9c30fdc9d8e1bc99e4596b44fba07c85e446
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e6db9c30fdc9d8…
Author: Andreas Boesl <ab(a)mathias-kettner.de>
Date: Tue Nov 11 12:20:48 2014 +0100
#1435 FIX Saving BI aggregations: No longer reports 'Request-URI Too Large'
The data from this formular now gets send as a POST instead of a GET request.
---
.werks/1435 | 10 ++++++++++
ChangeLog | 3 +++
web/htdocs/wato.py | 2 +-
3 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/.werks/1435 b/.werks/1435
new file mode 100644
index 0000000..83c5ec3
--- /dev/null
+++ b/.werks/1435
@@ -0,0 +1,10 @@
+Title: Saving BI aggregations: No longer reports 'Request-URI Too Large'
+Level: 1
+Component: bi
+Class: fix
+Compatible: compat
+State: unknown
+Version: 1.2.5i7
+Date: 1415704778
+
+The data from this formular now gets send as a POST instead of a GET request.
diff --git a/ChangeLog b/ChangeLog
index 67b71d5..0850e9d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -53,6 +53,9 @@
Notifications:
* 1168 FIX: HTML mails can now be configured to display graphs among each other...
+ BI:
+ * 1435 FIX: Saving BI aggregations: No longer reports 'Request-URI Too Large'...
+
Event Console:
* 1169 Added host state type filter to "recent event history" view
diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py
index 9621790..081460b 100644
--- a/web/htdocs/wato.py
+++ b/web/htdocs/wato.py
@@ -16614,7 +16614,7 @@ def mode_bi_edit_aggregation(phase):
else:
value = aggregations[nr]
- html.begin_form("biaggr")
+ html.begin_form("biaggr", method = "POST")
vs_aggregation.render_input("aggr", value)
forms.end()
html.hidden_fields()
Module: check_mk
Branch: master
Commit: 39dbeb2cb2dfd134cd0c5b16a0c848d04a98e472
URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=39dbeb2cb2dfd1…
Author: Lars Michelsen <lm(a)mathias-kettner.de>
Date: Tue Nov 11 10:06:13 2014 +0100
#1496 FIX Fixed exception after editing a dashboard as user without permission to publish dashboards
When a user without permission to publish a dashboard created or customized a dashboard,
the dashboard could be saved, but resulted in an exception later during rendering the
following pages. This fix prevents creation of damages dashboards.
The exception can be fixed by removing the dashboard definition from var/check_mk/web/USER/user_dashboards.mk
or simply removing the whole file, which would delete all custom dashboards of the user.
---
.werks/1496 | 15 +++++++++++++++
ChangeLog | 1 +
web/htdocs/visuals.py | 3 +++
3 files changed, 19 insertions(+)
diff --git a/.werks/1496 b/.werks/1496
new file mode 100644
index 0000000..0077d79
--- /dev/null
+++ b/.werks/1496
@@ -0,0 +1,15 @@
+Title: Fixed exception after editing a dashboard as user without permission to publish dashboards
+Level: 1
+Component: multisite
+Class: fix
+Compatible: compat
+State: unknown
+Version: 1.2.5i7
+Date: 1415696641
+
+When a user without permission to publish a dashboard created or customized a dashboard,
+the dashboard could be saved, but resulted in an exception later during rendering the
+following pages. This fix prevents creation of damages dashboards.
+
+The exception can be fixed by removing the dashboard definition from var/check_mk/web/USER/user_dashboards.mk
+or simply removing the whole file, which would delete all custom dashboards of the user.
diff --git a/ChangeLog b/ChangeLog
index f26c72c..67b71d5 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -39,6 +39,7 @@
* 1488 FIX: Fixed wrong information showing up on "Host Group" and "Service Group" views...
* 1433 FIX: Quicksearch: no longer shows an invalid search result when looking for multiple hosts...
* 1494 FIX: Fixed error in NagVis Maps snapin when some users had no contact groups assigned
+ * 1496 FIX: Fixed exception after editing a dashboard as user without permission to publish dashboards...
WATO:
* 1170 Added buttons to move rules to top/bottom of the list to ruleset edit dialog
diff --git a/web/htdocs/visuals.py b/web/htdocs/visuals.py
index 1245c9d..d06a733 100644
--- a/web/htdocs/visuals.py
+++ b/web/htdocs/visuals.py
@@ -667,6 +667,9 @@ def page_edit_visual(what, all_visuals, custom_field_handler = None,
for key, title in visibility_choices:
visual[key] = key in general_properties['visibility']
+ if not config.may("general.publish_" + what):
+ visual['public'] = False
+
if create_handler:
visual = create_handler(old_visual, visual)