Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64242 discussions

[Checkmk/checkmk] c91ffa: 17059 SEC Escape user input on load failure of vis...

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: c91ffa81b3cb743d0f8aafb8b18a63e77d971096 https://github.com/Checkmk/checkmk/commit/c91ffa81b3cb743d0f8aafb8b18a63e77… Author: Ronny Bruska <ronny.bruska(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A .werks/17059 M cmk/gui/visuals/__init__.py Log Message: ----------- 17059 SEC Escape user input on load failure of visuals CMK-17245 Change-Id: Iebd1575eed7a84efb0a5d37418eb8b04facdef0b To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] 750a32: 17059 SEC Escape user input on load failure of vis...

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 750a32453a319740681ea9f5871d6c9349b17d2d https://github.com/Checkmk/checkmk/commit/750a32453a319740681ea9f5871d6c934… Author: Ronny Bruska <ronny.bruska(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A .werks/17059.md M cmk/gui/visuals/_store.py Log Message: ----------- 17059 SEC Escape user input on load failure of visuals CMK-17245 Change-Id: Iebd1575eed7a84efb0a5d37418eb8b04facdef0b To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] 6d7182: 16787 FIX ldap: users should be created without th...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 6d71822c82b22c0b9799c654d80bd45da1c6b528 https://github.com/Checkmk/checkmk/commit/6d71822c82b22c0b9799c654d80bd45da… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A .werks/16787.md M cmk/gui/userdb/_check_credentials.py M cmk/gui/userdb/ldap_connector.py M tests/unit/cmk/gui/userdb/test_ldap_golden.py Log Message: ----------- 16787 FIX ldap: users should be created without the suffix unless there are conflicts Previously, if you had an ldap connection configured with both a "suffix" and "create users only on login" enabled. The username used to login would be used to create a user profile. e.g. * testuser1 -> created a userprofile called testuser1 * testuser1@suffix -> created a userprofile called testuser1@suffix This was incorrect. The suffix should only be used when there are conflicts. This werk addresses this issue by changing the behaviour to: * Check if the user (without the suffix) already exists. * If it's the same user, login with this user. No need to create a new user profile. * If it's a different user, repeat the process using the username with the suffix. SUP-18262 Change-Id: I1c1019ef18a34b3c05a46ee8d1cd260e68277098 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] 2e2ba6: Move htpasswd module to cmk.gui

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 2e2ba6f93d9356f945cd201a12b3a76c221f8a5f https://github.com/Checkmk/checkmk/commit/2e2ba6f93d9356f945cd201a12b3a76c2… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M bin/cmk-passwd M cmk/cmkpasswd.py M cmk/gui/auth.py M cmk/gui/userdb/_check_credentials.py M cmk/gui/userdb/htpasswd.py M cmk/gui/userdb/store.py A cmk/gui/utils/htpasswd.py R cmk/utils/store/htpasswd.py M tests/pylint/checker_cmk_module_layers.py M tests/unit/cmk/gui/userdb/test_userdb.py M tests/unit/cmk/utils/test_store_htpasswd.py Log Message: ----------- Move htpasswd module to cmk.gui * We would like to isolate cmk.utils.store as module with cross-cutting concern. `htpasswd` isn't X-cutting. * htpasswd only has users in `cmk.gui` so moving it there improves the cohesion. CMK-18050 Change-Id: I52686d36d2c2ad2523e3c40ce421af6c31343c8e Commit: cc28f64ea9f8dd91b62efc048c1dd1c659c08661 https://github.com/Checkmk/checkmk/commit/cc28f64ea9f8dd91b62efc048c1dd1c65… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/base/config.py M cmk/base/core_nagios/_create_config.py M cmk/base/default_config/base.py M cmk/base/notify.py M cmk/bi/packs.py M cmk/ec/actions.py M cmk/ec/core_queries.py M cmk/gui/logged_in.py M cmk/gui/type_defs.py M cmk/gui/userdb/store.py M cmk/gui/wato/pages/folders.py M cmk/gui/watolib/host_attributes.py M cmk/gui/watolib/hosts_and_folders.py M cmk/utils/store/host_storage.py M tests/unit/cmk/base/test_notify.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py Log Message: ----------- Avoid importing `str` from a module It introduces the most useless kind of coupling. It's confusing and lying as it makes it look like we have a more precise type than `str`. CMK-18050 Change-Id: Ifa34dd4182800d4869cb9ba953a11cb4475ce030 Commit: ec9b13e37c9e2c6a1e2a47e8ee252aafef4b8cca https://github.com/Checkmk/checkmk/commit/ec9b13e37c9e2c6a1e2a47e8ee252aafe… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/base/config.py M cmk/base/default_config/base.py M cmk/gui/watolib/hosts_and_folders.py A cmk/utils/host_storage.py R cmk/utils/store/host_storage.py M tests/unit/cmk/utils/test_store.py Log Message: ----------- Move cmk.utils.store.host_storage out of store Separation X-cutting/domain CMK-18050 Change-Id: I5a87d4f7082914c896a8cd59740b72a01dcaae31 Commit: c1584a404761dea3db8837bde7701219b3ec93ce https://github.com/Checkmk/checkmk/commit/c1584a404761dea3db8837bde7701219b… Author: Ronny Bruska <ronny.bruska(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A .werks/17059.md M cmk/gui/visuals/_store.py Log Message: ----------- 17059 SEC Escape user input on load failure of visuals CMK-17245 Change-Id: Iebd1575eed7a84efb0a5d37418eb8b04facdef0b Compare: https://github.com/Checkmk/checkmk/compare/89a8991810e1...c1584a404761 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] e7c58e: File signl4.py in 2.2.0 should be the same as in 2...

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: e7c58e8b02a24d7f0aba79ea8979aa1f7bcc61a3 https://github.com/Checkmk/checkmk/commit/e7c58e8b02a24d7f0aba79ea8979aa1f7… Author: Ron <43244104+rons4(a)users.noreply.github.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/notification_plugins/signl4.py Log Message: ----------- File signl4.py in 2.2.0 should be the same as in 2.3.0 File signl4.py in 2.2.0 should be the same as in 2.3.0. Some things have been fixed there already. Change-Id: Ie824f409a1306b96bb063ec24b20de709033edfd closes: #668 Commit: aec78f0444ce7dc856e84b0fa732a1479230ba54 https://github.com/Checkmk/checkmk/commit/aec78f0444ce7dc856e84b0fa732a1479… Author: Ronny Bruska <ronny.bruska(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A .werks/16068 Log Message: ----------- 16068 FIX SIGNL4: better support of service alerting and two-way status updates Change-Id: I7bf8b36f626397f911998ded8044ec9e2aa12e48 closes: #668 Compare: https://github.com/Checkmk/checkmk/compare/d8a53dc879cb...aec78f0444ce To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] ca725e: testlib.site: Improve error message for the intera...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: ca725e92aedba5f7b87233d6613a1e2b3840b3d7 https://github.com/Checkmk/checkmk/commit/ca725e92aedba5f7b87233d6613a1e2b3… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M tests/testlib/site.py Log Message: ----------- testlib.site: Improve error message for the interactive-update process Change-Id: I98bdb5d2dbe3ffe071992b50e8705076c3fcb2d9 Commit: ec075989e1273439bce0ea88edd4ba601b054d68 https://github.com/Checkmk/checkmk/commit/ec075989e1273439bce0ea88edd4ba601… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/wsgi/test_wsgi_router.py Log Message: ----------- unit tests: remove redundant fixture `wsgi_app_debug_off`. Based on the observations, + the input argument `test=True|False` has no effect on the test run. + `debug=False` within `wsgi_app` as well + affected test case passes when `wsgi_app` is being used as a fixture. Change-Id: I25e79120a972bf7a71f60bd5acde509eb6063f33 Commit: 89a8991810e14eb03bedbbdece83009f4a2133e1 https://github.com/Checkmk/checkmk/commit/89a8991810e14eb03bedbbdece83009f4… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/openapi/test_openapi_folder_config.py M tests/unit/cmk/post_rename_site/plugins/actions/conftest.py M tests/unit/cmk/special_agents/conftest.py M tests/unit/cmk/update_config/conftest.py Log Message: ----------- unit tests: streamline fixtures in the `flask_app`. + new fixture workflow `aut_user_auth_wsgi_app` resulted in two `Flask` objects, handling the same API endpoint. ``` aut_user_auth_wsgi_app |-> with_automation_user > ... > flask_app: Flask |-> wsgi_app: wrapper(flask_app: Flask) ``` To remove the redundancy, the following fixture relation is established ``` aut_user_auth_wsgi_app > with_automation_user > request_context > wsgi_app > flask_app: Flask ``` + necessary changes to retain test-design. Simulate an isolated flask-app context for `GET` calls * reset `redis_client` before a `GET` call. * `invalidate_caches` before a `GET` call. CMK-16516 CMK-14175 Change-Id: Ieb11eefe1e2fc80145f5effe727a2512e83f967c Compare: https://github.com/Checkmk/checkmk/compare/19f6415c5e54...89a8991810e1 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] f9707e: Dissolve BackgroundProcess class

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: f9707e36fc402bb3f800c4f6d3f3b0be6970d88b https://github.com/Checkmk/checkmk/commit/f9707e36fc402bb3f800c4f6d3f3b0be6… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/gui/background_job/__init__.py M cmk/gui/background_job/_base.py M cmk/gui/background_job/_process.py M tests/unit/cmk/gui/conftest.py Log Message: ----------- Dissolve BackgroundProcess class The class did not add real value. With the new structure the dependencies of the individual functions are much clearer. Change-Id: I819d258da7237e75a285af6ffabb488cdab8f841 Commit: 388cd186add5e46639d2fae266f41eff8d5a21f0 https://github.com/Checkmk/checkmk/commit/388cd186add5e46639d2fae266f41eff8… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/gui/background_job/_base.py M cmk/gui/background_job/_process.py Log Message: ----------- Cleanup unnecessary job status read The lock_wato and is_stoppable flags are needed during job startup and can be handed over to the process via args instead of piping it through the job status. Change-Id: Ice7c0c3ed660b7899771f4bba4bc47e2210676f2 Commit: c0919db819611b80f4699c403ff45742085b4310 https://github.com/Checkmk/checkmk/commit/c0919db819611b80f4699c403ff457420… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/gui/background_job/_base.py M cmk/gui/background_job/_process.py M tests/unit/cmk/gui/test_background_job.py Log Message: ----------- Get rid of debug_logging test fixture Change-Id: I226df4cbf721e5c165974e28c2a415685c4aa4d8 Commit: 19f6415c5e545cd7b79e6caf0b2f8999468352e9 https://github.com/Checkmk/checkmk/commit/19f6415c5e545cd7b79e6caf0b2f89994… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M tests/unit/cmk/gui/test_background_job.py Log Message: ----------- Cleanup useless dependencies on request_context Change-Id: I2b1af516cfea72054c22726bf712bcc7e9962906 Compare: https://github.com/Checkmk/checkmk/compare/acaa98a0d397...19f6415c5e54 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] 47f433: 16717 FIX Fix DCD creation using the Rest API

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 47f433d7e8f32dd2400b2fe7fa1f8291f38bd49f https://github.com/Checkmk/checkmk/commit/47f433d7e8f32dd2400b2fe7fa1f8291f… Author: Leonardo Petrora <leonardo.petrora(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A .werks/16717.md Log Message: ----------- 16717 FIX Fix DCD creation using the Rest API When creating a DCD using the Rest API, the hour and minutes of the exculded times were saved in an incorrect format, causing the GUI to crash. This werk fixes the problem and the fields are now saved as integers instead of strings. CMK-18060 Change-Id: If1b6942baf8362727a9e3ac109d64110f50f8cab To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] acaa98: Use default import mode in the unit tests

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: acaa98a0d3973d9a7aefeb595e6c74391de64a8c https://github.com/Checkmk/checkmk/commit/acaa98a0d3973d9a7aefeb595e6c74391… Author: René Slowenski <rene.slowenski(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M tests/Makefile Log Message: ----------- Use default import mode in the unit tests Now that the tests are packages (were namespace packages) the default import mode works again. This fixes the broken assertion rewriting in pytest with importlib Change-Id: I54be2a64db8ab93d783efe70f5e3c26a7d9148f2 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] 79b85b: 16717 FIX Fix DCD creation using the Rest API

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 79b85b0e6bfc019a94591a84ea308ee6e15ef3a4 https://github.com/Checkmk/checkmk/commit/79b85b0e6bfc019a94591a84ea308ee6e… Author: Leonardo Petrora <leonardo.petrora(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A .werks/16717.md Log Message: ----------- 16717 FIX Fix DCD creation using the Rest API When creating a DCD using the Rest API, the hour and minutes of the exculded times were saved in an incorrect format, causing the GUI to crash. This werk fixes the problem and the fields are now saved as integers instead of strings. CMK-18060 Change-Id: If1b6942baf8362727a9e3ac109d64110f50f8cab Commit: 0c875739559437794c89fb6a72d8691eae566502 https://github.com/Checkmk/checkmk/commit/0c875739559437794c89fb6a72d8691ea… Author: Moritz Kiemer <moritz.kiemer(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/plugins/collection/server_side_calls/cisco_meraki.py M cmk/special_agents/agent_cisco_meraki.py M tests/unit/cmk/plugins/collection/server_side_calls/test_cisco_meraki.py M tests/unit/cmk/plugins_consistency/test_special_agent_args.py M tests/unit/cmk/special_agents/test_agent_cisco_meraki.py Log Message: ----------- agent cisco meraki: allow to pass secret explicitly as well Change-Id: I0325a15d953f255c1c45fc68ba0e6c7c05c23ae4 Compare: https://github.com/Checkmk/checkmk/compare/5fc4ce1f56e7...0c8757395594 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits