Checkmk git commits

checkmk-commits@lists.checkmk.com

1 participants
64242 discussions

[Checkmk/checkmk] cad421: testlib: Add helper to create dynamic host configu...

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: cad421b7ec002b48b8ebc72605c59454d9c35211 https://github.com/Checkmk/checkmk/commit/cad421b7ec002b48b8ebc72605c59454d… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M tests/testlib/openapi_session.py Log Message: ----------- testlib: Add helper to create dynamic host configuration via API CMK-17945 Change-Id: I2162ff6c2151679b0d3621258b13c07b48909090 Commit: bee0d07b71dfd2c14e6e069e5095c3a4e8a73cec https://github.com/Checkmk/checkmk/commit/bee0d07b71dfd2c14e6e069e5095c3a4e… Author: Matteo Stifano <matteo.stifano(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M tests/testlib/openapi_session.py Log Message: ----------- testlib: Add helper to remove dynamic host configuration via API CMK-17945 Change-Id: Ie071325077fd39f0b7be8f634d877744e9a3df7c Commit: 529f138ef13193e81f0e866bfe676484410f671b https://github.com/Checkmk/checkmk/commit/529f138ef13193e81f0e866bfe6764844… Author: Maximilian Wirtz <maximilian.wirtz(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/gui/type_defs.py M cmk/gui/utils/security_log_events.py M cmk/gui/wato/pages/user_profile/two_factor.py Log Message: ----------- Change parameter to type AuthType CMK-17995 Change-Id: I878df2d8211b4a39f88ac5f188aaeb10484b0e52 Commit: ec63892e04bd084e2de829b0faafd6e0709f5a54 https://github.com/Checkmk/checkmk/commit/ec63892e04bd084e2de829b0faafd6e07… Author: Maximilian Wirtz <maximilian.wirtz(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: A .werks/17010.md Log Message: ----------- 17010 SEC XSS in SQL check parameters Here on master this was already fixed with `64147810f50f` CMK-17809 Change-Id: I8cf2d8218f1d6bb449beb6947d879b8a114e081a Commit: 4eff15c2c51b0e063813c08f13a5b44f3b1c78cb https://github.com/Checkmk/checkmk/commit/4eff15c2c51b0e063813c08f13a5b44f3… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/config.py M cmk/base/core_factory.py M cmk/base/default_config/notify.py M cmk/base/diagnostics.py M cmk/base/modes/check_mk.py M cmk/gui/autocompleters.py M cmk/gui/availability.py M cmk/gui/bi/_config.py M cmk/gui/config.py M cmk/gui/dashboard/__init__.py M cmk/gui/dashboard/cre_dashboards.py M cmk/gui/dashboard/page_show_dashboard.py M cmk/gui/fields/definitions.py M cmk/gui/global_config.py M cmk/gui/logged_in.py M cmk/gui/login.py M cmk/gui/main_menu.py M cmk/gui/main_modules.py M cmk/gui/mkeventd/wato.py M cmk/gui/openapi/endpoints/contact_group_config/__init__.py M cmk/gui/openapi/endpoints/host_group_config/__init__.py M cmk/gui/openapi/endpoints/password/__init__.py M cmk/gui/openapi/endpoints/service_group_config/__init__.py M cmk/gui/openapi/endpoints/site_management/common.py M cmk/gui/openapi/endpoints/utils.py M cmk/gui/openapi/endpoints/version/__init__.py M cmk/gui/page_menu_utils.py M cmk/gui/pagetypes.py M cmk/gui/painter/v0/painters.py M cmk/gui/plugins/config/base.py M cmk/gui/plugins/main_modules/registration.py M cmk/gui/plugins/wato/special_agents/azure.py M cmk/gui/plugins/wato/special_agents/datadog.py M cmk/gui/plugins/wato/special_agents/kube.py M cmk/gui/raw/registration.py M cmk/gui/sidebar/_snapin/__init__.py M cmk/gui/sites.py M cmk/gui/userdb/_check_credentials.py M cmk/gui/userdb/ldap_connector.py M cmk/gui/utils/theme.py M cmk/gui/view_renderer.py M cmk/gui/views/availability.py M cmk/gui/views/builtin_views.py M cmk/gui/views/command/commands.py M cmk/gui/visuals/__init__.py M cmk/gui/visuals/_add_to_visual.py M cmk/gui/visuals/_store.py M cmk/gui/wato/_check_mk_configuration.py M cmk/gui/wato/_main_modules.py M cmk/gui/wato/_notification_parameter/_mail.py M cmk/gui/wato/_omd_configuration.py M cmk/gui/wato/page_handler.py M cmk/gui/wato/pages/__init__.py M cmk/gui/wato/pages/_host_attributes.py M cmk/gui/wato/pages/activate_changes.py M cmk/gui/wato/pages/automation.py M cmk/gui/wato/pages/diagnostics.py M cmk/gui/wato/pages/events.py M cmk/gui/wato/pages/groups.py M cmk/gui/wato/pages/host_rename.py M cmk/gui/wato/pages/notifications.py M cmk/gui/wato/pages/user_profile/mega_menu.py M cmk/gui/wato/pages/user_profile/page_menu.py M cmk/gui/wato/pages/userdb_common.py M cmk/gui/wato/pages/users.py M cmk/gui/wato/registration.py M cmk/gui/watolib/activate_changes.py M cmk/gui/watolib/automation_commands.py M cmk/gui/watolib/automations.py M cmk/gui/watolib/config_domains.py M cmk/gui/watolib/config_sync.py M cmk/gui/watolib/global_settings.py M cmk/gui/watolib/groups.py M cmk/gui/watolib/registration.py M cmk/gui/watolib/rulesets.py M cmk/gui/watolib/rulespecs.py M cmk/gui/watolib/search.py M cmk/gui/watolib/site_management.py M cmk/gui/watolib/sites.py M cmk/gui/wsgi/applications/rest_api.py M cmk/gui/wsgi/applications/utils.py M cmk/plugins/collection/agent_based/inventory_checkmk_server.py M cmk/plugins/emailchecks/rulesets/active_check_mail.py M cmk/plugins/gcp/rulesets/gcp.py M cmk/post_rename_site/main.py M cmk/update_config/main.py M cmk/update_config/plugins/pre_actions/rulesets.py M cmk/utils/licensing/registry.py M cmk/utils/licensing/usage.py M cmk/utils/version.py M omd/packages/omd/omdlib/config_hooks.py M tests/conftest.py M tests/integration/cmk/base/test_check_variables.py M tests/integration/cmk/gui/utils/test_theme.py M tests/integration/cmk/snmplib/helper_get_single_oid.py M tests/integration/cmk/snmplib/helper_get_snmp_table.py M tests/integration/cmk/snmplib/helper_walk_for_export.py M tests/testlib/rest_api_client.py M tests/unit/cmk/automations/test_results.py M tests/unit/cmk/base/server_side_calls/test_macro_support_doc.py M tests/unit/cmk/base/test_core_config.py M tests/unit/cmk/base/test_core_nagios.py M tests/unit/cmk/base/test_unit_automations.py M tests/unit/cmk/gui/openapi/test_headers.py M tests/unit/cmk/gui/openapi/test_notification_rules.py M tests/unit/cmk/gui/openapi/test_openapi_agent.py M tests/unit/cmk/gui/openapi/test_openapi_autocompleters.py M tests/unit/cmk/gui/openapi/test_openapi_downtime.py M tests/unit/cmk/gui/openapi/test_openapi_folder_config.py M tests/unit/cmk/gui/openapi/test_openapi_group_config.py M tests/unit/cmk/gui/openapi/test_openapi_host_config.py M tests/unit/cmk/gui/openapi/test_openapi_password.py M tests/unit/cmk/gui/openapi/test_openapi_service.py M tests/unit/cmk/gui/openapi/test_openapi_user.py M tests/unit/cmk/gui/openapi/test_site_management.py M tests/unit/cmk/gui/openapi/test_version.py M tests/unit/cmk/gui/plugins/sidebar/test_snapins.py M tests/unit/cmk/gui/plugins/views/test_painters.py M tests/unit/cmk/gui/plugins/visuals/test_filters.py M tests/unit/cmk/gui/plugins/wato/utils/test_sample_config.py M tests/unit/cmk/gui/test_background_job.py M tests/unit/cmk/gui/test_cron.py M tests/unit/cmk/gui/test_dashboard.py M tests/unit/cmk/gui/test_pages.py M tests/unit/cmk/gui/test_visuals.py M tests/unit/cmk/gui/userdb/test_userdb.py M tests/unit/cmk/gui/utils/test_ntop.py M tests/unit/cmk/gui/views/icon/test_icons.py M tests/unit/cmk/gui/views/test_join_service_rows.py M tests/unit/cmk/gui/views/test_row_post_processing.py M tests/unit/cmk/gui/views/test_views.py M tests/unit/cmk/gui/wato/pages/test_automation.py M tests/unit/cmk/gui/wato/test_menu.py M tests/unit/cmk/gui/watolib/test_analyze_configuration.py M tests/unit/cmk/gui/watolib/test_config_sync.py M tests/unit/cmk/gui/watolib/test_gui_rulesets.py M tests/unit/cmk/gui/watolib/test_rulespecs.py M tests/unit/cmk/gui/watolib/test_user_roles.py M tests/unit/cmk/gui/watolib/test_watolib.py M tests/unit/cmk/plugins/aws/rulesets/test_aws.py M tests/unit/cmk/plugins/collection/agent_based/test_inv_checkmk.py M tests/unit/cmk/plugins/collection/agent_based/test_section_host_label_doc.py M tests/unit/cmk/update_config/plugins/actions/test_rulesets.py M tests/unit/cmk/utils/rulesets/test_tuple_rulesets.py M tests/unit/cmk/utils/test_version.py M tests/unit/conftest.py Log Message: ----------- Remove paths dep from cmk.utils.version mechanical CMK-18050 Change-Id: I404432159a020e5c5e7863e4a615f8f885172010 Commit: 1f162c49c683e45bcbb8e4b3f96975a146ff68fb https://github.com/Checkmk/checkmk/commit/1f162c49c683e45bcbb8e4b3f96975a14… Author: Max Linke <max.linke(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M tests/integration/checks/test_checks_sanity.py Log Message: ----------- test: fix sanity integration test in cse The CSE now only allows push mode for the agent. The sanity check assumes that the agent is configured in pull mode. We now deactivate active in the CSE and set less aggressive timeouts in the CSE edition. Tests take a bit longer but will still pass. Change-Id: I8b74bd215bea4b6391f3adeec241ec3dfd275b36 Commit: bf4e0b9e47e2723c7305da2679bc00b2211c3017 https://github.com/Checkmk/checkmk/commit/bf4e0b9e47e2723c7305da2679bc00b22… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: A .werks/17076.md M cmk/gui/utils/rule_specs/legacy_converter.py M cmk/gui/valuespec/definitions.py M tests/unit/cmk/gui/utils/rulespecs/test_legacy_converter.py Log Message: ----------- 17076 Fix float valuespec ignoring its self._validate The Percentage form spec relied on the validate_value function of the float valuespec to report its validators.NumberInRange. However, the Float validate_value method was overwritten instead of its _validate_value method. Resulting in all valuespecs only checking its bounds and not its custom validation functions. This also fixes the assumption that the Percentage form spec continues to use the legacy Percentage default bounds. Change-Id: I476ec419c80784dc4cad85b5acd7b19cd60de856 Commit: 90c039bb448cff0d4a5f38e5dff7622901930b98 https://github.com/Checkmk/checkmk/commit/90c039bb448cff0d4a5f38e5dff762290… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: A .werks/17077.md M cmk/gui/plugins/wato/check_parameters/filesystem_utils.py M cmk/gui/plugins/wato/check_parameters/netapp_volumes.py M cmk/plugins/collection/agent_based/df_netapp.py Log Message: ----------- 17077 Allow filesystem service rule levels to go above 100% We have one monster "filesystem" rule which is being used all over the place. However, there have been quite a few support requests for single checks coming in asking us to remove the 101% limit for the used space level as they are monitoring virtualized file systems. However, making just some checks use a specialized rule set of is a lot of work and in the end it's easier to lift the restriction for the whole rule set, even if some cases values above 100% still might not be valid. Motivated by SUP-18744 Change-Id: I107a0c885ce03b2cfab7bcbfd2278896a040f3a4 Commit: 2f013261ee460de7f6cb87f6607aca27a517a0fe https://github.com/Checkmk/checkmk/commit/2f013261ee460de7f6cb87f6607aca27a… Author: Moritz Kirschner <moritz.kirschner(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M cmk/gui/plugins/wato/check_parameters/filesystem_utils.py Log Message: ----------- Remove deprecated "levels_unbound" filesystem arg The standard levels option is unbound now anyway with Werk 17077. No rules need to be migrated since all levels report to the "levels" dict item. Change-Id: I3c13ebfb35d01d8a53f87ebd8ee2d5b422cb88e3 Commit: c7b9bd881ba782b16fb9a2dd692c5830b3150322 https://github.com/Checkmk/checkmk/commit/c7b9bd881ba782b16fb9a2dd692c5830b… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M cmk/gui/openapi/endpoints/parent_scan/__init__.py M tests/unit/cmk/gui/openapi/test_openapi_parent_scan.py Log Message: ----------- REST API: Fix AttributeError when starting parent scan Calling the "Start the parent scan background job" endpoint resulted in the following exception: 'HostAddress' object has no attribute 'site_id' Sadly the issue was not found by mypy because params is not well typed. This is a systematical issue of the REST API we need to solve at some point to get rid of this kind of issue. Change-Id: I4409053ada83a1487f85a62ee77f7c1be225f045 Commit: ea8c3c5799c967fed49cf65a135e1f4a8fe22b02 https://github.com/Checkmk/checkmk/commit/ea8c3c5799c967fed49cf65a135e1f4a8… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M cmk/gui/watolib/parent_scan.py M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/watolib/test_scan_parents_background_job.py Log Message: ----------- Prepare parent scan job for a spawned process * Previously the SuperUserContext was inherited with the fork from from the run_cron page. This needs to be initialized locally now. * The lambda is not compatible with the spawn mode, replace with partial * The `inline_background_jobs` missed some now needed mocks. * Lastly the final assert needs a fresh request context now. Change-Id: I072df33d6b5570a8fad8fee7a594f35f221c0506 Commit: 7d6a8291be690d201c46bb90527831dd99b1a8bd https://github.com/Checkmk/checkmk/commit/7d6a8291be690d201c46bb90527831dd9… Author: Jonas Scharpf <jonas.scharpf(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M .werks/16878.md Log Message: ----------- Fix werk text formatting Change-Id: I9fe4ffabcf142273664a15824e963f7cfbe50914 Commit: 76d9efb2826b815085edb5b7a6f50944f1f21cdd https://github.com/Checkmk/checkmk/commit/76d9efb2826b815085edb5b7a6f50944f… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: A cmk/gui/quick_setup/aws_stages.py Log Message: ----------- quick setup: implement aws first stage CMK-17738 Change-Id: I20c61b5e82f587f921e0f34fc0f70c6a19c61466 Commit: 60d50691f9acf418e0e85f165bc27bb860d27c88 https://github.com/Checkmk/checkmk/commit/60d50691f9acf418e0e85f165bc27bb86… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M tests/unit/cmk/utils/test_version.py Log Message: ----------- Remove 1 useless monkeypatching Change-Id: Ic4893f1917eb7c5c35e5265eeca5fa46681baed8 Commit: 5d28702b96152e491c755af4d55a7c4b8fdc10e0 https://github.com/Checkmk/checkmk/commit/5d28702b96152e491c755af4d55a7c4b8… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M cmk/utils/crash_reporting.py M tests/unit/cmk/base/test_base_crash_reporting.py M tests/unit/cmk/gui/test_gui_crash_reporting.py Log Message: ----------- crashreporting: Remove dead code CMK-18050 Change-Id: I7e49edca34f741ec65d524dccce41dc0a395be55 Commit: 08b43015a0a90eb41abd3cec594ccaa9f94d3ff6 https://github.com/Checkmk/checkmk/commit/08b43015a0a90eb41abd3cec594ccaa9f… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M bin/check_mk M cmk/gui/crash_handler.py M cmk/utils/crash_reporting.py Log Message: ----------- crashreporting: Fixup typing CMK-18050 Change-Id: Ice992375514b0eedd2e0fe1a71ad791934f893e4 Commit: 266c55a1f22e0bb719eadbaa8e1d1fbba72287f6 https://github.com/Checkmk/checkmk/commit/266c55a1f22e0bb719eadbaa8e1d1fbba… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M bin/check_mk M cmk/base/errorhandling/_crash.py M cmk/ec/main.py M cmk/gui/crash_handler.py M cmk/gui/wsgi/applications/rest_api.py M cmk/special_agents/v0_unstable/crash_reporting.py M cmk/utils/crash_reporting.py M tests/unit/cmk/base/test_base_crash_reporting.py M tests/unit/cmk/ec/test_ec_crash_reporting.py M tests/unit/cmk/utils/test_crash_reporting.py Log Message: ----------- crashreporting: Remove one dep on cmk.utils.paths CMK-18050 Change-Id: I8c0a445c5f22ef6125735703796834ae338d86db Commit: e1767086964fd7aaea9e265b797c4b16ac5c7ba2 https://github.com/Checkmk/checkmk/commit/e1767086964fd7aaea9e265b797c4b16a… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: A .werks/16431.md M omd/packages/omd/omdlib/main.py Log Message: ----------- 16431 FIX omd restore: Fix RuntimeError: Failed to determine site version SUP-18672 Change-Id: Ic212139fd8e2e38c2dfbb70c9db68812870d22d5 Commit: 40daf4d59827c8387f8361b7e9a891bd5abc4045 https://github.com/Checkmk/checkmk/commit/40daf4d59827c8387f8361b7e9a891bd5… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M tests/gui_e2e/test_werks.py Log Message: ----------- gui-e2e: add `ignore_werks` list to `test_werks_available`. Werk 16878 doesn't render within 30 second timeout. CMK-18094 Change-Id: Iee9c5c9bd0d29b49f36e1df86686ba96b9fab2d0 Commit: a9209b01cc5807c96b97279110045ce846bc2682 https://github.com/Checkmk/checkmk/commit/a9209b01cc5807c96b97279110045ce84… Author: Gav <gavin.mcguigan(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M cmk/gui/openapi/endpoints/activate_changes/__init__.py Log Message: ----------- activate_changes: catch unknown activation processes error before returning running activations Running activations have already been activated (in some cases) when we then ask for the activation details. This is causing the test to be flaky. CMK-18048 Change-Id: I2789e03a04a15ea6b4c95cd88ed1eb4286e51c8f Commit: 1a8f935e36772e0330b6aa84d6dfdeb38755d75a https://github.com/Checkmk/checkmk/commit/1a8f935e36772e0330b6aa84d6dfdeb38… Author: Ronny Bruska <ronny.bruska(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: A .werks/17060.md M cmk/gui/wato/_notification_parameter/_jira_issues.py M cmk/utils/notify_types.py Log Message: ----------- 17060 Jira: Add proxy option CMK-18096 Change-Id: Icb112771f3c2c539507310d45d7d3764c68f267e Commit: a684ae00d1ecfcbb0a5631a57d0249f7a03675d5 https://github.com/Checkmk/checkmk/commit/a684ae00d1ecfcbb0a5631a57d0249f7a… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M bin/check_mk M cmk/base/errorhandling/_crash.py M cmk/ec/main.py M cmk/gui/crash_handler.py M cmk/gui/wsgi/applications/rest_api.py M cmk/special_agents/v0_unstable/crash_reporting.py M cmk/utils/crash_reporting.py M tests/unit/cmk/base/test_base_crash_reporting.py M tests/unit/cmk/ec/test_ec_crash_reporting.py M tests/unit/cmk/utils/test_crash_reporting.py Log Message: ----------- crashreporting: Remove dep on cmk.utils.{paths,version} CMK-18050 Change-Id: Ie01b9e1fd00f118e8b612f15cf69dd17b9541dc4 Commit: c809b16278127bac5936a7308e40293b4468a5cf https://github.com/Checkmk/checkmk/commit/c809b16278127bac5936a7308e40293b4… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M tests/unit/cmk/base/test_base_crash_reporting.py M tests/unit/cmk/ec/test_ec_crash_reporting.py M tests/unit/cmk/utils/test_crash_reporting.py Log Message: ----------- crashreporting: Remove unnecessary monkeypatching CMK-18050 Change-Id: I73c7734cbdac676c097952f4d49d8b2bacb5afc0 Commit: ef6cd04f6941751133da046f2bf4ee255f9c98e7 https://github.com/Checkmk/checkmk/commit/ef6cd04f6941751133da046f2bf4ee255… Author: Simon Jess <simon.jess(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: A .werks/16753.md M cmk/gui/views/inventory/_data_sources.py M cmk/gui/views/join_service_rows.py Log Message: ----------- 16753 FIX HW/SW Inventory: Fix missing joined service columns if a service is assigned to a cluster Change-Id: I75b0bd6141ba2f4b715b8c06f8aeb844df1641f3 Commit: d2f4cc26e6105a6729c59da01d53462f890f3170 https://github.com/Checkmk/checkmk/commit/d2f4cc26e6105a6729c59da01d53462f8… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M cmk/gui/background_job/_base.py M cmk/gui/background_job/_process.py M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/test_background_job.py Log Message: ----------- Change background jobs to use spawn instead of fork method With the previous fork approach we traded fast job startup against correctess and ultimately robustness. Doing that we took over part(!) of the resources held by the origin process and had to clean up various things and reinitialize some of them to have a sane execution environment. However, we can not guarantee this for each and every dependency we load into the UI code. Since we are using threading in a few places and have the one or the other native dependency, we can not be sure that the fork method does not cause any trouble. This change now changes the method to the spawn method. It does a fork, followed by an exec which load a clean Python environment and executes the target function. This comes with some additional overhead when launching a background job, but this seems to be acceptable for the jobs we currently have. As a side effect we can now get rid of the special cleanup actions, like disabling of the timeout manager, cleaning up of file handles and so on. A few cleanups are done in this commit. Some follow in separate commits. Change-Id: I165b0f439940d6aeac597de744689ca433c27257 Commit: a8bfd334d7bd406e461c8f496e0d1f1193c59648 https://github.com/Checkmk/checkmk/commit/a8bfd334d7bd406e461c8f496e0d1f119… Author: Lars Michelsen <lm(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M cmk/gui/background_job/_base.py M cmk/gui/background_job/_interface.py M cmk/gui/background_job/_process.py Log Message: ----------- Consolidate job parameter handling Change-Id: I260fc6ec195ebd30bb5b5ce1676b25b7e4da01fc Commit: 9af4d4b16587eb77b922ba5bfdf06c9a20e56f3a https://github.com/Checkmk/checkmk/commit/9af4d4b16587eb77b922ba5bfdf06c9a2… Author: Dhananjay Shah <dhananjay.shah(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M tests/gui_e2e/test_login.py Log Message: ----------- gui-e2e: remove redundant test-cases. * `test_login_works` <> `test_dashboard::test_dashboard_sanity_check` * `test_logout_works` <> `test_menu_user::test_user_logout` Change-Id: I71869cb04590840843b27e6a64935db2f1812911 Commit: 866409e8db69f50789ede13bff8d57f0f701227a https://github.com/Checkmk/checkmk/commit/866409e8db69f50789ede13bff8d57f0f… Author: Checkmk release system <feedback(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M tests/update/base_versions.json Log Message: ----------- Include 2.3.0p8 in base-versions list for update-test Commit: ab561c1b92006245adb8d493591eb6bdac6706a7 https://github.com/Checkmk/checkmk/commit/ab561c1b92006245adb8d493591eb6bda… Author: Hannes Rantzsch <hannes.rantzsch(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: A .werks/17090.md M cmk/gui/backup/handler.py M cmk/gui/bi/_config.py M cmk/gui/custom_icons/_modes.py M cmk/gui/key_mgmt.py M cmk/gui/mkeventd/wato.py M cmk/gui/wato/pages/_simple_modes.py M cmk/gui/wato/pages/audit_log.py M cmk/gui/wato/pages/bulk_discovery.py M cmk/gui/wato/pages/bulk_edit.py M cmk/gui/wato/pages/bulk_import.py M cmk/gui/wato/pages/diagnostics.py M cmk/gui/wato/pages/folders.py M cmk/gui/wato/pages/global_settings.py M cmk/gui/wato/pages/groups.py M cmk/gui/wato/pages/host_diagnose.py M cmk/gui/wato/pages/host_rename.py M cmk/gui/wato/pages/ldap.py M cmk/gui/wato/pages/notifications.py M cmk/gui/wato/pages/parentscan.py M cmk/gui/wato/pages/read_only.py M cmk/gui/wato/pages/roles.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/search.py M cmk/gui/wato/pages/sites.py M cmk/gui/wato/pages/tags.py M cmk/gui/wato/pages/timeperiods.py M cmk/gui/wato/pages/user_migrate.py M cmk/gui/wato/pages/users.py M packages/cmk-frontend/src/js/modules/forms.ts Log Message: ----------- 17090 SEC Fix Various CSRF Issues This Werk adds priviously missing CSRF-Token validation to various endpoints in WATO. The lack of CSRF-Token validation could allow an attacker to perform actions on behalf of a user without their consent, by tricking the user into visiting clicking on a malicious link. This vulnerability was identified during a commissioned penetration test conducted by PS Positive Security GmbH. *Affected Versions*: * 2.3.0 * 2.2.0 * 2.1.0 * 2.0.0 (EOL) *Vulnerability Management*: We have rated the issue with a CVSS Score of 8.8 High (`CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H`) and assigned `CVE-2024-28828`. Change-Id: Ib12128b873b7d06140e48fb66147e7a2599dd6f9 Commit: 26332221ae4612bc4a56608e3be2807419fb4cba https://github.com/Checkmk/checkmk/commit/26332221ae4612bc4a56608e3be280741… Author: David Gervasoni <david.gervasoni(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: R cmk/base/legacy_checks/mknotifyd.py A cmk/plugins/collection/agent_based/mknotifyd.py R tests/unit/checks/generictests/datasets/mknotifyd_2019-04-12_15-51-12_5cb097d06ea82_regression.py R tests/unit/checks/generictests/datasets/mknotifyd_with_deferred_corrupted.py R tests/unit/checks/generictests/datasets/mknotifyd_with_timestamp.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/cmk/plugins/collection/agent_based/test_mknotifyd.py Log Message: ----------- mknotifyd: migrate to new API Change-Id: Ie72eead2790865d85a6c9127368de9969f2f47ca Commit: 291ec346f7f3cf2aef833250534170eb5f26ddc1 https://github.com/Checkmk/checkmk/commit/291ec346f7f3cf2aef833250534170eb5… Author: David Gervasoni <david.gervasoni(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M cmk/plugins/collection/agent_based/mknotifyd.py M tests/unit/cmk/plugins/collection/agent_based/test_mknotifyd.py Log Message: ----------- mknotifyd: refactoring II Change-Id: Ic2acc0849c336b151602b59cc4c2429cfc408af6 Commit: 3cba2643a4eacebffef1f6cab06cd7c8e6c5377e https://github.com/Checkmk/checkmk/commit/3cba2643a4eacebffef1f6cab06cd7c8e… Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: A .werks/16845.md M agents/wnx/include/wnx/cfg_details.h M agents/wnx/include/wnx/cma_core.h M agents/wnx/src/common/wtools.cpp M agents/wnx/src/engine/cfg.cpp M agents/wnx/src/engine/cma_core.cpp M agents/wnx/watest/test-yaml.cpp Log Message: ----------- 16845 SEC fix a privilege escalation vulnerability in the Checkmk Windows Agent This Werk fixes a privilege escalation vulnerability in the Checkmk Windows Agent. Prior to this Werk, it was possible for authenticated users on the monitored Windows host to execute commands as administrator account that is used to run the Agent, allowing them to elevate their privileges. The reason for this issue were excessive write permissions on the `ProgramData\checkmk\agent` directory. Note that you must update Checkmk as well as the agent in order to apply this fix. This issue was found in a commissioned penetration test conducted by modzero GmbH. *Affected Versions*: * 2.3.0 * 2.2.0 * 2.1.0 *Mitigations*: If updating is not possible, you can manually remove write access for non-admin users on the `ProgramData\checkmk\agent` folder. To do this, navigate to the folder's property settings and make sure to verify the special permissions and advanced permission settings in addition to the basic permission settings. *Vulnerability Management*: We have rated the issue with a CVSS Score of 8.8 High (`CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:C/C:H/I:H/A:H`) and assigned `CVE-2024-28827`. Change-Id: I7f410d9ea98c2a7f7af084160842924bca07b5e6 Commit: 3621c393ff03d3cf04248ae4688592713828885e https://github.com/Checkmk/checkmk/commit/3621c393ff03d3cf04248ae4688592713… Author: Sofia Colakovic <sofia.colakovic(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: A .werks/16863.md M cmk/special_agents/agent_proxmox_ve.py M tests/unit/cmk/special_agents/test_agent_proxmox_ve.py Log Message: ----------- 16863 FIX proxmox: Fix log parsing crash for Proxmox versions 3.2.4 and newer The backup log format changed in Proxmox version 3.2.4 which resulted in a crash in the Proxmox special agent. The special agent can now handle both old and the new format of backup log messages. SUP-19222 Change-Id: I57c0108b20874b8d3fb5841f8827779ed1504d3a Commit: b72a722d7f2910b6079141bdba27f6332576f4e4 https://github.com/Checkmk/checkmk/commit/b72a722d7f2910b6079141bdba27f6332… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-07-02 (Tue, 02 Jul 2024) Changed paths: M cmk/plugins/collection/agent_based/inventory_kube_pod.py M cmk/plugins/collection/agent_based/kube_cluster_api_health.py M cmk/plugins/collection/agent_based/kube_cluster_info.py M cmk/plugins/collection/agent_based/kube_collector_info.py M cmk/plugins/collection/agent_based/kube_cronjob_info.py M cmk/plugins/collection/agent_based/kube_cronjob_status.py M cmk/plugins/collection/agent_based/kube_daemonset_info.py M cmk/plugins/collection/agent_based/kube_deployment_conditions.py M cmk/plugins/collection/agent_based/kube_deployment_info.py M cmk/plugins/collection/agent_based/kube_namespace_info.py M cmk/plugins/collection/agent_based/kube_node_container_count.py M cmk/plugins/collection/agent_based/kube_node_info.py M cmk/plugins/collection/agent_based/kube_node_kubelet.py M cmk/plugins/collection/agent_based/kube_persistent_volume_claim.py M cmk/plugins/collection/agent_based/kube_pod_conditions.py M cmk/plugins/collection/agent_based/kube_pod_containers.py M cmk/plugins/collection/agent_based/kube_pod_info.py M cmk/plugins/collection/agent_based/kube_pod_phase.py M cmk/plugins/collection/agent_based/kube_pod_resources.py M cmk/plugins/collection/agent_based/kube_replicas.py M cmk/plugins/collection/agent_based/kube_statefulset_info.py M cmk/plugins/lib/kube_resources.py M tests/unit/cmk/plugins/collection/agent_based/test_kube_pod_restarts.py Log Message: ----------- don't combine json with pydantic The feature set of pydantic and json are different. This can lead to subtle bugs, see Werk 16435. Change-Id: Ibe97189b445f6d24b8b927bd00d43c924113b253 Compare: https://github.com/Checkmk/checkmk/compare/cff7cd6381bd...b72a722d7f29 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] 105ffe: fix typo

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 105ffefff92eebcad2d3fd1cd7abb4c1eee58115 https://github.com/Checkmk/checkmk/commit/105ffefff92eebcad2d3fd1cd7abb4c1e… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M .werks/16434.md Log Message: ----------- fix typo Change-Id: I7e911498dde3150f21f996791de8f8430cccffae (cherry picked from commit cff7cd6381bd06cfd7a643dc73edcd0fc2e27c2a) To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] e3222a: Include 2.2.0p28 in base-versions list for update-...

by Checkmk git commit messages

Branch: refs/heads/2.2.0 Home: https://github.com/Checkmk/checkmk Commit: e3222a6bc5ff1312561a4b6a0fe76fc14f77acc9 https://github.com/Checkmk/checkmk/commit/e3222a6bc5ff1312561a4b6a0fe76fc14… Author: Checkmk release system <feedback(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M tests/update/base_versions_current_branch.json Log Message: ----------- Include 2.2.0p28 in base-versions list for update-test To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] cff7cd: fix typo

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: cff7cd6381bd06cfd7a643dc73edcd0fc2e27c2a https://github.com/Checkmk/checkmk/commit/cff7cd6381bd06cfd7a643dc73edcd0fc… Author: Solomon Jacobs <solomon.jacobs(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M .werks/16434.md Log Message: ----------- fix typo Change-Id: I7e911498dde3150f21f996791de8f8430cccffae To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] 9528b8: Include 2.2.0p28 in base-versions list for update-...

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: 9528b835192b88a66ebffa97b869524042bc76f7 https://github.com/Checkmk/checkmk/commit/9528b835192b88a66ebffa97b86952404… Author: Checkmk release system <feedback(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M tests/update/base_versions_previous_branch.json Log Message: ----------- Include 2.2.0p28 in base-versions list for update-test To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] 088932: Remove paths dep from cmk.utils.store

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 088932aa2f7b62a3160e946ac5c7301685825a49 https://github.com/Checkmk/checkmk/commit/088932aa2f7b62a3160e946ac5c730168… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/base/core_config.py M cmk/base/modes/check_mk.py M cmk/gui/background_job/_process.py M cmk/gui/openapi/restful_objects/decorators.py M cmk/gui/wato/page_handler.py M cmk/gui/wato/pages/automation.py M cmk/gui/watolib/activate_changes.py M cmk/gui/watolib/bulk_discovery.py M cmk/gui/watolib/network_scan.py M cmk/gui/watolib/parent_scan.py M cmk/gui/watolib/sample_config.py M cmk/utils/paths.py M cmk/utils/store/__init__.py M cmk/utils/store/_locks.py Log Message: ----------- Remove paths dep from cmk.utils.store Paths are metadata, we should pass them around. Not stuff them in global variables. CMK-18050 Change-Id: I4e7314898b14c62bccf6e3cc121c44e9de0531ec Commit: 7affa0d3d45a758e1ed9f70275a5bf9bd126aee7 https://github.com/Checkmk/checkmk/commit/7affa0d3d45a758e1ed9f70275a5bf9bd… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/base/diagnostics.py M cmk/gui/wsgi/blueprints/rest_api.py M cmk/notification_plugins/mail.py M cmk/special_agents/agent_bi.py M cmk/update_config/plugins/actions/update_core_config.py M cmk/utils/crash_reporting.py M cmk/utils/licensing/usage.py M cmk/utils/site.py M cmk/utils/version.py M tests/unit/cmk/utils/test_site.py Log Message: ----------- Remove paths dep from cmk.utils.site This `site` module is 😱 CMK-18050 Change-Id: Icc1beeff6a607839f2663f67d57bebdcd7837784 Commit: 2ace868a48a086a63015adb08c5eafc330c81dfe https://github.com/Checkmk/checkmk/commit/2ace868a48a086a63015adb08c5eafc33… Author: Mathias Laurin <mathias.laurin(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/base/automations/check_mk.py M cmk/gui/sidebar/_snapin/__init__.py M cmk/gui/wato/pages/activate_changes.py M cmk/gui/wato/pages/groups.py M cmk/gui/wato/pages/host_rename.py M cmk/gui/wato/registration.py M cmk/gui/watolib/registration.py M cmk/gui/watolib/sites.py M cmk/utils/version.py Log Message: ----------- Fix API in explicit edition/feature check CMK-18050 Change-Id: I13c42fbbb92eac53100ab282c414b63dbcd45145 Compare: https://github.com/Checkmk/checkmk/compare/866514b322ac...2ace868a48a0 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] 51524e: Remove superfluous pipenv usage

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 51524e8adc201e8d1808fb7740fbb33c76319b48 https://github.com/Checkmk/checkmk/commit/51524e8adc201e8d1808fb7740fbb33c7… Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M omd/Makefile M scripts/run-bazel-build.sh Log Message: ----------- Remove superfluous pipenv usage Those scripts are happy with the default python packages Change-Id: Ia2d65105ca78848e0c3f3cbe2bcbad83ff920102 Commit: 866514b322acbf41c53171e65f23f2dba81b775d https://github.com/Checkmk/checkmk/commit/866514b322acbf41c53171e65f23f2dba… Author: Timotheus Bachinger <timotheus.bachinger(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M doc/plugin-api/Makefile M omd/Makefile A omd/Pipfile A omd/Pipfile.lock M omd/packages/packages.make A omd/run-pipenv Log Message: ----------- Introduce a slim pipenv for building distro packages in the next step, it should be possible to remove those dependencies from the global pipenv Change-Id: Ic2dcb2bb2653bed5b3bbb0967bf4b04da614b04d Compare: https://github.com/Checkmk/checkmk/compare/4b5e703ceac3...866514b322ac To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk]

by Checkmk git commit messages

Branch: refs/tags/v2.2.0p28 Home: https://github.com/Checkmk/checkmk To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] b5256d: Fixup check_sql checkman for oracledb installation

by Checkmk git commit messages

Branch: refs/heads/2.3.0 Home: https://github.com/Checkmk/checkmk Commit: b5256da81384e64242015eb065fab001b81384f5 https://github.com/Checkmk/checkmk/commit/b5256da81384e64242015eb065fab001b… Author: Jonas Scharpf <jonas.scharpf(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/plugins/collection/checkman/check_sql M tests/integration/omd/test_python.py Log Message: ----------- Fixup check_sql checkman for oracledb installation Followup of SUP-14963 Change-Id: I65b0b950e29cf2b628dd1b71c206d4aa50ef6258 (cherry picked from commit 4b5e703ceac315e82fb3bfc85bf2961b5a5fc12e) To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

[Checkmk/checkmk] 4b5e70: Fixup check_sql checkman for oracledb installation

by Checkmk git commit messages

Branch: refs/heads/master Home: https://github.com/Checkmk/checkmk Commit: 4b5e703ceac315e82fb3bfc85bf2961b5a5fc12e https://github.com/Checkmk/checkmk/commit/4b5e703ceac315e82fb3bfc85bf2961b5… Author: Jonas Scharpf <jonas.scharpf(a)checkmk.com> Date: 2024-07-01 (Mon, 01 Jul 2024) Changed paths: M cmk/plugins/collection/checkman/check_sql M tests/integration/omd/test_python.py Log Message: ----------- Fixup check_sql checkman for oracledb installation Followup of SUP-14963 Change-Id: I65b0b950e29cf2b628dd1b71c206d4aa50ef6258 To unsubscribe from these emails, change your notification settings at https://github.com/Checkmk/checkmk/settings/notifications

2 months, 3 weeks

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits