Checkmk git commits April 2022

checkmk-commits@lists.checkmk.com

1 participants
674 discussions

[tribe29/checkmk] 48eba7: Remove transient and unused imports #14

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 48eba736470496616ef37d96fbb15d41196e8034 https://github.com/tribe29/checkmk/commit/48eba736470496616ef37d96fbb15d411… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/gui/fields/definitions.py M cmk/gui/plugins/openapi/endpoints/folder_config.py M cmk/gui/plugins/openapi/endpoints/host_config.py M cmk/gui/plugins/openapi/endpoints/host_tag.py M cmk/gui/plugins/openapi/endpoints/rule/__init__.py M cmk/gui/plugins/openapi/endpoints/service_discovery.py M cmk/gui/plugins/openapi/endpoints/utils.py M cmk/gui/plugins/sidebar/virtual_host_tree.py M cmk/gui/plugins/sidebar/wato.py M cmk/gui/plugins/views/wato.py M cmk/gui/plugins/visuals/wato.py M cmk/gui/plugins/wato/bi_valuespecs.py M cmk/gui/plugins/wato/builtin_attributes.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/plugins/wato/utils/context_buttons.py M cmk/gui/plugins/wato/utils/simple_modes.py M cmk/gui/plugins/webapi/autocompleters.py M cmk/gui/plugins/webapi/utils.py M cmk/gui/plugins/webapi/webapi.py M cmk/gui/wato/__init__.py M cmk/gui/wato/mkeventd.py M cmk/gui/wato/pages/activate_changes.py M cmk/gui/wato/pages/audit_log.py M cmk/gui/wato/pages/bulk_edit.py M cmk/gui/wato/pages/bulk_import.py M cmk/gui/wato/pages/custom_attributes.py M cmk/gui/wato/pages/download_agents.py M cmk/gui/wato/pages/fetch_agent_output.py M cmk/gui/wato/pages/folders.py M cmk/gui/wato/pages/global_settings.py M cmk/gui/wato/pages/groups.py M cmk/gui/wato/pages/host_diagnose.py M cmk/gui/wato/pages/host_rename.py M cmk/gui/wato/pages/hosts.py M cmk/gui/wato/pages/icons.py M cmk/gui/wato/pages/ldap.py M cmk/gui/wato/pages/notifications.py M cmk/gui/wato/pages/object_parameters.py M cmk/gui/wato/pages/parentscan.py M cmk/gui/wato/pages/pattern_editor.py M cmk/gui/wato/pages/random_hosts.py M cmk/gui/wato/pages/roles.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/search.py M cmk/gui/wato/pages/services.py M cmk/gui/wato/pages/sites.py M cmk/gui/wato/pages/tags.py M cmk/gui/wato/pages/timeperiods.py M cmk/gui/wato/pages/users.py M cmk/gui/watolib/__init__.py M cmk/gui/watolib/activate_changes.py M cmk/gui/watolib/custom_attributes.py M cmk/gui/watolib/host_attributes.py M cmk/gui/watolib/host_rename.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/services.py M cmk/gui/watolib/tags.py M tests/unit/cmk/gui/test_watolib_hosts_and_folders.py M tests/unit/cmk/gui/wato/pages/test_rulesets.py M tests/unit/cmk/gui/watolib/test_hosts_and_folders.py Log Message: ----------- Remove transient and unused imports #14 - cmk.gui.watolib.hosts_and_folders CMK-10313 Change-Id: I104e86054530f095d17b60ac36040255fd800737

2 years, 5 months

[tribe29/checkmk] 5bf9b4: web_api: replacing web_api by rest_api for execute...

by anthonyh209

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5bf9b497d18573e50067a26a7d566421b45056bd https://github.com/tribe29/checkmk/commit/5bf9b497d18573e50067a26a7d566421b… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/gui/watolib/automations.py M cmk/utils/type_defs/__init__.py A cmk/utils/type_defs/automations.py Log Message: ----------- web_api: replacing web_api by rest_api for execute_remote_automation call Change-Id: I0bbe32a5ecf0e01c52112b62b43998de1cf44df4

2 years, 5 months

[tribe29/checkmk] 832b02: Revert "13940 Long text in the inventory dashlet w...

by martinhv

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 832b02754d984d6b4a8855faf0eb2afaddd8a54b https://github.com/tribe29/checkmk/commit/832b02754d984d6b4a8855faf0eb2afad… Author: Martin Hirschvogel <martin.hirschvogel(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: R .werks/13940 M web/htdocs/js/index.ts M web/htdocs/js/modules/figures/cmk_figures.ts M web/htdocs/themes/facelift/scss/_dashboard.scss Log Message: ----------- Revert "13940 Long text in the inventory dashlet will now break into multiple lines" This reverts commit 1cc8550b462a204264c627086715e8c7f25fd101. Reason for revert: Breaks the gauge dashlet Change-Id: Ibfc167fd48ff51f4eaca9dd2b59cffd49f99ec6d

2 years, 5 months

[tribe29/checkmk] 1675f2: mk_inventory.linux: use safer way of sourcing

by SoloJacobs

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 1675f2aed4ebc9c6398e34133eda5529a2e206c1 https://github.com/tribe29/checkmk/commit/1675f2aed4ebc9c6398e34133eda5529a… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: use safer way of sourcing Sourcing files, which don't exist, is not posix compliant. Shells such as ash, dash and bash --posix will not continue execution after failing to source. Change-Id: Ifda2556af5aac4a69ff8f36ef150e9af0d7d874d Commit: 7b74009d6baa4f1849a8fab1311b93ffede12739 https://github.com/tribe29/checkmk/commit/7b74009d6baa4f1849a8fab1311b93ffe… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: remove bash array Change-Id: I8f4cd05710f4b88758ce96a6c2ba62eba2481b2d Commit: 21fad1a47cebf22fd300220ae5650037d346d560 https://github.com/tribe29/checkmk/commit/21fad1a47cebf22fd300220ae5650037d… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: remove -d from read and -print0 from find These options are not POSIX compliant. In particular, ash and dash don't understand them. The inventory still supports \n and whitespace. If you have device directories with more weird characters, we wish you the best. Change-Id: I3b92207debf12f8d7c89e0554ea865d9a14cd575 Commit: a57a4a46cbbd72478b894f517cdfb6b98dc36e09 https://github.com/tribe29/checkmk/commit/a57a4a46cbbd72478b894f517cdfb6b98… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: remove brace expansion that's not posix. Change-Id: I456ecccced22dd7c0e16c24abc9d123c2149a1a8 Commit: dad603e937f431e61ea1eafff0a405d749de2aa5 https://github.com/tribe29/checkmk/commit/dad603e937f431e61ea1eafff0a405d74… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: More " Change-Id: I9cb22dfa44f9c45ebc49877b2d4b3cc3cb820fc7 Commit: 8fb9a479a7411b1fa993de27d65adb6dad16d719 https://github.com/tribe29/checkmk/commit/8fb9a479a7411b1fa993de27d65adb6da… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: I don't like fi Change-Id: I33c42450db380e6e0dd2cfe553f3475becc74fa0 Commit: 788594c722619b6f88836e0c1ab8d6d9eb9b7972 https://github.com/tribe29/checkmk/commit/788594c722619b6f88836e0c1ab8d6d9e… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: We don't need DEVTYPE_CHECK Change-Id: Ib40bec5288907d4b088a1b4e743a72a7808ada72 Commit: 086b371c2fe073723de5dabe2f0e7e2988e5c1bd https://github.com/tribe29/checkmk/commit/086b371c2fe073723de5dabe2f0e7e298… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: remove case Seemed like Moritz wanted this. Change-Id: I897dee6f0740e99477b81f26e0a1696e20bedd00 Commit: 765827e0e305672c0395242c9258e3fd2720a6ac https://github.com/tribe29/checkmk/commit/765827e0e305672c0395242c9258e3fd2… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: add missing information Change-Id: If31201cebce234f966fad533c8fe3091a8296e60 Commit: ef1a01df6491e1328d2912317ee4daf7d82cfc0b https://github.com/tribe29/checkmk/commit/ef1a01df6491e1328d2912317ee4daf7d… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: execute with /bin/sh Previous commits have removed brace expansions, bash arrays and other elements, which don't comply to POSIX. At this point, the script can be called with bash --posix, dash and ash. Some non-compliant elements such as realpath remain. Change-Id: Ia72dfc318e5a84f52892e0f10e47937d878a3f90 Commit: 020c9607aae159adc16aa78312ca21486a17fb7a https://github.com/tribe29/checkmk/commit/020c9607aae159adc16aa78312ca21486… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/plugins/mk_inventory.linux Log Message: ----------- mk_inventory.linux: fixed swapped $ and { Change-Id: I892fc663db2dbe0ec71943bfe9f0976778f76cdc Compare: https://github.com/tribe29/checkmk/compare/217bdb25de99...020c9607aae1

2 years, 5 months

[tribe29/checkmk] b1cfbd: Fix some cyclic deps with hosts_and_folders

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b1cfbdce6ec0bdeed181d30a55c02be6e3b27d93 https://github.com/tribe29/checkmk/commit/b1cfbdce6ec0bdeed181d30a55c02be6e… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/gui/plugins/openapi/endpoints/host_config.py M cmk/gui/plugins/webapi/webapi.py M cmk/gui/wato/pages/folders.py M cmk/gui/wato/pages/hosts.py M cmk/gui/watolib/hosts_and_folders.py M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_activate_changes.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_host_config.py Log Message: ----------- Fix some cyclic deps with hosts_and_folders More precisely: hosts_and_folders -> check_mk_automations -> activate_changes -> hosts_and_folders CMK-10313 Change-Id: I57c2a174b87cbc56c3738bfcfd39fd9a8d2a8d9a

2 years, 5 months

[tribe29/checkmk] f5edba: Fix i18n

by Moritz

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: f5edba39f48e630a04e3b09d889cd16c6ab94e32 https://github.com/tribe29/checkmk/commit/f5edba39f48e630a04e3b09d889cd16c6… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/gui/views.py Log Message: ----------- Fix i18n Change-Id: I5ca11b30559323555415f587fe71505e0f6f1463

2 years, 5 months

[tribe29/checkmk] 9fe0d9: simplify systemd tests

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9fe0d9c7efbfb6e0d76f3801283312345d67ff89 https://github.com/tribe29/checkmk/commit/9fe0d9c7efbfb6e0d76f3801283312345… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M tests/unit/cmk/base/plugins/agent_based/test_systemd_units.py Log Message: ----------- simplify systemd tests Change-Id: Iab9354b8b2b6d192869ac3b47e1a44cbc76e9aae Commit: 6ebc78e2ef3637661ca7d134b0ee0024963ca4b3 https://github.com/tribe29/checkmk/commit/6ebc78e2ef3637661ca7d134b0ee00249… Author: Michael Prokop <michael.prokop(a)synpro.solutions> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/check_mk_agent.linux Log Message: ----------- check_mk_agent.linux / systemctl: properly handle units marked with bullet circles systemd uses the so called bullet circle (SPECIAL_GLYPH_BLACK_CIRCLE) to mark units in special states (not-found, inactive, dead,... but also failed). By default, and when running in a UTF-8 capable environment, systemd uses the "●" character for the bullet circle, only in ASCII fallback mode it uses "*" instead. When C.UTF-8 is available, check_mk_agent uses it as its LC_ALL setting though, returning something like: | % LC_ALL="C.utf8" systemctl --all --no-pager | sed '/^$/q' | tr -s ' ' | grep restic-backup | restic-backup-fileserver01-data-prune.service loaded inactive dead Restic backup prune of fileserver01-data | ● restic-backup-mail01-data-prune.service loaded failed failed Restic backup prune of mail01-data | restic-backup-fileserver01-data-prune.timer loaded active waiting Weekly restic backup prune of fileserver01-data | restic-backup-mail01-data-prune.timer loaded active waiting Weekly restic backup prune of mail01-data But such a failed unit isn't detected and handled by checkmk's systemd_units then (as observed with checkmk v2.0.0p22): | OK Systemd Service Summary Total: 102, Disabled: 9, Failed: 0 But when using an environment *without* UTF-8 support, systemd's systemctl would behave as expected by checkmk. Corresponding output: | % LC_ALL=C systemctl --all --no-pager | sed '/^$/q' | tr -s ' ' | grep restic-backup | restic-backup-fileserver01-data-prune.service loaded inactive dead Restic backup prune of fileserver01-data | * restic-backup-mail01-data-prune.service loaded failed failed Restic backup prune of mail01-data | restic-backup-fileserver01-data-prune.timer loaded active waiting Weekly restic backup prune of fileserver01-data | restic-backup-mail01-data-prune.timer loaded active waiting Weekly restic backup prune of mail01-data The proper solution though is to use the options `--no-legend --no-pager --plain` instead, quoting from systemd upstream commit 1cabd2d0c56b7: | systemctl: hide first column with --plain instead of --no-legend | | Hiding the first column, which may contain bullet circles, with --no-legend | is undocumented and potentially unexpected. On the other hand, not printing | bullet circles with --plain is documented so hiding the column with that | switch is sensible. | | The combination "--full --no-legend --no-pager --plain" is appropriate for | automated processing of systemctl output. And indeed, this behaves as expected then and also checkmk handles it properly then: | synpromika@backup ~ % LC_ALL="C.utf8" systemctl --all --no-legend --no-pager --plain | sed '/^$/q' | tr -s ' ' | grep restic-backup | restic-backup-fileserver01-data-prune.service loaded inactive dead Restic backup prune of fileserver01-data | restic-backup-mail01-data-prune.service loaded failed failed Restic backup prune of mail01-data | restic-backup-fileserver01-data-prune.timer loaded active waiting Weekly restic backup prune of fileserver01-data | restic-backup-mail01-data-prune.timer loaded active waiting Weekly restic backup prune of mail01-data And also checkmk handles it properly then: | CRIT Systemd Service Summary Total: 125, Disabled: 9, Failed: 1, 1 static service failed (restic-backup-mail01-data-prune) Verified systemctl behavior on systemd v232-25 (Debian/stretch), v241-7 (Debian/buster), v247.3 (Debian/bullseye) and v250.4 (Debian/unstable as of 2022-04-21). FTR: the --plain option isn't relevant for the new `systemctl status` handling that got introduced in commit e5d0b1c852. Quoting from systemctl(1) section about `status` unit command: | This function is intended to generate human-readable output. | If you are looking for computer-parsable output, use show instead. Closes: #457 Signed-off-by: Michael Prokop <tribe29(a)michael-prokop.at> Change-Id: I265ab6a906659c1fc8731f3b32a4b018436832a2 Commit: 2c1f6adc11b1dd8d525c1256964db4f1b24f374c https://github.com/tribe29/checkmk/commit/2c1f6adc11b1dd8d525c1256964db4f1b… Author: Max Linke <max.linke(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M agents/check_mk_agent.linux Log Message: ----------- update linux agent systemd section Change-Id: Iafb5cbe8b6e8f1a9a9717196d482c224dcab7a6d Commit: 539640e789851c9ef3652d1b1ed7024a2dea0e7b https://github.com/tribe29/checkmk/commit/539640e789851c9ef3652d1b1ed7024a2… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/gui/fields/definitions.py M cmk/gui/fields/utils.py M cmk/gui/plugins/openapi/endpoints/host_tag.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/plugins/webapi/utils.py M cmk/gui/wato/__init__.py M cmk/gui/wato/pages/bulk_edit.py M cmk/gui/wato/pages/folders.py M cmk/gui/wato/pages/hosts.py M cmk/gui/wato/pages/tags.py M cmk/gui/watolib/__init__.py M cmk/gui/watolib/host_attributes.py M tests/unit/cmk/gui/watolib/test_host_attributes.py Log Message: ----------- Remove transient and unused imports #13 - cmk.gui.watolib.host_attributes Including a trivial cycle where host_attributes module defines the host_attribute() function but uses it over an import. CMK-10313 Change-Id: I51f272a7986127208ee1cc41aff97ffac3434205 Compare: https://github.com/tribe29/checkmk/compare/3a22b04211f1...539640e78985

2 years, 5 months

[tribe29/checkmk] a37cce: KUBE api: addition of priority_class_name to pod spec

by anthonyh209

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a37cce661f8d5583b80ae31e5f3c5eb4423bb99f https://github.com/tribe29/checkmk/commit/a37cce661f8d5583b80ae31e5f3c5eb44… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/special_agents/utils_kubernetes/schemata/api.py M cmk/special_agents/utils_kubernetes/transform.py Log Message: ----------- KUBE api: addition of priority_class_name to pod spec Change-Id: I6b5d0c6033706fa7a97e3a951733553413d77eb4 Commit: fee0573d82b2cf3028b1a4d25cd9bc6c9835a43b https://github.com/tribe29/checkmk/commit/fee0573d82b2cf3028b1a4d25cd9bc6c9… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/special_agents/utils_kubernetes/schemata/api.py M cmk/special_agents/utils_kubernetes/transform.py Log Message: ----------- KUBE api: addition of active_deadline_seconds to pod spec Change-Id: Ibcb960ed758c7cc8259d12218cdedf3c5dee7c15 Commit: d4cfc51be09aaaf7094794829f1cdeb5d9f955eb https://github.com/tribe29/checkmk/commit/d4cfc51be09aaaf7094794829f1cdeb5d… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/special_agents/agent_kube.py Log Message: ----------- agent_kube: change PerformancePod from NamedTuple to BaseModel Change-Id: Ia8286e91a0c071dd0c5ed74d2e6f9b7401f3d7af Commit: 07dc3ff2048fbd3b5412c1881d5e7e5b5aa688ab https://github.com/tribe29/checkmk/commit/07dc3ff2048fbd3b5412c1881d5e7e5b5… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/special_agents/agent_kube.py M tests/unit/cmk/special_agents/agent_kube/factory.py M tests/unit/cmk/special_agents/agent_kube/test_agent_kube_performance.py Log Message: ----------- agent_kube: refactor write performance sections related functions Change-Id: I6f6e98ecc007e9149333cec95dc76e382f5ccc8b Commit: 90e9c55cf2f2ab9ce327bd601922a29c6fee95d1 https://github.com/tribe29/checkmk/commit/90e9c55cf2f2ab9ce327bd601922a29c6… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/special_agents/agent_kube.py Log Message: ----------- agent_kube: modify _write_sections to only output sections if content is not None Change-Id: Icd475af96081742eb0eab579c0940e8b30d60bbf Commit: ea8369cb3d739519b56562eb77c38c11e6a91acf https://github.com/tribe29/checkmk/commit/ea8369cb3d739519b56562eb77c38c11e… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M cmk/special_agents/agent_kube.py M cmk/special_agents/utils_kubernetes/api_server.py M cmk/special_agents/utils_kubernetes/schemata/api.py M cmk/special_agents/utils_kubernetes/transform.py Log Message: ----------- agent_kube: addition of resource quotas related sections Change-Id: I05f211cb39ea152e96b9029628de26b4d042d17e Commit: 3a22b04211f1440277873015b09063b8537eaa17 https://github.com/tribe29/checkmk/commit/3a22b04211f1440277873015b09063b85… Author: Wontek Hong <wontek.hong(a)tribe29.com> Date: 2022-04-29 (Fri, 29 Apr 2022) Changed paths: M tests/unit/cmk/special_agents/agent_kube/factory.py A tests/unit/cmk/special_agents/agent_kube/test_namespace.py Log Message: ----------- test_namespace: addition of tests for resource_quota related functions Change-Id: I8037071f970e31d25248687d3a2f7d56c39fe337 Compare: https://github.com/tribe29/checkmk/compare/4edc158b5e14...3a22b04211f1

2 years, 5 months

[tribe29/checkmk] b2d2a9: KUBE: fix false naming due copy-pasta in kube_name...

by SoloJacobs

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b2d2a9ff0ef5292e4a33c0e069e72f33a11de263 https://github.com/tribe29/checkmk/commit/b2d2a9ff0ef5292e4a33c0e069e72f33a… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-28 (Thu, 28 Apr 2022) Changed paths: M cmk/base/plugins/agent_based/kube_namespace_info.py M tests/unit/cmk/base/plugins/agent_based/test_kube_namespace_info.py Log Message: ----------- KUBE: fix false naming due copy-pasta in kube_namespace_info Change-Id: I07569d66299040862bfc31f3b6ca2496670ea333 Commit: f9936df383d35ec657288dc7d5b4bd088b854800 https://github.com/tribe29/checkmk/commit/f9936df383d35ec657288dc7d5b4bd088… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-28 (Thu, 28 Apr 2022) Changed paths: M cmk/base/plugins/agent_based/utils/kube.py M cmk/special_agents/utils_kubernetes/schemata/api.py Log Message: ----------- transform: fix incorrect schemata docstrings for Labels Fix consists of two parts: - validation_value was incorrect, because it excluded empty values. - Changes in cmk/special_agents/utils_kubernetes/schemata/api.py should match those in cmk/base/agent_based/plugins/utils/kube.py They now match. CMK-9882 Change-Id: Ie965f0d6ea776fc2553eff6343c10800cc351a40 Commit: 1a5fd6ce245a670a0edc6cbef101b933ec11c4f8 https://github.com/tribe29/checkmk/commit/1a5fd6ce245a670a0edc6cbef101b933e… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-28 (Thu, 28 Apr 2022) Changed paths: M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube_deployments.py A tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube_namespace.py M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kubernetes_api_nodes.py M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kubernetes_api_pods.py Log Message: ----------- KUBE: add test parse_metadata parse_metadata is now tested for Deployments and Pods. CMK-9882 Change-Id: I01aacf6485682422b7708a07595142f028899c5d Commit: b90c5d7832d6aab142e6894efd959ee8dc6aa385 https://github.com/tribe29/checkmk/commit/b90c5d7832d6aab142e6894efd959ee8d… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-28 (Thu, 28 Apr 2022) Changed paths: M tests/unit/cmk/special_agents/agent_kube/conftest.py M tests/unit/cmk/special_agents/agent_kube/factory.py M tests/unit/cmk/special_agents/agent_kube/test_node.py Log Message: ----------- KUBE: move api_to_agent_pod out of conftest.py Change-Id: I07c29364ccec12a7aa5f5961a9988e1c57845224 Commit: 77f57087e95c746ea768666358f72d4255d936e2 https://github.com/tribe29/checkmk/commit/77f57087e95c746ea768666358f72d425… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-28 (Thu, 28 Apr 2022) Changed paths: M tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube.py Log Message: ----------- KUBE: use Pydantic factories instead of default_pod Using factories improves maintainability. This is because new fields no longer affect the test (they are automatically populated). We also introduce the AAA pattern. Change-Id: I05a93978bfc039c52a1f023ce2219a96a29f6bb7 Commit: 4edc158b5e14612a57aedec3aa3a8400d188987d https://github.com/tribe29/checkmk/commit/4edc158b5e14612a57aedec3aa3a8400d… Author: Solomon Jacobs <solomon.jacobs(a)tribe29.com> Date: 2022-04-28 (Thu, 28 Apr 2022) Changed paths: M tests/unit/cmk/special_agents/agent_kube/test_agent_kube_api.py R tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube.py A tests/unit/cmk/special_agents/agent_kubernetes/test_agent_kube_filter_from_namespace.py Log Message: ----------- KUBE: refactor _collect_cpu_resources test We use Pydantic factories instead of a handrolled function. Moreover, we now test in a more uniform fashion and test _collect_memory_resources alongside. Moreover, the test is moved to the same locations as test_collect_workload_resources_from_api_pods and renamed accordingly. Finally, the original test file is renamed to reflect the tests is now contains. CMK-9525 Change-Id: If1c0d2527b5532ba072226044f3a50eb83395dc6 Compare: https://github.com/tribe29/checkmk/compare/b201b3282100...4edc158b5e14

2 years, 5 months

[tribe29/checkmk] 217bdb: Revert "13940 Long text in the inventory dashlet w...

by martinhv

Branch: refs/heads/2.1.0 Home: https://github.com/tribe29/checkmk Commit: 217bdb25de9963e8f505f038e85a9b920a558564 https://github.com/tribe29/checkmk/commit/217bdb25de9963e8f505f038e85a9b920… Author: Martin Hirschvogel <martin.hirschvogel(a)tribe29.com> Date: 2022-04-28 (Thu, 28 Apr 2022) Changed paths: R .werks/13940 M web/htdocs/js/index.ts M web/htdocs/js/modules/figures/cmk_figures.js M web/htdocs/themes/facelift/scss/_dashboard.scss Log Message: ----------- Revert "13940 Long text in the inventory dashlet will now break into multiple lines" This reverts commit 46782e59357110e1b11abb541c01ea6578f76bbe. Reason for revert: This breaks the gauge dashlet. Change-Id: Ifb199fc1f1ddbbb9f533e054db03d6b8a4f85d53

2 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits April 2022