Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: f3a89aa2aefddc1c16128ca5b9359ff39e2ffc3d
https://github.com/tribe29/checkmk/commit/f3a89aa2aefddc1c16128ca5b9359ff39…
Author: Konstantin Baikov <konstantin.baikov(a)tribe29.com>
Date: 2021-06-28 (Mon, 28 Jun 2021)
Changed paths:
M CONTRIBUTING.md
Log Message:
-----------
Use print as a function and correct some typos
The example uses a context manager now and print as in python3
Also environment error was merged to OSError since 3.3
Change-Id: I9ef68c5966cce5c5e761d18d2fec21ae90510385
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: d410efcd97c2238dca74f0e8cc12b3aba5edea19
https://github.com/tribe29/checkmk/commit/d410efcd97c2238dca74f0e8cc12b3aba…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-06-28 (Mon, 28 Jun 2021)
Changed paths:
M cmk/gui/pagetypes.py
Log Message:
-----------
Fix clone in overridable pagetypes, ownership transfer
As example in a custom graph. If a user were to clone a custom graph
from another user, the clone would remain in ownership of the other user
instead of the current active user, because no ownership transfer took
place.
Refactoring for code shrinking on.
Change-Id: Ife00b28419822cb7ec6d4fa12249fd7f2647f803
Branch: refs/heads/2.0.0
Home: https://github.com/tribe29/checkmk
Commit: a8c4034c82f5f0ac7642c5fc483c6b2383840dab
https://github.com/tribe29/checkmk/commit/a8c4034c82f5f0ac7642c5fc483c6b238…
Author: Óscar Nájera <oscar.najera(a)tribe29.com>
Date: 2021-06-28 (Mon, 28 Jun 2021)
Changed paths:
M cmk/gui/pagetypes.py
Log Message:
-----------
Fix clone in overridable pagetypes, ownership transfer
As example in a custom graph. If a user were to clone a custom graph
from another user, the clone would remain in ownership of the other user
instead of the current active user, because no ownership transfer took
place.
Refactoring for code shrinking on.
Change-Id: Ife00b28419822cb7ec6d4fa12249fd7f2647f803
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 4425ffa38ce05609a5832321c8abd1720c97e2a4
https://github.com/tribe29/checkmk/commit/4425ffa38ce05609a5832321c8abd1720…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2021-06-28 (Mon, 28 Jun 2021)
Changed paths:
M tests/unit/cmk/base/plugins/agent_based/utils/test_temperature.py
Log Message:
-----------
Remove default arguments from tests in temperature.py
It makes them more robust against changes in the signature.
Change-Id: I442eed744edb2a2092520dfceaff3b2283c308b9
Commit: 8b06e17a8dbc02a29275a50218e4ac1bfceebc58
https://github.com/tribe29/checkmk/commit/8b06e17a8dbc02a29275a50218e4ac1bf…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2021-06-28 (Mon, 28 Jun 2021)
Changed paths:
M cmk/base/plugins/agent_based/brocade_optical.py
M cmk/base/plugins/agent_based/entity_sensors.py
M cmk/base/plugins/agent_based/utils/temperature.py
M tests/unit/cmk/base/plugins/agent_based/test_brocade_optical.py
M tests/unit/cmk/base/plugins/agent_based/utils/test_temperature.py
Log Message:
-----------
check_temperature: unique_name and value_store are now mandatory
The arguments unique_name and value_store are used to determine the
place where trend data is stored if the user has enabled trend
computation.
Because the arguments were optional before, it was easy to forget one
or both of the arguments when a trend computation was configurable
(e.g. if a plugin uses the ruleset "temperature"). In this case the
plugins seems to work, but crashes as soon as the user activates the
trend computation. This was e.g. the case for the migrated plugin
entity_sensors.
brocade_optical on the other hand did not crash since its ruleset does
not contain a trend option. Nonetheless it specified a unique_name
which was not strictly necessary.
Now unique_name and value_store are both required. This minimizes the
risk to misuse the check_temperature function. Although plugins like
brocade_optical do not need the trend computation right now it will be
easier to add this option later on since check_temperature will
correcly handle this case as soon as the ruleset is extended.
Change-Id: I5e8e92b355c14ac10c2cc5d41993a668136141bd
Commit: 83b9b0e7ab20134f7b421e9b6a7c2aa2008677a9
https://github.com/tribe29/checkmk/commit/83b9b0e7ab20134f7b421e9b6a7c2aa20…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2021-06-28 (Mon, 28 Jun 2021)
Changed paths:
M tests/unit/cmk/base/plugins/agent_based/utils/test_temperature.py
Log Message:
-----------
check_temperature: improve test cases
Now all results are checked and a complete diff is shown on errors.
Change-Id: I35f34d6f1e4f1f5019159b0141f5b90c419030bc
Commit: d0e6e399ada8c912431e4df84e605d86112d051f
https://github.com/tribe29/checkmk/commit/d0e6e399ada8c912431e4df84e605d861…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2021-06-28 (Mon, 28 Jun 2021)
Changed paths:
M checks/cmciii
A cmk/base/plugins/agent_based/cmciii_temp_in_out.py
M tests/unit/checks/test_generic_legacy_conversion.py
M tests/unit/cmk/base/plugins/agent_based/test_cmciii.py
Log Message:
-----------
cmciii_temp_in_out: migrate to new API
Change-Id: Ic3cc3854b3fdf9fa836ff4c98c386c23de13612a
Commit: c835ee17b9bb15c4a84da071ae8e895c9e2e056c
https://github.com/tribe29/checkmk/commit/c835ee17b9bb15c4a84da071ae8e895c9…
Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com>
Date: 2021-06-28 (Mon, 28 Jun 2021)
Changed paths:
M checks/cmciii
A cmk/base/plugins/agent_based/cmciii_temp.py
M tests/unit/checks/test_generic_legacy_conversion.py
M tests/unit/cmk/base/plugins/agent_based/test_cmciii.py
Log Message:
-----------
cmciii_temp: migrate to new API
Change-Id: Ia8b73a62c6908ddf9930d997875a30ad061f1802
Compare: https://github.com/tribe29/checkmk/compare/174337f9726d...c835ee17b9bb