Checkmk git commits June 2021

checkmk-commits@lists.checkmk.com

1 participants
376 discussions

[tribe29/checkmk] 08a8b6: 2.0.0: Use correct image for "NEB/CMC Unit Tests" ...

by Lars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 08a8b697248115e034ae9df5211d7dc5526a844e https://github.com/tribe29/checkmk/commit/08a8b697248115e034ae9df5211d7dc55… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M livestatus/src/test/.f12 Log Message: ----------- 2.0.0: Use correct image for "NEB/CMC Unit Tests" jobs Change-Id: Iec3599d81fffd310df9075152931362b059c5cc6

3 years, 5 months

[tribe29/checkmk] 7294a7: Revert "12941 FIX hitachi_hnas_drives: crash on un...

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7294a74efa773ea02f192a47cc16cdfaa3b1f3d5 https://github.com/tribe29/checkmk/commit/7294a74efa773ea02f192a47cc16cdfaa… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: R .werks/12941 M checks/hitachi_hnas_drives Log Message: ----------- Revert "12941 FIX hitachi_hnas_drives: crash on unhandled exception: TypeError: unhashable type: 'list'" This reverts commit 56c43eda6451dede32c024eb59547454a3d1ae3e. Reason for revert: need to fix the werk versions Change-Id: Iafd63029a5e9c6de57cce2d5500f5497ea89ee04

3 years, 5 months

[tribe29/checkmk] 6e5273: 12791 Add support for Cisco WLC 9800

by Benedikt Seidl

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6e5273b491bcbece93acec0e746e9a6a6f751894 https://github.com/tribe29/checkmk/commit/6e5273b491bcbece93acec0e746e9a6a6… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: A .werks/12791 M cmk/base/plugins/agent_based/cisco_wlc.py M cmk/base/plugins/agent_based/cisco_wlc_clients.py M tests/unit/cmk/base/plugins/agent_based/test_cisco_wlc_clients.py Log Message: ----------- 12791 Add support for Cisco WLC 9800 Checkmk will now additionally discover the following services on Cisco WLC 9800 devices: * AP [access point name] (check plugin cisco_wlc): Display whether the access point is online or offline * Clients [SSID name|Summary] (check plugin wlc_clients): Displays the number of connected devices on this SSID. Summary displays the total number of connected devices. Change-Id: I319f1367624edc15b26fe74b2d6190efb54dd2ca

3 years, 5 months

[tribe29/checkmk] ced051: 12976 FIX Fix error using link of inherited attrib...

by rb

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ced0510166daa93f498ccdfec7f65ac651d27dc9 https://github.com/tribe29/checkmk/commit/ced0510166daa93f498ccdfec7f65ac65… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: A .werks/12976 M cmk/gui/plugins/wato/utils/__init__.py Log Message: ----------- 12976 FIX Fix error using link of inherited attributes SUP-6474 Change-Id: Id545892d332ef1c12a3324fc162c265bc7721fad

3 years, 5 months

[tribe29/checkmk] 064edd: 12991 FIX Previsualization of views/dashboard/repo...

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 064edd6d01071a23dde21279318f2beedfde69f2 https://github.com/tribe29/checkmk/commit/064edd6d01071a23dde21279318f2beed… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M .werks/12871 A .werks/12991 M cmk/gui/dashboard.py M cmk/gui/plugins/dashboard/utils.py M cmk/gui/views.py M cmk/gui/visuals.py Log Message: ----------- 12991 FIX Previsualization of views/dashboard/reports by admins Between werks 12871 and 12487 there was a feature competition. Users with permission "Edit foreign (views/dashboards/reports)" (mostly admins) must be able to edit and thus preview all those pages. However under normal use of checkmk, the working user(also admin) wants to use/work with the page of highest priority, which must be restricted to only pages that the user owns or are published for all users. Werk 12487 allowed admins to preview everything, but under normal operation, views from other users would become their active working view. Werk 12871 fixed that bringing the priority back, yet breaking the posibility to preview everything from the editor. This werk brings both behaviors to work together. Key distinction is that visuals.available determines visuals that are offered to the users(own, published, builtins). Admins with edit_foreign permission get an extra preview (_linkable) option from the edit page. Tested behavior in Views & dashboards and is ok. Reports as well but there are still problems with the inheritance. There is yet no consideration in cmk.gui.visuals.available to use a user different than the active one. Under the assumption that users don't overuse customization in chains of inherited reports this fix works well enough. Dashboards are consistent. From edit list, there is preview option, and for foreign reports cloning is allowed. When viewing, the option of "customize builtin dashboard" is only for builtin. For other user manual cloning must take place no automatic cloning. SUP-6459 Change-Id: I6a30593941db69b4f532ff3d21ed7cd182dfe3e8

3 years, 5 months

[tribe29/checkmk] 1c6185: Icons: Start adding type hints

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 1c61850add5891fb5e72c5f2cf8816db359b317a https://github.com/tribe29/checkmk/commit/1c61850add5891fb5e72c5f2cf8816db3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M cmk/gui/plugins/views/icons/__init__.py M cmk/gui/plugins/views/painters.py M cmk/gui/views.py M tests/unit/cmk/gui/plugins/views/test_icons.py Log Message: ----------- Icons: Start adding type hints Change-Id: Ifc316bddbb27128c0d33d775942e9ee59ddb0eca Commit: 7740e3372a21741b4f0bfc562324354e58bd6a72 https://github.com/tribe29/checkmk/commit/7740e3372a21741b4f0bfc562324354e5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M cmk/gui/plugins/views/icons/__init__.py M cmk/gui/plugins/views/icons/utils.py M cmk/gui/plugins/views/painters.py M cmk/gui/views.py Log Message: ----------- Refactor icons to dataclasses internally Next steps would be to: a) Cleanup the return types of all icon plugins to e.g. Optional[IconEntry] b) Drop the old plugin compatibility Change-Id: Ic23b448eb235f1212b161ba73dab83cd02d0ac6b Compare: https://github.com/tribe29/checkmk/compare/3e749e04e4dc...7740e3372a21

3 years, 5 months

[tribe29/checkmk] 3e749e: cmciii: migrate to new API

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 3e749e04e4dc7a63834275b0712c532a17eff5e8 https://github.com/tribe29/checkmk/commit/3e749e04e4dc7a63834275b0712c532a1… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: R checks/cmciii M cmk/base/plugins/agent_based/cmciii.py M tests/unit/checks/test_generic_legacy_conversion.py M tests/unit/cmk/base/plugins/agent_based/test_cmciii.py Log Message: ----------- cmciii: migrate to new API Change-Id: Ia75f1d5059055943f96c1163de0fb3918957be4a

3 years, 5 months

[tribe29/checkmk] 2f0b20: Publicize ConfigPath.from_deprecated()

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2f0b206d3eb73a3b01297346f7010205681cdb3b https://github.com/tribe29/checkmk/commit/2f0b206d3eb73a3b01297346f70102056… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M cmk/core_helpers/paths.py M tests/unit/cmk/core_helpers/test_config_paths.py Log Message: ----------- Publicize ConfigPath.from_deprecated() Now, we can transition from the typed to the untyped API with `ConfigPath.__str__()` and from the untyped to the typed API with `ConfigPath.from_deprecated()`. This makes the deprecation of the untyped API easier in that we can now modify manageable pieces of code. Change-Id: Icb30032aae4cafc35db12b2fbff33762a48d953d Commit: 3498c2071fcaf7a81333f284001388db92b0fe0f https://github.com/tribe29/checkmk/commit/3498c2071fcaf7a81333f284001388db9… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M cmk/base/core_config.py M cmk/base/core_nagios.py Log Message: ----------- Port MonitoringCore class to ConfigPath-API Change-Id: Ib9ee950049328e0789e3dd6048bb9a68777ecf52 Commit: f4122a03fe0e79bdc311fdf7689a35358c83022d https://github.com/tribe29/checkmk/commit/f4122a03fe0e79bdc311fdf7689a35358… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M cmk/core_helpers/controller.py M cmk/core_helpers/crash_reporting.py M tests/unit/cmk/core_helpers/test_controller.py Log Message: ----------- Port controller to ConfigPath API Change-Id: I6392eae6891954ed0c5d9536d7c84b88a15716aa Commit: f33740c43a0d05d4d6904cba77dfa706259ebfbb https://github.com/tribe29/checkmk/commit/f33740c43a0d05d4d6904cba77dfa7062… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M cmk/base/config.py M cmk/base/core_nagios.py M tests/unit/cmk/base/test_config.py M tests/unit/cmk/base/test_core_config.py M tests/unit/cmk/base/test_core_nagios.py Log Message: ----------- Port core_nagios to ConfigPath Change-Id: I5c850c0f568e09bdc94d3392136d137b5269d262 Compare: https://github.com/tribe29/checkmk/compare/d96a98c2da96...f33740c43a0d

3 years, 5 months

[tribe29/checkmk] bbc108: 12991 FIX Previsualization of views/dashboard/repo...

by Óscar Nájera

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: bbc10867444748c7dcc2cfa694a9cebbe01799c4 https://github.com/tribe29/checkmk/commit/bbc10867444748c7dcc2cfa694a9cebbe… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M .werks/12871 A .werks/12991 M cmk/gui/dashboard.py M cmk/gui/plugins/dashboard/utils.py M cmk/gui/views.py M cmk/gui/visuals.py Log Message: ----------- 12991 FIX Previsualization of views/dashboard/reports by admins Between werks 12871 and 12487 there was a feature competition. Users with permission "Edit foreign (views/dashboards/reports)" (mostly admins) must be able to edit and thus preview all those pages. However under normal use of checkmk, the working user(also admin) wants to use/work with the page of highest priority, which must be restricted to only pages that the user owns or are published for all users. Werk 12487 allowed admins to preview everything, but under normal operation, views from other users would become their active working view. Werk 12871 fixed that bringing the priority back, yet breaking the posibility to preview everything from the editor. This werk brings both behaviors to work together. Key distinction is that visuals.available determines visuals that are offered to the users(own, published, builtins). Admins with edit_foreign permission get an extra preview (_linkable) option from the edit page. Tested behavior in Views & dashboards and is ok. Reports as well but there are still problems with the inheritance. There is yet no consideration in cmk.gui.visuals.available to use a user different than the active one. Under the assumption that users don't overuse customization in chains of inherited reports this fix works well enough. Dashboards are consistent. From edit list, there is preview option, and for foreign reports cloning is allowed. When viewing, the option of "customize builtin dashboard" is only for builtin. For other user manual cloning must take place no automatic cloning. SUP-6459 Change-Id: I6a30593941db69b4f532ff3d21ed7cd182dfe3e8

3 years, 5 months

[tribe29/checkmk] f4f88b: Remove intermediate class 'Node'; move Attributes/...

by Simon

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: f4f88b897a4cfb79d6c5a84a675c23fd174a037a https://github.com/tribe29/checkmk/commit/f4f88b897a4cfb79d6c5a84a675c23fd1… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M cmk/gui/plugins/views/inventory.py M cmk/gui/views.py M cmk/utils/structured_data.py M tests/unit/cmk/utils/structured_data/test_structured_data.py Log Message: ----------- Remove intermediate class 'Node'; move Attributes/Table to Container Change-Id: Iefe6abe1e651c4c4811172fdb01bf559c61bb193 Commit: d96a98c2da96e1c95fd40993953fb78c5b082956 https://github.com/tribe29/checkmk/commit/d96a98c2da96e1c95fd40993953fb78c5… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2021-06-30 (Wed, 30 Jun 2021) Changed paths: M cmk/utils/structured_data.py Log Message: ----------- Make signatures less error-prone Change-Id: I8cfe7a2edd7d46e1c9563555b4e5fbc3f71395c9 Compare: https://github.com/tribe29/checkmk/compare/db1ca5c1cc35...d96a98c2da96

3 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits June 2021