Checkmk git commits June 2021

checkmk-commits@lists.checkmk.com

1 participants
376 discussions

[tribe29/checkmk] 56be95: Temporarily statehist cache in integration tests

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 56be95a80f3b4f5568673a6fcda7295fe82422a7 https://github.com/tribe29/checkmk/commit/56be95a80f3b4f5568673a6fcda7295fe… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-17 (Thu, 17 Jun 2021) Changed paths: M tests/testlib/site.py Log Message: ----------- Temporarily statehist cache in integration tests We are trying to track down a random startup issue of the Microcore. With this change we want to learn whether or not the issue is located in the optimizied statehist implementation. Change-Id: I7eac9aa2843a5fc0c64aae81aff324f54a2d2c63

3 years, 2 months

[tribe29/checkmk] 283a53: Same logic in __iter__ and __next__

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 283a53e9841e58cf333311029164fbfa5a68cdd2 https://github.com/tribe29/checkmk/commit/283a53e9841e58cf333311029164fbfa5… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-06-17 (Thu, 17 Jun 2021) Changed paths: M cmk/core_helpers/paths.py Log Message: ----------- Same logic in __iter__ and __next__ Change-Id: I96b6b45bb8c03ebf5a9ed0ac4903eebf7b3f10c7

3 years, 2 months

[tribe29/checkmk] 6aae0e: Make classes for the serial

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6aae0e2a012dbe2ec6fe3cc91cd8e9e5a9eb21cd https://github.com/tribe29/checkmk/commit/6aae0e2a012dbe2ec6fe3cc91cd8e9e5a… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-06-17 (Thu, 17 Jun 2021) Changed paths: M cmk/base/core_config.py M cmk/core_helpers/controller.py M cmk/core_helpers/paths.py M tests/unit/cmk/base/test_core_config.py M tests/unit/cmk/core_helpers/test_config_paths.py M tests/unit/cmk/core_helpers/test_controller.py Log Message: ----------- Make classes for the serial This clarifies the typing and the fact that the "serial" is but an implementation detail of the paths. Before, we had serials with values such as '0', '1', '2', ... that should obviously have been integers from the beginning. Also note that the value is increased when the configuration changes and the actual representation of the serial (the numbers here) is never relevant to user code. Moreover, `OptionalConfigSerial`, `ConfigSerial`, and `LATEST_SERIAL` are actually `str` so that the code was not really typed. And finally, the very fact that `OptionalConfigSerial` is not `Optional[ConfigSerial]` is simply uncivil. We replace the `str` types with three classes: A `VersionedConfigPath` with an integer (an actual integer, mind you) serial, a `LatestConfigPath` representing a constant path to the version, and `ConfigPath` that may be either one. In this step, we only remove the next_... and current_... methods that were used only once and add a compatibility layer. Change-Id: I23b666c1feb347c7839cb1f9f1add37dc4342ca2

3 years, 2 months

[tribe29/checkmk] 6c6578: Add some more metric related type hints

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6c6578af8a33f08f4b073850faa6e95a34419491 https://github.com/tribe29/checkmk/commit/6c6578af8a33f08f4b073850faa6e95a3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-16 (Wed, 16 Jun 2021) Changed paths: M cmk/gui/plugins/metrics/utils.py M cmk/gui/plugins/views/__init__.py M cmk/gui/type_defs.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py Log Message: ----------- Add some more metric related type hints Change-Id: Id18f9f7b7c3168d3e623043e1092a51717b7b3a7 Commit: 577cbceefbf163b64f7548dceecbd2ef0d566651 https://github.com/tribe29/checkmk/commit/577cbceefbf163b64f7548dceecbd2ef0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-16 (Wed, 16 Jun 2021) Changed paths: M cmk/gui/plugins/views/perfometer.py M cmk/gui/plugins/views/perfometers/__init__.py M cmk/gui/plugins/views/perfometers/active_checks.py M cmk/gui/plugins/views/perfometers/check_mk.py M tests/unit/cmk/gui/plugins/views/perfometers/test_perfometer_fileinfo.py Log Message: ----------- Add type hints to legacy perfometers This change uncovers a number of bugs from the type checking point of view which are also fixed along the way. Some of them seem like real bugs, but some of them may not appear in reality because the data produced by the related checks prevents that. However, it's a good idea to clarify all this. Detail: Exceptions in perfometers are normally silently suppressed. It is likely that these errors were not uncovered before for this reason. Change-Id: I4a5128465748280b328cb4e48bd1f223d1271a1f Commit: 2e2b7b21c8d0526c9d18cec4466e3541438d6ef4 https://github.com/tribe29/checkmk/commit/2e2b7b21c8d0526c9d18cec4466e35414… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-16 (Wed, 16 Jun 2021) Changed paths: M cmk/gui/plugins/views/perfometers/__init__.py Log Message: ----------- Add some more type hints to perfometers Change-Id: Ia6a0b8e2943c3223d65c136f5784c5069307a866 Commit: 0545924fcfe048138f4665cd8f33ec0e40793b36 https://github.com/tribe29/checkmk/commit/0545924fcfe048138f4665cd8f33ec0e4… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-16 (Wed, 16 Jun 2021) Changed paths: M cmk/gui/metrics.py M cmk/gui/plugins/metrics/utils.py M cmk/gui/plugins/views/__init__.py M cmk/gui/plugins/views/perfometer.py M cmk/gui/type_defs.py Log Message: ----------- Add even more type hints to perfometer code Also rename Perfometer specification from Perfometer to PerfometerSpec to prevent name clashes with the Perfometer painter class. Change-Id: I9ca1035cb0611ccad3bede137609921db93bb337 Compare: https://github.com/tribe29/checkmk/compare/4ca3ef1e5f17...0545924fcfe0

3 years, 2 months

[tribe29/checkmk] 4ca3ef: 12494 FIX Multiline interface descriptions now sup...

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4ca3ef1e5f175502b41fd3e99b0bbc810e5a8153 https://github.com/tribe29/checkmk/commit/4ca3ef1e5f175502b41fd3e99b0bbc810… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-06-16 (Wed, 16 Jun 2021) Changed paths: A .werks/12494 M cmk/base/plugins/agent_based/utils/if64.py M cmk/base/plugins/agent_based/utils/interfaces.py Log Message: ----------- 12494 FIX Multiline interface descriptions now supported Network interfaces that provide multiline descriptions would crash their corresponding service. In case that the rule "Network interface and switch port discovery" was configured to "use description" for the "appearance of network interface", all interfaces of the device stalled and remained on the PENDING state. This is now fixed. Change-Id: If0ffc804574a03c340fd23cfc46b008ba44c66ba

3 years, 2 months

[tribe29/checkmk] 4720f5: [Weblate] Updated translation files

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4720f575e661fc016ce00aab84dab422bae3d26e https://github.com/tribe29/checkmk/commit/4720f575e661fc016ce00aab84dab422b… Author: Weblate Transfer job <weblate(a)checkmk.com> Date: 2021-06-16 (Wed, 16 Jun 2021) Changed paths: M locale/de/LC_MESSAGES/multisite.po M locale/es/LC_MESSAGES/multisite.po M locale/it/LC_MESSAGES/multisite.po M locale/nl/LC_MESSAGES/multisite.po Log Message: ----------- [Weblate] Updated translation files Translation: checkmk/software Translate-URL: https://translate.checkmk.com/projects/checkmk/software/

3 years, 2 months

[tribe29/checkmk] f642c0: 12494 FIX Multiline interface descriptions now sup...

by Óscar Nájera

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: f642c0791f30975619931a77ee644dae242b70ca https://github.com/tribe29/checkmk/commit/f642c0791f30975619931a77ee644dae2… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-06-16 (Wed, 16 Jun 2021) Changed paths: A .werks/12494 M cmk/base/plugins/agent_based/utils/if64.py M cmk/base/plugins/agent_based/utils/interfaces.py Log Message: ----------- 12494 FIX Multiline interface descriptions now supported Network interfaces that provide multiline descriptions would crash their corresponding service. In case that the rule "Network interface and switch port discovery" was configured to "use description" for the "appearance of network interface", all interfaces of the device stalled and remained on the PENDING state. This is now fixed. Change-Id: If0ffc804574a03c340fd23cfc46b008ba44c66ba

3 years, 2 months

[tribe29/checkmk] 8c78a5: 12495 FIX Fix Graphs when active check ICMP inspec...

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8c78a519ed1225c04137e23afee26c9c6cac6225 https://github.com/tribe29/checkmk/commit/8c78a519ed1225c04137e23afee26c9c6… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-06-16 (Wed, 16 Jun 2021) Changed paths: A .werks/12495 M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py Log Message: ----------- 12495 FIX Fix Graphs when active check ICMP inspects a host with multiple addresses Graphs showed an exception. Now the behavior of version 1.6 is restored where each metric is plotted in a single graph. Metrics are not aggregated by IP address. SUP-6770 Change-Id: Ic29aa1f0504f6b6396876b45aa37d5d36b6ee279

3 years, 2 months

[tribe29/checkmk] 024f8c: 12495 FIX Fix Graphs when active check ICMP inspec...

by Óscar Nájera

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 024f8c7a08a01496993597cd40dae6af4cbdd1d2 https://github.com/tribe29/checkmk/commit/024f8c7a08a01496993597cd40dae6af4… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-06-16 (Wed, 16 Jun 2021) Changed paths: A .werks/12495 M cmk/gui/plugins/metrics/utils.py M tests/unit/cmk/gui/plugins/metrics/test_metrics_utils.py Log Message: ----------- 12495 FIX Fix Graphs when active check ICMP inspects a host with multiple addresses Graphs showed an exception. Now the behavior of version 1.6 is restored where each metric is plotted in a single graph. Metrics are not aggregated by IP address. SUP-6770 Change-Id: Ic29aa1f0504f6b6396876b45aa37d5d36b6ee279

3 years, 2 months

[tribe29/checkmk] 49212e: 12492 Fix add metric from service view to custom a...

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 49212eee09e2782284233803e949b83cc71f487c https://github.com/tribe29/checkmk/commit/49212eee09e2782284233803e949b83cc… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-06-16 (Wed, 16 Jun 2021) Changed paths: A .werks/12492 Log Message: ----------- 12492 Fix add metric from service view to custom and forecast graphs Problem arose because the add page popup had not updated its variable names to match the new Valuespec that controls metric specifications. Fix is to establish a relation between the used valuespec and the add popup, so that if ever in the future that changes, the link is noticeable. We have abused the inheritance of the autocompleters, their value is a string. Yet for the metric autocompleters, because we use also the information of the host and service hints, and even the type of metric. Value is a tuple. Mypy complains that overriding methods in such way is wrong(I agree), but until we get a better solution, the value arguments and method return types remain untyped. Fortunately/disapointingly mypy is not capable to infer the types in that case and does not complain about this malpractice. SUP-6705 Change-Id: Ic397bf0c925df3adc21aa2a675071233839b5437

3 years, 2 months

← Newer
1
...
19
20
21
22
23
24
25
...
38
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits June 2021