Checkmk git commits June 2021

checkmk-commits@lists.checkmk.com

1 participants
376 discussions

[tribe29/checkmk] 1dc2b7: 12945 REST API: option to show folders recursively...

by Christoph Rauch

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 1dc2b76957c9fda044c37ca373ffaeb484a8a11a https://github.com/tribe29/checkmk/commit/1dc2b76957c9fda044c37ca373ffaeb48… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: A .werks/12945 M cmk/gui/fields/definitions.py M cmk/gui/plugins/openapi/endpoints/folder_config.py M cmk/gui/plugins/openapi/restful_objects/response_schemas.py M cmk/gui/watolib/hosts_and_folders.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_folder_config.py Log Message: ----------- 12945 REST API: option to show folders recursively and return type The folder list endpoint now supports a "recursive" option, which will result in the folder and all its subfolders to be in the resulting collection. Additionally, the endpoint will now always return the folder object and never only the link. This makes it easier for script writers to parse the result. Change-Id: I655de590d7d06835e37a32b80282a99b14ce3530

3 years

[tribe29/checkmk] 1dbd48: HTML: Add strict escaping when joining with str now

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 1dbd481533274a566cbd4fb77e99ed5bc66af3aa https://github.com/tribe29/checkmk/commit/1dbd481533274a566cbd4fb77e99ed5bc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/gui/plugins/views/icons/__init__.py M cmk/gui/utils/html.py Log Message: ----------- HTML: Add strict escaping when joining with str now Operations like HTML("a") + "b" are still allowed to keep call sites clean, but the given str objects will now be HTML escaped. In case you experience issues with escaped HTML after this change in the GUI, you will likely have to clean up the call sites to provide the HTML code wrapped in a HTML object instead of just handing over a str. Another way would be to tighten the API of HTML and prevent the joins with str, but we would have to update a lot of call sites and this would also make the call sites more verbose. Change-Id: Ic7307206e9c0a81fdb3fbf3151afa63d660b8fc4 Commit: 9db1b42eecc8b69eaf0daedb19bbd8bf0fbda790 https://github.com/tribe29/checkmk/commit/9db1b42eecc8b69eaf0daedb19bbd8bf0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/gui/crash_reporting.py M cmk/gui/htmllib/__init__.py M cmk/gui/login.py M cmk/gui/plugins/sidebar/custom_links.py M cmk/gui/plugins/views/inventory.py M cmk/gui/plugins/views/painters.py M cmk/gui/plugins/wato/bi_config.py M cmk/gui/utils/rendering.py M cmk/gui/valuespec.py M cmk/gui/view_utils.py M cmk/gui/wato/mkeventd.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/wato/pages/services.py M cmk/gui/wato/pages/tags.py M cmk/gui/watolib/groups.py M cmk/gui/werks.py Log Message: ----------- Various HTML related cleanups * Use escape_html or html_escape_permissive instead of HTML() to ensure given strings are escaped. * Reduce some Union[str, HTML] by clarifying types and wrapping more strings into HTML. * Also drop some hand crafted HTML tags. Change-Id: I33038328c99df02cba66bdd60a70bdfb4d502462 Commit: d8158d5607cde6a57474f035b3ebfcadca9dc518 https://github.com/tribe29/checkmk/commit/d8158d5607cde6a57474f035b3ebfcadc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/gui/plugins/views/utils.py M cmk/gui/utils/html.py Log Message: ----------- HTML class: Add missing type hints Change-Id: I2e62ac6ccc5c7ade31bdeec10e2d2ec276826220 Compare: https://github.com/tribe29/checkmk/compare/42bfffd73681...d8158d5607cd

3 years

[tribe29/checkmk] ec1162: cmcii_phase: migrate to new API

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ec11620e02369ebbe8e0916db3e0c76c824e2aff https://github.com/tribe29/checkmk/commit/ec11620e02369ebbe8e0916db3e0c76c8… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M checks/cmciii M cmk/base/check_legacy_includes/elphase.py A cmk/base/plugins/agent_based/cmciii_phase.py A cmk/base/plugins/agent_based/utils/elphase.py M tests/unit/checks/test_generic_legacy_conversion.py M tests/unit/cmk/base/plugins/agent_based/test_cmciii.py Log Message: ----------- cmcii_phase: migrate to new API Change-Id: I1cb2ce395e0f5558afbe5a41836e1f5146bae249 Commit: 8d105330d05507b7125ba5183f3a77d8b783e541 https://github.com/tribe29/checkmk/commit/8d105330d05507b7125ba5183f3a77d8b… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/base/plugins/agent_based/utils/elphase.py Log Message: ----------- Minor refactoring in utils/elphase.py Change-Id: I250ac8d359ebdc5e4de99d0978ccf73a1afdda05 Commit: 42bfffd73681662f3e2c5cd912ce5a81876dbdb1 https://github.com/tribe29/checkmk/commit/42bfffd73681662f3e2c5cd912ce5a818… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M checks/cmciii M cmk/base/check_legacy_includes/humidity.py A cmk/base/plugins/agent_based/cmciii_humidity.py M cmk/base/plugins/agent_based/utils/cmciii.py A cmk/base/plugins/agent_based/utils/humidity.py M tests/unit/checks/test_generic_legacy_conversion.py M tests/unit/cmk/base/plugins/agent_based/test_cmciii.py Log Message: ----------- cmciii_humidity: migrate to new API Change-Id: I7308e266f3feef294577f1a204a311bdbfd72b3d Compare: https://github.com/tribe29/checkmk/compare/7e109173b558...42bfffd73681

3 years

[tribe29/checkmk] 88ea6d: Fix gui crash on view "All hosts"

by Benedikt Seidl

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 88ea6dddde366131e33516c701adcb1b40aada64 https://github.com/tribe29/checkmk/commit/88ea6dddde366131e33516c701adcb1b4… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/gui/views.py Log Message: ----------- Fix gui crash on view "All hosts" gui crashed when adding a host tag to: column, sorting and grouping in the "All hosts" view: TypeError (<lambda>() takes 2 positional arguments but 3 were given) This bug was introduced with change Ic0d3ca61b012548de26c418d8813a37c9d50c3dd Change-Id: I4ca30afdafbc0f92760e7a1694de9167545b0528 Commit: a54b11dbce701ae33533d6e223cc9d14568e4b00 https://github.com/tribe29/checkmk/commit/a54b11dbce701ae33533d6e223cc9d145… Author: Benedikt Seidl <benedikt.seidl(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: A .werks/12792 M cmk/base/plugins/agent_based/cisco_wlc.py Log Message: ----------- 12792 cisco_wlc: add support for cisco wlc 9800 Add support for cisco wlc 9800 devices: One check is created for each Access Point. Change-Id: I8c7e8274ac934152aa44668b4edbe5595a108ce0 Compare: https://github.com/tribe29/checkmk/compare/1e0185ddf169...a54b11dbce70

3 years

[tribe29/checkmk] bcd7c0: 12982 FIX <tt>oracle_recovery_status</tt>: Stop ig...

by Thorsten Bruhns

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: bcd7c03693792e3dc91a5aaa50203fd5019ec21f https://github.com/tribe29/checkmk/commit/bcd7c03693792e3dc91a5aaa50203fd50… Author: Thorsten Bruhns <thorsten.bruhns(a)googlemail.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: A .werks/12982 M agents/plugins/mk_oracle M agents/windows/plugins/mk_oracle.ps1 Log Message: ----------- 12982 FIX <tt>oracle_recovery_status</tt>: Stop ignoring offline datafiles (12.1+) The Oracle agent plugin (both Linux and Windows) ignored offline datafiles for version 12.1 and above. This affected environments with physical standby databases. Instead of CRIT, the corresponding check plugin <tt>oracle_recovery_status</tt> went stale. This has been fixed. For this werk to come into effect, you have to update the Oracle agent plugin on affected hosts. Closes #378 Change-Id: Id30de51bb38095e961c160edd613617ef5442aca

3 years

[tribe29/checkmk] 1e0185: 12982 FIX <tt>oracle_recovery_status</tt>: Stop ig...

by Thorsten Bruhns

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 1e0185ddf169db460209bf9600941dde29200c79 https://github.com/tribe29/checkmk/commit/1e0185ddf169db460209bf9600941dde2… Author: Thorsten Bruhns <thorsten.bruhns(a)googlemail.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: A .werks/12982 M agents/plugins/mk_oracle M agents/windows/plugins/mk_oracle.ps1 Log Message: ----------- 12982 FIX <tt>oracle_recovery_status</tt>: Stop ignoring offline datafiles (12.1+) The Oracle agent plugin (both Linux and Windows) ignored offline datafiles for version 12.1 and above. This affected environments with physical standby databases. Instead of CRIT, the corresponding check plugin <tt>oracle_recovery_status</tt> went stale. This has been fixed. For this werk to come into effect, you have to update the Oracle agent plugin on affected hosts. Closes #378 Change-Id: Id30de51bb38095e961c160edd613617ef5442aca

3 years

[tribe29/checkmk] 7e1091: 12982 FIX <tt>oracle_recovery_status</tt>: Stop ig...

by Thorsten Bruhns

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7e109173b55849936e7625c78a2701b6d49acd67 https://github.com/tribe29/checkmk/commit/7e109173b55849936e7625c78a2701b6d… Author: Thorsten Bruhns <thorsten.bruhns(a)googlemail.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: A .werks/12982 M agents/plugins/mk_oracle M agents/windows/plugins/mk_oracle.ps1 Log Message: ----------- 12982 FIX <tt>oracle_recovery_status</tt>: Stop ignoring offline datafiles (12.1+) The Oracle agent plugin (both Linux and Windows) ignored offline datafiles for version 12.1 and above. This affected environments with physical standby databases. Instead of CRIT, the corresponding check plugin <tt>oracle_recovery_status</tt> went stale. This has been fixed. For this werk to come into effect, you have to update the Oracle agent plugin on affected hosts. Closes #378 Change-Id: Id30de51bb38095e961c160edd613617ef5442aca

3 years

[tribe29/checkmk] 8502af: if check params: improve formatting

by Jörg Herbel

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 8502afa559e785c6f57964961c181ecef25b0e59 https://github.com/tribe29/checkmk/commit/8502afa559e785c6f57964961c181ecef… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/gui/plugins/wato/check_parameters/interfaces.py Log Message: ----------- if check params: improve formatting Change-Id: Ibb02ed7d23dcea909f743a25282e1b3fa498061a Commit: 9fca5c0b7d6b6973601f00ef48fa704524a3034a https://github.com/tribe29/checkmk/commit/9fca5c0b7d6b6973601f00ef48fa70452… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/base/plugins/agent_based/utils/interfaces.py M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py Log Message: ----------- interface utils and tests: fix legacy import "State as state" Change-Id: I6450d8e95832955ce15a9d3acbacd90a92c5f107 Commit: 9b9cd4b950924523c061e857b6c572f12283c9fd https://github.com/tribe29/checkmk/commit/9b9cd4b950924523c061e857b6c572f12… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/base/plugins/agent_based/utils/interfaces.py Log Message: ----------- Refactoring in interface utils This is a preparation for implementing a configuration option which allows for configuring mappings of combinations of operational and admin states to a monitoring state. SUP-6489 Change-Id: I325d950339670d10785640431e7c7dbfc94d57ec Commit: 9996cbbf6cfb864f7ec5e5cdf9e844b5682e0640 https://github.com/tribe29/checkmk/commit/9996cbbf6cfb864f7ec5e5cdf9e844b56… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/base/plugins/agent_based/utils/interfaces.py M cmk/gui/plugins/wato/check_parameters/interfaces.py M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py M tests/unit/cmk/gui/plugins/wato/check_parameters/test_if_parameters.py Log Message: ----------- if checks: implement new config option to map op. and admin. states This new configuration option allows for mapping combinations of operational and admin states to monitoring states. Previously, these two quantities could only be mapped independently of each other. This commit only adds the corresponding configuration option, the actual functionality will be added in the following commits. SUP-6489 Change-Id: I12e794797f819bcca2d6e338a2d30a005da53b57 Commit: ce2b62bb35cae9288921bcc906d7f9b0ad47b765 https://github.com/tribe29/checkmk/commit/ce2b62bb35cae9288921bcc906d7f9b0a… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/base/plugins/agent_based/utils/interfaces.py M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py Log Message: ----------- if checks: implement checking of combinations of oper and admin states SUP-6489 Change-Id: Ibb2d2f9797b37f5f00b72e54b2429691c0749bd2 Commit: 5f566b96182b5c8f838afcdd5672402e24467d40 https://github.com/tribe29/checkmk/commit/5f566b96182b5c8f838afcdd5672402e2… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: A .werks/12885 Log Message: ----------- 12885 <tt>if64</tt>: Option to Check Combination of Operational and Admin States The interface check <tt>if64</tt> always displays the operational status <tt>ifOperStatus</tt> of the interface. Furthermore, it can be configured to fetch and display the admin status <tt>ifAdminStatus</tt>. For both states, there are configuration options to map them to monitoring states (eg. ifOperStatus=up --> OK, ifOperStatus=down --> CRIT). However, before this werk, there was no option to assign a monitoring state to a combination of an operational and an admin state. With the additional configuration option introduced by this werk, you can for example configure that an interface which is down and admin down should be considered OK. Such a setting will only apply to interfaces matching the configured operational and the configured admin state. For example, an interface which is down but admin up would not be affected. SUP-6489 Change-Id: I61ae379c55eb53de2128c332e20fc536a384eef8 Compare: https://github.com/tribe29/checkmk/compare/6b773fa1585f...5f566b96182b

3 years

[tribe29/checkmk] 8d9d3b: 12303 FIX Fix cache miss on discovery

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8d9d3b772194a6e6b9a068655b83e8b588a85771 https://github.com/tribe29/checkmk/commit/8d9d3b772194a6e6b9a068655b83e8b58… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: A .werks/12303 M cmk/base/agent_based/data_provider.py M cmk/base/agent_based/discovery/__init__.py M cmk/base/automations/check_mk.py M cmk/base/config.py M cmk/base/modes/check_mk.py M cmk/base/sources/_abstract.py M cmk/base/sources/_checkers.py M cmk/core_helpers/agent.py M cmk/core_helpers/cache.py M cmk/core_helpers/controller.py M cmk/core_helpers/snmp.py M tests/unit/cmk/base/agent_based/test_data_provider_collect_host_sections.py M tests/unit/cmk/base/sources/test_cmd_caching.py M tests/unit/cmk/base/sources/test_tcp_data_source.py M tests/unit/cmk/base/test_config.py M tests/unit/cmk/core_helpers/test_cache.py M tests/unit/cmk/core_helpers/test_fetchers.py Log Message: ----------- 12303 FIX Fix cache miss on discovery Let cache max age depend on the mode This changes the type of `max_age` from `int` to its own type in the fetcher caches and the other changes use mypy and are mechanical. This fixes a problem with the cache invalidation of the discovery data. This could have two consequences: a performance problem where the hosts would be unnecessarily queries; or the opposite where the data would not be refreshed. CMK-8136 Change-Id: Ifa046669f87c5f8d54e52f00c422693f8766339b Commit: 983df0530f223d7a3de90e814d012c2a84e2cc9a https://github.com/tribe29/checkmk/commit/983df0530f223d7a3de90e814d012c2a8… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/core_helpers/__init__.py M cmk/core_helpers/_base.py M cmk/core_helpers/cache.py M cmk/core_helpers/controller.py M cmk/core_helpers/ipmi.py M cmk/core_helpers/piggyback.py M cmk/core_helpers/program.py M cmk/core_helpers/snmp.py M cmk/core_helpers/tcp.py M cmk/snmplib/type_defs.py M cmk/utils/cpu_tracking.py M cmk/utils/type_defs/_misc.py M tests/unit/cmk/core_helpers/test_cache.py Log Message: ----------- Use immutable mapping for de/serialization Change-Id: Iad402089365a35c93a669af5fd9d93b0b8c18f6b Compare: https://github.com/tribe29/checkmk/compare/32622cf511d3...983df0530f22

3 years

[tribe29/checkmk] 9d0d16: if check params: improve formatting

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9d0d16889cf0d283aa77b93beb1d5851e923f42d https://github.com/tribe29/checkmk/commit/9d0d16889cf0d283aa77b93beb1d5851e… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/gui/plugins/wato/check_parameters/interfaces.py Log Message: ----------- if check params: improve formatting Change-Id: Ibb02ed7d23dcea909f743a25282e1b3fa498061a Commit: a5f4b5de1866697531ac0aaf9790efb425421862 https://github.com/tribe29/checkmk/commit/a5f4b5de1866697531ac0aaf9790efb42… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/base/plugins/agent_based/utils/interfaces.py M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py Log Message: ----------- interface utils and tests: fix legacy import "State as state" Change-Id: I6450d8e95832955ce15a9d3acbacd90a92c5f107 Commit: 09dff88fdd92f763314d4905bbd014b75e5b77eb https://github.com/tribe29/checkmk/commit/09dff88fdd92f763314d4905bbd014b75… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/base/plugins/agent_based/utils/interfaces.py Log Message: ----------- Refactoring in interface utils This is a preparation for implementing a configuration option which allows for configuring mappings of combinations of operational and admin states to a monitoring state. SUP-6489 Change-Id: I325d950339670d10785640431e7c7dbfc94d57ec Commit: e745d371f610d7c629f0679d835b7b6b06909690 https://github.com/tribe29/checkmk/commit/e745d371f610d7c629f0679d835b7b6b0… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/base/plugins/agent_based/utils/interfaces.py M cmk/gui/plugins/wato/check_parameters/interfaces.py M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py M tests/unit/cmk/gui/plugins/wato/check_parameters/test_if_parameters.py Log Message: ----------- if checks: implement new config option to map op. and admin. states This new configuration option allows for mapping combinations of operational and admin states to monitoring states. Previously, these two quantities could only be mapped independently of each other. This commit only adds the corresponding configuration option, the actual functionality will be added in the following commits. SUP-6489 Change-Id: I12e794797f819bcca2d6e338a2d30a005da53b57 Commit: 86a21e038c326aac4b9cdd39f8ef51c75f914776 https://github.com/tribe29/checkmk/commit/86a21e038c326aac4b9cdd39f8ef51c75… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: M cmk/base/plugins/agent_based/utils/interfaces.py M tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py Log Message: ----------- if checks: implement checking of combinations of oper and admin states SUP-6489 Change-Id: Ibb2d2f9797b37f5f00b72e54b2429691c0749bd2 Commit: 32622cf511d375ddb572a008e81809242b0c0eae https://github.com/tribe29/checkmk/commit/32622cf511d375ddb572a008e81809242… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2021-06-22 (Tue, 22 Jun 2021) Changed paths: A .werks/12885 Log Message: ----------- 12885 <tt>if64</tt>: Option to Check Combination of Operational and Admin States The interface check <tt>if64</tt> always displays the operational status <tt>ifOperStatus</tt> of the interface. Furthermore, it can be configured to fetch and display the admin status <tt>ifAdminStatus</tt>. For both states, there are configuration options to map them to monitoring states (eg. ifOperStatus=up --> OK, ifOperStatus=down --> CRIT). However, before this werk, there was no option to assign a monitoring state to a combination of an operational and an admin state. With the additional configuration option introduced by this werk, you can for example configure that an interface which is down and admin down should be considered OK. Such a setting will only apply to interfaces matching the configured operational and the configured admin state. For example, an interface which is down but admin up would not be affected. SUP-6489 Change-Id: I61ae379c55eb53de2128c332e20fc536a384eef8 Compare: https://github.com/tribe29/checkmk/compare/e03464ef6416...32622cf511d3

3 years

← Newer
1
...
11
12
13
14
15
16
17
...
38
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits June 2021