Checkmk git commits February 2021

checkmk-commits@lists.checkmk.com

1 participants
964 discussions

[tribe29/checkmk] eebbe0: Check rds_licenses support Windows Server 2019

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: eebbe028f0a76a4e8c4462286d91985dcd616a60 https://github.com/tribe29/checkmk/commit/eebbe028f0a76a4e8c4462286d91985dc… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M checks/rds_licenses Log Message: ----------- Check rds_licenses support Windows Server 2019 Change-Id: I191e4350b86abe1881573a399489585362311c31

3 years, 5 months

[tribe29/checkmk] 327dc5: REST API: missing ETag gives 428 (precondition req.)

by Christoph Rauch

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 327dc509e915302f0ec9c341ab5c0c3414f165cc https://github.com/tribe29/checkmk/commit/327dc509e915302f0ec9c341ab5c0c341… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/openapi/restful_objects/constructors.py M cmk/gui/plugins/openapi/restful_objects/decorators.py M cmk/gui/plugins/openapi/restful_objects/type_defs.py M tests/unit/cmk/gui/plugins/openapi/test_openapi_folder_config.py Log Message: ----------- REST API: missing ETag gives 428 (precondition req.) Change-Id: I027c8bf7460baaf4e304c628b84270267efb517b

3 years, 5 months

[tribe29/checkmk] e80e6c: [CMK-6971] - add manual testing ability to check s...

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e80e6ccbe46a0812c8008488388feff62a6470cb https://github.com/tribe29/checkmk/commit/e80e6ccbe46a0812c8008488388feff62… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M agents/wnx/src/common/mailslot_transport.h M agents/wnx/src/common/wtools.cpp M agents/wnx/src/engine/carrier.cpp A agents/wnx/watest/readme.md M agents/wnx/watest/watest.cpp Log Message: ----------- [CMK-6971] - add manual testing ability to check slot admin protection - add run_admin_mailslot, run_standard_mailslot, test_mailslot command line parameters for watest - add short readme to keep info about watest above mentioned commands - verify manually using command line - verify mailslot access using process explorer - minor refactoring char* -> string_view Change-Id: If207febfe040bab463307d7335b5eee54cc2638a

3 years, 5 months

[tribe29/checkmk] fc3e32: Dashlet Plot unit formatting + default

by Óscar Nájera

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: fc3e32e4c4e8a083e9e69c3c8e24d90153d48b64 https://github.com/tribe29/checkmk/commit/fc3e32e4c4e8a083e9e69c3c8e24d9015… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M web/htdocs/js/modules/figures/cmk_figures.js M web/htdocs/js/modules/figures/cmk_timeseries.js Log Message: ----------- Dashlet Plot unit formatting + default Change-Id: Ib069ca0292346fa21be15822c48618e57f4d8ddf (cherry picked from commit c87348f7db193859b791e4ef032ec4cf80e8a0ea)

3 years, 5 months

[tribe29/checkmk] c0ffd5: DRAFT Remove data generator class for dashlet

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c0ffd57aaaf6556c07e0fda01f6fd5a0c63b5d31 https://github.com/tribe29/checkmk/commit/c0ffd57aaaf6556c07e0fda01f6fd5a0c… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M cmk/gui/plugins/dashboard/single_metric.py M cmk/gui/plugins/dashboard/utils.py M tests/unit/cmk/gui/test_pages.py M web/htdocs/js/modules/figures/cmk_gauge.js Log Message: ----------- DRAFT Remove data generator class for dashlet Currently dashlets query an ajax endpoint, which is just a page, that replies to the dashlet data generator. These data generators come in a pair match to dashlet and thus become to rigid to serve multiple dashlets that only require a subset of the data or worse that can incompatible render attributes. Inspecting the ABCDatagenerator the only relevant method is generate_response_from_request. Within it, it was already capable to find the dashlet being draw, yet it extracted the configuration valuespec out of itself(DataGenerator) instead of the Dashlet, which is the correct candidate to know the required configuration valuespec. This refactoring taking as example the Single metric source, that can be displayed as a Gauge(w/o history) or Single Graph(w/o history) for a specific host and service or a Barplot with current value for multiple hosts. All configuration valuespec is transferred to the dashlets. Datagenerator is removed leaving some middle ware not to break other dashlets. And the WEB API ajax endpoint is named for single metric, but could easily process all new figure dashlets, because the dashlet type is recognized during processing not on API endpoint. The specificity of the configuration valuespec at the dashlet level allows for flexible and unique dashlet endpoint and correct data validation. Change-Id: I15b8561f1011a44f09348cfb3005af715ca484ea Commit: cb1aca74d959cab1fe6fa06883e1ad5f782c41f0 https://github.com/tribe29/checkmk/commit/cb1aca74d959cab1fe6fa06883e1ad5f7… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/utils.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Dashlet scatterplot: migrate vs_parameters to dashlet As proposed in previous draft. Dashlets need to keep the ownership of their parameters. Data generators only process Request on backend. No need for special page per dashlet. Change-Id: I9ededa2a9d37182d9dbb4cd4753710e190fad7b4 Commit: 4fbe28cdf7755b2586088e7216df4c3b7d0e8619 https://github.com/tribe29/checkmk/commit/4fbe28cdf7755b2586088e7216df4c3b7… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/alert_statistics.py M cmk/gui/plugins/dashboard/site_overview.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Dashlets: Site Overview & Alert statistics transfer vs Change-Id: I68df2bb3739fdf708ddbe812877d045f2c6abe30 Commit: 6ce54dc5072557048e67ab1a2b4b7b30872fecbe https://github.com/tribe29/checkmk/commit/6ce54dc5072557048e67ab1a2b4b7b308… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/bar_chart_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Moved bar charts to work without its data generator - Simplified title. It belongs to dashlet not data generator - The legend had repeated to title. Beforehand agreed to drop that. - For the moment workaround make all classmethods instance methods to track log_class & type. Will be simplified next Change-Id: I2d47833f0684809b3d7b692c532c862403d04e84 Commit: 5728703adf05d49c51803a95ebcd3f47214f010a https://github.com/tribe29/checkmk/commit/5728703adf05d49c51803a95ebcd3f472… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/bar_chart_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py Log Message: ----------- Dashlets: Alerts and notifications move vs_parameters to dashlets Change-Id: Ic400f2c3aacfbdae9e72c5cb48675b6f4c0fd034 Commit: 48da7735c59ed32d91e558b590c4abcd83de8dea https://github.com/tribe29/checkmk/commit/48da7735c59ed32d91e558b590c4abcd8… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/__init__.py M cmk/gui/plugins/dashboard/alert_statistics.py M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/bar_chart_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M cmk/gui/plugins/dashboard/single_metric.py M cmk/gui/plugins/dashboard/site_overview.py M cmk/gui/plugins/dashboard/utils.py Log Message: ----------- Discard the need for the ABCDataGenerator - Old DataGenerator subclasses just keep the name for cohesion, they act now as a namespace. - All figure dashlets now query a single figure dashlet API endpoint. Which validates Dashlet specific input. Change-Id: I4dea6b0b0756e61f213eacb971e10634a5c1f694 Compare: https://github.com/tribe29/checkmk/compare/39ebd99273b0...48da7735c59e

3 years, 5 months

[tribe29/checkmk] d46011: [CMK-6971] - add brand new admin mode to create ma...

by Sergey Kipnis

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: d460111ff44e388a499a43c0d556412db78e7c8e https://github.com/tribe29/checkmk/commit/d460111ff44e388a499a43c0d556412db… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M agents/wnx/src/common/mailslot_transport.h M agents/wnx/src/common/wtools.cpp M agents/wnx/src/common/wtools.h M agents/wnx/src/engine/carrier.h M agents/wnx/src/engine/service_processor.cpp M agents/wnx/watest/test-carrier.cpp M agents/wnx/watest/test-cfg.cpp M agents/wnx/watest/test-commander.cpp M agents/wnx/watest/test-runperf.cpp M agents/wnx/watest/test-service-processor.cpp M agents/wnx/watest/test-wtools.cpp Log Message: ----------- [CMK-6971] - add brand new admin mode to create mailslots - test all - rework test according to tribe29 guidelines - cleanup code Change-Id: Id414ac71ccf9c9a88c7eb984679daac93bac65e4 Commit: 4aca9b897b24e4670eb63632d6a783066794362b https://github.com/tribe29/checkmk/commit/4aca9b897b24e4670eb63632d6a783066… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M agents/wnx/src/common/mailslot_transport.h M agents/wnx/src/common/wtools.cpp Log Message: ----------- [CMK-6971] - make code more OOP - separate win32 from the logic - remove old trash Change-Id: I7501e42bc6724c9eff455a1dd1e0e6e6dd4a6402 Compare: https://github.com/tribe29/checkmk/compare/a93f09a991f9...4aca9b897b24

3 years, 5 months

[tribe29/checkmk] 46d5e8: 12031 FIX Views: Views are now asking for missing ...

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 46d5e858678cf9088109271525fcde623d0b3436 https://github.com/tribe29/checkmk/commit/46d5e858678cf9088109271525fcde623… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: A .werks/12031 M cmk/gui/plugins/views/availability.py M cmk/gui/views.py M cmk/gui/visuals.py M tests/unit/cmk/gui/test_visuals.py Log Message: ----------- 12031 FIX Views: Views are now asking for missing contexts just like dashboards When a view that requires a context (e.g. as host name) is opened without a "host" HTTP request variable, the view only showed an error message and stopped rendering the view. The user then had to add the missing context information to the view configuration or to the URL variables. >From now on, the view is still displaying a warning message like "Unable to render this view, because we miss some required context information (host). Please update the form on the right to make this view render.", but also displaying the filter form asking the user to provide the missing context. Change-Id: I2338f9645629c4934a3d37e44b8e565b42434358 Commit: 39ebd99273b0bded316660632fe54d0dd8c25b3d https://github.com/tribe29/checkmk/commit/39ebd99273b0bded316660632fe54d0dd… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M agents/wnx/src/common/mailslot_transport.h M agents/wnx/src/common/wtools.cpp Log Message: ----------- [CMK-6971] - make code more OOP - separate win32 from the logic - remove old trash Change-Id: I7501e42bc6724c9eff455a1dd1e0e6e6dd4a6402 Compare: https://github.com/tribe29/checkmk/compare/4a031c055db2...39ebd99273b0

3 years, 5 months

[tribe29/checkmk] a93f09: 12031 FIX Views: Views are now asking for missing ...

by Lars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: a93f09a991f9de3c679f35d06a9d740b37d1d4e0 https://github.com/tribe29/checkmk/commit/a93f09a991f9de3c679f35d06a9d740b3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: A .werks/12031 M cmk/gui/plugins/views/availability.py M cmk/gui/views.py M cmk/gui/visuals.py M tests/unit/cmk/gui/test_visuals.py Log Message: ----------- 12031 FIX Views: Views are now asking for missing contexts just like dashboards When a view that requires a context (e.g. as host name) is opened without a "host" HTTP request variable, the view only showed an error message and stopped rendering the view. The user then had to add the missing context information to the view configuration or to the URL variables. >From now on, the view is still displaying a warning message like "Unable to render this view, because we miss some required context information (host). Please update the form on the right to make this view render.", but also displaying the filter form asking the user to provide the missing context. Change-Id: I2338f9645629c4934a3d37e44b8e565b42434358

3 years, 5 months

[tribe29/checkmk] e9b1e6: 12032 FIX Reporting snapin: Fix empty page when ch...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e9b1e62677dfde592f234ac4dc29c0df622fd67d https://github.com/tribe29/checkmk/commit/e9b1e62677dfde592f234ac4dc29c0df6… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: A .werks/12032 Log Message: ----------- 12032 FIX Reporting snapin: Fix empty page when changing timerange after adding snapin Change-Id: I4432020b7a6f5c7b0ae5e9fb5bb55788ac1ad731 Commit: 4a031c055db2982b3fc2a0ce33682f5792ed10ed https://github.com/tribe29/checkmk/commit/4a031c055db2982b3fc2a0ce33682f579… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: A .werks/12033 M cmk/gui/notifications.py Log Message: ----------- 12033 FIX Fix deletion of failed notifications in distributed setups CMK-6966 Change-Id: I2371aeba60588d34ebae1bbfafdbe7e35043fdf5 Compare: https://github.com/tribe29/checkmk/compare/ca2dd1782a8c...4a031c055db2

3 years, 5 months

[tribe29/checkmk] 79aacb: 12033 FIX Fix deletion of failed notifications in ...

by Lars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 79aacb93dba422e4ed84a1bac419b45746b886e3 https://github.com/tribe29/checkmk/commit/79aacb93dba422e4ed84a1bac419b4574… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: A .werks/12033 M cmk/gui/notifications.py Log Message: ----------- 12033 FIX Fix deletion of failed notifications in distributed setups CMK-6966 Change-Id: I2371aeba60588d34ebae1bbfafdbe7e35043fdf5

3 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2021