Checkmk git commits February 2021

checkmk-commits@lists.checkmk.com

1 participants
964 discussions

[tribe29/checkmk] ee9917: Moved bar charts to work without its data generator

by Óscar Nájera

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: ee99179561b0a19be28256e7f19ce9c0c3210778 https://github.com/tribe29/checkmk/commit/ee99179561b0a19be28256e7f19ce9c0c… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/bar_chart_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Moved bar charts to work without its data generator - Simplified title. It belongs to dashlet not data generator - The legend had repeated to title. Beforehand agreed to drop that. - For the moment workaround make all classmethods instance methods to track log_class & type. Will be simplified next Change-Id: I2d47833f0684809b3d7b692c532c862403d04e84 Commit: 9910f689510a947fcf0bda48f4881037a489d810 https://github.com/tribe29/checkmk/commit/9910f689510a947fcf0bda48f4881037a… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/bar_chart_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py Log Message: ----------- Dashlets: Alerts and notifications move vs_parameters to dashlets Change-Id: Ic400f2c3aacfbdae9e72c5cb48675b6f4c0fd034 Commit: 1751ce078ab35ef3e53ae87ec36b14ea59f86e6c https://github.com/tribe29/checkmk/commit/1751ce078ab35ef3e53ae87ec36b14ea5… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/__init__.py M cmk/gui/plugins/dashboard/alert_statistics.py M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/bar_chart_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M cmk/gui/plugins/dashboard/single_metric.py M cmk/gui/plugins/dashboard/site_overview.py M cmk/gui/plugins/dashboard/utils.py Log Message: ----------- Discard the need for the ABCDataGenerator - Old DataGenerator subclasses just keep the name for cohesion, they act now as a namespace. - All figure dashlets now query a single figure dashlet API endpoint. Which validates Dashlet specific input. Change-Id: I4dea6b0b0756e61f213eacb971e10634a5c1f694 Commit: e37c8364767b1bd254f7c082cc88f27a752449fd https://github.com/tribe29/checkmk/commit/e37c8364767b1bd254f7c082cc88f27a7… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py Log Message: ----------- Fix livestatus query for single number alerts/notification Dashlet Match needs to be against empty string not the next line Filter. Change-Id: Iefa8003f1f3d0001063dca4a4705f3bf285278cb (cherry picked from commit fb60cb5adb89957f3b620f8fcd5f21408623e40e) Compare: https://github.com/tribe29/checkmk/compare/7645bb1c4448...e37c8364767b

3 years, 5 months

[tribe29/checkmk] 4fd61d: Fix: Data binding at correct class

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4fd61dd637e11114f5a4f2e187c626de15d8279c https://github.com/tribe29/checkmk/commit/4fd61dd637e11114f5a4f2e187c626de1… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M web/htdocs/js/modules/figures/cmk_tabs.js Log Message: ----------- Fix: Data binding at correct class * We need the data binding at those classes which implements set_ifid * One side effect bug previous this change was, that tabs could not being switched back Change-Id: Icf7ff5ac234499e4d412b8372a789f6396c21b6a

3 years, 5 months

[tribe29/checkmk] 7645bb: Fix: Data binding at correct class

by Timotheus Bachinger

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 7645bb1c444820986a1e52b3f03f0800a17b8e24 https://github.com/tribe29/checkmk/commit/7645bb1c444820986a1e52b3f03f0800a… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M web/htdocs/js/modules/figures/cmk_tabs.js Log Message: ----------- Fix: Data binding at correct class * We need the data binding at those classes which implements set_ifid * One side effect bug previous this change was, that tabs could not being switched back Change-Id: Icf7ff5ac234499e4d412b8372a789f6396c21b6a

3 years, 5 months

[tribe29/checkmk] 83b7ef: Add valgrind to sles 12 sp 3 and 4

by AZurhake

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 83b7efa69232d67c28a5089f013a8370b16ed645 https://github.com/tribe29/checkmk/commit/83b7efa69232d67c28a5089f013a8370b… Author: Alex Zurhake <alex.zurhake(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M buildscripts/infrastructure/build-nodes/sles-12sp3/Dockerfile M buildscripts/infrastructure/build-nodes/sles-12sp4/Dockerfile Log Message: ----------- Add valgrind to sles 12 sp 3 and 4 Change-Id: Idb6fd5c0de75733f0afe8e8e8d32357cdc673d8c

3 years, 5 months

[tribe29/checkmk] 87d0ca: replaced braintower with new brand brevis.one

by Marcel Arentz

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 87d0ca1d950ba7b2337130a7965d84e8e94eb5c3 https://github.com/tribe29/checkmk/commit/87d0ca1d950ba7b2337130a7965d84e8e… Author: Marcel Arentz <marcel.arentz(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: R doc/treasures/notifications/braintower A doc/treasures/notifications/brevis.one Log Message: ----------- replaced braintower with new brand brevis.one Braintower SMS Gateway is now brevis.one and the integration is therefor renamed to the new brand. There is no new functionality to this script, so it is not required to replace it in production environments unless you want to see the new brand name. Change-Id: Iaa275cc284e2711e6d7aad21d732f3d8e1620f29

3 years, 5 months

[tribe29/checkmk] fb60cb: Fix livestatus query for single number alerts/noti...

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: fb60cb5adb89957f3b620f8fcd5f21408623e40e https://github.com/tribe29/checkmk/commit/fb60cb5adb89957f3b620f8fcd5f21408… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py Log Message: ----------- Fix livestatus query for single number alerts/notification Dashlet Match needs to be against empty string not the next line Filter. Change-Id: Iefa8003f1f3d0001063dca4a4705f3bf285278cb

3 years, 5 months

[tribe29/checkmk] d9dda4: replaced braintower with new brand brevis.one

by Marcel Arentz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d9dda4ce55f8f08a2e689b190c49ff7e567ffef7 https://github.com/tribe29/checkmk/commit/d9dda4ce55f8f08a2e689b190c49ff7e5… Author: Marcel Arentz <marcel.arentz(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: R doc/treasures/notifications/braintower A doc/treasures/notifications/brevis.one Log Message: ----------- replaced braintower with new brand brevis.one Braintower SMS Gateway is now brevis.one and the integration is therefor renamed to the new brand. There is no new functionality to this script, so it is not required to replace it in production environments unless you want to see the new brand name. Change-Id: Iaa275cc284e2711e6d7aad21d732f3d8e1620f29

3 years, 5 months

[tribe29/checkmk] 907d09: Page menu topics: align topic titles with icons

by Lars

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: 907d090087051adcd0a2885535179f259c2d5577 https://github.com/tribe29/checkmk/commit/907d090087051adcd0a2885535179f259… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- Page menu topics: align topic titles with icons CMK-6787 showed that the alignment with the links is confusing, because the styling of the topic titles looked like disabled links. This commit changes the alignment to clarify the difference. Change-Id: Ib9d3432536a65ae5bd362e98f51df0234d589de4

3 years, 5 months

[tribe29/checkmk] fd0c5b: Page menu topics: align topic titles with icons

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: fd0c5bfa61f11c2f4ec6a1f48ba13d75b899e2f0 https://github.com/tribe29/checkmk/commit/fd0c5bfa61f11c2f4ec6a1f48ba13d75b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- Page menu topics: align topic titles with icons CMK-6787 showed that the alignment with the links is confusing, because the styling of the topic titles looked like disabled links. This commit changes the alignment to clarify the difference. Change-Id: Ib9d3432536a65ae5bd362e98f51df0234d589de4

3 years, 5 months

[tribe29/checkmk] a84e8b: RRD columns refactor

by Sergey Kipnis

Branch: refs/heads/2.0.0 Home: https://github.com/tribe29/checkmk Commit: a84e8bd27287ed1992fd627a1308c3f7b09fc42b https://github.com/tribe29/checkmk/commit/a84e8bd27287ed1992fd627a1308c3f7b… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/single_metric.py M cmk/gui/plugins/metrics/rrd_fetch.py Log Message: ----------- RRD columns refactor Change-Id: I1d246efd5123682093c973432e7375f0a6d1f9c6 Commit: 8e4f95c8ee558c90de881b766cf2224d2a152848 https://github.com/tribe29/checkmk/commit/8e4f95c8ee558c90de881b766cf2224d2… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/event_bar_chart_dashlet.py M cmk/gui/plugins/dashboard/single_metric.py M cmk/gui/plugins/dashboard/utils.py M tests/unit/cmk/gui/test_pages.py M web/htdocs/js/modules/figures/cmk_gauge.js Log Message: ----------- DRAFT Remove data generator class for dashlet Currently dashlets query an ajax endpoint, which is just a page, that replies to the dashlet data generator. These data generators come in a pair match to dashlet and thus become to rigid to serve multiple dashlets that only require a subset of the data or worse that can incompatible render attributes. Inspecting the ABCDatagenerator the only relevant method is generate_response_from_request. Within it, it was already capable to find the dashlet being draw, yet it extracted the configuration valuespec out of itself(DataGenerator) instead of the Dashlet, which is the correct candidate to know the required configuration valuespec. This refactoring taking as example the Single metric source, that can be displayed as a Gauge(w/o history) or Single Graph(w/o history) for a specific host and service or a Barplot with current value for multiple hosts. All configuration valuespec is transferred to the dashlets. Datagenerator is removed leaving some middle ware not to break other dashlets. And the WEB API ajax endpoint is named for single metric, but could easily process all new figure dashlets, because the dashlet type is recognized during processing not on API endpoint. The specificity of the configuration valuespec at the dashlet level allows for flexible and unique dashlet endpoint and correct data validation. Change-Id: I15b8561f1011a44f09348cfb3005af715ca484ea Commit: be661b2d4278e23bd04220b301e0ca98b1881873 https://github.com/tribe29/checkmk/commit/be661b2d4278e23bd04220b301e0ca98b… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/average_scatterplot_dashlet.py M cmk/gui/plugins/dashboard/utils.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Dashlet scatterplot: migrate vs_parameters to dashlet As proposed in previous draft. Dashlets need to keep the ownership of their parameters. Data generators only process Request on backend. No need for special page per dashlet. Change-Id: I9ededa2a9d37182d9dbb4cd4753710e190fad7b4 Commit: 7f33a572d919b77d67cfd45f91c863123caed484 https://github.com/tribe29/checkmk/commit/7f33a572d919b77d67cfd45f91c863123… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M cmk/gui/plugins/dashboard/alert_statistics.py M cmk/gui/plugins/dashboard/site_overview.py M tests/unit/cmk/gui/test_pages.py Log Message: ----------- Dashlets: Site Overview & Alert statistics transfer vs Change-Id: I68df2bb3739fdf708ddbe812877d045f2c6abe30 Commit: c6a5a3996aa195fe79b7eebab66afa06448c59d3 https://github.com/tribe29/checkmk/commit/c6a5a3996aa195fe79b7eebab66afa064… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M agents/wnx/src/common/mailslot_transport.h M agents/wnx/src/common/wtools.cpp M agents/wnx/src/engine/carrier.cpp A agents/wnx/watest/readme.md M agents/wnx/watest/watest.cpp Log Message: ----------- [CMK-6971] - add manual testing ability to check slot admin protection - add run_admin_mailslot, run_standard_mailslot, test_mailslot command line parameters for watest - add short readme to keep info about watest above mentioned commands - verify manually using command line - verify mailslot access using process explorer - minor refactoring char* -> string_view Change-Id: If207febfe040bab463307d7335b5eee54cc2638a Commit: cd432d0997c1da4a0d1dcf9cbe86f55db20835b6 https://github.com/tribe29/checkmk/commit/cd432d0997c1da4a0d1dcf9cbe86f55db… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2021-02-01 (Mon, 01 Feb 2021) Changed paths: M checks/rds_licenses Log Message: ----------- Check rds_licenses support Windows Server 2019 Change-Id: I191e4350b86abe1881573a399489585362311c31 Compare: https://github.com/tribe29/checkmk/compare/327dc509e915...cd432d0997c1

3 years, 5 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2021