Checkmk git commits September 2020

checkmk-commits@lists.checkmk.com

1 participants
431 discussions

[tribe29/checkmk] c60dcc: Cleanup ancient unicode filter classes

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c60dcc18e86308066771bbbf38a748f01380a125 https://github.com/tribe29/checkmk/commit/c60dcc18e86308066771bbbf38a748f01… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M cmk/gui/plugins/visuals/__init__.py M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/visuals.py M tests/unit/cmk/gui/plugins/visuals/test_filters.py Log Message: ----------- Cleanup ancient unicode filter classes These special classes were needed in Python 2.x, since we were dealing with byte and unicode strings. After moving to Python 3.x all the text strings are of type str now and there is no need for a special unicode filter handling anymore. Change-Id: I621b65930eba6b8fa109a854219457a4123e912b Commit: 9067b54c863f556a1bc1751ed971b0d3f89cf898 https://github.com/tribe29/checkmk/commit/9067b54c863f556a1bc1751ed971b0d3f… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/visuals/inventory.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/visuals.py Log Message: ----------- Filters: remove double_height attribute The new UX does not work with the single / double height attributes anymore. Change-Id: Ibb6d9dc10103b02d185c9b19b43b23581f105ebb Compare: https://github.com/tribe29/checkmk/compare/b49c8288cc20...9067b54c863f

4 years

[tribe29/checkmk] b49c82: Clang tidy, cppcheck and iwyut tool in docker

by AZurhake

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b49c8288cc20003145c5c2afd5872adaa9a3cc99 https://github.com/tribe29/checkmk/commit/b49c8288cc20003145c5c2afd5872adaa… Author: Alex Zurhake <alex.zurhake(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M tests/Makefile Log Message: ----------- Clang tidy, cppcheck and iwyut tool in docker Used to run the targets in docker on Jenkins Change-Id: I19b653b1a36c1c878e284b0dbb7adeca11b40761

4 years

[tribe29/checkmk] 51f3e5: 11366 brocade_optical: Adjust to new discovery rul...

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 51f3e5bc73e5a829e7b15443bb82f4924295e3d3 https://github.com/tribe29/checkmk/commit/51f3e5bc73e5a829e7b15443bb82f4924… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: A .werks/11366 M checkman/brocade_optical R checks/brocade_optical A cmk/base/plugins/agent_based/brocade_optical.py M cmk/base/plugins/agent_based/utils/interfaces.py R tests/unit/checks/generictests/datasets/brocade_optical_1_regression.py R tests/unit/checks/generictests/datasets/brocade_optical_2_regression.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/cmk/base/plugins/agent_based/test_brocade_optical.py Log Message: ----------- 11366 brocade_optical: Adjust to new discovery ruleset for network interfaces The discovery of the services corresponding to the check <tt>brocade_optical</tt>, which monitors the signal quality of the optical ports of Brocade switches, is configurable via the rule "Network Interface and Switch Port Discovery". As announced in werk #11361, this rule has been reworked. With this werk, we adjust <tt>brocade_optical</tt> to the new version of the discovery ruleset for network interfaces. This check now uses the discovery ruleset for network interfaces the same way as all other interface checks and is thus consistent with werk #11361, which was not the case before. However, note that, as before, <tt>brocade_optical</tt> does not implement all of the options offered by this discovery rule. The grouping of interfaces is not supported and the items are always given by the port numbers, independently of the option chosen under "Appearance of network interface". Furthermore, out of the six matching conditions offered by the rule, this check supports only the following three: the matching of the port type, the matching of the port state and the matching of the interface description. This werk is incompatible. Currently discovered services will continue to work, however, upon re-discovery, some services might vanish or new services might be discovered. This depends on the user-defined rules from the ruleset "Network Interface and Switch Port Discovery". In such cases, users have to adjust their rules. Note that the default behavior of the check has not changed. Hence, this werk is compatible for users with no corresponding user-defined rules. This change also migrates brocade_optical to the new API. CMK-5321 Change-Id: I1abf6d205825ef88c6bef26ead4f64dc6e97b70f

4 years

[tribe29/checkmk] cbf5b1: Plugin registry: Add decorator for registering cla...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: cbf5b197f3b0ed4ee681978d68e9117e7c4784cc https://github.com/tribe29/checkmk/commit/cbf5b197f3b0ed4ee681978d68e9117e7… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M cmk/utils/plugin_registry.py M tests/unit/cmk/utils/test_plugin_registry.py Log Message: ----------- Plugin registry: Add decorator for registering class instances Previously you had to specify the class declaration and instantiation with registration in separate blocks, like this: class DecoratedPlugin(Plugin): pass plugin_registry.register(DecoratedPlugin()) With the new decorator it is possible to register class instances to an instance registry next to the class declaration: @registry.register_instance class DecoratedPlugin(Plugin): pass Change-Id: Iff41d441b70987a94e7f0c223ea34651449cf84c Commit: 80978cdb4281aca40a206978f394b1827a40c125 https://github.com/tribe29/checkmk/commit/80978cdb4281aca40a206978f394b1827… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M cmk/gui/mkeventd.py M cmk/gui/plugins/views/inventory.py M cmk/gui/plugins/visuals/filters.py M cmk/gui/plugins/visuals/inventory.py M cmk/gui/plugins/visuals/utils.py M cmk/gui/plugins/visuals/wato.py M cmk/gui/visuals.py M tests/unit/cmk/gui/plugins/visuals/test_filters.py M tests/unit/cmk/gui/test_visuals.py Log Message: ----------- Refactor filter_registry to objects All call sites to the registry create instances from the filter. Direcly getting instances from the registry simplifies the call sites. Having a dedicated class for each filter is consuming more memory than having just a number of classes with one instance for each filter. The filters were previously all registered with their classes in the registry. Even the dynamically created inventory filters that are all based on a small number of classes was creating and registering a dedicated class each registered filter. This structure was originally chosen, because the filters are registered on module level with all their attributes, including localizable strings (title, description), but the localization information is not loaded during module loading, making these strings not localizable. Since we have extended our GUI framework with speaklater, which allows us to declare lazy localizations (using _l() instead of _()), we can now declare localized strings during module load time. Change-Id: I889bbdd6c19dab1d4d9a4ef5cc7103b39a066673 Compare: https://github.com/tribe29/checkmk/compare/4897e014be21...80978cdb4281

4 years

[tribe29/checkmk] 4897e0: Migration of statgrab_net

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4897e014be21f200fe547e65b47987301b5e40fb https://github.com/tribe29/checkmk/commit/4897e014be21f200fe547e65b47987301… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M checkman/statgrab_net R checks/statgrab_net A cmk/base/plugins/agent_based/statgrab_net.py M tests/unit/checks/test_generic_legacy_conversion.py Log Message: ----------- Migration of statgrab_net CMK-5321 Change-Id: Iea6d7a5d9ab709040e65ed07029f965108677243

4 years

[tribe29/checkmk] 6e8a1d: 11391 Redis agent plugin now supports databases li...

by Óscar Nájera

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6e8a1ddd9c55f46971e3640a773351948099ef1a https://github.com/tribe29/checkmk/commit/6e8a1ddd9c55f46971e3640a773351948… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: A .werks/11391 M agents/plugins/mk_redis M checks/redis_info A tests/agent-plugin-unit/test_mk_redis.sh Log Message: ----------- 11391 Redis agent plugin now supports databases listening on unix sockets - Include the option to connect to redis by socket (-s) - Refactor agent to make it test-able in parts - Add new simple test for arguments SUP-4060 Change-Id: I33bbf2a822c3919d6468dd0c3b0e5fddb1d94767

4 years

[tribe29/checkmk] 5bf4ba: Migration of section fritz and of check plugin fri...

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5bf4babee1dd94fdab43cb05560476295e21ce40 https://github.com/tribe29/checkmk/commit/5bf4babee1dd94fdab43cb05560476295… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M checkman/fritz_wan_if M checks/fritz A cmk/base/plugins/agent_based/fritz.py M cmk/base/plugins/agent_based/utils/interfaces.py M tests/unit/checks/test_generic_legacy_conversion.py Log Message: ----------- Migration of section fritz and of check plugin fritz.wan_if to new API CMK-5321 Change-Id: I6481e4e578ad4a279567fa1bc8a341a8fbd3c130

4 years

[tribe29/checkmk] a894dc: Fix regression in error handling / fetcher proto

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a894dcb51380707f9326c31f771fc9e046b02eb6 https://github.com/tribe29/checkmk/commit/a894dcb51380707f9326c31f771fc9e04… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M cmk/fetchers/controller.py Log Message: ----------- Fix regression in error handling / fetcher proto CMK-5316 Change-Id: If35a2bb0cdf311bc7117fa875309991fd17fc972

4 years

[tribe29/checkmk] 66567a: Migration of netapp_api_if

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 66567a49707b1e02346d4e8bcb822c0f8ef884a5 https://github.com/tribe29/checkmk/commit/66567a49707b1e02346d4e8bcb822c0f8… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M checkman/netapp_api_if M checks/netapp_api.include R checks/netapp_api_if A cmk/base/plugins/agent_based/netapp_api_if.py A cmk/base/plugins/agent_based/utils/netapp_api.py R tests/unit/checks/generictests/datasets/netapp_api_if_ontap_auto_speed.py R tests/unit/checks/generictests/datasets/netapp_api_if_physical_regression.py R tests/unit/checks/generictests/datasets/netapp_api_if_regression.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/cmk/base/plugins/agent_based/test_netapp_api_if.py Log Message: ----------- Migration of netapp_api_if CMK-5321 Change-Id: Id464b0d758e8ef043d91bb32549837c02cdfd834 Commit: c101b72753458805031ed30d38b2d49ecc4f7fde https://github.com/tribe29/checkmk/commit/c101b72753458805031ed30d38b2d49ec… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M agents/wnx/src/common/cfg_yaml.h M agents/wnx/src/engine/modules.cpp Log Message: ----------- Fix some unit tests for Python module Change-Id: I767e1a12cc2229e19e991f1669fe1d102834412f Commit: 604c2c1af3dce3dbef808f9997dc36747c65b783 https://github.com/tribe29/checkmk/commit/604c2c1af3dce3dbef808f9997dc36747… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M checkman/hp_msa_if M checks/hp_msa.include R checks/hp_msa_if A cmk/base/plugins/agent_based/hp_msa_if.py A cmk/base/plugins/agent_based/utils/hp_msa.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/cmk/base/plugins/agent_based/utils/test_hp_msa.py Log Message: ----------- Migration of hp_msa_if This change also fixes a bug in parse_hp_msa in hp_msa.include CMK-5321 Change-Id: Ieb2ba4f28be8931fbd0167fe20fa53042efc4ef5 Compare: https://github.com/tribe29/checkmk/compare/c6bf91b67bb8...604c2c1af3dc

4 years

[tribe29/checkmk] ec7ab7: 11365 FIX vms_if: Fix broken discovery and check e...

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: ec7ab7e8f24cd9e2e061afce3f0d1c3836fb054d https://github.com/tribe29/checkmk/commit/ec7ab7e8f24cd9e2e061afce3f0d1c383… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: A .werks/11365 M checkman/vms_if R checks/vms_if A cmk/base/plugins/agent_based/vms_if.py M tests/unit/checks/test_generic_legacy_conversion.py Log Message: ----------- 11365 FIX vms_if: Fix broken discovery and check execution A bug in the check <tt>vms_if</tt>, which monitors network interfaces on OpenVMS, prevented the corresponding services from being discovered and resulted in a crash for already discovered services (error message: "TypeError: '<' not supported between instances of 'str' and 'int'"). This bug occurred since 2012 and affects all hosts. With this werk, <tt>vms_if</tt> will again be discovered and work. This change also migrates vms_if to the new API. CMK-5321 Change-Id: I610ab9aa6f1e20c616feef5ce1f245d2d781fa8f Commit: c19b2a1ccc1e2805817cd27ba851b489f7bc8302 https://github.com/tribe29/checkmk/commit/c19b2a1ccc1e2805817cd27ba851b489f… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M checks/logwatch M cmk/base/plugins/agent_based/utils/logwatch.py Log Message: ----------- logwatch: migrate helper Change-Id: I1e0bc69984fcb5691f386f2944dc8ec3469c63b8 Commit: c6bf91b67bb8e0368929ccca53f610b78d2ba9ab https://github.com/tribe29/checkmk/commit/c6bf91b67bb8e0368929ccca53f610b78… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-09-09 (Wed, 09 Sep 2020) Changed paths: M checks/logwatch M cmk/base/plugins/agent_based/logwatch_section.py M cmk/base/plugins/agent_based/utils/logwatch.py Log Message: ----------- rename logwatch.SectionLogwatch Change-Id: I59655d122bf82f8f3c674d166b3d69dfb7dc18fe Compare: https://github.com/tribe29/checkmk/compare/b7fe41516667...c6bf91b67bb8

4 years

← Newer
1
...
29
30
31
32
33
34
35
...
44
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2020