Checkmk git commits September 2020

checkmk-commits@lists.checkmk.com

1 participants
431 discussions

[tribe29/checkmk] 9d02be: Add missing `raise NotImplementedError()` to fetchers

by Christian Haase

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9d02be80536ba0a455ed5e67d90d80dd99ae4b31 https://github.com/tribe29/checkmk/commit/9d02be80536ba0a455ed5e67d90d80dd9… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/fetchers/_base.py Log Message: ----------- Add missing `raise NotImplementedError()` to fetchers Change-Id: I0ee8aa42a4b4af38812142ff6f3fd0873379a81c Commit: 64517a3149a409a50392318480535913eec03cf0 https://github.com/tribe29/checkmk/commit/64517a3149a409a50392318480535913e… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/base/checkers/_abstract.py M cmk/fetchers/_base.py Log Message: ----------- API: Try to protect the API with `@final` CMK-5450 Change-Id: I03481049bb4ebcae72a05df9adcdc2e2dcaf7209 Commit: a716fd98373db2e8217df34fcf01fb598bb0144c https://github.com/tribe29/checkmk/commit/a716fd98373db2e8217df34fcf01fb598… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/checkers/_abstract.py M cmk/base/checkers/_checkers.py M cmk/base/checkers/agent.py M cmk/base/checkers/ipmi.py M cmk/base/checkers/piggyback.py M cmk/base/checkers/programs.py M cmk/base/checkers/snmp.py M cmk/base/checkers/tcp.py M cmk/base/discovery.py M cmk/base/inventory.py M cmk/base/modes/check_mk.py M cmk/fetchers/__init__.py M cmk/fetchers/_base.py M cmk/fetchers/ipmi.py M cmk/fetchers/piggyback.py M cmk/fetchers/program.py M cmk/fetchers/snmp.py M cmk/fetchers/tcp.py M tests/unit/cmk/base/checkers/conftest.py M tests/unit/cmk/base/checkers/test_agent.py M tests/unit/cmk/base/checkers/test_cmd_caching.py M tests/unit/cmk/base/checkers/test_tcp_data_source.py M tests/unit/cmk/base/test_modes_check_mk.py M tests/unit/cmk/fetchers/test_fetchers.py Log Message: ----------- API: Localize FileCache serialize and deserialize This change moves the serialization part of FileCache to the FileCache class, where the deserialization already was. On top of the better maintainability, this change brings a series of general improvements: - Typing of FileCache is stricter and safer: It is not possible anymore to instantiate, for example, PiggyBack with a DefaultAgentFileCache, &c. - Also regarding typing: The sources now explicitly instantiate and return the correct FileCache type. - The sources now directly instantiate FileCache objects instead of going through serialization and deserialization. - The new API is consistent with the other factories (parser, summarizer, &c.) - The new API should also let us change the `__init__` of the FileCache classes, for example by emptying NoCache.__init__(). We still group the global variables in a FileCacheFactory class. The class may be removed once the globals are not global anymore. CMK-5450 Change-Id: I463b392a6efb6c23e1fa5d67297ecf6c6d1963ce Commit: d520105ddb80233d1d54f1d4a9272468d86eb6f3 https://github.com/tribe29/checkmk/commit/d520105ddb80233d1d54f1d4a9272468d… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/fetchers/ipmi.py M cmk/fetchers/piggyback.py M cmk/fetchers/program.py M cmk/fetchers/snmp.py M cmk/fetchers/tcp.py M tests/unit/cmk/fetchers/test_fetchers.py Log Message: ----------- API: Improve Fetcher API We make the field of the Fetchers public and final. As it comes from outside anyway, it is not the Fetcher's responsibility to hide it. Even when it was private, the values were actually displayed by `__repr__()`. The remaining private attributes clarify the intent of the class. The public attributes make the Fetchers fully black-box testable. It should also makes sense to the user that a TCP fetcher, for example, has an `address` and an `encryption_settings` attribute. This also lets us fix some typing issues. Now, the Fetchers are also more consistent with args/kwargs in `__init__()`. CMK-5450 Change-Id: I20cb90ab9c1276925ca4a3fc2f1432da095679e4 Commit: 8e528ede6371e786dc0c1fcd8b6d80bd91ed7802 https://github.com/tribe29/checkmk/commit/8e528ede6371e786dc0c1fcd8b6d80bd9… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/base/checkers/_abstract.py M cmk/base/checkers/fetcher_configuration.py M cmk/base/checkers/ipmi.py M cmk/base/checkers/piggyback.py M cmk/base/checkers/programs.py M cmk/base/checkers/snmp.py M cmk/base/checkers/tcp.py M cmk/fetchers/__init__.py M cmk/fetchers/_base.py M cmk/fetchers/ipmi.py M cmk/fetchers/piggyback.py M cmk/fetchers/program.py M cmk/fetchers/snmp.py M cmk/fetchers/tcp.py M tests/unit/cmk/base/checkers/test_agent.py M tests/unit/cmk/base/checkers/test_tcp_data_source.py M tests/unit/cmk/fetchers/test_fetchers.py Log Message: ----------- API: Serialize and deserialize Fetcher in Fetcher This consolidates the API in that the serialization and deserialization methods are in the same class. This also lets us separate concerns (serialization and instantiation of the Fetcher in a Source) better. Instantiating a Fetcher directly from a source does not perform the useless serialization / deserialization steps anymore. The API is also now more consistent and therefore easier to learn. CMK-5450 Change-Id: I8d02fe363cb49a4ae3f3ce0df2fc6fdff7d4c813 Commit: e7090925128a56e12c7728bf036f43d1f46ffeb6 https://github.com/tribe29/checkmk/commit/e7090925128a56e12c7728bf036f43d1f… Author: Christian Haase <c.haase(a)ifu.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M docker/docker-entrypoint.sh Log Message: ----------- Abort docker-entrypoint script when a hook fails Change-Id: I24c8ed9c3959c8d2a9e1fffb5e9a964b15315cdc Commit: c23423a990ee13ceca611d7c0e87f696d51460c2 https://github.com/tribe29/checkmk/commit/c23423a990ee13ceca611d7c0e87f696d… Author: Christian Haase <c.haase(a)ifu.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M docker/docker-entrypoint.sh Log Message: ----------- Add very early docker-entrypoint hook Change-Id: I64e26b8e0751cd7fc85a7d46158b25e00ec57b6d Compare: https://github.com/tribe29/checkmk/compare/1fe5e400caeb...c23423a990ee

3 years, 12 months

[tribe29/checkmk] 6f6924: Cleanup for menus regarding agent files

by Jonas Kluger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6f6924eaa036bbc5366edd0b3666148652229e36 https://github.com/tribe29/checkmk/commit/6f6924eaa036bbc5366edd0b366614865… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/gui/wato/pages/download_agents.py Log Message: ----------- Cleanup for menus regarding agent files * Use the correct names for titles and topics * Filter the files correctly on the different pages * If the agent bakery is present it is now the first entry in the dropdown Change-Id: I4ebda295a5c68fea76a0f54cbaf960a733f65cd2 Commit: e155ebf1b5fd9164e7708e222efa5d382ec88d66 https://github.com/tribe29/checkmk/commit/e155ebf1b5fd9164e7708e222efa5d382… Author: Jonas Kluger <jonas.kluger(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M web/htdocs/js/modules/figures/cmk_table.js M web/htdocs/themes/facelift/scss/_cmk_figures.scss Log Message: ----------- ntop: add loading wheel while fetching data Change-Id: I6fad4ebf6e759b3167641b5547ab6994c5ee3fe5 Commit: 1fe5e400caebcef32dda01d825b63676d9d06078 https://github.com/tribe29/checkmk/commit/1fe5e400caebcef32dda01d825b63676d… Author: Jonas Kluger <jonas.kluger(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M web/htdocs/themes/facelift/scss/_cmk_figures.scss Log Message: ----------- ntop: fix loading wheel Change-Id: Ib718b9ab7264b0f080aab8808bfa883328f151c1 Compare: https://github.com/tribe29/checkmk/compare/d3934283f5fb...1fe5e400caeb

3 years, 12 months

[tribe29/checkmk] d39342: Migrate oracle_tablespaces: Do the migration

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d3934283f5fbbd08b26acb2a53db9391fed35adb https://github.com/tribe29/checkmk/commit/d3934283f5fbbd08b26acb2a53db9391f… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: R checks/oracle_tablespaces A cmk/base/plugins/agent_based/oracle_tablespaces.py M cmk/base/plugins/agent_based/utils/oracle.py M cmk/utils/migrated_check_variables.py M tests/testlib/base.py R tests/unit/checks/generictests/datasets/oracle_tablespaces.py M tests/unit/checks/test_generic_legacy_conversion.py A tests/unit/cmk/base/plugins/agent_based/test_oracle_tablespaces.py Log Message: ----------- Migrate oracle_tablespaces: Do the migration CMK-5268 Change-Id: I141ff2924268cec4cacf1e71bae106315376ab7b

3 years, 12 months

[tribe29/checkmk] b0cf66: Fixed two typos for NGINX

by rb

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: b0cf66fb709a7c777249330476b67e3e2fd123e5 https://github.com/tribe29/checkmk/commit/b0cf66fb709a7c777249330476b67e3e2… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M agents/cfg_examples/nginx_status.cfg Log Message: ----------- Fixed two typos for NGINX Change-Id: Iaa53616024488b0efb31d4cf88c54c9b8cbcd482

3 years, 12 months

[tribe29/checkmk] d7f46b: Extend help texts for rules of hosts and services

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d7f46bcd925ca7d165a7ae087274e60f61738217 https://github.com/tribe29/checkmk/commit/d7f46bcd925ca7d165a7ae087274e60f6… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/gui/plugins/wato/active_checks.py M cmk/gui/plugins/wato/builtin_modules.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/watolib/rulespecs.py Log Message: ----------- Extend help texts for rules of hosts and services Change-Id: I282347d46fad9cc81d417e282c8f4ed7dd4d9d29

3 years, 12 months

[tribe29/checkmk] 2dada2: Remove comments in SVGs

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2dada2921866cbcec890686b7c618bb29f3e147f https://github.com/tribe29/checkmk/commit/2dada2921866cbcec890686b7c618bb29… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M web/htdocs/themes/facelift/images/icon_main_cmk_dashboard.svg M web/htdocs/themes/facelift/images/icon_main_customize.svg M web/htdocs/themes/facelift/images/icon_main_dashboard.svg M web/htdocs/themes/facelift/images/icon_main_folder.svg M web/htdocs/themes/facelift/images/icon_main_help.svg M web/htdocs/themes/facelift/images/icon_main_monitoring.svg M web/htdocs/themes/facelift/images/icon_main_problems.svg M web/htdocs/themes/facelift/images/icon_main_search.svg M web/htdocs/themes/facelift/images/icon_main_setup.svg M web/htdocs/themes/facelift/images/icon_main_user.svg M web/htdocs/themes/facelift/images/icon_show_less.svg M web/htdocs/themes/facelift/images/icon_show_more.svg M web/htdocs/themes/facelift/images/tribe29_icon.svg M web/htdocs/themes/modern-dark/images/icon_main_cmk_dashboard.svg M web/htdocs/themes/modern-dark/images/icon_main_customize.svg M web/htdocs/themes/modern-dark/images/icon_main_dashboard.svg M web/htdocs/themes/modern-dark/images/icon_main_folder.svg M web/htdocs/themes/modern-dark/images/icon_main_help.svg M web/htdocs/themes/modern-dark/images/icon_main_monitoring.svg M web/htdocs/themes/modern-dark/images/icon_main_problems.svg M web/htdocs/themes/modern-dark/images/icon_main_search.svg M web/htdocs/themes/modern-dark/images/icon_main_setup.svg M web/htdocs/themes/modern-dark/images/icon_main_user.svg M web/htdocs/themes/modern-dark/images/icon_show_less.svg M web/htdocs/themes/modern-dark/images/icon_show_more.svg Log Message: ----------- Remove comments in SVGs Change-Id: I8fe6c3d8d76e1e145d97f1ed5458ea9502149802

3 years, 12 months

[tribe29/checkmk] 46282a: [CMK-5458] - prevent long line formatted output by...

by Moritz

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 46282aceac5477a39e16339603a530dff71ed366 https://github.com/tribe29/checkmk/commit/46282aceac5477a39e16339603a530dff… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M agents/windows/plugins/windows_tasks.ps1 Log Message: ----------- [CMK-5458] - prevent long line formatted output by Powershell This "format long lines" behavior of Powershell may break our checks on Monitoring Site Minor fix: added support for English(UK) language. Also SUP-3895 Change-Id: I70a59cc98021a8438d7446936f841b0ed594a940 Commit: a7e85d5ccf4656f8c4de7aed1be3973b4973641d https://github.com/tribe29/checkmk/commit/a7e85d5ccf4656f8c4de7aed1be3973b4… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: A .werks/11115 M checks/agent_bi Log Message: ----------- 11115 FIX agent_bi: Filter by groups Filtering aggregations by groups using the datasource program rule in the WATO had not been working. Change-Id: Id1a0af9eab460a419d3d764627b5f2bda0703516 Compare: https://github.com/tribe29/checkmk/compare/652a0a8eeae2...a7e85d5ccf46

3 years, 12 months

[tribe29/checkmk] 693218: Move rulesets from Host Checks/Service Checks to V...

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6932184ff0b89505f666bbf9f843a705f15d37bd https://github.com/tribe29/checkmk/commit/6932184ff0b89505f666bbf9f843a705f… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/wato/mkeventd.py Log Message: ----------- Move rulesets from Host Checks/Service Checks to Various * Alternative display name for services: from Notifications to Various * Notes URL for services: from Notifications to Various * Clustered services: from Discovery and Checkmk settings to Various * Notes URL for hosts: from Notifications to Various * Host labels: from Host Checks to Various * Service Level of hosts: from Host Checks to Various * Assign SLA definition to service: from Service Checks to Various * Custom service attributes: move from Service Checks to Various * Service labels: move from Service Checks to Various * Service tags: move from Service Checks to Various * Service Levels of service: move from Service Checks to Various Change-Id: I01d2015b9c52851ae204d2ac660b45eebd1d0108 Commit: cfcd97c2e4f75753f47ba0e7b3d6a0b0a5d57010 https://github.com/tribe29/checkmk/commit/cfcd97c2e4f75753f47ba0e7b3d6a0b0a… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: A .werks/11115 M checks/agent_bi Log Message: ----------- 11115 FIX agent_bi: Filter by groups Filtering aggregations by groups using the datasource program rule in the WATO had not been working. Change-Id: Id1a0af9eab460a419d3d764627b5f2bda0703516 Compare: https://github.com/tribe29/checkmk/compare/c93f78578142...cfcd97c2e4f7

3 years, 12 months

[tribe29/checkmk] 652a0a: Update werk

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 652a0a8eeae2026a9f911cff3e7e66710bd9886e https://github.com/tribe29/checkmk/commit/652a0a8eeae2026a9f911cff3e7e66710… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M .werks/11460 Log Message: ----------- Update werk Change-Id: I465d1c68b755b51d90d862ed13a3b570ed03181b

3 years, 12 months

[tribe29/checkmk] c93f78: Update werk

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c93f7857814257cd4314e77a24a947bfea064d2d https://github.com/tribe29/checkmk/commit/c93f7857814257cd4314e77a24a947bfe… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M .werks/11460 Log Message: ----------- Update werk Change-Id: I465d1c68b755b51d90d862ed13a3b570ed03181b

3 years, 12 months

← Newer
1
...
12
13
14
15
16
17
18
...
44
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2020