Checkmk git commits August 2020

checkmk-commits@lists.checkmk.com

1 participants
411 discussions

[tribe29/checkmk] 9252d7: Fix integration test test_bulk_discovery_start_wit...

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9252d7db74a75ad1cd2ad9d3ecedc5672cd12433 https://github.com/tribe29/checkmk/commit/9252d7db74a75ad1cd2ad9d3ecedc5672… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M tests/integration/cmk/gui/test_webapi.py Log Message: ----------- Fix integration test test_bulk_discovery_start_with_parameters This test was broken by the migration of livestatus_status. Change-Id: I3b9bc9a4e46d79ebaa5e1782cec30b288a58ebeb

4 years, 1 month

[tribe29/checkmk] 070baf: Added WK11410

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 070baf7a7f8e5fffa0a768270b8425016622f3fd https://github.com/tribe29/checkmk/commit/070baf7a7f8e5fffa0a768270b8425016… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: A .werks/11410 M cmk/gui/wato/pages/tags.py Log Message: ----------- Added WK11410 Change-Id: I76dd707fef32d6d6f4e10949f8a4fc159d244450

4 years, 1 month

[tribe29/checkmk] 7cbf78: Improve suggestion buttons

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7cbf788eca0f8d4f8cd70de52f4dd1e3bebde7bf https://github.com/tribe29/checkmk/commit/7cbf788eca0f8d4f8cd70de52f4dd1e3b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- Improve suggestion buttons * Fix hover effect * Click effect is now on the whole button, not only the central area Change-Id: Ied1663279fd2ecdd90e3e6eb6d46b3390c914f27 Commit: c44e8349e8116896f3de396b4554df7b1fac05dd https://github.com/tribe29/checkmk/commit/c44e8349e8116896f3de396b4554df7b1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/gui/wato/user_profile.py Log Message: ----------- Fix saving of user profile pages Change-Id: I007b710a1a881a929b6708d0b1ff0d83e73b31fc Commit: da8db53cdc45610db977de373c6a9d11cfd0811d https://github.com/tribe29/checkmk/commit/da8db53cdc45610db977de373c6a9d11c… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M web/htdocs/themes/facelift/scss/_mega_menu.scss M web/htdocs/themes/facelift/scss/_page_menu.scss M web/htdocs/themes/facelift/scss/_snapins.scss M web/htdocs/themes/facelift/scss/_variables.scss M web/htdocs/themes/modern-dark/scss/_variables.scss Log Message: ----------- Fix several glitches in modern theme Change-Id: Ib21e396a13ec6e93e106f12bd3fb158bc1619cfd Commit: 49ec75f6f3a27d95013c33f9e27318cd62320a17 https://github.com/tribe29/checkmk/commit/49ec75f6f3a27d95013c33f9e27318cd6… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M web/htdocs/themes/facelift/scss/_mega_menu.scss M web/htdocs/themes/facelift/scss/_sidebar.scss Log Message: ----------- Add a little more space to side fold link Change-Id: Ie96134f9435684ace996ab094d2f6f6a278a2942 Commit: 1ea108220fa9e41aae973d64ccfd09a360bc185e https://github.com/tribe29/checkmk/commit/1ea108220fa9e41aae973d64ccfd09a36… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/gui/plugins/dashboard/builtin.py M cmk/gui/plugins/views/builtin.py Log Message: ----------- Clarify view titles and reorder history topic Change-Id: Id8b79bafcd22d02a43d7916b93157afe5a57845f Commit: 776b3dd3b66de5c7c00d7f16c39d47cefe81a2f7 https://github.com/tribe29/checkmk/commit/776b3dd3b66de5c7c00d7f16c39d47cef… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: R .werks/10545 M cmk/gui/watolib/host_attributes.py Log Message: ----------- Revert "Added WK10545: improved performance when sorting wato hosttag groups" This reverts commit b1339a5ef83e2ec045164e9be69ff87fec527871. Commit: 97484b14ede34643cab3cc30e20c32592c83c9de https://github.com/tribe29/checkmk/commit/97484b14ede34643cab3cc30e20c32592… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/gui/pagetypes.py R web/htdocs/themes/facelift/images/icon_new_bookmark_list.png R web/htdocs/themes/facelift/images/icon_new_custom_graph.png R web/htdocs/themes/facelift/images/icon_new_custom_snapin.png R web/htdocs/themes/facelift/images/icon_new_forecast_graph.png R web/htdocs/themes/facelift/images/icon_new_graph_collection.png R web/htdocs/themes/facelift/images/icon_new_graph_tuning.png R web/htdocs/themes/facelift/images/icon_new_pagetype_topic.png R web/htdocs/themes/facelift/images/icon_new_sla_configuration.png Log Message: ----------- Remove page type specific new icon The icons were clear together with the label but not in the shortcut bar. Changing them all to use the standard icon for adding new objects. Change-Id: I21c537925ad5d4823e5d589a4c0b8afa8af81d01 Compare: https://github.com/tribe29/checkmk/compare/d63716c3518c...97484b14ede3

4 years, 1 month

[tribe29/checkmk] 82d827: Phase make_checkers out

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 82d82714df8a83166411c1609d2c29f15e329f83 https://github.com/tribe29/checkmk/commit/82d82714df8a83166411c1609d2c29f15… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/core_nagios.py M cmk/base/data_sources/fetcher_configuration.py M cmk/base/dump_host.py Log Message: ----------- Phase make_checkers out In the new API, `make_checkers` is never what ones really want. This patches the most obvious calls to make_checkers. The remaining ones require larger changes in the code base. CMK-5275 Change-Id: Ibfab2c1ebad446449a8a341261afd6dd4695481a Commit: d63716c3518ccbd40c2e21c3c93e6115d2ab77cd https://github.com/tribe29/checkmk/commit/d63716c3518ccbd40c2e21c3c93e6115d… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/dump_host.py Log Message: ----------- Do to do - list comprehension Change-Id: I8b5107f31974db3b7c31c0d6d54358807f0f2009 Compare: https://github.com/tribe29/checkmk/compare/ed985063bb67...d63716c3518c

4 years, 1 month

[tribe29/checkmk] 22d69b: Add suggested links to WATO hosts list

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 22d69b179fd7a4112adff52e59498b2ecbd6114f https://github.com/tribe29/checkmk/commit/22d69b179fd7a4112adff52e59498b2ec… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/gui/wato/pages/folders.py Log Message: ----------- Add suggested links to WATO hosts list Change-Id: Ie23465799791ed2b65ce8c0a3c0d545bdd380213 Commit: 19b564195f42702795245e7f206ce0abea633d42 https://github.com/tribe29/checkmk/commit/19b564195f42702795245e7f206ce0abe… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/gui/page_menu.py M web/htdocs/themes/facelift/images/icon_suggestion.png M web/htdocs/themes/facelift/scss/_page_menu.scss A web/htdocs/themes/modern-dark/images/icon_suggestion.png Log Message: ----------- Improve suggested actions * All shortcut links are now also suggested actions. This makes the suggested toggle button a toggle between two display modes. * Update the suggested icon to some hopefully more meaningful * Move suggested toggle icon to the beginning of the shortcuts to make swapping between both states easier Change-Id: I142d7d3e026d93e5c2b24dd4f614616708437d92 Commit: ed985063bb67f416a98c2f401a4de334dc7b1630 https://github.com/tribe29/checkmk/commit/ed985063bb67f416a98c2f401a4de334d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/gui/page_menu.py Log Message: ----------- Suggested entries can now render popup triggers Change-Id: I2da56a167c417756ab1261455150f7b829d28fb6 Compare: https://github.com/tribe29/checkmk/compare/57620f32455e...ed985063bb67

4 years, 1 month

[tribe29/checkmk] 57620f: Fix unit test for inventory plugin inv_checkmk

by Timotheus Bachinger

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 57620f32455eca3285f237b042189e1232b8bd59 https://github.com/tribe29/checkmk/commit/57620f32455eca3285f237b042189e123… Author: Timotheus Bachinger <timotheus.bachinger(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M tests/unit/cmk/base/plugins/agent_based/test_inv_checkmk.py Log Message: ----------- Fix unit test for inventory plugin inv_checkmk * As Travis tests against Raw edition, the merged sections needed to be adapted Change-Id: I378dce68d3765c198525d15b13e87f8db189ba2e

4 years, 1 month

[tribe29/checkmk] b1339a: Added WK10545: improved performance when sorting w...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b1339a5ef83e2ec045164e9be69ff87fec527871 https://github.com/tribe29/checkmk/commit/b1339a5ef83e2ec045164e9be69ff87fe… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: A .werks/10545 M cmk/gui/watolib/host_attributes.py Log Message: ----------- Added WK10545: improved performance when sorting wato hosttag groups CMK-5214 Change-Id: If0cee37b4f736765a9ac766b76dc3da5ccc8208a Commit: f1716894b020d662f54ff7bff4d2ff552b2aed9d https://github.com/tribe29/checkmk/commit/f1716894b020d662f54ff7bff4d2ff552… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/autochecks.py Log Message: ----------- autochecks parsing: fixed missing maincheckify call Change-Id: I983a236eb4c826201b04de6de718ec7a721eff0b Compare: https://github.com/tribe29/checkmk/compare/c4891ab2c3cb...f1716894b020

4 years, 1 month

[tribe29/checkmk] c00fa4: Added WK10545: improved performance when sorting w...

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: c00fa4d335ff61c91037776f9ea248d9c66e5490 https://github.com/tribe29/checkmk/commit/c00fa4d335ff61c91037776f9ea248d9c… Author: Andreas Boesl <andreas.boesl(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: A .werks/10545 M cmk/gui/watolib/host_attributes.py Log Message: ----------- Added WK10545: improved performance when sorting wato hosttag groups CMK-5214 Change-Id: If0cee37b4f736765a9ac766b76dc3da5ccc8208a

4 years, 1 month

[tribe29/checkmk] 944ade: 11361 Reworking of discovery rulesets for network ...

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 944adeb17e689c61c9d8933ca59e99dba0b6ab95 https://github.com/tribe29/checkmk/commit/944adeb17e689c61c9d8933ca59e99dba… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: A .werks/11361 M checkman/lnx_if M checks/if.include R checks/lnx_if M cmk/base/config.py M cmk/base/plugins/agent_based/lnx_if.py M cmk/base/plugins/agent_based/utils/interfaces.py M cmk/gui/plugins/wato/check_parameters/if.py M inventory/lnx_if R tests/unit/checks/generictests/datasets/lnx_if_no_ethtool_regression.py R tests/unit/checks/generictests/datasets/lnx_if_regression.py R tests/unit/checks/generictests/datasets/lnx_if_states_regression.py R tests/unit/checks/generictests/datasets/lnx_if_tunnel_regression.py M tests/unit/checks/test_generic_legacy_conversion.py R tests/unit/checks/test_legacy_lnx_if.py M tests/unit/cmk/base/plugins/agent_based/test_lnx_if.py A tests/unit/cmk/base/plugins/agent_based/utils/test_interfaces.py Log Message: ----------- 11361 Reworking of discovery rulesets for network interfaces and switch ports Title: Reworking of discovery rulesets for network interfaces and switch ports Class: feature Compatible: incomp Component: checks Date: 1596798161 Edition: cre Knowledge: undoc Level: 2 Version: 1.7.0i1 Up to now, the discovery of network interfaces and switch ports was controlled by two main rules: "Network Interface and Switch Port Discovery" (discovery of single interfaces) and "Network interface groups" (grouping of interfaces). With this werk, we integrate "Network interface groups" into "Network Interface and Switch Port Discovery" and rework the latter. The rule "Network interface groups" is now deprecated and not applied any more. The reworked discovery ruleset is split into three parts: the configuration of the discovery of single interfaces, the configuration of interfaces groups and conditions which determine to which interfaces this rule applies. In the following, we explain the changes in more detail. <ul> <li>In the first part, you can activate or deactivate the discovery of single interfaces. You can also configure the way monitored interfaces are represented, i.e., by index, by description or by alias.</li> <li>The second part offers the option to group interfaces. Here, you can specify the names of the groups and they way the corresponding services display their members in the service output (again, by index, by description or by alias). Contrary to before, there is no separate option any more to define interface groups on clusters, since this option was anyway redundant. </li> <li>The third part of the rule determines to which interfaces this rule applies. You can choose to apply this rule to all interfaces or you can set conditions such as a regular expression matching the interface description or a set of port types. Each interface will first determine the set of rules which actually applies to this interface and then merge these rules together, whereby rules higher up in the hierarchy (e.g. rules in subfolders) overwrite rules further below.</li> <li>Note that due to the point above, this rule is a somewhat special case compared to other rulesets in checkmk. Usually, the conditions for a rule to apply are exclusively configured in the section "Conditions". However, here, you can set additional, interface-specific conditions, which offer a finer control over the discovery process.</li> </ul> This change is incompatible. It affects the following checks: <tt>aix_if</tt>, <tt>brocade_optical</tt>, <tt>emc_vplex_if</tt>, <tt>esx_vsphere_counters</tt>, <tt>fritz</tt>, <tt>hitachi_hnas_fc_if</tt>, <tt>hp_msa_if</tt>, <tt>hpux_if</tt>, <tt>if</tt>, <tt>if64</tt>, <tt>if64adm</tt>, <tt>if64_tplink</tt>, <tt>if_brocade</tt>, <tt>if_fortigate</tt>, <tt>if_lancom</tt>, <tt>lnx_if</tt>, <tt>mcdata_fcport</tt>, <tt>netapp_api_if</tt>, <tt>statgrab_net</tt>, <tt>ucs_bladecenter_if</tt>, <tt>vms_if</tt>, <tt>winperf_if</tt>. For users monitoring interface groups, this change is definitely incompatible. They have to migrate their current rules for grouping interfaces from the now deprecated ruleset "Network interface groups" to the new discovery ruleset. Note that there is no option any more to discover interface groups <i>instead of</i> the corresponding single interfaces. To reproduce this behavior, configure your interfaces groups and switch off the discovery of single interfaces for the group members. After migrating the grouping rules, these users have to re-discover the services of affected hosts. For all others users monitoring network interfaces, this change might be incompatible. Generally, any already discovered interface services will continue to work. However, depending on the user- defined rules from the (now reworked) ruleset "Network Interface and Switch Port Discovery", some interface services might vanish upon re-discovery or new interface services might appear. In such cases, users have to adapt the new, reworked versions of their user-defined rules. Finally, it is worth nothing that the new ruleset offers the option to match all interfaces, which allows for simplifying some rules. In particular, users might be able to simplify rules where all interface port types and states are selected. This change also migrates the check plugin lnx_if to the new API. CMK-5085 Change-Id: Ib2e70ac1196f90375fbb52dc2c7e0a17449763ee Commit: cb2864a381e58a38f933b5b66e16876c657549ef https://github.com/tribe29/checkmk/commit/cb2864a381e58a38f933b5b66e16876c6… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/api/agent_based/register/section_plugins.py M cmk/base/api/agent_based/type_defs.py M cmk/base/data_sources/snmp.py M cmk/snmplib/type_defs.py M tests/unit/cmk/base/api/agent_based/register/test_section_plugins.py M tests/unit/cmk/base/data_sources/test_snmp_data_source.py A tests/unit/cmk/snmplib/test_snmp_type_defs.py Log Message: ----------- Dynamically compute SNMP detection specifications based on discovery rules This change adds the option to dynamically compute SNMP detection specifications based on user-defined discovery rulesets. This is not an official part of the new API and its usage requires explicit API violations. However, there are checks (for example interface checks) which rely on this legacy functionality. CMK-5181 Change-Id: I55788bdb9fc514cc3011c4fe99404c914c0cba66 Commit: ba0d99df762a060bcf8281e0c8d4329af7253a8a https://github.com/tribe29/checkmk/commit/ba0d99df762a060bcf8281e0c8d4329af… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M tests/unit/cmk/base/data_sources/test_data_sources.py Log Message: ----------- Linting overlooked(?) by Gerrit Change-Id: I0eb4a7110dcf56f964a482d5411704acbd0aa467 Commit: bb1f7ee60f8f80254314c022b8f67257d8488f8b https://github.com/tribe29/checkmk/commit/bb1f7ee60f8f80254314c022b8f67257d… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/data_sources/_abstract.py M cmk/base/data_sources/_data_sources.py M cmk/base/data_sources/agent.py M cmk/base/data_sources/ipmi.py M cmk/base/data_sources/piggyback.py M cmk/base/data_sources/programs.py M cmk/base/data_sources/snmp.py M cmk/base/data_sources/tcp.py M cmk/base/discovery.py M cmk/base/inventory.py M cmk/base/modes/check_mk.py M tests/unit/cmk/base/data_sources/conftest.py M tests/unit/cmk/base/data_sources/test_agent.py M tests/unit/cmk/base/data_sources/test_cmd_caching.py M tests/unit/cmk/base/data_sources/test_host_sections.py M tests/unit/cmk/base/data_sources/test_ipmi_management_board_data_source.py M tests/unit/cmk/base/data_sources/test_piggy_back_data_source.py M tests/unit/cmk/base/data_sources/test_program_data_source.py M tests/unit/cmk/base/data_sources/test_snmp_data_source.py M tests/unit/cmk/base/data_sources/test_tcp_data_source.py Log Message: ----------- Rename DataSource -> Checker Automated, mechanical renaming: ack --python -l DataSource | xargs sed -i 's/DataSource/Checker/g' and yapf. CMK-5244 Change-Id: I442a05a24dcae25e3f219c1b63d73037b38d39f8 Commit: c4891ab2c3cb7961a934f9224508574cf524313b https://github.com/tribe29/checkmk/commit/c4891ab2c3cb7961a934f9224508574cf… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/base/checking.py M cmk/base/core_nagios.py M cmk/base/data_sources/_data_sources.py M cmk/base/data_sources/fetcher_configuration.py M cmk/base/discovery.py M cmk/base/dump_host.py M cmk/base/inventory.py M tests/unit/cmk/base/data_sources/test_host_sections.py Log Message: ----------- Rename make_sources -> make_checkers Automated, mechanical renaming: ack --python -l make_sources | xargs sed -i 's/make_sources/make_checkers/g' CMK-5244 Change-Id: Ie25c11ae74947a5f56114883e881fb794911034c Compare: https://github.com/tribe29/checkmk/compare/e2f5b9869643...c4891ab2c3cb

4 years, 1 month

[tribe29/checkmk] e2f5b9: "make_kwargs_for":replace getfullargspec with sign...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: e2f5b98696432678d4929878ccf97a1dcada9730 https://github.com/tribe29/checkmk/commit/e2f5b98696432678d4929878ccf97a1dc… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M cmk/utils/misc.py Log Message: ----------- "make_kwargs_for":replace getfullargspec with signature().parameters inspect.getfullargspec is incompatible to decorated functions, even if the wrapper itself got decorated with functools.wraps(). inspect.signature().parameters is compatible to this scenario and returns the correct arguments of the wrapped function. Change-Id: I8774a7e188b5882a750f1800a1063ad427cce1be

4 years, 1 month

← Newer
1
...
6
7
8
9
10
11
12
...
42
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits August 2020