Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 4e6d3cabb09b6514460b18b2679b3f40f483242a
https://github.com/tribe29/checkmk/commit/4e6d3cabb09b6514460b18b2679b3f40f…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/base/data_sources/_abstract.py
M cmk/base/data_sources/agent.py
M cmk/base/data_sources/snmp.py
M cmk/base/inventory.py
M cmk/base/modes/check_mk.py
Log Message:
-----------
Revert "Handle fetcher exceptions in the caller"
This reverts commit d3ad1518af961fbf625f323f14f78184e8b39d55.
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: d3ad1518af961fbf625f323f14f78184e8b39d55
https://github.com/tribe29/checkmk/commit/d3ad1518af961fbf625f323f14f78184e…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/base/data_sources/_abstract.py
M cmk/base/data_sources/agent.py
M cmk/base/data_sources/snmp.py
M cmk/base/inventory.py
M cmk/base/modes/check_mk.py
Log Message:
-----------
Handle fetcher exceptions in the caller
Fetcher exceptions should not be raise from the modes.
Before the fetcher/checker split, exception from the fetchers were kept
in the checker. This patch simulates this behavior but moves the
exception handling to the caller as the checkers do not call
Fetcher.fetch() anymore.
CMK-5243
Change-Id: I97ce00b76e88081377ded481bfff08314397cd3f
Branch: refs/heads/1.6.0
Home: https://github.com/tribe29/checkmk
Commit: dd8a7f0dab6b797716d7966a6278be23b85a1be0
https://github.com/tribe29/checkmk/commit/dd8a7f0dab6b797716d7966a6278be23b…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/wato/pages/host_diagnose.py
Log Message:
-----------
Re-enable transaction checking
It was recently disabled during testing and not enabled again.
Change-Id: I78bbb4628b134eede692253ed34e8319e709bdef
Commit: a9c52a2a073b446bedf6efbd14836d9350a83ad0
https://github.com/tribe29/checkmk/commit/a9c52a2a073b446bedf6efbd14836d935…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
A .werks/11259
M cmk/gui/wato/pages/host_diagnose.py
M cmk/gui/wato/pages/hosts.py
Log Message:
-----------
11259 FIX Fix host "Save & Test" action showing "API error" for all tests
The host diagnostic page was initially showing the message "API Error: The text
None is not a valid integer number." after adding or editing a host and
confirming the dialog with the "Save & Test" button.
This regression was introduced by werk #11254 in version 1.6.0p15.
You could workaround this issue by clicking the "Test" button on the page
showing that error. It will start the tests in the correct way.
Change-Id: I8042b0bd2de35bff2d55b4cff41131147fd6a47c
Compare: https://github.com/tribe29/checkmk/compare/5b66a329959d...a9c52a2a073b
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: c42f387cd28c8ba4df5f3e66e87e47b6b44a0f9d
https://github.com/tribe29/checkmk/commit/c42f387cd28c8ba4df5f3e66e87e47b6b…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/base/exceptions.py
Log Message:
-----------
Let MKAgentError derive from MKFetcherError
Exceptions deriving MKAgentError such as MKEmptyAgentData are indeed
fetcher errors so that it makes sense to have agent errors simply be
fetcher errors as well.
CMK-5243
Change-Id: I72eb7ade043b4471eefdef01596381a968dda3f0
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: d748ed89d20535657e62f3704d3bb586afa40c37
https://github.com/tribe29/checkmk/commit/d748ed89d20535657e62f3704d3bb586a…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/wato/__init__.py
M cmk/gui/wato/pages/groups.py
Log Message:
-----------
Groups: Move save buttons to page menu
Along the way: Mark the abstract base class to be one.
Change-Id: I4a1633a171fc219a6abdabe77b5dc69281c4359e
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: a9216fe387454c373648aab07cfa7a7eb136ff18
https://github.com/tribe29/checkmk/commit/a9216fe387454c373648aab07cfa7a7eb…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/base/decorator.py
Log Message:
-----------
Let `cmk.base.decorator` handle MKFetcherError
In the split between fetchers and checkers, we also split the exceptions
MKAgentError into MKAgentError and MKFetcherError to better reflect the
layering. Now, code that used to only handle MKAgentError must now also
handle MKFetcherError.
This patch should further fix an integration test.
CMK-5243
Change-Id: Id75357a71cc73ccf579853686967e4940ad541bd
Commit: ade6886db1ea27d349647bdbb0288f045532a5e6
https://github.com/tribe29/checkmk/commit/ade6886db1ea27d349647bdbb0288f045…
Author: Marcel Arentz <marcel.arentz(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M agents/plugins/mk_oracle
Log Message:
-----------
extended bash 3.2 compatibility
Change-Id: I0625994dc74b018eb45cad477bdbf6d49962f5ab
Compare: https://github.com/tribe29/checkmk/compare/426a8c5b0211...ade6886db1ea
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 1b8a8f1278a922045f8723e1e0ec3ccc5bd1e9b1
https://github.com/tribe29/checkmk/commit/1b8a8f1278a922045f8723e1e0ec3ccc5…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/base/data_sources/_abstract.py
M cmk/base/data_sources/_data_sources.py
M cmk/base/data_sources/snmp.py
M cmk/base/inventory.py
M tests/unit/cmk/base/data_sources/test_data_sources.py
M tests/unit/cmk/base/data_sources/test_host_sections.py
Log Message:
-----------
Replace DataSource.run() callers
Now, `DS.check(RawData)` and `DS.run()` are duplicates. But
`DS.check(RawData)` is more consistent with the new API as it
clarifies the distinction between fetching and checking. We
therefore replace the calls to `run()` with calls to `fetch() ->
RawData` and `check(RawData)`.
In a following patch, we can finally remove `run()` and its callees.
CMK-5243
Change-Id: I5713c1161ad39c3645a7f62caf5b29d69f70e6cf
Commit: 426a8c5b0211015c58e70b9cb1c87bd99c1db6ad
https://github.com/tribe29/checkmk/commit/426a8c5b0211015c58e70b9cb1c87bd99…
Author: Mathias Laurin <mathias.laurin(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/base/data_sources/_abstract.py
M cmk/base/data_sources/ipmi.py
M cmk/base/data_sources/piggyback.py
M cmk/base/data_sources/programs.py
M cmk/base/data_sources/snmp.py
M cmk/base/data_sources/tcp.py
Log Message:
-----------
Remove obsolete methods
- run()
- _run()
- _execute()
are obsoleted by `Fetcher.fetch() -> RawData` and
`DataSource.check(RawData)`
CMK-5243
Change-Id: I5f819aec228525f7fcf3ff4e404f19babe09961a
Compare: https://github.com/tribe29/checkmk/compare/b6160c7428a5...426a8c5b0211
Branch: refs/heads/master
Home: https://github.com/tribe29/checkmk
Commit: 135afce481a5b975f7f6473a5ac6e9f40f548a9b
https://github.com/tribe29/checkmk/commit/135afce481a5b975f7f6473a5ac6e9f40…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/page_menu.py
M cmk/gui/plugins/views/availability.py
M cmk/gui/views.py
M cmk/gui/werks.py
M web/htdocs/js/modules/page_menu.js
M web/htdocs/js/modules/utils.js
M web/htdocs/themes/facelift/scss/_page_menu.scss
Log Message:
-----------
Generalized side popup
Instead of individually caring about making the the side popups
scrollable, this is now done automatically by the generic code.
A side popup is now added by explicitly using a page menu item
PageMenuSidePopup.
The side popup now automatically gets the class "side_popup" assigned.
The side popup now needs to have a div element with the class
"side_popup_content". This is being made scrollable and handled with
SimpleBar automatically.
Change-Id: I46646a0666bbebfb5cfeeecfb73eb51e46dc7979
Commit: 51e444021e0b3ba014d2ce23db8224b2b3f48f11
https://github.com/tribe29/checkmk/commit/51e444021e0b3ba014d2ce23db8224b2b…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M web/htdocs/themes/facelift/scss/_dashboard.scss
M web/htdocs/themes/facelift/scss/_main.scss
M web/htdocs/themes/facelift/scss/_page_menu.scss
M web/htdocs/themes/facelift/scss/_views.scss
Log Message:
-----------
Simplify floatfilter styling
The old floatfilter styling is not needed anymore. We also don't
need the old override logic of the classic > modern themes anymore.
This and the new UX styling makes it possible to drop a lot of
redundant / ineffective declarations and simplify things.
Change-Id: I93261fcb19901c2a95978106f6e9e3626164e365
Commit: ccf290c94a8709737cba247681013069710c8538
https://github.com/tribe29/checkmk/commit/ccf290c94a8709737cba2476810130697…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/dashboard.py
Log Message:
-----------
Extract dasboard specific filter computations from form rendering
Change-Id: I150d1773fdf59a44e4214a9369c3ef1684ed340c
Commit: 067c695caedf8d295cc67d6240b8341ca85e2191
https://github.com/tribe29/checkmk/commit/067c695caedf8d295cc67d6240b8341ca…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/dashboard.py
M web/htdocs/themes/facelift/scss/_dashboard.scss
Log Message:
-----------
Use side popup for dashboard context filtering
This allows removal of dashboard context dialog specific CSS styles.
With some more changes it will be possible to consolidate the dashboard
and view filter dialogs.
Change-Id: Ife12154097f9417181aabf08a109df8152a27198
Commit: b551060a342cce4ff97a2c4a630cdb79611fac54
https://github.com/tribe29/checkmk/commit/b551060a342cce4ff97a2c4a630cdb796…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/dashboard.py
M cmk/gui/views.py
M cmk/gui/visuals.py
Log Message:
-----------
Consolidate view and dashboard filter forms
Change-Id: I30f79854f6e14aea3d2131b995c667339db91e67
Commit: 9f072934d57b1d132c2c1c3479863391130db56d
https://github.com/tribe29/checkmk/commit/9f072934d57b1d132c2c1c34798633911…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/page_menu.py
M cmk/gui/wato/pages/rulesets.py
A web/htdocs/themes/facelift/images/icon_export.png
Log Message:
-----------
Add page menu to remaining rule pages
Change-Id: Iae62028c61cc0386790e0b0799a915be87a39751
Commit: 2544fd6ad99c83958057a69b7ab86c6299e709c4
https://github.com/tribe29/checkmk/commit/2544fd6ad99c83958057a69b7ab86c629…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/wato/pages/read_only.py
Log Message:
-----------
Add page menu to read-only mode
Change-Id: I4de97d91f51032454dacf2c432af580d6073a08e
Commit: 604141e8440400027f9f0f67fe69fc108169fd92
https://github.com/tribe29/checkmk/commit/604141e8440400027f9f0f67fe69fc108…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/wato/pages/timeperiods.py
Log Message:
-----------
Add page menu to time period modes
Change-Id: Ieee0e5d6caf73f552cd54ecc632750af9dc8c83a
Commit: baf715012196d3c59670fb6ccbf57e4f37eb4c07
https://github.com/tribe29/checkmk/commit/baf715012196d3c59670fb6ccbf57e4f3…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/wato/pages/tags.py
Log Message:
-----------
Add page menu to tag modes
Change-Id: I8150776fe6c2d11dfd4726335eceaa5fa71cda01
Commit: 9bfbf43bd72c7b234c6591ea68931f88259c7fdb
https://github.com/tribe29/checkmk/commit/9bfbf43bd72c7b234c6591ea68931f882…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M cmk/gui/notify.py
M cmk/gui/wato/pages/users.py
Log Message:
-----------
Add page menu to user modes
Change-Id: If7044d294eafcfe4f0bd037a574f3db2429d0025
Commit: 9bb5f6354a5b3d851349d3aab3ed92cf42960766
https://github.com/tribe29/checkmk/commit/9bb5f6354a5b3d851349d3aab3ed92cf4…
Author: Lars Michelsen <lm(a)tribe29.com>
Date: 2020-08-24 (Mon, 24 Aug 2020)
Changed paths:
M web/htdocs/themes/facelift/scss/_page_menu.scss
Log Message:
-----------
Dashboard: Enable/disable "add dashlet" dropdown instead of hiding/showing
Change-Id: I16cb847276d2e71d62c054f8d4d04fa9ca3e8c58
Compare: https://github.com/tribe29/checkmk/compare/81bc45b3f2a7...9bb5f6354a5b