Checkmk git commits August 2020

checkmk-commits@lists.checkmk.com

1 participants
411 discussions

[tribe29/checkmk] 586176: Fix delayed loading of graphs

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 586176649ea76feee8a54ffa4ba4c38c00241e0d https://github.com/tribe29/checkmk/commit/586176649ea76feee8a54ffa4ba4c38c0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/plugins/metrics/html_render.py M web/htdocs/js/modules/utils.js Log Message: ----------- Fix delayed loading of graphs Since we introduced simplebar for the content pages, listening on scroll elements does not work as before. We first need to finish initializing simplebar and can then register the event listener on the scroll element of simplebar. To make this possible, the event listeners for the delayed loading have to be moved to the final javascript. Change-Id: If9877f8edf74e24082c5984c654e6ad823f41f28

3 years, 10 months

[tribe29/checkmk] 81c74f: 11260 FIX Fix crash in EC configuration (regressio...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 81c74f7de1ebf278a893deb0e0491a679a17cc8d https://github.com/tribe29/checkmk/commit/81c74f7de1ebf278a893deb0e0491a679… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: A .werks/11260 M cmk/ec/main.py Log Message: ----------- 11260 FIX Fix crash in EC configuration (regression since 1.6.0p14) When there were open events in the Event Console that were created by a rule that was removed from the Event Console, this resulted in an exception on the Event Console configuration page (IndexError (list index out of range)). However, this message was rather a consequence error. The original error message was found in var/log/mkeventd.log. There you could find messages of this kind: C+: 2020-08-27 14:19:42,913 [40] [cmk.mkeventd.StatusServer] Error handling client : 'my_rule' Traceback (most recent call last): File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 3031, in serve File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 3071, in handle_client File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 3092, in _answer_query File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 2753, in query File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 2871, in _enumerate File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 736, in get_status row += self._add_event_limit_status() File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 766, in _add_event_limit_status self.get_rules_with_active_event_limit(), File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 1784, in get_rules_with_active_event_limit if num_events >= self._get_rule_event_limit(rule_id)[0]: File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 1885, in _get_rule_event_limit rule = self._rule_by_id.get(rule_id) KeyError: 'my_rule' C-: Change-Id: I0648769d99cdae526f4fcfba2a1abc99be4ee89a

3 years, 10 months

[tribe29/checkmk] ce08d1: Improve error handling when EC status can not be f...

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: ce08d15d3309a408c8555e94ad573e5e05ec6ff9 https://github.com/tribe29/checkmk/commit/ce08d15d3309a408c8555e94ad573e5e0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/mkeventd.py Log Message: ----------- Improve error handling when EC status can not be fetched Instead of raising a crash, we now display an error message that points to the mkeventd.log which should contain more information about the issue. Change-Id: I5ac686cdc574aedfedd377dfb5290c5fc072a250 Commit: f4b77018749689779d96b5ae77966cbda916dc52 https://github.com/tribe29/checkmk/commit/f4b77018749689779d96b5ae77966cbda… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: A .werks/11260 M cmk/ec/main.py Log Message: ----------- 11260 FIX Fix crash in EC configuration (regression since 1.6.0p14) When there were open events in the Event Console that were created by a rule that was removed from the Event Console, this resulted in an exception on the Event Console configuration page (IndexError (list index out of range)). However, this message was rather a consequence error. The original error message was found in var/log/mkeventd.log. There you could find messages of this kind: C+: 2020-08-27 14:19:42,913 [40] [cmk.mkeventd.StatusServer] Error handling client : 'my_rule' Traceback (most recent call last): File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 3031, in serve File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 3071, in handle_client File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 3092, in _answer_query File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 2753, in query File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 2871, in _enumerate File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 736, in get_status row += self._add_event_limit_status() File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 766, in _add_event_limit_status self.get_rules_with_active_event_limit(), File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 1784, in get_rules_with_active_event_limit if num_events >= self._get_rule_event_limit(rule_id)[0]: File "/omd/sites/stable/lib/python/cmk/ec/main.py", line 1885, in _get_rule_event_limit rule = self._rule_by_id.get(rule_id) KeyError: 'my_rule' C-: Change-Id: I0648769d99cdae526f4fcfba2a1abc99be4ee89a Compare: https://github.com/tribe29/checkmk/compare/6f87cc43dda8...f4b770187496

3 years, 10 months

[tribe29/checkmk] afa262: Add page menu to report pages

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: afa26232ab5783d75f212836eef4c9fd3f5bcec5 https://github.com/tribe29/checkmk/commit/afa26232ab5783d75f212836eef4c9fd3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/forms.py Log Message: ----------- Add page menu to report pages Change-Id: I09a838827dc85f95a906b092352fa45d273bca1b Commit: 429c3b3a866270d8f684a59c6c1b46133d9af659 https://github.com/tribe29/checkmk/commit/429c3b3a866270d8f684a59c6c1b46133… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/plugins/wato/__init__.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/plugins/wato/utils/context_buttons.py M cmk/gui/plugins/wato/utils/simple_modes.py M cmk/gui/wato/__init__.py M cmk/gui/wato/page_handler.py M cmk/gui/wato/pages/rulesets.py M web/htdocs/themes/facelift/scss/_pages.scss M web/htdocs/themes/facelift/scss/_variables.scss M web/htdocs/themes/modern-dark/scss/_variables.scss Log Message: ----------- Remove context button code We have finally replaced all context buttons with the new page menu. Hoooray :D Now we remove the whole context button rendering and styling code. Change-Id: I3c4a2d40ed8d4e54e3b4389a60fdb2a19c8f5e9e Compare: https://github.com/tribe29/checkmk/compare/bd4c018529a7...429c3b3a8662

3 years, 10 months

[tribe29/checkmk] bd4c01: [CMK-5277] - format fetcher logs as required by pr...

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: bd4c018529a75f2774ffd31bd3bac8f0657ef9b8 https://github.com/tribe29/checkmk/commit/bd4c018529a75f2774ffd31bd3bac8f06… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M bin/fetcher M cmk/fetchers/controller.py M cmk/utils/log/_log.py M tests/unit/cmk/fetchers/test_controller.py Log Message: ----------- [CMK-5277] - format fetcher logs as required by protocol microcore-fetcher Change-Id: Ifb9faa981feb6e1fb922c9e55c88fbf69c1bb308

3 years, 10 months

[tribe29/checkmk] 2338cd: Extract loop for make_host_sections

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 2338cd4a37ea4d4a554a01c049224882f721c7d5 https://github.com/tribe29/checkmk/commit/2338cd4a37ea4d4a554a01c049224882f… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/base/checking.py M cmk/base/data_sources/_data_sources.py M cmk/base/discovery.py M cmk/base/inventory.py M tests/unit/cmk/base/data_sources/test_host_sections.py Log Message: ----------- Extract loop for make_host_sections Exception handling and host sections (summary) handling are done using an implicit protocol as both are cached on the Checker class. Originally, the data source class was also caching the exception from the fetcher. After the split, this is not practicable anymore as the fetcher is not in the checker anymore. Therefore, we now need to make the error handling protocol explicit. This requires some refactoring in the data source users such as inventory, discovery, or check_mk (compare 🍝). The biggest culprit here is now `make_host_sections` because it calls `fetcher.fetch()` and `checker.check()` directly and hides raw data, exception, and host sections. Unfortunately, the fact that `make_host_sections` takes an iterable makes it nearly impossible to simply rearrange the code. This patch separates the construction of the loop from the iteration on the loop. CMK-5275 Change-Id: I3139233dc67b03974f4bb99a7100d295ec02b1a8 Commit: 897bb8e470d83e4eec0bfcb69d1a6a8574c59d5b https://github.com/tribe29/checkmk/commit/897bb8e470d83e4eec0bfcb69d1a6a857… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/base/discovery.py Log Message: ----------- Minor unyapfing of discovery CMK-5275 Change-Id: I62768d020d0d32df9b037564555199dda5fe2cc5 Commit: cc6f6bfdad2f4b85ca014daac1e5d5b8f000fb4d https://github.com/tribe29/checkmk/commit/cc6f6bfdad2f4b85ca014daac1e5d5b8f… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M agents/wnx/src/common/wtools.cpp M agents/wnx/src/engine/cfg.cpp Log Message: ----------- [FEED-5122] - enable only root folder protection: programdata/checkmk use SID instead of Users group name to support internationalization Change-Id: I3bf86843af951dc1988de5ce4f82226e3c46f4b0 Compare: https://github.com/tribe29/checkmk/compare/d783f4f23593...cc6f6bfdad2f

3 years, 10 months

[tribe29/checkmk] 8a92c3: host_sections: remove unused function

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8a92c39dca686937c8640a23a38e06b285a7bb40 https://github.com/tribe29/checkmk/commit/8a92c39dca686937c8640a23a38e06b28… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/base/data_sources/host_sections.py Log Message: ----------- host_sections: remove unused function All plugins with either node_info set to true or extra_sections defined are migrated manually, and thus will never be called in the legacy mode from hell. In the remaining cases neither of the two functions will do anything, so we remove them. This further reduces the entaglement between host_sections and base/config. Change-Id: I8c53eb12f0fd1672bdf4338b718077a26fbf3fe8 Commit: b7812757193d6383f4140400b4a43254cc4eb239 https://github.com/tribe29/checkmk/commit/b7812757193d6383f4140400b4a43254c… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/base/checking.py M cmk/base/data_sources/host_sections.py M tests/unit/cmk/base/data_sources/test_host_sections.py Log Message: ----------- host_sections: make check_info a proper argument This way we further reduce the entanglement with base/config.py. Change-Id: I29ecd0f7030262de5370b702290bff461791daf5 Commit: d783f4f23593edf3c663d054db1de26db24154e1 https://github.com/tribe29/checkmk/commit/d783f4f23593edf3c663d054db1de26db… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/base/data_sources/host_sections.py M tests/unit/cmk/base/data_sources/test_host_sections.py Log Message: ----------- host_sections: remove dead code and tighten typing The only remaining call site of 'get_section_content' allways passes a service description. The None case had been for discovery only (and thus never in combination with clusters). Change-Id: I0ef6f398f220f345edec90e90aa2bbdca1d997da Compare: https://github.com/tribe29/checkmk/compare/265104d40881...d783f4f23593

3 years, 10 months

[tribe29/checkmk] 265104: Fix merge issue

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 265104d408817a58dd7903759eab54bb9b04fe2a https://github.com/tribe29/checkmk/commit/265104d408817a58dd7903759eab54bb9… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/wato/mkeventd.py Log Message: ----------- Fix merge issue Change-Id: I586b10b15e8dc970c3dfb0e94c61223dae9a038c

3 years, 10 months

[tribe29/checkmk] 38274f: Add parent mode declarations to backup modes

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 38274f47ca6fb6dfa93be7b4ab81fae0b1cfdd72 https://github.com/tribe29/checkmk/commit/38274f47ca6fb6dfa93be7b4ab81fae0b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/wato/pages/backup.py Log Message: ----------- Add parent mode declarations to backup modes Change-Id: Icb7303f54a8527159328f077d2f97d6467b6ec7f Commit: 9962566b74d3742b55afd79dee173838a4843350 https://github.com/tribe29/checkmk/commit/9962566b74d3742b55afd79dee173838a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M web/htdocs/themes/facelift/scss/_page_menu.scss Log Message: ----------- Make suggestion buttons respect disable state Change-Id: I4331c061bcd4e8a068f267273230f12c2ae0b422 Commit: 17cd7e5dc03deef84654016e6976ede961f4f963 https://github.com/tribe29/checkmk/commit/17cd7e5dc03deef84654016e6976ede96… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/backup.py Log Message: ----------- Add page menu to backup modes Change-Id: I84cb3e18078828b8cc9db5de02e16d7b58a4d92a Compare: https://github.com/tribe29/checkmk/compare/743571566fcd...17cd7e5dc03d

3 years, 10 months

[tribe29/checkmk] 7260ca: Add page menu to EC settings and status modes

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7260ca7db8ce9c933aa440126bfb139bdeee5878 https://github.com/tribe29/checkmk/commit/7260ca7db8ce9c933aa440126bfb139bd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/wato/mkeventd.py Log Message: ----------- Add page menu to EC settings and status modes Change-Id: Ib1011bc38b5107cbb2dde66eba3cb55f78f833a2 Commit: 94830891f0a46085ee33cb4604922718cdb90ce3 https://github.com/tribe29/checkmk/commit/94830891f0a46085ee33cb4604922718c… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/wato/mkeventd.py Log Message: ----------- Add page menu to EC rule list and edit modes Change-Id: I98a14f8a6bc857d20347858ff632127d66e3022a Commit: 377c83475e7d4817cdee37a7b3dc040fe9354686 https://github.com/tribe29/checkmk/commit/377c83475e7d4817cdee37a7b3dc040fe… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/wato/mkeventd.py Log Message: ----------- Add page menu to EC rule pack mode Change-Id: I71b2dff2a700f92a9e08844f0a3cb6a4b22c366d Commit: 833ab48588ca1bf4291567695e7f77c7ddff7c2d https://github.com/tribe29/checkmk/commit/833ab48588ca1bf4291567695e7f77c7d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/wato/mkeventd.py Log Message: ----------- EC: Extract SNMP MIB upload form to dedicated mode Change-Id: If0fa300d40f16b7665622a51532d258d61e4c8e8 Commit: 75abb9c47d4619ebdf8fc17abbf791969f2d6974 https://github.com/tribe29/checkmk/commit/75abb9c47d4619ebdf8fc17abbf791969… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/wato/mkeventd.py Log Message: ----------- Add page menu to remaining EC modes Change-Id: Iebd166c2df12365e31efcfee48077cb0c14a0ccd Commit: 08a4956137218b4beb8b575f061d5279acb95955 https://github.com/tribe29/checkmk/commit/08a4956137218b4beb8b575f061d5279a… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: A web/htdocs/themes/facelift/images/icon_edit_forecast_model.png Log Message: ----------- Add page menu to forecast graph pages Change-Id: I48f7e6a35f32a23f0f07bdc460a3bd383972d12b Commit: 90fbb8bfd365693bc86d46ceeeb77e0d93870a6d https://github.com/tribe29/checkmk/commit/90fbb8bfd365693bc86d46ceeeb77e0d9… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/pagetypes.py Log Message: ----------- Drop obsolete methods Change-Id: I2a022e1d60e9c86c397d926f9b20150be2936eca Commit: 2451b2ce61824036b8c5274d4d643f67edc526b7 https://github.com/tribe29/checkmk/commit/2451b2ce61824036b8c5274d4d643f67e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/crash_reporting.py Log Message: ----------- Add page menu to crash report detail page Change-Id: I168f8047ed37f108f6214a15c15e2e5070ff2328 Commit: 0fddad790a45af5cc52e6f12ceab32f799881c25 https://github.com/tribe29/checkmk/commit/0fddad790a45af5cc52e6f12ceab32f79… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: A web/htdocs/themes/facelift/images/icon_edit_custom_graph.png Log Message: ----------- Add missing image Change-Id: I938de57f62e05f57c9a13cd9c5a5ae1058387e3a Commit: 5cc1bde884ee21b87eab7eb1ae4e2a9019a07656 https://github.com/tribe29/checkmk/commit/5cc1bde884ee21b87eab7eb1ae4e2a901… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/dashboard.py Log Message: ----------- Add page menu to dashlet edit pages Change-Id: Icae87e6bf1e5b72d3027cd17a9701a458cb05b0e Commit: 386244ed51a0099da7bfab5f40f7ff508a9aeba7 https://github.com/tribe29/checkmk/commit/386244ed51a0099da7bfab5f40f7ff508… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/logwatch.py Log Message: ----------- Update breadcrumb and add page menu on logwatch pages Change-Id: I0494520757ef2a3887d77f13b56d73b2541c8b68 Commit: 743571566fcd70eb40c6ea975abec89dc0d2cda2 https://github.com/tribe29/checkmk/commit/743571566fcd70eb40c6ea975abec89dc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/gui/logwatch.py Log Message: ----------- Logwatch acknowledge: Use page menu of actual pages Previously the "acknowledge log files" confirm page was rendered with a completely own page header (incl. breadcrumb, page menu). Since it is only a confirm dialog in a context of another page, it should really have the same breadcrumb and menu. This commit moves the confirm handling to the individual pages which needs a bit of copy-n-paste, but that seems to be OK for this. Change-Id: Idbc7ad201f9eb4a66b169a8e6a402316f5e8e59e Compare: https://github.com/tribe29/checkmk/compare/e06d87a3f8c1...743571566fcd

3 years, 10 months

← Newer
1
2
3
4
5
6
7
...
42
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits August 2020