Checkmk git commits August 2020

checkmk-commits@lists.checkmk.com

1 participants
411 discussions

[tribe29/checkmk] 8d12aa: Fixed race condition when logging handler is changed.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 8d12aa1e79e6a3665bed44aaaef5902dbaf9c75c https://github.com/tribe29/checkmk/commit/8d12aa1e79e6a3665bed44aaaef5902db… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: M livestatus/src/Logger.h Log Message: ----------- Fixed race condition when logging handler is changed. There was a race between Core::setLogConfi() and logging in the rrdached connection thread (which starts very early). It could even lead to a crash due to a use-after-free. CMK-5250 Change-Id: Ie178b296f3a2923908f1bf9ffaa803f62c9a6aaa

3 years, 10 months

[tribe29/checkmk] 7f835b: [Temporary Fix]

by Sergey Kipnis

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 7f835b361d2638ef911d6d84e845e657d88670af https://github.com/tribe29/checkmk/commit/7f835b361d2638ef911d6d84e845e657d… Author: Sergey Kipnis <sergey.kipnis(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: M cmk/fetchers/_base.py M tests/unit/cmk/base/test_automations_check_mk.py M tests/unit/cmk/base/test_modes_check_mk.py Log Message: ----------- [Temporary Fix] Cache is hard-disabled, because cache entry may be never too old. Two unit-tests are disabled The change is 100% safe. The change will be reverted with working cache Change-Id: I9c660a1887393fcf1e7fc99ee35fd5f7a38317a1

3 years, 10 months

[tribe29/checkmk] d42370: Make summary protocol explicit in two more places

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d42370fbcc3577c8cfb10df73b0ab77a8f1dec6a https://github.com/tribe29/checkmk/commit/d42370fbcc3577c8cfb10df73b0ab77a8… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/modes/check_mk.py Log Message: ----------- Make summary protocol explicit in two more places We must make the protocol for summary computation explicit in order to be able to properly handle errors in the check helpers. This patch demonstrates that it is possible in two more places. The only remaining one is in `cmk/base/inventory.py` and requires more changes to the code. CMK-5275 Change-Id: Ie1b384a989333b0dcd44fc386724c3baa7b940cf

3 years, 10 months

[tribe29/checkmk] bc0377: Make TSAN a bit more happy.

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: bc037766f39a76c57213034069da23a347fca08b https://github.com/tribe29/checkmk/commit/bc037766f39a76c57213034069da23a34… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: M livestatus/src/global_counters.cc Log Message: ----------- Make TSAN a bit more happy. Protected the global counters with mutexes, removing some data races. Change-Id: I284c94391d204aa6aaf41cbbdf700e1f664a6db8

3 years, 10 months

[tribe29/checkmk] a49caa: 11265 FIX Discovery Page: Do not show last job fai...

by Sven Panne

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a49caa5bce6d81e643efd62bfa9abb9d45ccffd5 https://github.com/tribe29/checkmk/commit/a49caa5bce6d81e643efd62bfa9abb9d4… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: A .werks/11265 M cmk/gui/watolib/services.py Log Message: ----------- 11265 FIX Discovery Page: Do not show last job failures if they are fixed Change-Id: I7b8823c176628e02a7e4e4aec2db7b67758974be Commit: e177ae7372b65bd57c6336b78a14d5e60e90b26c https://github.com/tribe29/checkmk/commit/e177ae7372b65bd57c6336b78a14d5e60… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: M cmk/utils/type_defs.py M tests/unit/cmk/utils/test_type_defs.py Log Message: ----------- Removed unwrap_ok alias for unwrap. The naming in the Rust enum is probably not 100% perfect, but keeping a 1:1 correspondence between that and our Python class is more important: We can simply point to the Rust docs... Furthermore, more unwrap-like functions will be added, and we don't want to introduce more aliases then. Change-Id: I92a4b6b68a312bf4a02efc6af784d03a35030cc3 Commit: 6ba499e1609bc86b056b123f39c1f4386e164737 https://github.com/tribe29/checkmk/commit/6ba499e1609bc86b056b123f39c1f4386… Author: Sven Panne <sven.panne(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: M cmk/utils/type_defs.py M tests/unit/cmk/utils/test_type_defs.py Log Message: ----------- Added more Rust-style unwrapping methods to Result. Change-Id: I6d1aa63707e16965e14d6d89316a2f8bfc988a45 Compare: https://github.com/tribe29/checkmk/compare/784557b90a68...6ba499e1609b

3 years, 10 months

[tribe29/checkmk] 784557: snmp_scan: refactor and make evaluate_snmp_detecti...

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 784557b90a68811c605bc371e2add2faa4590d3e https://github.com/tribe29/checkmk/commit/784557b90a68811c605bc371e2add2faa… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: M cmk/snmplib/snmp_modes.py M cmk/snmplib/snmp_scan.py M tests/unit/cmk/lib/test_snmplib_snmp_scan.py Log Message: ----------- snmp_scan: refactor and make evaluate_snmp_detection public This way we can use the function to test detect specs. Change-Id: I4e54e3544adc9164d93d52fc89aaebba94aa6ccc

3 years, 10 months

[tribe29/checkmk] 1e4e04: Extract fetching of image data from registry

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 1e4e04402a9f88d2e7335c32d81847559e2317a6 https://github.com/tribe29/checkmk/commit/1e4e04402a9f88d2e7335c32d81847559… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: M tests/testlib/containers.py Log Message: ----------- Extract fetching of image data from registry Change-Id: I8bd583609bfd5e82267b45ee8513a69a37f7da77 Commit: 329656c19328a9c9bba88e0c96a4c025868d6fa6 https://github.com/tribe29/checkmk/commit/329656c19328a9c9bba88e0c96a4c0258… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: M tests/testlib/containers.py Log Message: ----------- Integration tests: Invalidate test image on base image changes Once a new base image is built by our "Build Build Container" job, we don't want to use the test containers that were built on top of the old build containers. This commit ensures the base image and test images are always up-to-date or rebuilt once a new base image occurs. It is still supported to continue with the available images in case there is no connection possible to the docker registry. Change-Id: Id0e2005deac506d1c321ed42bf3c1bea43c3ec10 Compare: https://github.com/tribe29/checkmk/compare/d1c7fe6745a9...329656c19328

3 years, 10 months

[tribe29/checkmk] d1c7fe: Consolidate setting cache opts; Minor cleanup

by Simon

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d1c7fe6745a902e396d1f534fd956fade3d41dbf https://github.com/tribe29/checkmk/commit/d1c7fe6745a902e396d1f534fd956fade… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2020-08-28 (Fri, 28 Aug 2020) Changed paths: M cmk/base/automations/check_mk.py M cmk/base/data_sources/_abstract.py M cmk/base/modes/check_mk.py Log Message: ----------- Consolidate setting cache opts; Minor cleanup Change-Id: I8ff02ba7a57320d54cb402aeebedff8dcaed738d

3 years, 10 months

[tribe29/checkmk] 0416af: Let mhs computation return the computed host sections

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 0416afb0dced0b9fcc81ded6d4d230eba61393f5 https://github.com/tribe29/checkmk/commit/0416afb0dced0b9fcc81ded6d4d230eba… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/base/checking.py M cmk/base/data_sources/_abstract.py M cmk/base/data_sources/_data_sources.py M cmk/base/discovery.py M cmk/base/inventory.py M tests/unit/cmk/base/data_sources/test_agent.py M tests/unit/cmk/base/data_sources/test_host_sections.py Log Message: ----------- Let mhs computation return the computed host sections Exception handling and host sections (summary) handling are done using an implicit protocol as both are cached on the Checker class. Originally, the data source class was also caching the exception from the fetcher. After the split, this is not practicable anymore as the fetcher is not in the checker anymore. Therefore, we now need to make the error handling protocol explicit. This requires some refactoring in the data source users such as inventory, discovery, or check_mk (compare 🍝). We modify `make_host_sections` so that it *returns* the host sections to be summarized. CMK-5275 Change-Id: Ie94fead164fd2ef3fea5ffc2374495ca7c838e19

3 years, 10 months

[tribe29/checkmk] d740f5: Add Rust-inspired Result type

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d740f588315d39f55997f49a53b84fd36023cd96 https://github.com/tribe29/checkmk/commit/d740f588315d39f55997f49a53b84fd36… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-27 (Thu, 27 Aug 2020) Changed paths: M cmk/utils/type_defs.py M tests/unit/cmk/utils/test_type_defs.py Log Message: ----------- Add Rust-inspired Result type It is never correct to raise an exception in the check helpers, instead, the errors are treated like regular data and are simply reported with the status flag. The Result class reflects that in the type system. CMK-5275 Change-Id: Ia1e5ac0b4ea9e457cc917def0d28063026c86b12

3 years, 10 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits August 2020