Checkmk git commits August 2020

checkmk-commits@lists.checkmk.com

1 participants
411 discussions

[tribe29/checkmk] a3cbfc: UX Styling: New colors for the facelift theme

by Kenneth

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a3cbfcfb777f3226939b204c31f20831a4d24d14 https://github.com/tribe29/checkmk/commit/a3cbfcfb777f3226939b204c31f20831a… Author: Kenneth Okoh <kenneth.okoh(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M web/htdocs/themes/facelift/scss/_main.scss M web/htdocs/themes/facelift/scss/_mega_menu.scss M web/htdocs/themes/facelift/scss/_page_menu.scss M web/htdocs/themes/facelift/scss/_pages.scss M web/htdocs/themes/facelift/scss/_sidebar.scss M web/htdocs/themes/facelift/scss/_snapins.scss M web/htdocs/themes/facelift/scss/_variables.scss M web/htdocs/themes/modern-dark/scss/_variables.scss Log Message: ----------- UX Styling: New colors for the facelift theme Change-Id: I0be037294a243a6fbb3565c686824bec69ee06a1

4 years, 1 month

[tribe29/checkmk] 4ea2da: Use central regex compilation and crentralize host...

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 4ea2dab71a0a71d2a1cd093d4caed526bed62cb6 https://github.com/tribe29/checkmk/commit/4ea2dab71a0a71d2a1cd093d4caed526b… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/valuespec.py M cmk/utils/regex.py Log Message: ----------- Use central regex compilation and crentralize host regex Change-Id: Idafd284d851830978ad83477ca9ddc5aa610fa80 Commit: 3f68113adbb598b31523f23409539ae0ee63c2a6 https://github.com/tribe29/checkmk/commit/3f68113adbb598b31523f23409539ae0e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: A .werks/11263 M cmk_base/data_sources/abstract.py Log Message: ----------- 11263 SEC Fix piggyback path traversal In previous versions it was possible to create files in the querying Checkmk site by modifying or extending an agent on a monitored system. So an attacker who gained rights on a monitored system to extend the agent could create and modify files in the monitoring Checkmk site with certain modifications of the agent. The creation or modification of files in the Checkmk site was done with rights of the Checkmk site user. This problem is now solved by a better validation of hostnames of piggybacked hosts. With this change only these characters are allowed in Piggybacked hostnames: <tt>0-9a-zA-Z_.-</tt>. These are exactly the same characters that Checkmk normally allows when creating hostnames. A special feature of Piggyback hostnames is that all illegal hostnames are replaced by "_". This change means that Piggyback hosts created with now invalid characters will have to be created differently after this change so that they can continue to be monitored. Change-Id: I36e37d8eb15ccb0b92792eac84eefc56efd52d96 Compare: https://github.com/tribe29/checkmk/compare/2f5012e5401a...3f68113adbb5

4 years, 1 month

[tribe29/checkmk] 527882: Use central regex compilation and crentralize host...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 527882210677c61d0b73a9e8ddc878a2571b1b78 https://github.com/tribe29/checkmk/commit/527882210677c61d0b73a9e8ddc878a25… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/valuespec.py M cmk/utils/regex.py Log Message: ----------- Use central regex compilation and crentralize host regex Change-Id: Idafd284d851830978ad83477ca9ddc5aa610fa80 Commit: da331bdf26f450c70b8498decf6438d412f4b021 https://github.com/tribe29/checkmk/commit/da331bdf26f450c70b8498decf6438d41… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: A .werks/11263 M cmk/base/data_sources/agent.py M tests/unit/cmk/base/data_sources/test_agent.py Log Message: ----------- 11263 SEC Fix piggyback path traversal In previous versions it was possible to create files in the querying Checkmk site by modifying or extending an agent on a monitored system. So an attacker who gained rights on a monitored system to extend the agent could create and modify files in the monitoring Checkmk site with certain modifications of the agent. The creation or modification of files in the Checkmk site was done with rights of the Checkmk site user. This problem is now solved by a better validation of hostnames of piggybacked hosts. With this change only these characters are allowed in Piggybacked hostnames: <tt>0-9a-zA-Z_.-</tt>. These are exactly the same characters that Checkmk normally allows when creating hostnames. A special feature of Piggyback hostnames is that all illegal hostnames are replaced by "_". This change means that Piggyback hosts created with now invalid characters will have to be created differently after this change so that they can continue to be monitored. Change-Id: Ia2d63e9bde603361e2810fffde19587c3fcc68e5 Commit: ac598e5ca4f8dd74cdd9fa9edacd8d58ef9f88c3 https://github.com/tribe29/checkmk/commit/ac598e5ca4f8dd74cdd9fa9edacd8d58e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/wato/mkeventd.py Log Message: ----------- EC global setting: Make page menu work Change-Id: Ibcaf3906b21e6337157ab402fd64edbbcedb192d Compare: https://github.com/tribe29/checkmk/compare/33ac52797418...ac598e5ca4f8

4 years, 1 month

[tribe29/checkmk] f92730: Revert werks 10534 and 11229

by Simon

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: f92730f1120996c1a1c45e41c4d1434439ade1e1 https://github.com/tribe29/checkmk/commit/f92730f1120996c1a1c45e41c4d143443… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk_base/discovery.py M tests/unit/cmk_base/test_data_sources_unit.py Log Message: ----------- Revert werks 10534 and 11229 CMK-5119 Change-Id: I0371673e8fece5ba2da7276cd15150e19b1639f1 Commit: 2f5012e5401a374208a19a9f599f8d3f9e395dae https://github.com/tribe29/checkmk/commit/2f5012e5401a374208a19a9f599f8d3f9… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: A .werks/11238 M cmk_base/data_sources/abstract.py M cmk_base/data_sources/ipmi.py M cmk_base/data_sources/piggyback.py M cmk_base/data_sources/programs.py M cmk_base/data_sources/snmp.py M cmk_base/data_sources/tcp.py M cmk_base/snmp.py M tests/unit/cmk_base/test_data_sources_unit.py Log Message: ----------- 11238 FIX Check_MK Discovery: Was unable to discover new SNMP check types CMK-5119 Change-Id: I1a4e562d823ad1cbcd2f6ab4c2225d07d2d26e46 Compare: https://github.com/tribe29/checkmk/compare/627f2cf134d0...2f5012e5401a

4 years, 1 month

[tribe29/checkmk] 21f623: simplify new page default name

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 21f623b8d31359de91cfbde1a5939daea23c851b https://github.com/tribe29/checkmk/commit/21f623b8d31359de91cfbde1a5939daea… Author: Óscar Nájera <oscar.najera(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/pagetypes.py Log Message: ----------- simplify new page default name Change-Id: Ib8f9ec3a52d942313c63ccd88ef4b54f75821250 Commit: 33ac527974187801f4e418e5b9ad71890591cef8 https://github.com/tribe29/checkmk/commit/33ac527974187801f4e418e5b9ad71890… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/wato/builtin_modules.py Log Message: ----------- Spread type hints Change-Id: I13d7251a2b5259c485095a5c35dcc199570ffcda Compare: https://github.com/tribe29/checkmk/compare/a6003e3ea93d...33ac52797418

4 years, 1 month

[tribe29/checkmk] baf54c: DCD connections, passwords and predefined conditio...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: baf54c67f543637130f0c2fb07cd5ee51baf5fe2 https://github.com/tribe29/checkmk/commit/baf54c67f543637130f0c2fb07cd5ee51… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/wato/utils/simple_modes.py M cmk/gui/wato/pages/password_store.py M cmk/gui/wato/pages/predefined_conditions.py Log Message: ----------- DCD connections, passwords and predefined conditions: Add page menu Change-Id: Iad6aca92a4905f8e613ac026aae2ce7e43e5013f Commit: 32e8cac84c439cb15ed7b4dec9b3bf9adb09050a https://github.com/tribe29/checkmk/commit/32e8cac84c439cb15ed7b4dec9b3bf9ad… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Minor quicksearch topic output improvement Some other cleanups on the way Change-Id: Iba54056cda429a6398c1f2376a204bd82276cab1 Commit: b7e75d8061bf2b43f7f3c97257c3eb26e35058ad https://github.com/tribe29/checkmk/commit/b7e75d8061bf2b43f7f3c97257c3eb26e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py M cmk/gui/sidebar.py Log Message: ----------- Clarify class names Change-Id: I823ba61d02294f898a5508017701b620441d00de Commit: b0a7335ccacd8f2138fc5afbd7fcf28cda885e5c https://github.com/tribe29/checkmk/commit/b0a7335ccacd8f2138fc5afbd7fcf28cd… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/sidebar.py Log Message: ----------- Drop support for old quicksearch_match_plugins The API was changed 2 years ago and is now dropped to reduce the compatibility code we have to deal with. Also remove search_plugins structure which was not used at all. Change-Id: Ida0fc460404fe32f14d288e038d60a87dbc4c058 Commit: fb43490585c3fd882cf8be6e87ec7edac49738f4 https://github.com/tribe29/checkmk/commit/fb43490585c3fd882cf8be6e87ec7edac… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Refactor quick search registry to hold instances Change-Id: Ida3a435b7eb906a5810762e879dbc72b00dc6537 Commit: eacdd985e7f95bd699fdae5778344ce7eaaa2d6e https://github.com/tribe29/checkmk/commit/eacdd985e7f95bd699fdae5778344ce7e… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Standardize name attribute and access to it Change-Id: I3b3124278d6e5259c5e9730e2030e0ecec53781f Commit: a6003e3ea93d63a915d170fd1d4228f2fbb50e1d https://github.com/tribe29/checkmk/commit/a6003e3ea93d63a915d170fd1d4228f2f… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Spread type hints Change-Id: I13d7251a2b5259c485095a5c35dcc199570ffcda Compare: https://github.com/tribe29/checkmk/compare/c1530c9ac5f7...a6003e3ea93d

4 years, 1 month

[tribe29/checkmk] 185fdc: Add fixture to create admin user for tests

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 185fdc5dc36fbf485cbd17a325a222a820427a1c https://github.com/tribe29/checkmk/commit/185fdc5dc36fbf485cbd17a325a222a82… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M tests/unit/cmk/gui/conftest.py Log Message: ----------- Add fixture to create admin user for tests Change-Id: If5ab412bb4201377efa22c50ddbea434d5795e75 Commit: dbd27e26cedc522860dfae1fd24aa1a4878e0e2e https://github.com/tribe29/checkmk/commit/dbd27e26cedc522860dfae1fd24aa1a48… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: A tests/unit/cmk/gui/plugins/sidebar/test_wato.py Log Message: ----------- Add test to ensure the menu does not change in upcoming refactorings Change-Id: I8df09a78cea552dc17907d406116f669b093082f Commit: da3e5a4b228e7f912ed91c8890f345928e2def62 https://github.com/tribe29/checkmk/commit/da3e5a4b228e7f912ed91c8890f345928… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/wato/utils/base_modes.py M cmk/gui/wato/pages/rulesets.py M cmk/gui/werks.py Log Message: ----------- Make WATO mode breadcrumbs contain their topics For the top level modes we need to prepend the topic of the mode. The mode is sadly not available directly in WatoMode. Instead it is configured in the MainModule class that is related to the WatoMode. There is no 1:1 connection between WatoMode / MainModule classes. For the moment we lookup the main_module_registry to find the topics for as many modes as possible. Once all non top level modes have a parent_mode() method, we know which modes are top level modes. Then we could move all attributes from the MainModules to the WatoModes and create the WATO menu items directly out of the WatoModes. Change-Id: I1453a07f3f408ce6abc7a918a1a50c6353906252 Commit: bb39df7ae215db861b3e54435af5b13e5f9fc436 https://github.com/tribe29/checkmk/commit/bb39df7ae215db861b3e54435af5b13e5… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/wato/pages/global_settings.py Log Message: ----------- Global settings: Add page menu to listing + CME GUI design page Change-Id: I23b741fe60d18cad0db19b169124fa51a7967068 Commit: 94616fa79d0c529e990da166f9a22d6a13736110 https://github.com/tribe29/checkmk/commit/94616fa79d0c529e990da166f9a22d6a1… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/htmllib.py M tests/unit/cmk/gui/watolib/test_watolib.py Log Message: ----------- Remove CME GUI color selection This "interesting" feature was only affecting the classic theme and rarely used. Now that the classic theme was dropped, this color selection can also be removed. Change-Id: I59f2e94db88a8afa46a84f925793ef7f70bdaf09 Commit: 7d1674847416837dc9f51fc94d24f9923c4cd710 https://github.com/tribe29/checkmk/commit/7d1674847416837dc9f51fc94d24f9923… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/page_menu.py Log Message: ----------- Extract single button calculations Change-Id: I0840dd3b706656293cbb2057b7972cb36bf495f5 Commit: 26c7ffaa4668e10c9166c6e532868c7cc0145652 https://github.com/tribe29/checkmk/commit/26c7ffaa4668e10c9166c6e532868c7cc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/page_menu.py Log Message: ----------- Make simple form actions also available via dropdowns When you look at the concept of the "edit host" dialog, it is done there in the same way. The most prominent actions are available as suggested actions, shortcuts AND using the dropdowns. Change-Id: I40db15abe1a02b664c0dbc73a8f8fd4d16c8535d Commit: c1530c9ac5f77595911ff799271effdbc79098f5 https://github.com/tribe29/checkmk/commit/c1530c9ac5f77595911ff799271effdbc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/wato/pages/global_settings.py A web/htdocs/themes/facelift/images/icon_reset.png Log Message: ----------- Global settings: Add page menu to edit page Change-Id: If0eb40bffd23a53f0fe145533760d409378df778 Compare: https://github.com/tribe29/checkmk/compare/a16fe6bffba5...c1530c9ac5f7

4 years, 1 month

[tribe29/checkmk] 627f2c: 11303 FIX mem.linux: false CRIT status when Vmallo...

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 627f2cf134d07ebb2dd634b2371e7e8d1bc573b0 https://github.com/tribe29/checkmk/commit/627f2cf134d07ebb2dd634b2371e7e8d1… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: A .werks/11303 M checks/mem A tests/unit/checks/generictests/datasets/mem_linux_vmalloc_chunk_regression.py Log Message: ----------- 11303 FIX mem.linux: false CRIT status when VmallocChunk is set to 0 kB CMK-4302 Change-Id: I30c176d77667fadb159258396ede5d38e3acde6c

4 years, 1 month

[tribe29/checkmk] a16fe6: Simplify return type to `DataSource._get_raw_data()`

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a16fe6bffba5857d63c6173e4dbb5a8c7f221a29 https://github.com/tribe29/checkmk/commit/a16fe6bffba5857d63c6173e4dbb5a8c7… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/base/data_sources/_abstract.py M cmk/base/data_sources/piggyback.py Log Message: ----------- Simplify return type to `DataSource._get_raw_data()` The highly optimized code in abcdatasource._run() prevents us from moving FileCache handling to the fetchers. In the new design, the raw data is provided by the fetchers. Caching is to be handled in the fetchers as well. The checkers on the receiver end must treat cached data and data from I/O in the same manner, that is, parse them. Neither end of the data chain has room for a boolean flag. In this patch, we remove the boolean value returned by `_get_raw_data()` to indicate whether the raw data comes from cache or I/O. Instead, we check whether the persisted sections are the same as the cached ones. This should be functionaly equivalent. CMK-5174 Change-Id: I104820cfa79223c6f74c34f724a7b8cfca321d56

4 years, 1 month

[tribe29/checkmk] 6992d2: Display a small user menu

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 6992d2f8d539b5ba44dbabacb43419b6a0cb5f01 https://github.com/tribe29/checkmk/commit/6992d2f8d539b5ba44dbabacb43419b6a… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M web/htdocs/themes/facelift/scss/_mega_menu.scss M web/htdocs/themes/facelift/scss/_sidebar.scss Log Message: ----------- Display a small user menu Fix the position of the menu popups at the top along the way. Change-Id: I5476e75ee80c4d5375f74f68ac50ed005f1f0c36

4 years, 1 month

← Newer
1
...
19
20
21
22
23
24
25
...
42
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits August 2020