Checkmk git commits August 2020

checkmk-commits@lists.checkmk.com

1 participants
411 discussions

[tribe29/checkmk] bcb223: 11263 SEC Fix piggyback path traversal

by Lars

Branch: refs/heads/1.5.0 Home: https://github.com/tribe29/checkmk Commit: bcb22313b4c06cf8854c59f5a3220e3318a858ec https://github.com/tribe29/checkmk/commit/bcb22313b4c06cf8854c59f5a3220e331… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: A .werks/11263 M cmk_base/data_sources/abstract.py Log Message: ----------- 11263 SEC Fix piggyback path traversal In previous versions it was possible to create files in the querying Checkmk site by modifying or extending an agent on a monitored system. So an attacker who gained rights on a monitored system to extend the agent could create and modify files in the monitoring Checkmk site with certain modifications of the agent. The creation or modification of files in the Checkmk site was done with rights of the Checkmk site user. This problem is now solved by a better validation of hostnames of piggybacked hosts. With this change only these characters are allowed in Piggybacked hostnames: <tt>0-9a-zA-Z_.-</tt>. These are exactly the same characters that Checkmk normally allows when creating hostnames. A special feature of Piggyback hostnames is that all illegal hostnames are replaced by "_". This change means that Piggyback hosts created with now invalid characters will have to be created differently after this change so that they can continue to be monitored. Change-Id: I36e37d8eb15ccb0b92792eac84eefc56efd52d96

4 years, 1 month

[tribe29/checkmk] 05d4ab: Extract search object selection

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 05d4ab1aed8042e5d4aca7ab0f6f1f0616274ecf https://github.com/tribe29/checkmk/commit/05d4ab1aed8042e5d4aca7ab0f6f1f061… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Extract search object selection Change-Id: Ia74aa7e94674a89ae0f3e9c353e6ee4dbfdd4a67 Commit: ce01fd6f844ee245acc3af71b06223402cfd586b https://github.com/tribe29/checkmk/commit/ce01fd6f844ee245acc3af71b06223402… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Introduce non livestatus quick search matching base classes To prepare for the first non livestatus search filter, we now separate the livestatus match plugins and conductor from the other plugins using a small class hierarchy. The basic plugin search conductor is a stub for the moment and will be populated with the next commits. Change-Id: Ia9102101189d9c9420ce025d470f5c148644932c Commit: 67c9e6f285f7228a07205b4a62cd6f0475c57a72 https://github.com/tribe29/checkmk/commit/67c9e6f285f7228a07205b4a62cd6f047… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Cleanup livestatus_table attribute usage The attribute was not initialized in the constructor and the typing was not clear. All call sites now use the acessor which ensures that the attribute was initialized before. Change-Id: I82c5dcfdfe94e4264ad25dc9bee5a23872bd3fd5 Commit: d67d1b4b94ee55d190c541d92158a2387de7c1d4 https://github.com/tribe29/checkmk/commit/d67d1b4b94ee55d190c541d92158a2387… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Add type hints for get_matches return values Change-Id: I667ae1b5459e9602f24907bf1798867254e54222 Compare: https://github.com/tribe29/checkmk/compare/b4d87c15439f...d67d1b4b94ee

4 years, 1 month

[tribe29/checkmk] dc19fc: Fix recently added test with CRE repo

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: dc19fcdd8bc350acbfcc21915fb45c8ca5992934 https://github.com/tribe29/checkmk/commit/dc19fcdd8bc350acbfcc21915fb45c8ca… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/wato/builtin_modules.py Log Message: ----------- Fix recently added test with CRE repo Change-Id: Ib3a5403ac2101aae4eb02f0aeee0239b59772dc9 Commit: 229a75feb102a901d3e62e3c685cbd5d90ecf220 https://github.com/tribe29/checkmk/commit/229a75feb102a901d3e62e3c685cbd5d9… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/base/data_sources/_abstract.py M cmk/base/data_sources/_cache.py M cmk/base/data_sources/snmp.py Log Message: ----------- Fixup persisted section store typing Let SectionStore know the type of its elements: This way, we can fix it once on instantiation and use the methods in a type checked manner. CMK-5174 Change-Id: I7092c7a31113802b3c6f726d48beafad6673d0ce Commit: b4d87c15439f19658d637d191ca524103de9c5f5 https://github.com/tribe29/checkmk/commit/b4d87c15439f19658d637d191ca524103… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/base/data_sources/_abstract.py Log Message: ----------- Add DataSource.check(RawData) method The new method can be used for direct communication between fetchers and checkers (as implemented now) or for communication over CMC where the checker-manager process must instantiate the checkers and forward the raw data from the core to this method. CMK-5174 Change-Id: I1c4bb3f5fe5ec905f9dfc6e0bb35f9474ab07053 Compare: https://github.com/tribe29/checkmk/compare/5e627caa2780...b4d87c15439f

4 years, 1 month

[tribe29/checkmk] 5e627c: Dark theme images: Introduce an overriding mechanism

by Kenneth

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 5e627caa27802f7ee77335cebaf3cc70d4feec8e https://github.com/tribe29/checkmk/commit/5e627caa27802f7ee77335cebaf3cc70d… Author: Kenneth Okoh <kenneth.okoh(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/htmllib.py M omd/packages/check_mk/skel/etc/check_mk/apache.conf M web/htdocs/themes/facelift/images/icon_close.png M web/htdocs/themes/facelift/images/icon_main_cmk_dashboard.svg M web/htdocs/themes/facelift/images/icon_main_configure.svg M web/htdocs/themes/facelift/images/icon_main_dashboard.svg M web/htdocs/themes/facelift/images/icon_main_folder.svg M web/htdocs/themes/facelift/images/icon_main_help.svg M web/htdocs/themes/facelift/images/icon_main_monitoring.svg M web/htdocs/themes/facelift/images/icon_main_problems.svg M web/htdocs/themes/facelift/images/icon_main_search.svg M web/htdocs/themes/facelift/images/icon_main_setup.svg M web/htdocs/themes/facelift/images/icon_main_user.svg M web/htdocs/themes/facelift/images/icon_maxisnapin.png M web/htdocs/themes/facelift/images/icon_minisnapin.png M web/htdocs/themes/facelift/images/icon_show_less.svg M web/htdocs/themes/facelift/images/icon_show_more.svg M web/htdocs/themes/facelift/images/side_fold.png M web/htdocs/themes/facelift/scss/_more.scss M web/htdocs/themes/facelift/scss/_page_menu.scss M web/htdocs/themes/facelift/scss/_sidebar.scss R web/htdocs/themes/modern-dark/images A web/htdocs/themes/modern-dark/images/icon_close.png A web/htdocs/themes/modern-dark/images/icon_main_cmk_dashboard.svg A web/htdocs/themes/modern-dark/images/icon_main_configure.svg A web/htdocs/themes/modern-dark/images/icon_main_dashboard.svg A web/htdocs/themes/modern-dark/images/icon_main_folder.svg A web/htdocs/themes/modern-dark/images/icon_main_help.svg A web/htdocs/themes/modern-dark/images/icon_main_monitoring.svg A web/htdocs/themes/modern-dark/images/icon_main_problems.svg A web/htdocs/themes/modern-dark/images/icon_main_search.svg A web/htdocs/themes/modern-dark/images/icon_main_setup.svg A web/htdocs/themes/modern-dark/images/icon_main_user.svg A web/htdocs/themes/modern-dark/images/icon_maxisnapin.png A web/htdocs/themes/modern-dark/images/icon_minisnapin.png A web/htdocs/themes/modern-dark/images/icon_show_less.svg A web/htdocs/themes/modern-dark/images/icon_show_more.svg A web/htdocs/themes/modern-dark/images/side_fold.png Log Message: ----------- Dark theme images: Introduce an overriding mechanism * Remove symlink to facelift images * Place some dark theme image versions in themes/modern-dark/images/ * Treat facelift images as backups Change-Id: Ibc58effb991b544c65056a767f7d26a928b49751

4 years, 1 month

[tribe29/checkmk] a30635: 11362 rmon_stats: new, separate discovery ruleset

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: a3063506431f1b7f5613809e545eeea00debebf7 https://github.com/tribe29/checkmk/commit/a3063506431f1b7f5613809e545eeea00… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: A .werks/11362 M checkman/rmon_stats M checks/rmon_stats M cmk/gui/plugins/wato/check_parameters/if.py A cmk/gui/plugins/wato/check_parameters/rmon.py Log Message: ----------- 11362 rmon_stats: new, separate discovery ruleset The discovery of the services provided by the check <tt>rmon_stats</tt>, which monitors RMON statistics, used to be configured via the ruleset "Network Interface and Switch Port Discovery". However, <tt>rmon_stats</tt> does not honor any of the other settings provided by this ruleset. Therefore, the service discovery for <tt>rmon_stats</tt> is now configured via the new, separate ruleset "Monitor RMON statistics". This werk is marked as incompatible because users who configured <tt>rmon_stats</tt> to be discovered have to adjust their rulesets accordingly. This is done by activating the discovery of <tt>rmon_stats</tt> for the corresponding hosts using the new ruleset "Monitor RMON statistics". Without this step, the corresponding services will continue to work but will disappear if a re-discovery is performed. This is a preparation for migrating the if-checks to the new API. Change-Id: Id6970c28f7836eced466be5041dfb7ebc608d4cd

4 years, 1 month

[tribe29/checkmk] 9ed53f: Activate changes: Fix exception before first activ...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9ed53fb3fa4a413e9ea1b1bea1e2c4be24063815 https://github.com/tribe29/checkmk/commit/9ed53fb3fa4a413e9ea1b1bea1e2c4be2… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/wato/pages/activate_changes.py Log Message: ----------- Activate changes: Fix exception before first activation Change-Id: I858a21c645b5120b5465fba62722eab508978726

4 years, 1 month

[tribe29/checkmk] b0b456: Fix page status update: Correctly show number of s...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: b0b456fea4bddda9bd526f08a36ea6a931960e97 https://github.com/tribe29/checkmk/commit/b0b456fea4bddda9bd526f08a36ea6a93… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M web/htdocs/js/modules/selection.js M web/htdocs/js/modules/utils.js Log Message: ----------- Fix page status update: Correctly show number of selected rows Change-Id: I1eb601f4992807dd1de762a6fb8cfd8c37a5ed21

4 years, 1 month

[tribe29/checkmk] 0e5cab: Better alignment of topic icon and image

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 0e5cabccdec830d4b8ed676438aefa7a03e468c6 https://github.com/tribe29/checkmk/commit/0e5cabccdec830d4b8ed676438aefa7a0… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M web/htdocs/themes/facelift/scss/_mega_menu.scss Log Message: ----------- Better alignment of topic icon and image Change-Id: Ide3ef78b88b81d4829c0b1f9c3832962512c4c95

4 years, 1 month

[tribe29/checkmk] 297bc0: Adapt the size of the "Show all" menu as well

by Tom Bärwinkel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 297bc015491b9aa219fe13faf3e168fcb176b762 https://github.com/tribe29/checkmk/commit/297bc015491b9aa219fe13faf3e168fcb… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M web/htdocs/js/modules/popup_menu.js M web/htdocs/themes/facelift/scss/_mega_menu.scss Log Message: ----------- Adapt the size of the "Show all" menu as well The mega menu is now resized as well when the "Show all" link is clicked, the menu is resized, or the back arrow to the all topics overview is clicked. CMK-5115 Change-Id: If34d4bc9102408c8ab1a666f3f480555509b8a87

4 years, 1 month

[tribe29/checkmk] 9493f8: Simplify classes

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 9493f8e0db9dd3626e5e4aa0a5ee1dd30d684d82 https://github.com/tribe29/checkmk/commit/9493f8e0db9dd3626e5e4aa0a5ee1dd30… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Simplify classes Make _build_url a simple helper function and drop the now empty base class LivestatusSearchBase. Change-Id: I28459870f0709e86eff7904033c6d52b24f450b9 Commit: 7fff9851f3fdddac4f23454d212038ab232e3e37 https://github.com/tribe29/checkmk/commit/7fff9851f3fdddac4f23454d212038ab2… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Clarified result processing Instead of populating the class member self._elements, the results of the search are now passed through the call stack until they reach the method that generates HTML code for the search result. This reduces the class level state to simplify the code. Change-Id: I8187160f7897dbf94ba2221b41fb5d35d2a1460d Commit: f6975f030d5ecde8f4c4ecc4ccfa39a95ea9f18e https://github.com/tribe29/checkmk/commit/f6975f030d5ecde8f4c4ecc4ccfa39a95… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Use better data structure for results Change-Id: Ibd0e87dcda42c45a764a1e62202d17e70e2f7dfc Commit: fed3ac75a1de708e4ba46cede559ef4a3df6c767 https://github.com/tribe29/checkmk/commit/fed3ac75a1de708e4ba46cede559ef4a3… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Extract result HTML rendering Move the HTML rendering of the search results to a dedicated render class. Inline two tiny helper functions into the quicksearch page handlers for a smaller call stack. Change-Id: I5c516574c35971cff6b92e2725f12e3808d7274e Commit: 1ec32e20b38157eaece4b06e41c825dcc78bc35a https://github.com/tribe29/checkmk/commit/1ec32e20b38157eaece4b06e41c825dcc… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/config/base.py M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Clarify filter behaviour value Change-Id: I329ee2eab0a52bea887335fbefb99622c5d39a13 Commit: 7b0686665096ac9589d5f83768c7f8a16f659749 https://github.com/tribe29/checkmk/commit/7b0686665096ac9589d5f83768c7f8a16… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Clarified search object processing Instead of populating the class member self._search_objects, these objects are are now passed through the call stack until they produce the search result objects. This clarifies the dependencies and flow. Change-Id: I956b44d446cf771224f5cb42679b4fe2f34945d9 Commit: fa996af48a243ccf6bb159c7bd2b8e7d933ec9fc https://github.com/tribe29/checkmk/commit/fa996af48a243ccf6bb159c7bd2b8e7d9… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Generalized class name The quicksearch plugins may use livestatus, but are not tied to it. We'll have non livestatus plugins soon. Prepare for it. Add some more doc strings. Change-Id: Iaa5929740bfb0b944db023bde0a7dcd9e7e3dbcd Commit: 25eec5885d9e854212bb095a84f4c2a755ce5444 https://github.com/tribe29/checkmk/commit/25eec5885d9e854212bb095a84f4c2a75… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-08-17 (Mon, 17 Aug 2020) Changed paths: M cmk/gui/plugins/sidebar/quicksearch.py Log Message: ----------- Add conductor base class Until now all quicksearch plugins are based on livestatus queries and may be aggregated by the LivestatusSearchConductor. Once we add the first non livestatus filter, we need to handle it in a different way. This commit prepares for introducing another type of plugin. This will then be managed by a search conductor without further aggregation. Change-Id: Ie78bb290c454f80063bac142b63ee21a9ac5d694 Compare: https://github.com/tribe29/checkmk/compare/a3cbfcfb777f...25eec5885d9e

4 years, 1 month

← Newer
1
...
18
19
20
21
22
23
24
...
42
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits August 2020