Checkmk git commits October 2020

checkmk-commits@lists.checkmk.com

1 participants
676 discussions

[tribe29/checkmk] fdc83f: Rewrite matching a href unescape regex to separate...

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: fdc83feb6afa04ad48a6de5e211322850470a86f https://github.com/tribe29/checkmk/commit/fdc83feb6afa04ad48a6de5e211322850… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/htmllib.py M tests/unit/cmk/gui/test_htmllib_Escaper.py Log Message: ----------- Rewrite matching a href unescape regex to separate attributes The goal of this commit is to separate the values of the href and target attributes in dedicated match groups. We also exclude the quotes from the match groups to simplify the code. Change-Id: Iadcd8a252f0c8bd737e5ad5671b93cc875f71898 Commit: 87ceb966b1ae46947b696232af84a4f9f0ab74e1 https://github.com/tribe29/checkmk/commit/87ceb966b1ae46947b696232af84a4f9f… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/htmllib.py M tests/unit/cmk/gui/test_htmllib_Escaper.py Log Message: ----------- Prevent non http/https links from being unescaped Our permissive HTML escaping is preserving some HTML tags, which includes basic link tags (a tag with href and optional target attributes). Previous versions were not inspecting the value of href, which made it possible to add links with e.g. a "javascript:" protocol. This opened some XSS attack vectors. After this change it is only possible to link to http and https protocols. All other links will not be unescaped. Change-Id: If639df20428e46d5bdc7ef14dec659babd89f86d Commit: cada7adf232c5454dbdd4946c099c7b3d4f60ed7 https://github.com/tribe29/checkmk/commit/cada7adf232c5454dbdd4946c099c7b3d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11501 Log Message: ----------- 11501 SEC Fix possible XSS using titles of views Authenticated users that are allowed to configure and share custom views could inject arbitrary JS code to all users which are permitted to view this view. Change-Id: Ib7f2e4523eff3b3a460c6558b13e160057dcfffd Compare: https://github.com/tribe29/checkmk/compare/121a72f1bdd3...cada7adf232c

3 years, 11 months

[tribe29/checkmk] 121a72: heartbeat_crm: refactored general parse function

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 121a72f1bdd3b405be8211ff05dde8338ce0a677 https://github.com/tribe29/checkmk/commit/121a72f1bdd3b405be8211ff05dde8338… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M checks/heartbeat_crm Log Message: ----------- heartbeat_crm: refactored general parse function Change-Id: Icec5b473df224bdc52d34498f1c17ed53b11a86f

3 years, 11 months

[tribe29/checkmk] 449bd4: nimble_latency: refactored to use check_levels

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 449bd47177d7644afdcf2c629db27f8b11c7131b https://github.com/tribe29/checkmk/commit/449bd47177d7644afdcf2c629db27f8b1… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M checks/nimble_latency Log Message: ----------- nimble_latency: refactored to use check_levels Note: no test file as check is producting wrong results. See analysis: CMK-5821. Test will be added once the check has been reworked. CMK-5927 Change-Id: I8c090be0d91100f391a199d79f8016ed077b2752

3 years, 11 months

[tribe29/checkmk] 7db1d3: [Weblate] Updated translation files

by Weblate (bot)

Branch: refs/heads/test_weblate2 Home: https://github.com/tribe29/checkmk Commit: 7db1d31bbcd24db8017621ea8ac7346dd5ae0190 https://github.com/tribe29/checkmk/commit/7db1d31bbcd24db8017621ea8ac7346dd… Author: Weblate <noreply(a)weblate.org> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M locale/de/LC_MESSAGES/multisite.po M locale/fr/LC_MESSAGES/multisite.po M locale/ro/LC_MESSAGES/multisite.po Log Message: ----------- [Weblate] Updated translation files Translation: checkmk2/test_weblate2 Translate-URL: https://translate.checkmk.com/projects/checkmk2/test_weblate2/ Change-Id: I959c63998c5965dc0d2c47b04be02c0f07bed618

3 years, 11 months

[tribe29/checkmk] 4c00e0: 11331 FIX heartbeat_crm: fixed crash when checking...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 4c00e0e721cc437e412d9d6f3bcdc01960a6fea8 https://github.com/tribe29/checkmk/commit/4c00e0e721cc437e412d9d6f3bcdc0196… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11331 M checks/heartbeat_crm A tests/unit/checks/generictests/datasets/heartbeat_crm_2_regression.py Log Message: ----------- 11331 FIX heartbeat_crm: fixed crash when checking pacemaker version 2.0.3 CMK-5454 Change-Id: I51211e55da08106a4c3a79d26db81f17e16095d2

3 years, 11 months

[tribe29/checkmk] 89258e: Replace call sites of cmk.gui.htmllib.HTML.makeuri...

by Jörg Herbel

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 89258ecc92b705c80c9d8f75b549901a2190eff9 https://github.com/tribe29/checkmk/commit/89258ecc92b705c80c9d8f75b549901a2… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/plugins/dashboard/utils.py M cmk/gui/plugins/dashboard/view.py M cmk/gui/plugins/metrics/html_render.py M cmk/gui/plugins/sidebar/bi.py M cmk/gui/plugins/sidebar/search.py M cmk/gui/plugins/sidebar/tactical_overview.py M cmk/gui/plugins/sidebar/virtual_host_tree.py M cmk/gui/plugins/views/availability.py M cmk/gui/plugins/views/bi.py M cmk/gui/plugins/views/crash_reporting.py M cmk/gui/plugins/views/graphs.py M cmk/gui/plugins/views/icons/builtin.py M cmk/gui/plugins/views/icons/topology.py M cmk/gui/plugins/views/icons/wato.py M cmk/gui/plugins/views/inventory.py M cmk/gui/plugins/views/painters.py M cmk/gui/plugins/views/utils.py Log Message: ----------- Replace call sites of cmk.gui.htmllib.HTML.makeuri*, part 2/5 * cmk.gui.htmllib.HTML.makeuri --> cmk.gui.utils.urls.makeuri * cmk.gui.htmllib.HTML.makeuri_contextless --> cmk.gui.utils.urls.makeuri_contextless CMK-5885 Change-Id: I19118090e411e33e6b77cd47756ff11c671ec1bf Commit: be1441cd82ab3e1d1355e1bcbd3bbb6500f5e92f https://github.com/tribe29/checkmk/commit/be1441cd82ab3e1d1355e1bcbd3bbb650… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/htmllib.py Log Message: ----------- Remove now unused methods makeuri* from cmk.gui.htmllib.HTML The following two methods now reside in cmk.gui.utils.urls: * makeuri * makeuri_contextless CMK-5885 Change-Id: I26f706caff17bc9e11ca8e788edce6795232797e Compare: https://github.com/tribe29/checkmk/compare/c2fb95805a75...be1441cd82ab

3 years, 11 months

[tribe29/checkmk] 42310d: Re-build search index when missing

by Jörg Herbel

Branch: refs/heads/test_weblate2 Home: https://github.com/tribe29/checkmk Commit: 42310d92d6b5c0f2a54b09f657e87cec03ab280d https://github.com/tribe29/checkmk/commit/42310d92d6b5c0f2a54b09f657e87cec0… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/watolib/search.py Log Message: ----------- Re-build search index when missing When attempting to load the search index but the file is missing (for example because the tmpfs was unmounted), we re-build the full index. CMK-5947 Change-Id: Ifb05fde21f213363fd3cfd9792aa27a3b309407a Commit: 098e67253b291c0eedd590a557707262e8249f29 https://github.com/tribe29/checkmk/commit/098e67253b291c0eedd590a557707262e… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11401 Log Message: ----------- 11401 New Bakery API CMK-4680 Change-Id: I54a7210af45f51b82a5c3b653877386dcb673cd7 Commit: f78b5f7241291616e956fa67db25a5a996a33d1a https://github.com/tribe29/checkmk/commit/f78b5f7241291616e956fa67db25a5a99… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11402 Log Message: ----------- 11402 Agent Bakery: New "Bake and sign" action It is now possible to bake and sign all agents in one step. You can simply do this by pressing the corresponding button at the agent bakery. It will be available as soon as at least one signature key has been created or imported. When invoking "Bake and sign agents", you will be prompted for selecting a signature key and entering its passphrase. After that, every agent package will get baked and signed immediately after baking. When using "Bake and sign", it is assured that there are no unsigned packages visible for download at any time, avoiding that it could be seen accidentally by a calling agent updater, leading to a "The deployment server provides an agent but that is not signed." error. The "Bake and sign" action is also available via REST API, please refer to the documentation for details. CMK-4680 Change-Id: I47706ea843b1c7f0e53561d6e7e5d87ea39d2930 Commit: 5cae433d3c160d315f2a3ce4e90daaf9a4e8ed90 https://github.com/tribe29/checkmk/commit/5cae433d3c160d315f2a3ce4e90daaf9a… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11403 Log Message: ----------- 11403 Improved versioning for baked agent packages Previously, when updating a baked agent via a package manager, you would eventually receive a warning about a downgrade of the Checkmk agent. The reason for this was the baked agent's version string, that was formed of Checkmk version and the agent's configuration hash , with the latter being quite random and thus confusing the package manager, that expects an increasing versioning. E.g. a version string could be <tt>1.6.0p18.f123abcd</tt> before bake, and <tt>1.6.0p18.1234cdef</tt> after bake. This behavior is now fixed by introducing an internal bake revision, that increases on every newly baked package (per Checkmk version) and that's only purpose is to guarantee an inceasing version string for the .rpm, .deb and .pkg packages (e.g. <tt>1.6.0p18-1.f123abcd</tt> before bake, <tt>1.6.0p17-2.1234cdef</tt> after bake). Please note that this revision won't be visible on the GUI or in the package's filenames, it only affects the package's metadata. CMK-4860 Change-Id: I5d2c65de22bc64ebb1cb53f76d6a77082428658f Commit: bd23e38bc37f1a45fede40f844c2ada178b3946c https://github.com/tribe29/checkmk/commit/bd23e38bc37f1a45fede40f844c2ada17… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11118 M tests/unit/cmk/base/test_checks.py Log Message: ----------- 11118 Plugin development: make all includes imports This Werk only affects users who have developed their own check or inventory plugins *and* are using some of the shipped includes in them. Change-Id: Ia9b86a981a4197def7960dfd7146c0c89263dc64 Commit: 0f3c4c421322f6b9ae1724bf3df8027911113e88 https://github.com/tribe29/checkmk/commit/0f3c4c421322f6b9ae1724bf3df802791… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/watolib/changes.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/rulespecs.py M cmk/gui/watolib/search.py M tests/unit/cmk/gui/conftest.py Log Message: ----------- Change-specific updates of search index used for Setup search Up to now, the full index was re-built at every change. Now, upon a change, we only re-build the affected sub-indices. CMK-5867 Change-Id: Ib058c9e3b4c1a148c20a2e8d864928ce638c8e58 Commit: fcad5ad9d79de80cc0b20d897142502b64f514e1 https://github.com/tribe29/checkmk/commit/fcad5ad9d79de80cc0b20d897142502b6… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/plugins/wato/__init__.py M cmk/gui/plugins/wato/builtin_modules.py M cmk/gui/plugins/wato/check_parameters/cpu_utilization_cluster.py M cmk/gui/plugins/wato/check_parameters/domino_tasks.py M cmk/gui/plugins/wato/check_parameters/hw_errors.py M cmk/gui/plugins/wato/check_parameters/mem_cluster.py M cmk/gui/plugins/wato/check_parameters/omd_status.py M cmk/gui/plugins/wato/check_parameters/ps.py M cmk/gui/plugins/wato/check_parameters/raid.py M cmk/gui/plugins/wato/check_parameters/tcp_connections.py M cmk/gui/plugins/wato/check_parameters/temperature_auto.py M cmk/gui/plugins/wato/check_parameters/vm_state.py M cmk/gui/plugins/wato/check_parameters/wmic_process.py M cmk/gui/plugins/wato/check_parameters/zpool_status.py M cmk/gui/plugins/wato/check_parameters/zypper.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/watolib/__init__.py M cmk/gui/watolib/rulespecs.py M tests/unit/cmk/gui/plugins/sidebar/test_wato.py M tests/unit/cmk/gui/watolib/test_rulespecs.py Log Message: ----------- Rename "Manual services" to "Enforced services" and change placement in MegaMenu CMK-5796 Change-Id: I2a14d597cbdae2a55c0d5f6b519a8187a12a1013 Commit: c5362093a620b25556abeebc4c630dac21f278cc https://github.com/tribe29/checkmk/commit/c5362093a620b25556abeebc4c630dac2… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/plugins/wato/active_checks.py M cmk/gui/plugins/wato/builtin_modules.py M tests/unit/cmk/gui/watolib/test_rulespecs.py Log Message: ----------- Rename "Check networking services" to "HTTP, TCP, Email, ..." CMK-5796 Change-Id: I3a7df953d2a24b5739ed8066f37ffa2aa968bc4a Commit: 656eba798b8c86daf7ff585d167cbc43561e6b7d https://github.com/tribe29/checkmk/commit/656eba798b8c86daf7ff585d167cbc435… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M web/htdocs/themes/facelift/scss/_pages.scss Log Message: ----------- Fix highlighting invalid select2 dropdowns CMK-5897 Change-Id: I0a4c4ca80957fb02261dbebd882ffde5f4ff8e8a Commit: 9a95b750a5c42ff010d78f7d34e2bb7babaec967 https://github.com/tribe29/checkmk/commit/9a95b750a5c42ff010d78f7d34e2bb7ba… Author: Ronny Bruska <ronny.bruska(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/forms.py M cmk/gui/plugins/wato/utils/__init__.py Log Message: ----------- Fixed "Show more"/"Show less" mode in wato pages "Show more" settings were not shown in enforced "Show more" mode. CMK-5296 Change-Id: I48028f8b6ad86ee14c93ce7671e6dd1f56d0cfc4 Commit: 1b4585abd321afdcaf2f42244288c25c889dbde5 https://github.com/tribe29/checkmk/commit/1b4585abd321afdcaf2f42244288c25c8… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/base/checkers/_abstract.py M cmk/utils/cpu_tracking.py M tests/unit/cmk/utils/test_cpu_tracking.py Log Message: ----------- cpu_tracking: Remove `track` decorator cpu tracking is used 3 times in our code base. Every time via a different mechanism. By removing one such mechanism, we make the code more consistent and easier to modify and understand. CMK-5920 Change-Id: I860cd4c6b4c29eee226d70baf861fe942e560447 Commit: 131bcb514e1b3de6a173f391a05efb98f1f9642c https://github.com/tribe29/checkmk/commit/131bcb514e1b3de6a173f391a05efb98f… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/base/checking.py Log Message: ----------- cpu_tracking: Use `execute()` context manager in checking This increases the consistency of the code and should allow us to privatize a series of functions in cpu_tracking. Diff the code with `--ignore-all-space`. CMK-5920 Change-Id: I1949daa73b181c378e8ca245d2769dcab18c0ef8 Commit: 0be6e24a9427b477d17c4e6b6c007609bdc0d1ef https://github.com/tribe29/checkmk/commit/0be6e24a9427b477d17c4e6b6c007609b… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/utils/cpu_tracking.py M tests/unit/cmk/utils/test_cpu_tracking.py Log Message: ----------- cpu_tracking: Make private API This improves the layering and makes sure that we control the entry points into this module. CMK-5920 Change-Id: Ifba1dea2e1bd26a2e2c79100c14a4bd1ce72395f Commit: 797dbbca7a4a63a419bf23a6d2cb275681ec36d6 https://github.com/tribe29/checkmk/commit/797dbbca7a4a63a419bf23a6d2cb27568… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/base/plugins/agent_based/snmp_info.py R inventory/snmp_info Log Message: ----------- Migrate snmp_info inventory plugin The inventory plugin was incompatible with the section of the already migrated check which lead to a crash in SNMP device inventories. CMK-5890 Change-Id: I394c4ca422df352208ed1a04e9ae2781242ab594 Commit: c71b16d8c8fe472e72afd7b453e16e951357c82e https://github.com/tribe29/checkmk/commit/c71b16d8c8fe472e72afd7b453e16e951… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/7899 M cmk/gui/watolib/host_attributes.py Log Message: ----------- 7899 FIX Fix configuring empty tag ID tags on hosts / folders CMK-2277 Change-Id: Ib152de01a826e3f8f1c07a40b4eb3129fd1b453a Commit: 2eac736889de1151f9b05ae6fd3c2c16e9543095 https://github.com/tribe29/checkmk/commit/2eac736889de1151f9b05ae6fd3c2c16e… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11404 Log Message: ----------- 11404 Better detection of changes in baked agent packages Previously, the only property that has been observed by the agent bakery to decide whether to bake new agents, was the WATO agent configuration. This sometimes lead to problems when deploying your own plugins, because changes in agent plugin files won't get recognized and hence no new agent would get baked. Furthermore, if you managed to force-bake the agents, including the file changes, the config hash would still stay the same, hence the agent updater would refuse to deploy the new package to the hosts. The agent bakery will now recognize changes in every file that gets deployed to the configured agent packages and reflect them in generating a different agent hash on baking agents. Similar to a config change, changes in underlying files will lead to a highlighted "Bake agents" button at the agent bakery. Please note that this mechanism will only work work bakery plugins that are specified via the new Bakery API, see Werk #11401. This includes all builtin bakery plugins. E.g., if you decide to adapt the Checkmk linux agent (copy an adapted version to the local hierarchy), your changes will get recognized. CMK-4860 Change-Id: Iccd1ed937bde2439bad4b5e3c5352e8895a30935 Commit: bf57fb0d05ae18ce52cff4469803c6e692e8f680 https://github.com/tribe29/checkmk/commit/bf57fb0d05ae18ce52cff4469803c6e69… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/watolib/hosts_and_folders.py Log Message: ----------- Fix wrong target URLs for hosts/folders from setup search Change-Id: Ib80b035f4e7a11c22a7febb82c25260a38666095 Commit: 08ef54261ab227b73a283279edeebc6a7ddf5cc1 https://github.com/tribe29/checkmk/commit/08ef54261ab227b73a283279edeebc6a7… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/utils/cpu_tracking.py Log Message: ----------- cpu_tracking: Explicitly pass `phase_name` CMK-5920 Change-Id: I995e3e75f06abdb19630f594f099a362529f6dae Commit: cc4153e99c4a52ab69b49cfb5de5f05653b4ba1d https://github.com/tribe29/checkmk/commit/cc4153e99c4a52ab69b49cfb5de5f0565… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M tests/unit/cmk/utils/test_cpu_tracking.py Log Message: ----------- cpu_tracking: Add `set_time` fixture This avoids code duplication while being more explicit. CMK-5920 Change-Id: I1085d26e410fb56f52bfa6a35235dff1b628d505 Commit: 54e80c73665dcf95f4876b4458f6fc783d173c6d https://github.com/tribe29/checkmk/commit/54e80c73665dcf95f4876b4458f6fc783… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M tests/unit/cmk/utils/test_cpu_tracking.py Log Message: ----------- cpu_tracking: Add nesting test This seems to be buggy as the stacking does not work and the measurements run sequentially. CMK-5920 Change-Id: I9cc35f0486311db255cd951b9af9783faf52627a Commit: 8f1eb4f8b8b8b91208c1160746676ebf925643b1 https://github.com/tribe29/checkmk/commit/8f1eb4f8b8b8b91208c1160746676ebf9… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/base/plugins/agent_based/tcp_conn_stats.py M tests/unit/cmk/base/plugins/agent_based/test_tcp_conn_stats.py Log Message: ----------- tcp_conn_stats: shorten service output Change-Id: Ia8b4ad3a81c6c4ccd6a2f1b6539281dfa0e9ad61 Commit: d12b258e3d86b1ec73a5b6801b960f8a42958e3d https://github.com/tribe29/checkmk/commit/d12b258e3d86b1ec73a5b6801b960f8a4… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/main_menu.py M cmk/gui/pagetypes.py M cmk/gui/plugins/sidebar/bookmarks.py M cmk/gui/plugins/sidebar/main_menu.py M cmk/gui/plugins/sidebar/utils.py M cmk/gui/plugins/sidebar/views.py M cmk/gui/plugins/sidebar/wato.py M cmk/gui/plugins/views/builtin.py M cmk/gui/plugins/views/mkeventd.py M cmk/gui/plugins/wato/bi_config.py M cmk/gui/plugins/wato/builtin_modules.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/plugins/wato/utils/main_menu.py M cmk/gui/type_defs.py M cmk/gui/valuespec.py M cmk/gui/views.py M cmk/gui/wato/pages/icons.py M cmk/gui/wato/user_profile.py M web/htdocs/js/modules/valuespecs.js Log Message: ----------- Emblems can be selected in IconSelector now It is now possible to select an emblem in an IconSelector if with_emblem is set to True. To make this possible the icon rendering methods in htmllib.py now accept either a str which uses a plain icon or a TypedDict with an icon and an emblem. The various call sites are adapted as well. Right now the selector with an emblem is relatively simple and will be changed in a later commit. CMK-5775 Change-Id: I9b279f146facea8db28cdfda6f0cfcb2cc44b1ce Commit: c2fb95805a75ae6b80cec8a3a5ef6ef19fdb9b99 https://github.com/tribe29/checkmk/commit/c2fb95805a75ae6b80cec8a3a5ef6ef19… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Improve dropdown valuespec validation error Change-Id: Ia94f721afb66b1dab4573475725d70aa56db1c6a Commit: 274d2fc5866cf4c99df510b1020b924c0a48ab4a https://github.com/tribe29/checkmk/commit/274d2fc5866cf4c99df510b1020b924c0… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11118 A .werks/11401 A .werks/11402 A .werks/11403 A .werks/11404 A .werks/7899 M cmk/base/checkers/_abstract.py M cmk/base/checking.py M cmk/base/plugins/agent_based/snmp_info.py M cmk/base/plugins/agent_based/tcp_conn_stats.py M cmk/gui/forms.py M cmk/gui/htmllib.py M cmk/gui/main_menu.py M cmk/gui/pagetypes.py M cmk/gui/plugins/sidebar/bookmarks.py M cmk/gui/plugins/sidebar/main_menu.py M cmk/gui/plugins/sidebar/utils.py M cmk/gui/plugins/sidebar/views.py M cmk/gui/plugins/sidebar/wato.py M cmk/gui/plugins/views/builtin.py M cmk/gui/plugins/views/mkeventd.py M cmk/gui/plugins/wato/__init__.py M cmk/gui/plugins/wato/active_checks.py M cmk/gui/plugins/wato/bi_config.py M cmk/gui/plugins/wato/builtin_modules.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/plugins/wato/check_parameters/cpu_utilization_cluster.py M cmk/gui/plugins/wato/check_parameters/domino_tasks.py M cmk/gui/plugins/wato/check_parameters/hw_errors.py M cmk/gui/plugins/wato/check_parameters/mem_cluster.py M cmk/gui/plugins/wato/check_parameters/omd_status.py M cmk/gui/plugins/wato/check_parameters/ps.py M cmk/gui/plugins/wato/check_parameters/raid.py M cmk/gui/plugins/wato/check_parameters/tcp_connections.py M cmk/gui/plugins/wato/check_parameters/temperature_auto.py M cmk/gui/plugins/wato/check_parameters/vm_state.py M cmk/gui/plugins/wato/check_parameters/wmic_process.py M cmk/gui/plugins/wato/check_parameters/zpool_status.py M cmk/gui/plugins/wato/check_parameters/zypper.py M cmk/gui/plugins/wato/utils/__init__.py M cmk/gui/plugins/wato/utils/main_menu.py M cmk/gui/type_defs.py M cmk/gui/valuespec.py M cmk/gui/views.py M cmk/gui/wato/pages/icons.py M cmk/gui/wato/user_profile.py M cmk/gui/watolib/__init__.py M cmk/gui/watolib/changes.py M cmk/gui/watolib/host_attributes.py M cmk/gui/watolib/hosts_and_folders.py M cmk/gui/watolib/rulespecs.py M cmk/gui/watolib/search.py M cmk/utils/cpu_tracking.py R inventory/snmp_info M tests/unit/cmk/base/plugins/agent_based/test_tcp_conn_stats.py M tests/unit/cmk/base/test_checks.py M tests/unit/cmk/gui/conftest.py M tests/unit/cmk/gui/plugins/sidebar/test_wato.py M tests/unit/cmk/gui/watolib/test_rulespecs.py M tests/unit/cmk/utils/test_cpu_tracking.py M web/htdocs/js/modules/valuespecs.js M web/htdocs/themes/facelift/scss/_pages.scss Log Message: ----------- Merge branch 'master' into test_weblate2 Change-Id: I486cb31d6ed305f690786ebf92728fb9099ab7b8 Compare: https://github.com/tribe29/checkmk/compare/025cd7aa2742...274d2fc5866c

3 years, 11 months

[tribe29/checkmk] d12b25: Emblems can be selected in IconSelector now

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d12b258e3d86b1ec73a5b6801b960f8a42958e3d https://github.com/tribe29/checkmk/commit/d12b258e3d86b1ec73a5b6801b960f8a4… Author: Tom Baerwinkel <tom.baerwinkel(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/htmllib.py M cmk/gui/main_menu.py M cmk/gui/pagetypes.py M cmk/gui/plugins/sidebar/bookmarks.py M cmk/gui/plugins/sidebar/main_menu.py M cmk/gui/plugins/sidebar/utils.py M cmk/gui/plugins/sidebar/views.py M cmk/gui/plugins/sidebar/wato.py M cmk/gui/plugins/views/builtin.py M cmk/gui/plugins/views/mkeventd.py M cmk/gui/plugins/wato/bi_config.py M cmk/gui/plugins/wato/builtin_modules.py M cmk/gui/plugins/wato/check_mk_configuration.py M cmk/gui/plugins/wato/utils/main_menu.py M cmk/gui/type_defs.py M cmk/gui/valuespec.py M cmk/gui/views.py M cmk/gui/wato/pages/icons.py M cmk/gui/wato/user_profile.py M web/htdocs/js/modules/valuespecs.js Log Message: ----------- Emblems can be selected in IconSelector now It is now possible to select an emblem in an IconSelector if with_emblem is set to True. To make this possible the icon rendering methods in htmllib.py now accept either a str which uses a plain icon or a TypedDict with an icon and an emblem. The various call sites are adapted as well. Right now the selector with an emblem is relatively simple and will be changed in a later commit. CMK-5775 Change-Id: I9b279f146facea8db28cdfda6f0cfcb2cc44b1ce Commit: c2fb95805a75ae6b80cec8a3a5ef6ef19fdb9b99 https://github.com/tribe29/checkmk/commit/c2fb95805a75ae6b80cec8a3a5ef6ef19… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/valuespec.py Log Message: ----------- Improve dropdown valuespec validation error Change-Id: Ia94f721afb66b1dab4573475725d70aa56db1c6a Compare: https://github.com/tribe29/checkmk/compare/8f1eb4f8b8b8...c2fb95805a75

3 years, 11 months

[tribe29/checkmk] cc4153: cpu_tracking: Add `set_time` fixture

by Moritz

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: cc4153e99c4a52ab69b49cfb5de5f05653b4ba1d https://github.com/tribe29/checkmk/commit/cc4153e99c4a52ab69b49cfb5de5f0565… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M tests/unit/cmk/utils/test_cpu_tracking.py Log Message: ----------- cpu_tracking: Add `set_time` fixture This avoids code duplication while being more explicit. CMK-5920 Change-Id: I1085d26e410fb56f52bfa6a35235dff1b628d505 Commit: 54e80c73665dcf95f4876b4458f6fc783d173c6d https://github.com/tribe29/checkmk/commit/54e80c73665dcf95f4876b4458f6fc783… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M tests/unit/cmk/utils/test_cpu_tracking.py Log Message: ----------- cpu_tracking: Add nesting test This seems to be buggy as the stacking does not work and the measurements run sequentially. CMK-5920 Change-Id: I9cc35f0486311db255cd951b9af9783faf52627a Commit: 8f1eb4f8b8b8b91208c1160746676ebf925643b1 https://github.com/tribe29/checkmk/commit/8f1eb4f8b8b8b91208c1160746676ebf9… Author: Moritz Kiemer <moritz.kiemer(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/base/plugins/agent_based/tcp_conn_stats.py M tests/unit/cmk/base/plugins/agent_based/test_tcp_conn_stats.py Log Message: ----------- tcp_conn_stats: shorten service output Change-Id: Ia8b4ad3a81c6c4ccd6a2f1b6539281dfa0e9ad61 Compare: https://github.com/tribe29/checkmk/compare/08ef54261ab2...8f1eb4f8b8b8

3 years, 11 months

[tribe29/checkmk] 08ef54: cpu_tracking: Explicitly pass `phase_name`

by Mathias Laurin

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 08ef54261ab227b73a283279edeebc6a7ddf5cc1 https://github.com/tribe29/checkmk/commit/08ef54261ab227b73a283279edeebc6a7… Author: Mathias Laurin <mathias.laurin(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/utils/cpu_tracking.py Log Message: ----------- cpu_tracking: Explicitly pass `phase_name` CMK-5920 Change-Id: I995e3e75f06abdb19630f594f099a362529f6dae

3 years, 11 months

← Newer
1
...
24
25
26
27
28
29
30
...
68
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2020