Checkmk git commits October 2020

checkmk-commits@lists.checkmk.com

1 participants
676 discussions

[tribe29/checkmk] c00f45: Rewrite matching a href unescape regex to separate...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: c00f450f884d8a229b7d8ab3f0452ed802a1ae04 https://github.com/tribe29/checkmk/commit/c00f450f884d8a229b7d8ab3f0452ed80… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: M cmk/gui/escaping.py M tests/unit/cmk/gui/test_htmllib_Escaper.py Log Message: ----------- Rewrite matching a href unescape regex to separate attributes The goal of this commit is to separate the values of the href and target attributes in dedicated match groups. We also exclude the quotes from the match groups to simplify the code. Change-Id: I1e64946a1a426d81284b3173db43135ee0d1debc Commit: e7fd8e4c90be490e4293ec91804d00ec01af5ca6 https://github.com/tribe29/checkmk/commit/e7fd8e4c90be490e4293ec91804d00ec0… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: M cmk/gui/escaping.py M tests/unit/cmk/gui/test_htmllib_Escaper.py Log Message: ----------- Prevent non http/https links from being unescaped Our permissive HTML escaping is preserving some HTML tags, which includes basic link tags (a tag with href and optional target attributes). Previous versions were not inspecting the value of href, which made it possible to add links with e.g. a "javascript:" protocol. This opened some XSS attack vectors. After this change it is only possible to link to http and https protocols. All other links will not be unescaped. Change-Id: I6e029ecc52f3dd3fc1f213c7f809332e3e49b3ee Commit: 8b2ec5192eb3dc29ca4a85b3e932bf56dd5b433a https://github.com/tribe29/checkmk/commit/8b2ec5192eb3dc29ca4a85b3e932bf56d… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: A .werks/11501 Log Message: ----------- 11501 SEC Fix possible XSS using titles of views Authenticated users that are allowed to configure and share custom views could inject arbitrary JS code to all users which are permitted to view this view. Change-Id: Ib7f2e4523eff3b3a460c6558b13e160057dcfffd Compare: https://github.com/tribe29/checkmk/compare/1c2e8c2f6e49...8b2ec5192eb3

3 years, 11 months

[tribe29/checkmk] 1c2e8c: WSGI Profiler: reset on every request

by Christoph Rauch

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 1c2e8c2f6e49a2a99612f497f41acfc35ee395a6 https://github.com/tribe29/checkmk/commit/1c2e8c2f6e49a2a99612f497f41acfc35… Author: Christoph Rauch <christoph.rauch(a)tribe29.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: M cmk/gui/wsgi/profiling.py M tests/unit/cmk/gui/wsgi/test_wsgi_router.py Log Message: ----------- WSGI Profiler: reset on every request * can be set to "accumulating" again by changing a flag in the code. Change-Id: I4497d0ffb4a30fa5b09b43a0ece7e9927a3bfd22

3 years, 11 months

[tribe29/checkmk] 1200ad: 11500 Microcore: Improved memory efficiency of hel...

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 1200ad9bfb02168ffdf76b7708361bb68e5a46d5 https://github.com/tribe29/checkmk/commit/1200ad9bfb02168ffdf76b7708361bb68… Author: Lars Michelsen <lm(a)tribe29.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: A .werks/11500 Log Message: ----------- 11500 Microcore: Improved memory efficiency of helper processes In previous versions the Checkmk Microcore used so called Checkmk helper processes to execute the "Check_MK" services of the monitored hosts. In larger installations, these processes consumed a lot of memory, because a) they held the Checkmk configuration in memory and b) you needed to configure a lot of them to scale the performance of your monitoring with the growing number of hosts. This resulted in a resource bottleneck. Checkmk 2.0 comes with a completely reworked helper model. This introduces two kinds of helper processes. <ul> <li>Fetcher: It's only task is to fetch the needed information from the monitored hosts. So it handles the network communication with the Checkmk agent, SNMP agent or other special agents. It may take some time to gather these information and it also may be blocked by network timeouts. But it consumes only a small amount of memory. So you can configure a lot of these processes without problems.</li> <li>Checker: It's task is to parse, analyze and evaluate the information gathered by the fetcher. It produces the check results for your services. It is a memory hungry process, because it needs to know all of your Checkmk configuration. It only takes a very short time to process the information from the fetcher. There is no network IO done by this helper process, which makes it pretty fast. You only need a small number of these processes.</li> </ul> This new model separates the problems of the previous "Checkmk helpers" into two separate pools: a) The network IO bound fetching of information and b) the CPU bound checking of the fetched information. We can now scale these different helper types independently from each other. Bottom line: Checkmk 2.0 has consumes significantly less memory (~ factor of 4, depending on your configuration) while achieving the same amount of checks per second. As a result, Checkmk 2.0 can monitor even more hosts on the same platform than before. The new model is enabled with Checkmk 2.0 by default. It can be configured using the global settings "Use separate fetchers and checkers", "Maximum concurrent Checkmk fetchers", "Maximum concurrent Checkmk checkers". All sites start with 13 fetcher processes and 4 checker processes. After updating you should have a look at the "Fetcher helper usage" and "Checker helper usage". It can be viewed in the "Micro core statistics" snapin and the detailed output of the "OMD [SITE] performance" services on your Checkmk host. The usage of both pools should not exceed 80%. In case it does, you should consider increasing the number of helpers of that type. Change-Id: I5d0c4193be1c3c52577ac61aa366211d2e10a7d8

3 years, 11 months

[tribe29/checkmk] 0659ec: 11331 FIX heartbeat_crm: fixed crash when checking...

by Lars

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: 0659ecafa31bc97e29a37004e710cca0c44023a4 https://github.com/tribe29/checkmk/commit/0659ecafa31bc97e29a37004e710cca0c… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: A .werks/11331 M checks/heartbeat_crm A tests/unit/checks/generictests/datasets/heartbeat_crm_2_regression.py Log Message: ----------- 11331 FIX heartbeat_crm: fixed crash when checking pacemaker version 2.0.3 CMK-5454 Change-Id: I51211e55da08106a4c3a79d26db81f17e16095d2

3 years, 11 months

[tribe29/checkmk] d7a27d: 11513 FIX sap_hana_diskusage: Fix scaling of files...

by Simon

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: d7a27dd449a6ae72e64073fcaa8b5cf89e988643 https://github.com/tribe29/checkmk/commit/d7a27dd449a6ae72e64073fcaa8b5cf89… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: A .werks/11513 M cmk/gui/plugins/metrics/translation.py Log Message: ----------- 11513 FIX sap_hana_diskusage: Fix scaling of filesystem values in service graphs Change-Id: I4e58f1305522a7c2458562a01f9610cd08304984

3 years, 11 months

[tribe29/checkmk] 89258e: Replace call sites of cmk.gui.htmllib.HTML.makeuri...

by Jörg Herbel

Branch: refs/heads/test_weblate2 Home: https://github.com/tribe29/checkmk Commit: 89258ecc92b705c80c9d8f75b549901a2190eff9 https://github.com/tribe29/checkmk/commit/89258ecc92b705c80c9d8f75b549901a2… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/plugins/dashboard/utils.py M cmk/gui/plugins/dashboard/view.py M cmk/gui/plugins/metrics/html_render.py M cmk/gui/plugins/sidebar/bi.py M cmk/gui/plugins/sidebar/search.py M cmk/gui/plugins/sidebar/tactical_overview.py M cmk/gui/plugins/sidebar/virtual_host_tree.py M cmk/gui/plugins/views/availability.py M cmk/gui/plugins/views/bi.py M cmk/gui/plugins/views/crash_reporting.py M cmk/gui/plugins/views/graphs.py M cmk/gui/plugins/views/icons/builtin.py M cmk/gui/plugins/views/icons/topology.py M cmk/gui/plugins/views/icons/wato.py M cmk/gui/plugins/views/inventory.py M cmk/gui/plugins/views/painters.py M cmk/gui/plugins/views/utils.py Log Message: ----------- Replace call sites of cmk.gui.htmllib.HTML.makeuri*, part 2/5 * cmk.gui.htmllib.HTML.makeuri --> cmk.gui.utils.urls.makeuri * cmk.gui.htmllib.HTML.makeuri_contextless --> cmk.gui.utils.urls.makeuri_contextless CMK-5885 Change-Id: I19118090e411e33e6b77cd47756ff11c671ec1bf Commit: be1441cd82ab3e1d1355e1bcbd3bbb6500f5e92f https://github.com/tribe29/checkmk/commit/be1441cd82ab3e1d1355e1bcbd3bbb650… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M cmk/gui/htmllib.py Log Message: ----------- Remove now unused methods makeuri* from cmk.gui.htmllib.HTML The following two methods now reside in cmk.gui.utils.urls: * makeuri * makeuri_contextless CMK-5885 Change-Id: I26f706caff17bc9e11ca8e788edce6795232797e Commit: 4c00e0e721cc437e412d9d6f3bcdc01960a6fea8 https://github.com/tribe29/checkmk/commit/4c00e0e721cc437e412d9d6f3bcdc0196… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11331 M checks/heartbeat_crm A tests/unit/checks/generictests/datasets/heartbeat_crm_2_regression.py Log Message: ----------- 11331 FIX heartbeat_crm: fixed crash when checking pacemaker version 2.0.3 CMK-5454 Change-Id: I51211e55da08106a4c3a79d26db81f17e16095d2 Commit: 449bd47177d7644afdcf2c629db27f8b11c7131b https://github.com/tribe29/checkmk/commit/449bd47177d7644afdcf2c629db27f8b1… Author: Lisa Pichler <lisa.pichler(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M checks/nimble_latency Log Message: ----------- nimble_latency: refactored to use check_levels Note: no test file as check is producting wrong results. See analysis: CMK-5821. Test will be added once the check has been reworked. CMK-5927 Change-Id: I8c090be0d91100f391a199d79f8016ed077b2752 Commit: 61543f1375184d949f7771b66b87bba4da85fd1c https://github.com/tribe29/checkmk/commit/61543f1375184d949f7771b66b87bba4d… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11405 Log Message: ----------- 11405 Improved performance of agent bakery With the introduction of the new Bakery API (see Werk #11401), the Agent Bakery itself has undergone a complete overhaul. While baking agents, the agent bakery now tries to reuse as many resources as possible, instead of collecting data for every package separately. If the contents for a to-be-baked package are identical to an already-baked one, this optimization will be communicated as "fast repackage" (visible at the bake-agents background job within the GUI or at the console directly when baking on the command line). Furthermore, the packaging processes for RPM and DEB packages have been optimized in performance. In summary, you will experience an agent bakery that runs noticeably faster and finishes earlier, compared to Checkmk 1.6 and before. Change-Id: I91ea62fde408bb269915a31ab42fa4dbb24fa40e Commit: f1d371acec8681efc6fc406e87510169919371db https://github.com/tribe29/checkmk/commit/f1d371acec8681efc6fc406e875101699… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M .werks/11401 M .werks/11403 M .werks/11404 Log Message: ----------- Fix typos in Werks. Change-Id: I4668e0e3c2950c72cce615901be4a2822e583dd1 Commit: 6fb1c250ededf356c0d6f683248170e0983fd433 https://github.com/tribe29/checkmk/commit/6fb1c250ededf356c0d6f683248170e09… Author: Joerg Herbel <joerg.herbel(a)tribe29.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: A .werks/11331 M .werks/11401 M .werks/11403 M .werks/11404 A .werks/11405 M checks/heartbeat_crm M checks/nimble_latency M cmk/gui/htmllib.py M cmk/gui/plugins/dashboard/utils.py M cmk/gui/plugins/dashboard/view.py M cmk/gui/plugins/metrics/html_render.py M cmk/gui/plugins/sidebar/bi.py M cmk/gui/plugins/sidebar/search.py M cmk/gui/plugins/sidebar/tactical_overview.py M cmk/gui/plugins/sidebar/virtual_host_tree.py M cmk/gui/plugins/views/availability.py M cmk/gui/plugins/views/bi.py M cmk/gui/plugins/views/crash_reporting.py M cmk/gui/plugins/views/graphs.py M cmk/gui/plugins/views/icons/builtin.py M cmk/gui/plugins/views/icons/topology.py M cmk/gui/plugins/views/icons/wato.py M cmk/gui/plugins/views/inventory.py M cmk/gui/plugins/views/painters.py M cmk/gui/plugins/views/utils.py A tests/unit/checks/generictests/datasets/heartbeat_crm_2_regression.py Log Message: ----------- Merge branch 'master' into test_weblate2 Change-Id: I834ff061149189e997321a5f2bbb7afb0659685d Compare: https://github.com/tribe29/checkmk/compare/b533feb79759...6fb1c250eded

3 years, 11 months

[tribe29/checkmk] dbf123: 11514 FIX fileinfo: Fix service state if minimal, ...

by Simon

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: dbf12368b4697df51d72088ddf5bde49677283ba https://github.com/tribe29/checkmk/commit/dbf12368b4697df51d72088ddf5bde496… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: A .werks/11514 M checks/fileinfo A tests/unit/checks/test_fileinfo.py Log Message: ----------- 11514 FIX fileinfo: Fix service state if minimal, maximal age or minimal, maximal size is reached The levels for minimal, maximal age or and minimal, maximal size are evaluated correctly and the levels information {{warn/crit ...}} is added but the service state may stay {{OK}} in some cases. Change-Id: I878ef946c5383efaf944a533f9937b843a2d6223

3 years, 11 months

[tribe29/checkmk] b533fe: Updated multisite.pot

by Lars

Branch: refs/heads/test_weblate2 Home: https://github.com/tribe29/checkmk Commit: b533feb7975955185a3cc9bb962065638e530586 https://github.com/tribe29/checkmk/commit/b533feb7975955185a3cc9bb962065638… Author: Weblate Transfer job <weblate(a)checkmk.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: M locale/multisite.pot Log Message: ----------- Updated multisite.pot Change-Id: I6b0d4ef4afa8441f15cb02f68ba072405408054a

3 years, 11 months

[tribe29/checkmk] dc7006: 11513 FIX sap_hana_diskusage: Fix scaling of files...

by Simon

Branch: refs/heads/1.6.0 Home: https://github.com/tribe29/checkmk Commit: dc70065d7a48fee5848fa690ba09a89cc6ae3370 https://github.com/tribe29/checkmk/commit/dc70065d7a48fee5848fa690ba09a89cc… Author: Simon Jess <simon.jess(a)tribe29.com> Date: 2020-10-21 (Wed, 21 Oct 2020) Changed paths: A .werks/11513 M cmk/gui/plugins/metrics/check_mk.py Log Message: ----------- 11513 FIX sap_hana_diskusage: Fix scaling of filesystem values in service graphs Change-Id: Id48a9477e4ff50289bf1554a73df3ac9ab6f1143

3 years, 11 months

[tribe29/checkmk] 61543f: 11405 Improved performance of agent bakery

by Lars

Branch: refs/heads/master Home: https://github.com/tribe29/checkmk Commit: 61543f1375184d949f7771b66b87bba4da85fd1c https://github.com/tribe29/checkmk/commit/61543f1375184d949f7771b66b87bba4d… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: A .werks/11405 Log Message: ----------- 11405 Improved performance of agent bakery With the introduction of the new Bakery API (see Werk #11401), the Agent Bakery itself has undergone a complete overhaul. While baking agents, the agent bakery now tries to reuse as many resources as possible, instead of collecting data for every package separately. If the contents for a to-be-baked package are identical to an already-baked one, this optimization will be communicated as "fast repackage" (visible at the bake-agents background job within the GUI or at the console directly when baking on the command line). Furthermore, the packaging processes for RPM and DEB packages have been optimized in performance. In summary, you will experience an agent bakery that runs noticeably faster and finishes earlier, compared to Checkmk 1.6 and before. Change-Id: I91ea62fde408bb269915a31ab42fa4dbb24fa40e Commit: f1d371acec8681efc6fc406e87510169919371db https://github.com/tribe29/checkmk/commit/f1d371acec8681efc6fc406e875101699… Author: Andreas Umbreit <andreas.umbreit(a)tribe29.com> Date: 2020-10-20 (Tue, 20 Oct 2020) Changed paths: M .werks/11401 M .werks/11403 M .werks/11404 Log Message: ----------- Fix typos in Werks. Change-Id: I4668e0e3c2950c72cce615901be4a2822e583dd1 Compare: https://github.com/tribe29/checkmk/compare/449bd47177d7...f1d371acec86

3 years, 11 months

← Newer
1
...
23
24
25
26
27
28
29
...
68
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2020