Checkmk git commits September 2017

checkmk-commits@lists.checkmk.com

11 participants
255 discussions

4985 Service descriptions can be translated

by Simon Betz

Module: check_mk Branch: master Commit: a6f2217ffe9a3b58f8a047dabcee7c7ceb8ead9e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a6f2217ffe9a3b… Author: Simon Betz <si(a)mathias-kettner.de> Date: Wed Jul 26 11:56:05 2017 +0200 4985 Service descriptions can be translated Change-Id: I1937a2eafa163e98b25f080b5f712e36cc997d92 --- .werks/4985 | 29 ++++ cmk_base/checks.py | 13 -- cmk_base/config.py | 75 +++++++--- cmk_base/core_config.py | 3 +- cmk_base/core_nagios.py | 5 +- cmk_base/default_config/base.py | 1 + cmk_base/piggyback.py | 6 +- lib/{hostname_translation.py => translations.py} | 39 +++-- web/htdocs/wato.py | 175 +++++++++++++---------- web/plugins/wato/check_mk_configuration.py | 21 +++ 10 files changed, 239 insertions(+), 128 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=a6f2217ffe…

7 years

5014 FIX df: Fixed error if dynamic levels should be set

by Marcel Arentz

Module: check_mk Branch: master Commit: 614d34edc8575ef12e2033009a483520eff7154d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=614d34edc8575e… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Tue Sep 12 14:54:59 2017 +0200 5014 FIX df: Fixed error if dynamic levels should be set Since 1.2.8 no dynamic levels could be set anymore. The error "You need to specify levels for filesystems larger than 0 bytes." prevented the user from saving a rule if a filesystem has not 0 bytes. Thix has been fixed now. Change-Id: Ica4e5f21b5dc72ccaebd034b1136c9868ada4909 --- .werks/5014 | 12 ++++++++++++ web/plugins/wato/check_parameters.py | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/5014 b/.werks/5014 new file mode 100644 index 0000000..e88c5b1 --- /dev/null +++ b/.werks/5014 @@ -0,0 +1,12 @@ +Title: df: Fixed error if dynamic levels should be set +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1505220682 +Class: fix + +Since 1.2.8 no dynamic levels could be set anymore. The error "You need to +specify levels for filesystems larger than 0 bytes." prevented the user from +saving a rule if a filesystem has not 0 bytes. Thix has been fixed now. diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index ff4ad91..666eb13 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -6545,7 +6545,7 @@ def get_free_used_dynamic_valuespec(what, name, default_value = (80.0, 90.0)): ] def validate_dynamic_levels(value, varprefix): - if not [ v for v in value if v[0] == 0 ]: + if [ v for v in value if v[0] == 0 ]: raise MKUserError(varprefix, _("You need to specify levels for " "%ss larger than 0 bytes.") % name)

7 years

5122 FIX Service discovery: Find SNMP checks of not yet monitored type when using cached data

by Simon Betz

Module: check_mk Branch: master Commit: 44ed2bce5b7b75af40eda367a23160b12045131f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=44ed2bce5b7b75… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Sep 12 09:39:43 2017 +0200 5122 FIX Service discovery: Find SNMP checks of not yet monitored type when using cached data Change-Id: I84246b81a3c193f868ebd0607d0e5952b5593098 --- .werks/5122 | 11 +++++++++++ cmk_base/checks.py | 8 +++++++- cmk_base/discovery.py | 33 ++++++++++++++++++++------------- 3 files changed, 38 insertions(+), 14 deletions(-) diff --git a/.werks/5122 b/.werks/5122 new file mode 100644 index 0000000..8214338 --- /dev/null +++ b/.werks/5122 @@ -0,0 +1,11 @@ +Title: Service discovery: Find SNMP checks of not yet monitored type when using cached data +Level: 2 +Component: wato +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1505140261 + + diff --git a/cmk_base/checks.py b/cmk_base/checks.py index c23cbb6..094219a 100644 --- a/cmk_base/checks.py +++ b/cmk_base/checks.py @@ -499,11 +499,17 @@ def is_tcp_check(check_name): def discoverable_tcp_checks(): types = [] - for check_type, check in check_info.items(): if is_tcp_check(check_type) and check["inventory_function"]: types.append(check_type) + return sorted(types) + +def discoverable_snmp_checks(): + types = [] + for check_type, check in check_info.items(): + if is_snmp_check(check_type) and check["inventory_function"]: + types.append(check_type) return sorted(types) diff --git a/cmk_base/discovery.py b/cmk_base/discovery.py index 9d6364d..f969b47 100644 --- a/cmk_base/discovery.py +++ b/cmk_base/discovery.py @@ -207,7 +207,7 @@ def discover_on_host(mode, hostname, do_snmp_scan, use_caches, on_error="ignore" # Compute current state of new and existing checks services = _get_host_services(hostname, use_caches=use_caches, - do_snmp_scan=do_snmp_scan, on_error=on_error) + do_snmp_scan=do_snmp_scan, on_error=on_error) # Create new list of checks new_items = {} @@ -672,29 +672,37 @@ def _in_keepalive_mode(): # '----------------------------------------------------------------------' # gather auto_discovered check_types for this host -def _gather_check_types_native(hostname, ipaddress, on_error, do_snmp_scan): - check_types = [] +def _gather_check_types_native(hostname, ipaddress, on_error, do_snmp_scan, use_caches): + check_types = set() if config.is_snmp_host(hostname): # May we do an SNMP scan? if do_snmp_scan: try: - check_types = snmp_scan(hostname, ipaddress, on_error) + check_types.update(snmp_scan(hostname, ipaddress, on_error)) except Exception, e: if on_error == "raise": raise elif on_error == "warn": console.error("SNMP scan failed: %s" % e) + # Otherwise we gather all check types from autochecks and cached files. else: - # Otherwise use all check types that we already have discovered - # previously + snmp_check_types = set(checks.discoverable_snmp_checks()) for check_type, _unused_item, _unused_params in read_autochecks_of(hostname): - if check_type not in check_types and checks.is_snmp_check(check_type): - check_types.append(check_type) + if check_type in snmp_check_types: + check_types.add(check_type) + + if use_caches and os.path.isdir(cmk.paths.tcp_cache_dir): + for cachefile in os.listdir(cmk.paths.tcp_cache_dir): + if not cachefile.startswith("%s." % hostname): + continue + check_type = cachefile.split("%s." % hostname)[-1] + if check_type in snmp_check_types: + check_types.add(check_type) if config.is_tcp_host(hostname) or piggyback.has_piggyback_info(hostname): - check_types += checks.discoverable_tcp_checks() - return check_types + check_types.update(checks.discoverable_tcp_checks()) + return list(check_types) # Create a table of autodiscovered services of a host. Do not save @@ -747,7 +755,7 @@ def _discover_services(hostname, check_types, use_caches, do_snmp_scan, on_error # Check types not specified (via --checks=)? Determine automatically if not check_types: - check_types = _gather_check_types_native(hostname, ipaddress, on_error, do_snmp_scan) + check_types = _gather_check_types_native(hostname, ipaddress, on_error, do_snmp_scan, use_caches) return services + _discover_services_impl(hostname, check_types, use_caches, on_error, ipaddress) @@ -1085,8 +1093,7 @@ def _merge_manual_services(services, hostname, on_error): continue # ignore if config.service_ignored(hostname, check_type, descr): - new_source = "ignored" - services[(check_type, item)] = (new_source, paramstring) + services[(check_type, item)] = ("ignored", paramstring) return services

7 years

updated werk 5113

by Simon Betz

Module: check_mk Branch: master Commit: 0c74cf1ab6ea0238d2343ea317cfdcc74d965e04 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0c74cf1ab6ea02… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Sep 12 09:14:28 2017 +0200 updated werk 5113 Change-Id: Ie8e62228ff310a751c9430b58993cd34ffab00ce --- .werks/5113 | 2 +- agents/check_mk_agent.aix | 20 ++++++++------------ agents/check_mk_agent.linux | 20 +++++++++----------- 3 files changed, 18 insertions(+), 24 deletions(-) diff --git a/.werks/5113 b/.werks/5113 index c0cc253..ceca3e8 100644 --- a/.werks/5113 +++ b/.werks/5113 @@ -1,4 +1,4 @@ -Title: cifsmounts, nfsmounts: Fixed wrong reported error message if user has not right permissions on mount point +Title: cifsmounts: Fixed wrong reported error message if user has not right permissions on mount point Level: 1 Component: checks Compatible: compat diff --git a/agents/check_mk_agent.aix b/agents/check_mk_agent.aix index 6f5f5a7..dcc7a39 100755 --- a/agents/check_mk_agent.aix +++ b/agents/check_mk_agent.aix @@ -142,25 +142,21 @@ if type stat >/dev/null 2>&1 ; then echo '<<<nfsmounts>>>' mount | grep ' nfs' | awk '{print $3;}' | \ while read MP - do - if [ ! -r $MP ]; then - echo "$MP Permission denied" - else - waitmax 2 stat -f -c '"'$MP' ok - - - -"' "$MP" || \ - echo "$MP hanging 0 0 0 0" - fi - done + do + waitmax 2 stat -f -c '"'$MP' ok - - - -"' "$MP" || \ + echo "$MP hanging 0 0 0 0" + done echo '<<<cifsmounts>>>' mount | grep ' cifs' | awk '{print $3;}' | \ while read MP - do + do if [ ! -r $MP ]; then echo "$MP Permission denied" else - waitmax 2 stat -f -c '"'$MP' ok - - - -"' "$MP" || \ - echo "$MP hanging 0 0 0 0" + waitmax 2 stat -f -c '"'$MP' ok - - - -"' "$MP" || \ + echo "$MP hanging 0 0 0 0" fi - done + done fi echo '<<<ps>>>' diff --git a/agents/check_mk_agent.linux b/agents/check_mk_agent.linux index 2f5b94b..267138c 100755 --- a/agents/check_mk_agent.linux +++ b/agents/check_mk_agent.linux @@ -299,17 +299,15 @@ then sed -n '/ nfs4\? /s/[^ ]* $[^ ]*$ .*/\1/p' < /proc/mounts | sed 's/\\040/ /g' | while read MP - do - if [ ! -r $MP ]; then - echo "$MP Permission denied" - elif [ $STAT_VERSION != $STAT_BROKE ]; then - waitmax -s 9 2 stat -f -c "$MP ok %b %f %a %s" "$MP" || \ - echo "$MP hanging 0 0 0 0" - else - waitmax -s 9 2 stat -f -c "$MP ok %b %f %a %s" "$MP" && \ - printf '\n'|| echo "$MP hanging 0 0 0 0" - fi - done + do + if [ $STAT_VERSION != $STAT_BROKE ]; then + waitmax -s 9 2 stat -f -c "$MP ok %b %f %a %s" "$MP" || \ + echo "$MP hanging 0 0 0 0" + else + waitmax -s 9 2 stat -f -c "$MP ok %b %f %a %s" "$MP" && \ + printf '\n'|| echo "$MP hanging 0 0 0 0" + fi + done echo '<<<cifsmounts>>>' sed -n '/ cifs\? /s/[^ ]* $[^ ]*$ .*/\1/p' < /proc/mounts |

7 years

Reserved 10 Werk IDS

by Konstantin Büttner

Module: check_mk Branch: master Commit: 12d73a33e289d88459c5f04a48684e398598ef73 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=12d73a33e289d8… Author: Konstantin Büttner <kb(a)mathias-kettner.de> Date: Mon Sep 11 16:41:38 2017 +0200 Reserved 10 Werk IDS Change-Id: I1289e9e9d0b539952e5c9dbd7885e41011182dbb --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index 85cac58..c016a77 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -5218 +5228

7 years

5218 FIX jolokia_metrics: Fix failing parse function for MBeans containing ":"

by Konstantin Büttner

Module: check_mk Branch: master Commit: abc0607d78ef5ee31b9fa1b5ecfbd569a7cbef0b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=abc0607d78ef5e… Author: Konstantin Büttner <kb(a)mathias-kettner.de> Date: Mon Sep 11 16:45:02 2017 +0200 5218 FIX jolokia_metrics: Fix failing parse function for MBeans containing ":" Thanks to Bernhard Lichtinger for the patch! Change-Id: Ia986c73bd6a27419a8fd2b9ed8c92eed0afb3ffc --- .werks/5218 | 11 +++++++++++ checks/jolokia_metrics | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/.werks/5218 b/.werks/5218 new file mode 100644 index 0000000..e0d7a80 --- /dev/null +++ b/.werks/5218 @@ -0,0 +1,11 @@ +Title: jolokia_metrics: Fix failing parse function for MBeans containing ":" +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1505141030 + +Thanks to Bernhard Lichtinger for the patch! diff --git a/checks/jolokia_metrics b/checks/jolokia_metrics index dad38d3..d957c9d 100644 --- a/checks/jolokia_metrics +++ b/checks/jolokia_metrics @@ -87,7 +87,7 @@ def jolokia_metrics_parse(info): for part in parts[1:]: if ":" in part: - module, part = part.split(":") + module, part = part.split(":", 1) if "=" in part: key, val = part.split("=") attributes[key] = val

7 years

4806 df: Add option to include volume name in service description

by Konstantin Büttner

Module: check_mk Branch: master Commit: a72e800c6dbdbdbb05f7000ac5b6e385de6eb5c7 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a72e800c6dbdbd… Author: Konstantin Büttner <kb(a)mathias-kettner.de> Date: Mon Sep 11 12:53:11 2017 +0200 4806 df: Add option to include volume name in service description Change-Id: I5c1867edfb753a829a60f35a536ac7947e100fa9 --- .werks/4806 | 10 ++++++++++ checks/df | 38 ++++++++++++++++++++++++++++++------ web/plugins/wato/check_parameters.py | 14 +++++++++++++ 3 files changed, 56 insertions(+), 6 deletions(-) diff --git a/.werks/4806 b/.werks/4806 new file mode 100644 index 0000000..12fded2 --- /dev/null +++ b/.werks/4806 @@ -0,0 +1,10 @@ +Title: df: Add option to include volume name in service description +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1505127151 +Class: feature + + diff --git a/checks/df b/checks/df index b37a021..905d0ae 100644 --- a/checks/df +++ b/checks/df @@ -89,10 +89,12 @@ # C:\ NTFS 41838588 21776048 20062540 53% C:\ # C:\Program Files\Vision Solutions\Double-Take\Service\MountDir\usauhtest0010_c061b170-ad3f-473f-92ce-088c97fce98e_C\ NTFS 41835516 11895180 29940336 29% C:\Program Files\Vision Solutions\Double-Take\Service\MountDir\usauhtest0010_c061b170-ad3f-473f-92ce-088c97fce98e_C\ +inventory_df_rules = [] def parse_df(info): def parse_blocks_subsection(blocks_subsection): + mp_to_volume = {} df_blocks = [] btrfs_devices = set() for line in blocks_subsection: @@ -139,7 +141,9 @@ def parse_df(info): reserved_mb = size_mb - avail_mb - used_mb # reserved for root df_blocks.append((mountpoint, size_mb, avail_mb, reserved_mb)) - return df_blocks + mp_to_volume[mountpoint] = line[0] + + return df_blocks, mp_to_volume def parse_inodes_subsection(inodes_subsection): df_inodes = [] @@ -178,22 +182,44 @@ def parse_df(info): def inventory_df(parsed): - df_blocks, _ = parsed + + def is_mountpoint(inventory_entry): + return "patterns" not in inventory_entry[1] + + inventory_options = host_extra_conf_merged(host_name(), inventory_df_rules) + include_volume_name = inventory_options.get("include_volume_name", False) + (df_blocks, mp_to_volume), _ = parsed + mplist = [] for line in df_blocks: mountpoint = line[0] if mountpoint in inventory_df_exclude_mountpoints: continue # exclude this mount point (/tmp, /proc, whatever user wants) - mplist.append(mountpoint) - return df_inventory(mplist) + + if include_volume_name: + inventory = [] + for entry in df_inventory(mplist): + if is_mountpoint(entry): + mountpoint, params = entry + item = "%s %s" % (mp_to_volume[mountpoint], mountpoint) + inventory.append((item, params)) + else: + inventory.append(entry) + return inventory + else: + return df_inventory(mplist) def check_df(item, params, parsed): - df_blocks, df_inodes = parsed - return df_check_filesystem_list(item, params, df_blocks, df_inodes) + (df_blocks, mp_to_volume), df_inodes = parsed + if "patterns" in params or item in mp_to_volume: + return df_check_filesystem_list(item, params, df_blocks, df_inodes) + else: + mountpoint = { ("%s %s" % (mp_to_volume[mp], mp)) : mp for mp in mp_to_volume }[item] + return df_check_filesystem_list(mountpoint, params, df_blocks, df_inodes) check_info['df'] = { diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index b89adce..ff4ad91 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -1505,6 +1505,20 @@ register_rule(group + '/' + subgroup_inventory, match = 'dict', ) +register_rule(group + '/' + subgroup_inventory, + varname = "inventory_df_rules", + title = _("Include Volume name in Filesystem Checks"), + valuespec = Dictionary( + elements = [ + ("include_volume_name", Checkbox( + title = _("Include Volume name in item") + )), + ], + optional_keys = [] + ), + match = "dict", +) + #. # .--Applications--------------------------------------------------------. # | _ _ _ _ _ |

7 years

4862 MSSQL: detect instances on non-standard TCP ports

by Marcel Schulte

Module: check_mk Branch: master Commit: 343fff53360dabd1b3cbfc9b7c35e023d143bf0e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=343fff53360dab… Author: Marcel Schulte <ms(a)mathias-kettner.de> Date: Mon Sep 11 15:15:53 2017 +0200 4862 MSSQL: detect instances on non-standard TCP ports The MSSQL plugin detects SQL instances running on non-standard TCP ports now. Change-Id: I81272921bdc073294899c6a42de033fe2682c7b8 --- .werks/4862 | 11 +++++++++++ agents/windows/plugins/mssql.vbs | 17 +++++++++++++++-- 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/.werks/4862 b/.werks/4862 new file mode 100644 index 0000000..3a35b59 --- /dev/null +++ b/.werks/4862 @@ -0,0 +1,11 @@ +Title: MSSQL: detect instances on non-standard TCP ports +Level: 1 +Component: checks +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1505135694 +Class: feature + +The MSSQL plugin detects SQL instances running on non-standard TCP ports now. + diff --git a/agents/windows/plugins/mssql.vbs b/agents/windows/plugins/mssql.vbs index 738caef..d1ddb36 100644 --- a/agents/windows/plugins/mssql.vbs +++ b/agents/windows/plugins/mssql.vbs @@ -147,6 +147,11 @@ For Each rk In regkeys registry.GetStringValue HKLM, "SOFTWARE\" & rk & "\Microsoft\Microsoft SQL Server\" & _ instance_name & "\Cluster", "ClusterName", cluster_name + ' HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Microsoft SQL Server\MSSQL10_50.MSSQLSERVER\MSSQLServer\SuperSocketNetLib\TCP\IPAll + registry.GetStringValue HKLM, "SOFTWARE\" & rk & "\Microsoft\Microsoft SQL Server\" & _ + instance_name & "\MSSQLServer\SuperSocketNetLib\TCP\IPAll", _ + "tcpPort", tcpport + If IsNull(cluster_name) Then cluster_name = "" @@ -154,14 +159,22 @@ For Each rk In regkeys If instance_id = "MSSQLSERVER" Then sources.add instance_id, "(local)" Else - sources.add instance_id, hostname & "\" & instance_id + If isNull(tcpport) Then + sources.add instance_id, hostname & "\" & instance_id + Else + sources.add instance_id, hostname & "," & tcpport + End If End If Else ' In case the instance name is "MSSQLSERVER" always use the virtual server name If instance_id = "MSSQLSERVER" Then sources.add instance_id, cluster_name Else - sources.add instance_id, cluster_name & "\" & instance_id + If isNull(tcpport) Then + sources.add instance_id, cluster_name & "\" & instance_id + Else + sources.add instance_id, cluster_name & "," & tcpport + End If End If End If

7 years

5121 FIX check_sql: Added error message if cx_Oracle module is not installed

by Simon Betz

Module: check_mk Branch: master Commit: 9306064ab04321f7f6b41053ccf53552f82f2bd2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9306064ab04321… Author: Simon Betz <si(a)mathias-kettner.de> Date: Mon Sep 11 15:14:18 2017 +0200 5121 FIX check_sql: Added error message if cx_Oracle module is not installed Change-Id: I5bbd653a3d67e98e87f7fe0a591a947fed243c87 --- .werks/5121 | 11 +++++++++++ active_checks/check_sql | 5 ++++- 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/.werks/5121 b/.werks/5121 new file mode 100644 index 0000000..43253c5 --- /dev/null +++ b/.werks/5121 @@ -0,0 +1,11 @@ +Title: check_sql: Added error message if cx_Oracle module is not installed +Level: 1 +Component: checks +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1505135287 + + diff --git a/active_checks/check_sql b/active_checks/check_sql index ee0237f..866b1e2 100755 --- a/active_checks/check_sql +++ b/active_checks/check_sql @@ -191,7 +191,10 @@ try: elif opt_dbms == "oracle": sys.path.append('/usr/lib/python2.6/site-packages') sys.path.append('/usr/lib/python2.7/site-packages') - import cx_Oracle + try: + import cx_Oracle + except ImportError: + bail_out(3, "Requested python module 'cx_Oracle' not found. Please install it via 'pip install cx_Oracle'.") db = cx_Oracle if opt_port == None: opt_port=1521

7 years

Fixed issue in AD DC discovery: Wrong DCs were used for LDAP communication

by Lars Michelsen

Module: check_mk Branch: master Commit: 9ebd10bd3dc720ee0289512696cb528dd13f99a6 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9ebd10bd3dc720… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Mon Sep 11 14:24:24 2017 +0200 Fixed issue in AD DC discovery: Wrong DCs were used for LDAP communication Change-Id: Iad7bc5f7f19de0c11694a8747eb017bac09b0d74 --- .../0012-python-ad-fix-netlogon-response-site-parsing.dif | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/omd/packages/python-modules/patches/0012-python-ad-fix-netlogon-response-site-parsing.dif b/omd/packages/python-modules/patches/0012-python-ad-fix-netlogon-response-site-parsing.dif new file mode 100644 index 0000000..001ea85 --- /dev/null +++ b/omd/packages/python-modules/patches/0012-python-ad-fix-netlogon-response-site-parsing.dif @@ -0,0 +1,13 @@ +diff -Nur dest/python-ad-0.9.orig/lib/ad/protocol/netlogon.py dest/python-ad-0.9/lib/ad/protocol/netlogon.py +--- dest/python-ad-0.9.orig/lib/ad/protocol/netlogon.py 2008-10-31 15:19:34.000000000 +0100 ++++ dest/python-ad-0.9/lib/ad/protocol/netlogon.py 2017-09-11 14:20:19.499324819 +0200 +@@ -59,8 +59,8 @@ + netbios_domain = self._decode_rfc1035() + netbios_hostname = self._decode_rfc1035() + user = self._decode_rfc1035() +- client_site = self._decode_rfc1035() + server_site = self._decode_rfc1035() ++ client_site = self._decode_rfc1035() + return Reply(type=type, flags=flags, domain_guid=domain_guid, + forest=forest, domain=domain, hostname=hostname, + netbios_domain=netbios_domain,

7 years

← Newer
1
...
15
16
17
18
19
20
21
...
26
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2017