Checkmk git commits September 2017

checkmk-commits@lists.checkmk.com

11 participants
255 discussions

by Andreas Boesl

Module: check_mk Branch: master Commit: f2962259c2881b02bf27180d3cbf23ebc3078713 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f2962259c2881b… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Sep 13 11:11:56 2017 +0200 Reserved 30 Werk IDS --- .werks/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.werks/first_free b/.werks/first_free index c016a77..76bc56d 100644 --- a/.werks/first_free +++ b/.werks/first_free @@ -1 +1 @@ -5228 +5258

7 years

5228 FIX WATO Web-API: now able to edit users which were created through the GUI

by Andreas Boesl

Module: check_mk Branch: master Commit: f8e3112a90cd31f06ac17a30290915f72e2f5abb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f8e3112a90cd31… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Wed Sep 13 11:15:27 2017 +0200 5228 FIX WATO Web-API: now able to edit users which were created through the GUI Users created through the WATO users page lacked the attribute <tt>"connector":"htpasswd"</tt>. The edit_users Web API call can now handle this scenario. --- .werks/5228 | 12 ++++++++++++ web/plugins/webapi/webapi.py | 2 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/5228 b/.werks/5228 new file mode 100644 index 0000000..fda376a --- /dev/null +++ b/.werks/5228 @@ -0,0 +1,12 @@ +Title: WATO Web-API: now able to edit users which were created through the GUI +Level: 1 +Component: wato +Compatible: compat +Edition: cre +Version: 1.5.0i1 +Date: 1505293943 +Class: fix + +Users created through the WATO users page lacked the attribute <tt>"connector":"htpasswd"</tt>. +The edit_users Web API call can now handle this issue. + diff --git a/web/plugins/webapi/webapi.py b/web/plugins/webapi/webapi.py index 06c65a8..6df4f93 100644 --- a/web/plugins/webapi/webapi.py +++ b/web/plugins/webapi/webapi.py @@ -605,7 +605,7 @@ def action_edit_users(request): if user_id not in all_users: raise MKUserError(None, _("Unknown user: %s") % user_id) - if all_users[user_id].get("connector") != "htpasswd": + if all_users[user_id].get("connector", "htpasswd") != "htpasswd": raise MKUserError(None, _("This user is not a htpasswd user: %s") % user_id) user_attrs = copy.deepcopy(all_users[user_id])

7 years

5124 FIX Service discovery: Fixed permission if user is not allowed to manage services

by Simon Betz

Module: check_mk Branch: master Commit: edafd48f94cc2ab235b18734268b0370beb559dc URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=edafd48f94cc2a… Author: Simon Betz <si(a)mathias-kettner.de> Date: Wed Sep 13 10:19:05 2017 +0200 5124 FIX Service discovery: Fixed permission if user is not allowed to manage services Change-Id: I9cb2a422b7119e60ff839d050ad6560129bd7a4b --- .werks/5124 | 11 +++++++++++ web/htdocs/wato.py | 11 +++++++++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/.werks/5124 b/.werks/5124 new file mode 100644 index 0000000..9996ef4 --- /dev/null +++ b/.werks/5124 @@ -0,0 +1,11 @@ +Title: Service discovery: Fixed permission if user is not allowed to manage services +Level: 1 +Component: wato +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1505290711 + + diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 402afe7..c1511d7 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -3161,7 +3161,7 @@ class ModeDiscovery(WatoMode): def _show_bulk_checkbox(self, table_source, check_type, item, show_bulk_actions): - if not self._show_checkboxes: + if not self._show_checkboxes or not config.user.may("wato.services"): return if not show_bulk_actions: @@ -3215,10 +3215,17 @@ class ModeDiscovery(WatoMode): ("host", self._host_name), ("item", mk_repr(descr)), ]), _("Edit and analyze the disabled services rules"), "rulesets") + table.cell(css="buttons") + if not config.user.may("wato.services"): + html.empty_icon() + html.empty_icon() + html.empty_icon() + html.empty_icon() + return + table_source, check_type, checkgroup, item, paramstring, params, \ descr, state, output, perfdata = check checkbox_name = self._checkbox_name(check_type, item) - table.cell(css="buttons") buttons = [] if table_source == self.SERVICE_MONITORED: buttons.append(icon_button(table_source, checkbox_name, self.SERVICE_UNDECIDED, "undecided"))

7 years

5123 FIX Service discovery: Fix moving services from 'Disabled services' to 'Vanished services' or 'Undecided services'

by Simon Betz

Module: check_mk Branch: master Commit: 18850c40f887e5c45e8d95e629ea61fb5780e7b8 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=18850c40f887e5… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Sep 12 16:40:18 2017 +0200 5123 FIX Service discovery: Fix moving services from 'Disabled services' to 'Vanished services' or 'Undecided services' Change-Id: I57d2cbe0f6b10b81933ff9ac1e3dc183daf3af3c --- .werks/5123 | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/.werks/5123 b/.werks/5123 new file mode 100644 index 0000000..ce2ddaf --- /dev/null +++ b/.werks/5123 @@ -0,0 +1,13 @@ +Title: Service discovery: Fix moving services from 'Disabled services' to 'Vanished services' or 'Undecided services' +Level: 1 +Component: wato +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1505140485 + +Before passive services were not always listed in the right group resp. +they disappeared and just after a reload they were listed in the right +table. This has been fixed.

7 years

Updated bug entries #2952

by Lars Michelsen

Module: check_mk Branch: master Commit: b8efde871188b7a5f2579d0e0fd41b3f414c8fea URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b8efde871188b7… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Sep 13 10:57:16 2017 +0200 Updated bug entries #2952 Change-Id: Ie016e64ac8b1180182d0c00cb2457b2758234f78 --- .bugs/2952 | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/.bugs/2952 b/.bugs/2952 new file mode 100644 index 0000000..82e2d8a --- /dev/null +++ b/.bugs/2952 @@ -0,0 +1,20 @@ +Title: Fix piggyback cleanup mechanism +Component: core +State: open +Date: 2017-09-13 10:52:02 +Targetversion: 1.5.0 +Class: bug + +The logic for cleaning up piggyback files is not scaling well and may +also include race conditions. + +Idea: + +- Remove the cleanup routine (remove_piggyback_info_from()) +- Also remove the os.remove() from get_piggyback_files() +- Persist the time the a piggy source host was delivering data for the + last time +- Only use the piggyback data which is of equal age or newer than the + last time the piggyback source host was contacted. + -> Replace "config.piggyback_max_cachefile_age" handling and replace + it with the timestamp of the last source host contact

7 years

Updated bug entries #2951

by Lars Michelsen

Module: check_mk Branch: master Commit: e788ae8c6520771d24f3a81598f1b54304de3688 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e788ae8c652077… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Wed Sep 13 10:07:23 2017 +0200 Updated bug entries #2951 Change-Id: Ifad8671df271bbe5fe9eceb95ccbc2a75d7c0702 --- .bugs/2951 | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.bugs/2951 b/.bugs/2951 new file mode 100644 index 0000000..d540f16 --- /dev/null +++ b/.bugs/2951 @@ -0,0 +1,12 @@ +Title: Reflect "cluster aware" information of checks in man pages +Component: core +State: open +Date: 2017-09-13 10:04:25 +Targetversion: 1.5.0 +Class: cleanup + +The information whether or not a check is "cluster aware" is +not shown in the man page of a check. We should read the +"node_info" and show the information in the man page. + +On command line, the WATO GUI and the web page.

7 years

5206 FIX Ruleset quick search now excludes deprecated rulesets

by Lars Michelsen

Module: check_mk Branch: master Commit: e3eb949ad2614ef62bc2686bb7e1ac01c0481cb0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e3eb949ad2614e… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Sep 12 16:50:25 2017 +0200 5206 FIX Ruleset quick search now excludes deprecated rulesets Deprecated rulesets are now excluded from the search when performing a "quick search" for rulesets / rules in WATO when starting the search from a view that does not show deprecated rulesets. Change-Id: Id9b2d30367b1d959332f7b84945a7157b72039d2 --- .werks/5206 | 13 +++++++++++++ web/htdocs/wato.py | 5 +++++ 2 files changed, 18 insertions(+) diff --git a/.werks/5206 b/.werks/5206 new file mode 100644 index 0000000..10b79bf --- /dev/null +++ b/.werks/5206 @@ -0,0 +1,13 @@ +Title: Ruleset quick search now excludes deprecated rulesets +Level: 1 +Component: wato +Class: fix +Compatible: compat +Edition: cre +State: unknown +Version: 1.5.0i1 +Date: 1505227672 + +Deprecated rulesets are now excluded from the search when performing +a "quick search" for rulesets / rules in WATO when starting the search +from a view that does not show deprecated rulesets. diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 41dc4cd..402afe7 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -12369,6 +12369,11 @@ class ModeRulesets(WatoMode): def _from_vars(self): self._group_name = html.var("group") + # Explicitly hide deprecated rulesets by default + if not html.has_var("search_p_ruleset_deprecated"): + html.set_var("search_p_ruleset_deprecated", "1"), + html.set_var("search_p_ruleset_deprecated_USE", "on") + # Transform group argument to the "rule search arguments" # Keeping this for compatibility reasons for the moment if self._group_name:

7 years

Updated bug entries #2431

by Lars Michelsen

Module: check_mk Branch: master Commit: 873638f8e5a65acc06ba02c27c15fe74ada19d22 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=873638f8e5a65a… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Tue Sep 12 16:53:59 2017 +0200 Updated bug entries #2431 Change-Id: Iebfbc32108303fa373b2e03b47e0ccc9fbd11e8a --- .bugs/2431 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/2431 b/.bugs/2431 index 84d480b..41be113 100644 --- a/.bugs/2431 +++ b/.bugs/2431 @@ -1,8 +1,11 @@ Title: Duplicate for git bug 2430 for 1.4.0 Component: multisite -State: open +Class: bug +State: closed Date: 2017-08-10 13:47:36 Targetversion: 1.4.0 -Class: bug same issue as git bug #2430. 1.4.0 is also affected here. + +2017-09-12 16:51:43: changed state open -> closed +Duplicate of 2430 (we don't need separate reports for different versions)

7 years

added bug regarding missing webapi folder in local structure

by Marcel Arentz

Module: check_mk Branch: master Commit: d91f4e4a47f0bbc8ee240812b70128ff0d2e155f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d91f4e4a47f0bb… Author: Marcel Arentz <ma(a)mathias-kettner.de> Date: Tue Sep 12 17:26:16 2017 +0200 added bug regarding missing webapi folder in local structure Change-Id: If8838b87a80db150f9430b37c88bddbd443c03af --- .bugs/2515 | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/.bugs/2515 b/.bugs/2515 new file mode 100644 index 0000000..f8128ce --- /dev/null +++ b/.bugs/2515 @@ -0,0 +1,8 @@ +Title: folder for webapi is missing in local structure +Component: wato +State: open +Date: 2017-09-12 17:23:29 +Targetversion: 1.4.0 +Class: nastiness + +The mentioned folder must be created manually.

7 years

5092 FIX Service discovery performance: Do full scan once only right after clicking full scan

by Simon Betz

Module: check_mk Branch: master Commit: 946306651f05a5dfd0d97cb71d8e8d7034ba9f4b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=946306651f05a5… Author: Simon Betz <si(a)mathias-kettner.de> Date: Tue Sep 12 16:36:21 2017 +0200 5092 FIX Service discovery performance: Do full scan once only right after clicking full scan Change-Id: I8abc9ba2d46c31c92a231041e5493dc91e5c9df0 --- .werks/5092 | 11 + web/htdocs/wato.py | 860 ++++++++++++++++++++++---------------------------- web/htdocs/watolib.py | 2 - 3 files changed, 386 insertions(+), 487 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=946306651f…

7 years

← Newer
1
...
14
15
16
17
18
19
20
...
26
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits September 2017