Checkmk git commits January 2016

checkmk-commits@lists.checkmk.com

9 participants
303 discussions

by Lars Michelsen

Module: check_mk Branch: master Commit: f382187d988117a465243c8e59ccf9c63c15ef69 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f382187d988117… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 8 13:12:35 2016 +0100 Fixed deleting of foreign reports --- web/htdocs/visuals.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/visuals.py b/web/htdocs/visuals.py index a27a93d..2995cd7 100644 --- a/web/htdocs/visuals.py +++ b/web/htdocs/visuals.py @@ -297,7 +297,7 @@ def page_list(what, title, visuals, custom_columns = [], try: if check_deletable_handler: - check_deletable_handler(visuals, delname) + check_deletable_handler(visuals, user_id, delname) c = html.confirm(_("Please confirm the deletion of \"%s\".") % deltitle) if c:

8 years, 8 months

#2897 Changed move host action to be an action icon using a popup menu

by Lars Michelsen

Module: check_mk Branch: master Commit: fa0790a9d4691c0ea0c987239535d25ec57a98de URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fa0790a9d4691c… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 8 12:42:08 2016 +0100 #2897 Changed move host action to be an action icon using a popup menu The "move host" action in the host configuration lists has been changed to be an action icon just like the other host actions. When you have a confiuration with a large folder hierarchy like hundrets of folders, this change will increase the rendering time of the hosts lists a lot. --- .werks/2897 | 14 ++++ ChangeLog | 1 + web/htdocs/htmllib.py | 11 +-- web/htdocs/images/icon_move.png | Bin 0 -> 6524 bytes web/htdocs/js/checkmk.js | 5 ++ web/htdocs/js/wato.js | 21 +----- web/htdocs/wato.css | 13 ++-- web/htdocs/wato.py | 158 ++++++++++++++++++++++----------------- web/plugins/pages/wato.py | 25 ++++--- 9 files changed, 134 insertions(+), 114 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=fa0790a9d4…

8 years, 8 months

minor cleanup in checkpoint_connections check

by Simon Betz

Module: check_mk Branch: master Commit: b39320a23c5a97b7bfdbefbaf11696887808ad50 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b39320a23c5a97… Author: Simon Betz <si(a)mathias-kettner.de> Date: Fri Jan 8 09:41:46 2016 +0100 minor cleanup in checkpoint_connections check --- checks/checkpoint_connections | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/checks/checkpoint_connections b/checks/checkpoint_connections index c97d47b..cbc29d1 100644 --- a/checks/checkpoint_connections +++ b/checks/checkpoint_connections @@ -33,20 +33,20 @@ def inventory_checkpoint_connections(info): return [(None, "checkpoint_connections_default_levels")] def check_checkpoint_connections(item, params, info): - warn, crit = params - current = int(info[0][0]) + connections = int(info[0][0]) state = 0 - levels = " (warn/crit at %d/%d)" % (warn, crit) - infotext = "%d Current Connections" % (current) - if current >= warn: - state = 1 - infotext += levels - if current >= crit: + infotext = "%d current connections" % (connections) + warn, crit = params + + if connections >= crit: state = 2 - infotext += levels + elif connections >= warn: + state = 1 + + if state > 0: + infotext += " (warn/crit at %d/%d)" % (warn, crit) - perfdata = [("connections", current, warn, crit)] - return state, infotext, perfdata + return state, infotext, [("connections", connections, warn, crit)] check_info["checkpoint_connections"] = { "check_function" : check_checkpoint_connections,

8 years, 8 months

#2915 supermicro.smart: new check to monitor harddisk health on snmp-enabled supermicro devices

by Sebastian Herbord

Module: check_mk Branch: master Commit: d9f15ea6640bb3da29f78b667dbbf09f4e939cbe URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d9f15ea6640bb3… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Fri Jan 8 08:45:58 2016 +0100 #2915 supermicro.smart: new check to monitor harddisk health on snmp-enabled supermicro devices --- .werks/2915 | 9 ++++++ ChangeLog | 1 + checkman/supermicro.smart | 19 ++++++++++++ checks/supermicro | 74 ++++++++++++++++++++++++++++++++++++++++++++- 4 files changed, 102 insertions(+), 1 deletion(-) diff --git a/.werks/2915 b/.werks/2915 new file mode 100644 index 0000000..864c1d0 --- /dev/null +++ b/.werks/2915 @@ -0,0 +1,9 @@ +Title: supermicro.smart: new check to monitor harddisk health on snmp-enabled supermicro devices +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1452239072 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index 4cb4f74..4208568 100644 --- a/ChangeLog +++ b/ChangeLog @@ -75,6 +75,7 @@ * 2872 supermicro, supermicro.sensors: New check to monitor health on snmp-enabled devices by supermicro * 2913 fortigate_node, fortigate_node.cpu, fortigate_node.memory, fortigate_node.sessions: New checks to monitor HA nodes of fortigate firewalls * 1319 blade_bx_powerfan: Check can now be configured using Wato + * 2915 supermicro.smart: new check to monitor harddisk health on snmp-enabled supermicro devices * 2660 FIX: fixed windows agent using the wrong working directory... * 2664 FIX: ps: Speedup in situation with many matching processes... * 2661 FIX: windows agent: fixed incomplete process list... diff --git a/checkman/supermicro.smart b/checkman/supermicro.smart new file mode 100644 index 0000000..019d1a0 --- /dev/null +++ b/checkman/supermicro.smart @@ -0,0 +1,19 @@ +title: Supermicro Health Smart +agents: snmp +catalog: hw/other +license: GPL +distribution: check_mk +description: + This check tests S.M.A.R.T. health reported by snmp-enabled devices + from supermicro. + Currently this has only been tested with data from a mainboard on + windows. In this case an agent has to be enabled through the + SuperDoctor III software. + + Status {OK} and {CRIT} are relayed directly from the device, + a {WARN} may work but is not documented. + Status may also become {UNKNOWN} if the necessary driver is + uninstalled. + +inventory: + One item is reported per SMART-enabled harddisk. diff --git a/checks/supermicro b/checks/supermicro index 17de2a3..5b91fdf 100644 --- a/checks/supermicro +++ b/checks/supermicro @@ -60,6 +60,16 @@ # .1.3.6.1.4.1.10876.2.3 No problem. +#. +# .--Health--------------------------------------------------------------. +# | _ _ _ _ _ | +# | | | | | ___ __ _| | |_| |__ | +# | | |_| |/ _ \/ _` | | __| '_ \ | +# | | _ | __/ (_| | | |_| | | | | +# | |_| |_|\___|\__,_|_|\__|_| |_| | +# | | +# '----------------------------------------------------------------------' + def inventory_supermicro_health(info): if info[1]: return [(None, None)] @@ -72,7 +82,7 @@ def check_supermicro_health(_no_item, _no_params, info): check_info['supermicro'] = { 'check_function' : check_supermicro_health, 'inventory_function' : inventory_supermicro_health, - 'service_description' : "Health", + 'service_description' : "Overall Hardware Health", 'has_perfdata' : False, 'snmp_scan_function' : lambda oid: oid(".1.3.6.1.2.1.1.2.0") == ".1.3.6.1.4.1.311.1.1.3.1.2", 'snmp_info' : [ @@ -87,10 +97,23 @@ check_info['supermicro'] = { (".1.3.6.1.4.1.10876.2", [2, # smHealthAllinoneStatus 3, # smHealthAllinoneMsg ]), + (".1.3.6.1.4.1.10876.100.1.4.1", [1, # diskSerialNumber + 2, # diskName + 4]), # diskSmartStatus ] } +#. +# .--Sensors-------------------------------------------------------------. +# | ____ | +# | / ___| ___ _ __ ___ ___ _ __ ___ | +# | \___ \ / _ \ '_ \/ __|/ _ \| '__/ __| | +# | ___) | __/ | | \__ \ (_) | | \__ \ | +# | |____/ \___|_| |_|___/\___/|_| |___/ | +# | | +# '----------------------------------------------------------------------' + def inventory_supermicro_sensors(info): for name, sensor_type, reading, high, low, unit, status in info[0]: yield name, None @@ -152,6 +175,7 @@ def check_supermicro_sensors(item, _no_params, info): return (worst_status(status_high, status_low, dev_status), "%s%s" % (reading, unit), perfdata) + check_info['supermicro.sensors'] = { 'check_function' : check_supermicro_sensors, 'inventory_function' : inventory_supermicro_sensors, @@ -159,3 +183,51 @@ check_info['supermicro.sensors'] = { 'has_perfdata' : True, } + +#. +# .--SMART---------------------------------------------------------------. +# | ____ __ __ _ ____ _____ | +# | / ___|| \/ | / \ | _ \_ _| | +# | \___ \| |\/| | / _ \ | |_) || | | +# | ___) | | | |/ ___ \| _ < | | | +# | |____/|_| |_/_/ \_\_| \_\|_| | +# | | +# '----------------------------------------------------------------------' + + +def format_item_supermicro_smart(name): + return name.replace(r"\\\\.\\", "") + + +def inventory_supermicro_smart(info): + for serial, name, status in info[2]: + # status 3 indicates unknown, which may indicate missing driver support + if status != "3": + yield format_item_supermicro_smart(name), None + + +def check_supermicro_smart(item, _no_params, info): + # note (only status 0 (OK) and 2 (Crit) are documented. + # status 3 appears to indicate "unknown" as observed by a user. + # It's likely - but not verified - that status 1 would indicate a non- + # critical problem if it's used at all) + status_map = { + "0": "Healthy", + "1": "Warning", + "2": "Critical", + "3": "Unknown" + } + for serial, name, status in info[2]: + if format_item_supermicro_smart(name) == item: + return int(status), "(S/N %s) %s" % (serial, status_map[status]) + + +check_info['supermicro.smart'] = { + 'check_function' : check_supermicro_smart, + 'inventory_function' : inventory_supermicro_smart, + 'service_description' : "SMART Health %s", + 'has_perfdata' : True, +} + +#. +

8 years, 8 months

logwatch.ec: fixed failure to forward logwatch messages containing colons in the item name to event console

by Sebastian Herbord

Module: check_mk Branch: master Commit: d7a625e240607451c04d78b1082e957e721c4cf0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d7a625e2406074… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Thu Jan 7 18:20:38 2016 +0100 logwatch.ec: fixed failure to forward logwatch messages containing colons in the item name to event console --- mkeventd/bin/mkeventd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mkeventd/bin/mkeventd b/mkeventd/bin/mkeventd index e17ad39..5e4bb05 100755 --- a/mkeventd/bin/mkeventd +++ b/mkeventd/bin/mkeventd @@ -2150,7 +2150,7 @@ class EventServer: timestamp_str, host, rest = line[1:].split(None, 2) event["time"] = float(int(timestamp_str)) - service, message = rest.split(":", 1) + service, message = rest.split(": ", 1) event["application"] = service event["text"] = message.strip() event["host"] = host

8 years, 8 months

#1320 FIX fjdarye60_sum: Fixed bug in discovery function

by Bastian Kuhn

Module: check_mk Branch: master Commit: e9f7ed4433681d1fc34420d860a7ffbd794cf601 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e9f7ed4433681d… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Jan 7 15:36:04 2016 +0100 #1320 FIX fjdarye60_sum: Fixed bug in discovery function --- .werks/1320 | 9 +++++++++ ChangeLog | 3 ++- checks/fjdarye60_sum | 2 +- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/.werks/1320 b/.werks/1320 new file mode 100644 index 0000000..f20ae37 --- /dev/null +++ b/.werks/1320 @@ -0,0 +1,9 @@ +Title: fjdarye60_sum: Fixed bug in discovery function +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1452177343 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index d8dcd8c..4cb4f74 100644 --- a/ChangeLog +++ b/ChangeLog @@ -70,11 +70,11 @@ * 2817 cmc_temp: New temperature check for Rittal devices using the CMC MIB * 1600 check_mk_agent.linux: Diskstat Sektion now supports s390 DASDs (zLinux on IBM Mainframes) * 1318 cisco_asa_svcsessions: New Check to monitor VPN Connections on Cisco ASA devices - * 1319 blade_bx_powerfan: Check can now be configured using Wato * 2886 solaris_fmadm: new check monitors the severity and name of the fault class on Solaris systems using the 'fmadm faulty' command * 2871 msexch_database: New check to monitor access latencies to MS Exchange Databases * 2872 supermicro, supermicro.sensors: New check to monitor health on snmp-enabled devices by supermicro * 2913 fortigate_node, fortigate_node.cpu, fortigate_node.memory, fortigate_node.sessions: New checks to monitor HA nodes of fortigate firewalls + * 1319 blade_bx_powerfan: Check can now be configured using Wato * 2660 FIX: fixed windows agent using the wrong working directory... * 2664 FIX: ps: Speedup in situation with many matching processes... * 2661 FIX: windows agent: fixed incomplete process list... @@ -171,6 +171,7 @@ * 2820 FIX: winperf_phydisk: fixed invalid performance data for read/write ios * 2887 FIX: docsis_channels_downstream: now handles correct the downstream power in dBmV * 2914 FIX: hr_cpu: fixed check not being applied on some systems... + * 1320 FIX: fjdarye60_sum: Fixed bug in discovery function Multisite: * 2684 Added icons for downloading agent data / walks of hosts... diff --git a/checks/fjdarye60_sum b/checks/fjdarye60_sum index dcd3908..1b3b6bc 100644 --- a/checks/fjdarye60_sum +++ b/checks/fjdarye60_sum @@ -28,7 +28,7 @@ fjdarye60_sum_status = { 1: 'unknown', 2: 'unused', 3: 'ok', 4: 'warning', 5: 'failed' } def inventory_fjdarye60_sum(info): - return [ (int(index), '', None) for index, status in info ] + return [ (int(index), '', None) for index, status in info if index != '' ] def check_fjdarye60_sum(index, _no_param, info):

8 years, 8 months

Merge conflict

by Bastian Kuhn

Module: check_mk Branch: master Commit: 8e845211080636ea3379324185d7a6e8c912d5e2 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8e845211080636… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Jan 7 14:53:09 2016 +0100 Merge conflict ---

8 years, 8 months

#1319 blade_bx_powerfan: Check can now be configured using Wato

by Bastian Kuhn

Module: check_mk Branch: master Commit: 580a55025d0e683a0696bf9d2e570e5c3c102a7c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=580a55025d0e68… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Jan 7 14:52:26 2016 +0100 #1319 blade_bx_powerfan: Check can now be configured using Wato --- .werks/1319 | 9 +++++++++ ChangeLog | 1 + checks/blade_bx_powerfan | 38 +++++++++++++++++++++++++------------- 3 files changed, 35 insertions(+), 13 deletions(-) diff --git a/.werks/1319 b/.werks/1319 new file mode 100644 index 0000000..e8b4bee --- /dev/null +++ b/.werks/1319 @@ -0,0 +1,9 @@ +Title: blade_bx_powerfan: Check can now be configured using Wato +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1452174725 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index aa75dc6..22e401e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -69,6 +69,7 @@ * 2817 cmc_temp: New temperature check for Rittal devices using the CMC MIB * 1600 check_mk_agent.linux: Diskstat Sektion now supports s390 DASDs (zLinux on IBM Mainframes) * 1318 cisco_asa_svcsessions: New Check to monitor VPN Connections on Cisco ASA devices + * 1319 blade_bx_powerfan: Check can now be configured using Wato * 2660 FIX: fixed windows agent using the wrong working directory... * 2664 FIX: ps: Speedup in situation with many matching processes... * 2661 FIX: windows agent: fixed incomplete process list... diff --git a/checks/blade_bx_powerfan b/checks/blade_bx_powerfan index 9ddcc0d..0a90044 100644 --- a/checks/blade_bx_powerfan +++ b/checks/blade_bx_powerfan @@ -24,9 +24,15 @@ # to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, # Boston, MA 02110-1301 USA. - +# For legacy reasons blade_bx_fan_default_error_levels = (20, 10) # percentages or errors! +factory_settings['blade_bx_powerfan_default_levels'] = { + "levels_lower" : ( 20, 10 ), + "levels" : ( 80, 90 ), + +} + blade_bx_status = { "1" : "unknow", "2" : "disabled", "3" : "ok", @@ -40,10 +46,16 @@ blade_bx_status = { "1" : "unknow", def inventory_blade_bx_powerfan(info): for line in info: if line[1] != "8": - yield line[2], "blade_bx_fan_default_error_levels" + yield line[2],{} def check_blade_bx_powerfan(item, params, info): - warn_perc, crit_perc = params + if type(params) == dict: + warn_perc, crit_perc = params['levels'] + warn_perc_up, crit_perc_up = params['levels_lower'] + else: + warn_perc, crit_perc = params + warn_perc_up, crit_perc_up = None, None + for index, status, descr, rpm, max_speed, speed, ctrlstate in info: if descr != item: continue he = 1 @@ -56,22 +68,22 @@ def check_blade_bx_powerfan(item, params, info): return (2, "Fan not present or poweroff", perfdata) elif status != "3": return (2, "Status not OK (Status %s)" % blade_bx_status[status] , perfdata) - elif speedperc_int <= crit_perc: - return (2, "Speed at %d%% of max (crit at %d%%)" % (speedperc_int, crit_perc), perfdata) - elif speedperc_int <= warn_perc: - return (1, "Speed at %d%% of max (warning at %d%%)" % (speedperc_int, warn_perc), perfdata) + elif speedperc_int <= crit_perc or (crit_perc_up and speedperc_int >= crit_perc_up): + return 2, "Speed at %d%% of max (crit at < %d%% or > %d%%)" % (speedperc_int, crit_perc, crit_perc_up ), perfdata + elif speedperc_int <= warn_perc or (warn_perc and speedperc_int >= warn_perc_up): + return 1, "Speed at %d%% of max (warning at < %d%% > %d%%)" % (speedperc_int, warn_perc, warn_perc_up), perfdata else: return (0, "Speed at %s RPM (%d%% of max)" % (rpm, speedperc_int), perfdata) - return (3, "Device %s not found in SNMP data %s " % (item, perfdata ) ) - return (3, "Device %s not found in SNMP data" % item) check_info['blade_bx_powerfan'] = { - "check_function" : check_blade_bx_powerfan, - "inventory_function" : inventory_blade_bx_powerfan, - "service_description" : "Blade Cooling %s", - "has_perfdata" : True, + "check_function" : check_blade_bx_powerfan, + "inventory_function" : inventory_blade_bx_powerfan, + "service_description" : "Blade Cooling %s", + "has_perfdata" : True, + "group" : "hw_fans_perc", + "default_levels_variable" : "blade_bx_powerfan_default_levels", "snmp_info" : (".1.3.6.1.4.1.7244.1.1.1.3.3.1.1", [ 1, #index 2, #status

8 years, 8 months

ewon: fixed an incorrect comment

by Sebastian Herbord

Module: check_mk Branch: master Commit: 0ad4e04b435810d097ddf0ef3db84e7a40ff9581 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0ad4e04b435810… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Thu Jan 7 10:59:53 2016 +0100 ewon: fixed an incorrect comment --- checks/ewon | 1 - 1 file changed, 1 deletion(-) diff --git a/checks/ewon b/checks/ewon index 768d4df..4e3bb6d 100644 --- a/checks/ewon +++ b/checks/ewon @@ -42,7 +42,6 @@ ewon_discovery_rules = [] # "?" - we don't care about this flag # "*" - add the flag to the infotext but don't derive a state from it # "+" - add the flag to the infotext if it is set but don't derive a state from it -# letters define groups among which exactly one should be active # Also, we provide the names of flags for proper info texts. oxyreduct_tag_map = { 1: {"name": "alarms", "levels": (1, 2, -1, -1)},

8 years, 8 months

#2914 FIX hr_cpu: fixed check not being applied on some systems

by Sebastian Herbord

Module: check_mk Branch: master Commit: e88cbdfaa0308c6fa118ebc9140be1e5af040577 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e88cbdfaa0308c… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Thu Jan 7 14:19:21 2016 +0100 #2914 FIX hr_cpu: fixed check not being applied on some systems both hr_cpu and ucd_cpu_util prioritised the other in their scan function so that if both sections were available, neither got used. --- .werks/2914 | 11 +++++++++++ ChangeLog | 1 + checks/hr_cpu | 5 +---- 3 files changed, 13 insertions(+), 4 deletions(-) diff --git a/.werks/2914 b/.werks/2914 new file mode 100644 index 0000000..8085e92 --- /dev/null +++ b/.werks/2914 @@ -0,0 +1,11 @@ +Title: hr_cpu: fixed check not being applied on some systems +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1452172518 +Class: fix + +both hr_cpu and ucd_cpu_util prioritised the other in their +scan function so that if both sections were available, +neither got used. diff --git a/ChangeLog b/ChangeLog index c11be30..1473f3c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -169,6 +169,7 @@ * 2819 FIX: netapp_api_if: now able to detect even more interfaces... * 2820 FIX: winperf_phydisk: fixed invalid performance data for read/write ios * 2887 FIX: docsis_channels_downstream: now handles correct the downstream power in dBmV + * 2914 FIX: hr_cpu: fixed check not being applied on some systems... Multisite: * 2684 Added icons for downloading agent data / walks of hosts... diff --git a/checks/hr_cpu b/checks/hr_cpu index a3bc6a5..f327b66 100644 --- a/checks/hr_cpu +++ b/checks/hr_cpu @@ -49,10 +49,7 @@ check_info["hr_cpu"] = { 'service_description': 'CPU utilization', 'has_perfdata': True, 'snmp_info': ('.1.3.6.1.2.1.25.3.3.1', [2]), - 'snmp_scan_function': lambda oid: \ - not not oid('.1.3.6.1.2.1.25.1.1.0') and not \ - ("linux" in oid(".1.3.6.1.2.1.1.1.0").lower() - and oid(".1.3.6.1.4.1.2021.10.1.6.1")), + 'snmp_scan_function': lambda oid: oid('.1.3.6.1.2.1.25.1.1.0'), 'group': 'cpu_utilization_os', 'includes': [ 'cpu_util.include' ], }

8 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2016