Checkmk git commits January 2016

checkmk-commits@lists.checkmk.com

9 participants
303 discussions

#2916 checkpoint_fan, checkpoint_firewall, checkpoint_ha_problems, checkpoint_ha_status, checkpoint_powersupply, checkpoint_svn_status, checkpoint_temp, checkpoint_voltage: New checks for various aspects of checkpoint firewalls

by Sebastian Herbord

Module: check_mk Branch: master Commit: fae6f0becf5df1a0006741fd5053adef1684a9c5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=fae6f0becf5df1… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Mon Jan 11 08:41:13 2016 +0100 #2916 checkpoint_fan, checkpoint_firewall, checkpoint_ha_problems, checkpoint_ha_status, checkpoint_powersupply, checkpoint_svn_status, checkpoint_temp, checkpoint_voltage: New checks for various aspects of checkpoint firewalls --- .werks/2916 | 9 +++++ ChangeLog | 1 + checkman/checkpoint_fan | 14 +++++++ checkman/checkpoint_firewall | 12 ++++++ checkman/checkpoint_ha_problems | 16 ++++++++ checkman/checkpoint_ha_status | 20 ++++++++++ checkman/checkpoint_powersupply | 14 +++++++ checkman/checkpoint_svn_status | 16 ++++++++ checkman/checkpoint_temp | 16 ++++++++ checkman/checkpoint_voltage | 14 +++++++ checks/checkpoint.include | 8 ++++ checks/checkpoint_fan | 56 ++++++++++++++++++++++++++++ checks/checkpoint_firewall | 56 ++++++++++++++++++++++++++++ checks/checkpoint_ha_problems | 53 ++++++++++++++++++++++++++ checks/checkpoint_ha_status | 78 +++++++++++++++++++++++++++++++++++++++ checks/checkpoint_powersupply | 54 +++++++++++++++++++++++++++ checks/checkpoint_svn_status | 55 +++++++++++++++++++++++++++ checks/checkpoint_temp | 66 +++++++++++++++++++++++++++++++++ checks/checkpoint_voltage | 52 ++++++++++++++++++++++++++ 19 files changed, 610 insertions(+) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=fae6f0becf…

8 years, 8 months

Use autoreconf instead of autoFOO cascade. Easier and more consistent with .f12.

by Sven Panne

Module: check_mk Branch: master Commit: ff77c01231afb8ecf54ecbd953bed0af45a97181 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ff77c01231afb8… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Mon Jan 11 08:19:24 2016 +0100 Use autoreconf instead of autoFOO cascade. Easier and more consistent with .f12. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index e426078..9bb769b 100644 --- a/Makefile +++ b/Makefile @@ -154,7 +154,7 @@ mk-eventd: mk-livestatus: if [ ! -e livestatus/configure ] ; then \ - cd livestatus && aclocal && autoheader && automake -a && autoconf ; \ + cd livestatus && autoreconf --install ; \ fi rm -rf mk-livestatus-$(VERSION) mkdir -p mk-livestatus-$(VERSION)

8 years, 8 months

Select the 'best' compiler via configure.

by Sven Panne

Module: check_mk Branch: master Commit: 2ee17bf39a042c39f739fb1f3e893790b5663c93 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2ee17bf39a042c… Author: Sven Panne <sp(a)mathias-kettner.de> Date: Mon Jan 11 08:18:31 2016 +0100 Select the 'best' compiler via configure. --- livestatus/configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/livestatus/configure.ac b/livestatus/configure.ac index 8aac38f..0d832c3 100644 --- a/livestatus/configure.ac +++ b/livestatus/configure.ac @@ -34,8 +34,8 @@ AC_CONFIG_SRCDIR([config.h.in]) AC_CONFIG_HEADER([config.h]) # Checks for programs. -AC_PROG_CXX -AC_PROG_CC +AC_PROG_CC([gcc44 gcc clang]) +AC_PROG_CXX([g++44 g++ clang++]) AC_PROG_RANLIB AM_CONDITIONAL([HAVE_DIET], [which diet >/dev/null 2>&1]) # automake 1.12 seems to require this, but automake 1.11 doesn't recognize it. :-P

8 years, 8 months

update WK# 2700

by Andreas Boesl

Module: check_mk Branch: master Commit: 0e4135f848b8240e75cef8f855aa3b887fe72172 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0e4135f848b824… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Jan 8 16:56:59 2016 +0100 update WK# 2700 --- checks/ibm_svc_node | 2 -- 1 file changed, 2 deletions(-) diff --git a/checks/ibm_svc_node b/checks/ibm_svc_node index a9b2bed..7f4e429 100644 --- a/checks/ibm_svc_node +++ b/checks/ibm_svc_node @@ -43,8 +43,6 @@ def inventory_ibm_svc_node(info): iscsi_alias, panel_name, enclosure_id, canister_id,\ enclosure_serial_number, additional = line[:17] io_groups[io_group_name] = 1 - for line in info: - io_groups[line[5]] = 1 for io_group_name in io_groups.keys(): inventory.append( (io_group_name, None) ) return inventory

8 years, 8 months

#1321 sap.dialog: It is now possible to configure levels for FrontEndNetTime, ResponseTime and UsersLoggedIn

by Bastian Kuhn

Module: check_mk Branch: master Commit: 3aa77101d8a177939553376038c7a693f22d1217 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3aa77101d8a177… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Fri Jan 8 16:55:38 2016 +0100 #1321 sap.dialog: It is now possible to configure levels for FrontEndNetTime, ResponseTime and UsersLoggedIn --- .werks/1321 | 9 ++++++++ ChangeLog | 1 + checks/sap | 13 ++++++++--- web/plugins/wato/check_parameters.py | 42 ++++++++++++++++++++++++++++++++++ 4 files changed, 62 insertions(+), 3 deletions(-) diff --git a/.werks/1321 b/.werks/1321 new file mode 100644 index 0000000..c3bf833 --- /dev/null +++ b/.werks/1321 @@ -0,0 +1,9 @@ +Title: sap.dialog: It is now possible to configure levels for FrontEndNetTime, ResponseTime and UsersLoggedIn +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1452268457 +Class: feature + + diff --git a/ChangeLog b/ChangeLog index 42c3272..9329466 100644 --- a/ChangeLog +++ b/ChangeLog @@ -76,6 +76,7 @@ * 2913 fortigate_node, fortigate_node.cpu, fortigate_node.memory, fortigate_node.sessions: New checks to monitor HA nodes of fortigate firewalls * 1319 blade_bx_powerfan: Check can now be configured using Wato * 2915 supermicro.smart: new check to monitor harddisk health on snmp-enabled supermicro devices + * 1321 sap.dialog: It is now possible to configure levels for FrontEndNetTime, ResponseTime and UsersLoggedIn * 2660 FIX: fixed windows agent using the wrong working directory... * 2664 FIX: ps: Speedup in situation with many matching processes... * 2661 FIX: windows agent: fixed incomplete process list... diff --git a/checks/sap b/checks/sap index 8f165f4..b2f8449 100644 --- a/checks/sap +++ b/checks/sap @@ -64,12 +64,19 @@ def check_sap_dialog(item, params, info): return s.replace('(', '_').replace(')', '_').replace(' ', '_').replace('.', '_').rstrip('_') # {'UsersLoggedIn': (2, '-'), 'ResponseTime(StandardTran.)': (6, 'msec'), 'FrontEndNetTime': (0, 'msec'), 'ResponseTime': (77, 'msec')} - perfdata = [ (perf_clean_key(k), v[0]) for k, v in dialog.items() ] - output = ', '.join([ '%s: %d%s' % (k, v[0], (v[1] != '-' and v[1] or '')) for k, v in dialog.items() ]) - return (0, output, perfdata) + for key, value in dialog.items(): + state = 0 + if key in params: + warn, crit = params[key] + if value[0] >= crit: + state = 2 + elif value[0] >= warn: + state = 1 + yield state, "%s: %d%s" % (key, value[0], (value[1] != '-' and value[1] or '') ), [ (perf_clean_key(key), value[0]) ] check_info['sap.dialog'] = { "check_function" : check_sap_dialog, + "group" : "sap_dialog", "inventory_function" : inventory_sap_dialog, "service_description" : "%s Dialog", "has_perfdata" : True, diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 285884f..89ae8bd 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -2167,6 +2167,48 @@ register_check_parameters( register_check_parameters( subgroup_applications, + "sap_dialog", + ("SAP Dialog"), + Dictionary( + elements = [ + ( "UsersLoggedIn", + Tuple( + title = _("Number of Loggedin Users"), + elements = [ + Integer(title = _("Warning at"), label = _("Users")), + Integer(title = _("Critical at"), label = _("Users")) + ] + ) + ), + ( "FrontEndNetTime", + Tuple( + title = _("Frontend net time"), + elements = [ + Float(title = _("Warning at"), unit = _('ms') ), + Float(title = _("Critical at"), unit = _('ms') ) + ] + ) + ), + ( "ResponseTime", + Tuple( + title = _("Response Time"), + elements = [ + Float(title = _("Warning at"), unit = _('ms') ), + Float(title = _("Critical at"), unit = _('ms') ) + ] + ) + ), + ] + ), + TextAscii( + title = _("System ID"), + help = _("The SAP system ID."), + ), + match_type = "dict", +) + +register_check_parameters( + subgroup_applications, "nginx_status", ("Nginx Status"), Dictionary(

8 years, 8 months

#2888 FIX citrix_controller.licensing: ignoring double data from piggy backs

by Simon Betz

Module: check_mk Branch: master Commit: 3fe779ab4360e1fd7ed39a19c2b7a7a45e1edf7e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3fe779ab4360e1… Author: Simon Betz <si(a)mathias-kettner.de> Date: Fri Jan 8 15:56:38 2016 +0100 #2888 FIX citrix_controller.licensing: ignoring double data from piggy backs --- .werks/2888 | 9 +++++++++ ChangeLog | 1 + checks/citrix_controller | 41 ++++++++++++++++++++++------------------- 3 files changed, 32 insertions(+), 19 deletions(-) diff --git a/.werks/2888 b/.werks/2888 new file mode 100644 index 0000000..804cefd --- /dev/null +++ b/.werks/2888 @@ -0,0 +1,9 @@ +Title: citrix_controller.licensing: ignoring double data from piggy backs +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1452264891 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index d791b46..42c3272 100644 --- a/ChangeLog +++ b/ChangeLog @@ -174,6 +174,7 @@ * 2914 FIX: hr_cpu: fixed check not being applied on some systems... * 1320 FIX: fjdarye60_sum: Fixed bug in discovery function * 2898 FIX: smart: Using normalized value for determining reallocated events state... + * 2888 FIX: citrix_controller.licensing: ignoring double data from piggy backs Multisite: * 2684 Added icons for downloading agent data / walks of hosts... diff --git a/checks/citrix_controller b/checks/citrix_controller index 082ab51..9d79f6c 100644 --- a/checks/citrix_controller +++ b/checks/citrix_controller @@ -185,30 +185,33 @@ def check_citrix_controller_licensing(_no_item, _no_params, info): "licensingserverstate" : ( "Licensing Server State", { - "ServerNotSpecified" : 2, - "NotConnected" : 1, - "OK" : 0, - "LicenseNotInstalled" : 2, - "LicenseExpired" : 2, - "Incompatible" : 2, - "Failed" : 2, + "ServerNotSpecified" : (2, "server not specified"), + "NotConnected" : (1, "not connected"), + "OK" : (0, "OK"), + "LicenseNotInstalled" : (2, "license not installed"), + "LicenseExpired" : (2, "licenese expired"), + "Incompatible" : (2, "incompatible"), + "Failed" : (2, "failed"), }), "licensinggracestate" : ( - "Licensing Grace State: ", + "Licensing Grace State", { - "NotActive" : 0, - "Active" : 2, - "InOutOfBoxGracePeriod" : 1, - "InSupplementalGracePeriod" : 1, - "InEmergencyGracePeriod" : 2, - "GracePeriodExpired" : 2, + "NotActive" : (0, "not active"), + "Active" : (2, "active"), + "InOutOfBoxGracePeriod" : (1, "in-out-of-box grace period"), + "InSupplementalGracePeriod" : (1, "in-supplemental grace period"), + "InEmergencyGracePeriod" : (2, "in-emergency grace period"), + "GracePeriodExpired" : (2, "grace period expired"), }), } - - for what, (title, states) in statedict.items(): - for line in info: - if line[0].lower() == what: - yield states[line[1]], title + ": " + line[1] + # piggy back data might deliver double data + detected_states = [] + for line in info: + if line[0].lower() in statedict and line[0] not in detected_states: + detected_states.append(line[0]) + title, states = statedict[line[0].lower()] + state, state_readable = states[line[1]] + yield state, "%s: %s" % (title, state_readable) check_info["citrix_controller.licensing"] = {

8 years, 8 months

supermicro.smart: will now also discover items with unknown health status

by Sebastian Herbord

Module: check_mk Branch: master Commit: aff6ecedf6bf990722a7e9195a85a7149fce086e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=aff6ecedf6bf99… Author: Sebastian Herbord <sh(a)mathias-kettner.de> Date: Fri Jan 8 14:19:45 2016 +0100 supermicro.smart: will now also discover items with unknown health status --- checks/supermicro | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/checks/supermicro b/checks/supermicro index 5b91fdf..40f2195 100644 --- a/checks/supermicro +++ b/checks/supermicro @@ -201,9 +201,7 @@ def format_item_supermicro_smart(name): def inventory_supermicro_smart(info): for serial, name, status in info[2]: - # status 3 indicates unknown, which may indicate missing driver support - if status != "3": - yield format_item_supermicro_smart(name), None + yield format_item_supermicro_smart(name), None def check_supermicro_smart(item, _no_params, info):

8 years, 8 months

#2823 FIX Availability: Fixed division by zero error on rendering the availability table

by Andreas Boesl

Module: check_mk Branch: master Commit: 1ae69bd18126ecce63e5881b3b2272693c7747cb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1ae69bd18126ec… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Jan 8 15:11:53 2016 +0100 #2823 FIX Availability: Fixed division by zero error on rendering the availability table --- .werks/2823 | 9 +++++++++ ChangeLog | 3 +++ web/htdocs/availability.py | 3 +++ 3 files changed, 15 insertions(+) diff --git a/.werks/2823 b/.werks/2823 new file mode 100644 index 0000000..2b22313 --- /dev/null +++ b/.werks/2823 @@ -0,0 +1,9 @@ +Title: Availability: Fixed division by zero error on rendering the availability table +Level: 1 +Component: reporting +Compatible: compat +Version: 1.2.7i4 +Date: 1452262229 +Class: fix + + diff --git a/ChangeLog b/ChangeLog index 0a5a35a..d791b46 100644 --- a/ChangeLog +++ b/ChangeLog @@ -240,6 +240,9 @@ * 2815 FIX: Notification scripts: Fixed missing environment variables... * 2821 FIX: WATO rule based notifications: Validate regular expression for service conditions... + Reporting & Availability: + * 2823 FIX: Availability: Fixed division by zero error on rendering the availability table + Event Console: * 2733 Visibility of Event Console events more flexible now... * 1306 mkeventd: The Recent event history can you be filtered by extended regexes diff --git a/web/htdocs/availability.py b/web/htdocs/availability.py index 28a66c6..bfc210f 100644 --- a/web/htdocs/availability.py +++ b/web/htdocs/availability.py @@ -732,6 +732,9 @@ def compute_availability(what, av_rawdata, avoptions): def pass_availability_filter(row, avoptions): + if row["considered_duration"] == 0: + return True + for key, level in avoptions["av_filter_outages"].items(): if level == 0.0: continue

8 years, 8 months

#2822 FIX Availabiltiy: Fixed exception while rendering the timeline

by Andreas Boesl

Module: check_mk Branch: master Commit: 99440b540ab087afdb609e9bcfc1ae152e8a3acd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=99440b540ab087… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Jan 8 14:54:09 2016 +0100 #2822 FIX Availabiltiy: Fixed exception while rendering the timeline The error message <i>'valuespec' is not defined</i> will no longer show up with certain filter settings. --- .werks/2822 | 11 +++++++++++ ChangeLog | 1 + web/htdocs/availability.py | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/.werks/2822 b/.werks/2822 new file mode 100644 index 0000000..62ac955 --- /dev/null +++ b/.werks/2822 @@ -0,0 +1,11 @@ +Title: Availabiltiy: Fixed exception while rendering the timeline +Level: 1 +Component: multisite +Compatible: compat +Version: 1.2.7i4 +Date: 1452261103 +Class: fix + +The error message <i>'valuespec' is not defined</i> will no longer +show up with certain filter settings. + diff --git a/ChangeLog b/ChangeLog index 4e484c5..0a5a35a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -207,6 +207,7 @@ * 2810 FIX: esx_vsphere_counters, winperf_phydisk: fixed exception on pnpgraph overview page... * 2895 FIX: Fixed broken "back to view" links after checkbox actions in views... * 2896 FIX: Improved handling of wrong encoded input strings... + * 2822 FIX: Availabiltiy: Fixed exception while rendering the timeline... WATO: * 2442 WATO remove host: improved cleanup of obsolete host files... diff --git a/web/htdocs/availability.py b/web/htdocs/availability.py index 5ec7802..28a66c6 100644 --- a/web/htdocs/availability.py +++ b/web/htdocs/availability.py @@ -1249,7 +1249,7 @@ def find_next_choord(broken, scale): broken[1] = 1 broken[0] += 1 epoch = time.mktime(broken) - title = "%s %d" % (valuespec.month_names[broken[1]-1], broken[0]) + title = "%s %d" % (month_names[broken[1]-1], broken[0]) dst = broken[8] if old_dst == 1 and dst == 0:

8 years, 8 months

#2898 FIX smart: Using normalized value for determining reallocated events state

by Lars Michelsen

Module: check_mk Branch: master Commit: b0246f6e1ea574b04d8e34c6e2df49c175b5ea04 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b0246f6e1ea574… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 8 14:12:43 2016 +0100 #2898 FIX smart: Using normalized value for determining reallocated events state The smart check often reported errors for disks which had just a small number of reallocated events but where the normalized state value (aggregated by hardware manufacturer logic) did not report an issue. This was caused by the logic of the check which stores values the agent reports during service discovery and continously checks the difference between these values and the current values reported by the disk. In this progress the "raw values" of the smartctl output were used for all attributes. But this seemed - at least for the "reallocated events count" - not a really good approach because the raw values may slightly change during regular operation. But small changes of the values does not necessarly mean a predicted failure. So we decided to change the logic only for the "reallocated events" now. Maybe we need to change it for the other values in the future. But for the moment only the single value interpretation was changed. --- .werks/2898 | 24 ++++++++++++++++++++++++ ChangeLog | 1 + checks/smart | 50 +++++++++++++++++++++++++++++++++++++++++--------- 3 files changed, 66 insertions(+), 9 deletions(-) diff --git a/.werks/2898 b/.werks/2898 new file mode 100644 index 0000000..ae28eb0 --- /dev/null +++ b/.werks/2898 @@ -0,0 +1,24 @@ +Title: smart: Using normalized value for determining reallocated events state +Level: 1 +Component: checks +Compatible: compat +Version: 1.2.7i4 +Date: 1452258418 +Class: fix + +The smart check often reported errors for disks which had just a small number of +reallocated events but where the normalized state value (aggregated by hardware +manufacturer logic) did not report an issue. + +This was caused by the logic of the check which stores values the agent reports +during service discovery and continously checks the difference between these values +and the current values reported by the disk. In this progress the "raw values" of +the smartctl output were used for all attributes. + +But this seemed - at least for the "reallocated events count" - not a really good +approach because the raw values may slightly change during regular operation. But +small changes of the values does not necessarly mean a predicted failure. So we +decided to change the logic only for the "reallocated events" now. + +Maybe we need to change it for the other values in the future. But for the moment +only the single value interpretation was changed. diff --git a/ChangeLog b/ChangeLog index 5af50e1..4e484c5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -173,6 +173,7 @@ * 2887 FIX: docsis_channels_downstream: now handles correct the downstream power in dBmV * 2914 FIX: hr_cpu: fixed check not being applied on some systems... * 1320 FIX: fjdarye60_sum: Fixed bug in discovery function + * 2898 FIX: smart: Using normalized value for determining reallocated events state... Multisite: * 2684 Added icons for downloading agent data / walks of hosts... diff --git a/checks/smart b/checks/smart index 21e598c..a9b1ce2 100644 --- a/checks/smart +++ b/checks/smart @@ -24,8 +24,6 @@ # to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, # Boston, MA 02110-1301 USA. -# Author: Lars Michelsen <lm(a)mathias-kettner.de> - # EXAMPLE DATA FROM: WDC SSC-D0128SC-2100 #<<<smart>>> #/dev/sda ATA WDC_SSC-D0128SC- 1 Raw_Read_Error_Rate 0x000b 100 100 050 Pre-fail Always - 16777215 @@ -58,7 +56,7 @@ smart_stats_default_levels = { 'udma_crcs': (1, 1), } -def parse_smart(info): +def parse_smart_raw_values(info): disks = {} disk_name = None @@ -76,6 +74,25 @@ def parse_smart(info): return disks +def parse_smart_normalized_values(info): + disks = {} + disk_name = None + + for line in info: + if len(line) >= 13: + if line[0] != disk_name: + disk_name = line[0] + disk = {} + disks[disk_name] = disk + + field = line[4] + if field != "Unknown_Attribute": + value = int(line[6]) + threshold = int(line[8]) + disk[field] = value, threshold + return disks + + smart_stats_fields = [ 'Reallocated_Sector_Ct', 'Spin_Retry_Count', @@ -87,7 +104,7 @@ smart_stats_fields = [ 'UDMA_CRC_Error_Count', ] def inventory_smart_stats(info): - disks = parse_smart(info) + disks = parse_smart_raw_values(info) inventory = [] for disk_name, disk in disks.items(): for field in disk.keys(): @@ -100,7 +117,10 @@ def inventory_smart_stats(info): def check_smart_stats(item, params, info): # params is a snapshot of all counters at the point of time of inventory - disks = parse_smart(info) + + disks = parse_smart_raw_values(info) + normalized = parse_smart_normalized_values(info) + if item not in disks: return 3, "Disk not found" disk = disks[item] @@ -124,11 +144,23 @@ def check_smart_stats(item, params, info): value = disk[field] infos.append("%s: %d%s" % (descr, value, unit)) perfdata.append((field, value)) + if field in params: ref_value = params[field] - if value > ref_value: + + # For reallocated event counts we experienced to many reported errors for disks + # which still seem to be OK. The raw value increased by a small amount but the + # aggregated value remained at it's initial/ok state. So we use the aggregated + # value now. Only for this field. + if field == "Reallocated_Event_Count": + infos[-1] += " (was %d during discovery; normalized value looks OK)" % ref_value + norm_value, norm_threshold = normalized[item][field] + if norm_value <= norm_threshold: + state = 2 + + elif value > ref_value: state = 2 - infos[-1] += " - was %d during inventory(!!)" % ref_value + infos[-1] += "(!!) (was %d during discovery)" % ref_value return state, ", ".join(infos), perfdata @@ -141,13 +173,13 @@ check_info["smart.stats"] = { def inventory_smart_temp(info): - disks = parse_smart(info) + disks = parse_smart_raw_values(info) return [(disk_name, 'smart_temp_default_levels') for disk_name, disk in disks.items() if "Temperature_Celsius" in disk] def check_smart_temp(item, params, info): - disks = parse_smart(info) + disks = parse_smart_raw_values(info) try: temperature = disks[item]["Temperature_Celsius"]

8 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2016