Checkmk git commits February 2015

checkmk-commits@lists.checkmk.com

8 participants
297 discussions

Check_MK Git: check_mk: Updated werk description

by Mathias Kettner

Module: check_mk Branch: master Commit: a92eb126e02141f9eb3abd7352c96d33800e1783 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a92eb126e02141… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Feb 3 12:13:28 2015 +0100 Updated werk description --- .werks/1827 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.werks/1827 b/.werks/1827 index bd8b107..06e46a7 100644 --- a/.werks/1827 +++ b/.werks/1827 @@ -7,12 +7,12 @@ State: unknown Version: 1.2.7i1 Date: 1422393240 -The WATO rule missed a configuration for default incremente on datafiles. +The WATO rule missed a configuration for default increment on datafiles. This has been added. Importan Note: -The old configuration variable oracle_tablespaces_check_default_increment -has been replaced with the dictionary based parameter defaultincrement. +The old configuration variable <tt>oracle_tablespaces_check_default_increment</tt> +has been replaced with the dictionary based parameter <tt>defaultincrement</tt>. The default behaivor is still true and only users who disabled the check for default increment need to add a rule with the new dictionary based parameter.

9 years, 4 months

Check_MK Git: check_mk: #1827 oracle_tablespace: WATO rule for default increment

by Mathias Kettner

Module: check_mk Branch: master Commit: 86ceec68b9a544a059712ed8ec65525a703fcd2e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=86ceec68b9a544… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Feb 3 12:11:26 2015 +0100 #1827 oracle_tablespace: WATO rule for default increment The WATO rule missed a configuration for default incremente on datafiles. This has been added. Importan Note: The old configuration variable oracle_tablespaces_check_default_increment has been replaced with the dictionary based parameter defaultincrement. The default behaivor is still true and only users who disabled the check for default increment need to add a rule with the new dictionary based parameter. --- .werks/1827 | 19 +++++++++++++++++++ ChangeLog | 2 ++ checks/oracle_tablespaces | 7 ++++--- web/plugins/wato/check_parameters.py | 5 +++++ 4 files changed, 30 insertions(+), 3 deletions(-) diff --git a/.werks/1827 b/.werks/1827 new file mode 100644 index 0000000..bd8b107 --- /dev/null +++ b/.werks/1827 @@ -0,0 +1,19 @@ +Title: oracle_tablespace: WATO rule for default increment +Level: 1 +Component: checks +Class: feature +Compatible: incomp +State: unknown +Version: 1.2.7i1 +Date: 1422393240 + +The WATO rule missed a configuration for default incremente on datafiles. +This has been added. + +Importan Note: +The old configuration variable oracle_tablespaces_check_default_increment +has been replaced with the dictionary based parameter defaultincrement. +The default behaivor is still true and only users who disabled the check +for default increment need to add a rule with the new dictionary based +parameter. + diff --git a/ChangeLog b/ChangeLog index d413469..d86fae8 100644 --- a/ChangeLog +++ b/ChangeLog @@ -60,6 +60,8 @@ * 1216 hp_procurve_cpu: Can now be configured with Wato * 1676 if.include: now able to detect grouped interfaces... * 1928 netapp_api_if: Improved handling and check output of virtual interfaces... + * 1827 oracle_tablespace: WATO rule for default increment... + NOTE: Please refer to the migration notes! * 1217 dell_om_sensors: Check now uses generic temperature features... NOTE: Please refer to the migration notes! * 1929 netapp_api_if: improved inventory and check output of virtual interfaces... diff --git a/checks/oracle_tablespaces b/checks/oracle_tablespaces index 48e041e..8cb4e85 100644 --- a/checks/oracle_tablespaces +++ b/checks/oracle_tablespaces @@ -65,12 +65,14 @@ factory_settings["oracle_tablespaces_defaults"] = { "levels" : (10.0, 5.0), "magic_normsize" : 1000, "magic_maxlevels": (60.0, 50.0), + "defaultincrement": True, } # Whether to check auto extend settings oracle_tablespaces_check_autoext = True -# Whether to check default increment size +# this parameter is deprecated and needed for old configurations with +# parameter in main.mk. It is not used anymore! oracle_tablespaces_check_default_increment = True def inventory_oracle_tablespaces(info): @@ -242,7 +244,7 @@ def check_oracle_tablespaces(item, params, info): status = 0 # Check increment size, should not be set to default (1) - if oracle_tablespaces_check_default_increment: + if params.get("defaultincrement"): if uses_default_increment: infotext += ", DEFAULT INCREMENT(!)" status = 1 @@ -290,4 +292,3 @@ check_info['oracle_tablespaces'] = { "default_levels_variable" : "oracle_tablespaces_defaults", "includes" : [ "oracle.include" ] } -check_config_variables.append("oracle_tablespaces_check_default_increment") diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 04c5eeb..637c6f6 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -3624,6 +3624,11 @@ register_check_parameters( title = _("Autoextend"), label = _("Autoextension is expected"), help = "")), + ( "defaultincrement", + Checkbox( + title = _("Detault Increment"), + label = _("State is WARNING in case of next extent is default."), + help = "")), ]), TextAscii( title = _("Explicit tablespaces"),

9 years, 4 months

Check_MK Git: check_mk: Updated bug entries #2170

by Andreas Boesl

Module: check_mk Branch: master Commit: 36a9ac8ac9bb840d5efb0207c5d9892b2e822c40 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=36a9ac8ac9bb84… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Tue Feb 3 12:04:24 2015 +0100 Updated bug entries #2170 --- .bugs/2170 | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.bugs/2170 b/.bugs/2170 new file mode 100644 index 0000000..48288bd --- /dev/null +++ b/.bugs/2170 @@ -0,0 +1,17 @@ +Title: ensure that the params parameter is not modified within checks +Component: checks +State: open +Date: 2015-02-03 11:55:21 +Targetversion: future +Class: cleanup + +Example check: fritz + + if 'assumed_speed_in' not in params: + params['assumed_speed_in'] = int(data['NewLayer1DownstreamMaxBitRate']) + +This type of assignment actively modifies the params dictionary -> not allowed + +How to find such checks: +Make a comparision between the parameters before and after the execution of the check function +Any variation results either in an Exception or an output to stderr.

9 years, 4 months

Check_MK Git: check_mk: First test with a few Perf-O-Meters based on new metrics

by Mathias Kettner

Module: check_mk Branch: master Commit: d2a8ad811a594f174fd63f166e6c8ede0619f743 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d2a8ad811a594f… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Feb 1 16:20:06 2015 +0100 First test with a few Perf-O-Meters based on new metrics --- web/htdocs/index.py | 2 +- web/htdocs/metrics.py | 109 +++++++++++++++++++++ web/plugins/metrics/check_mk.py | 188 ++++++++++++++++++++++++++++++++++++ web/plugins/pages/metrics.py | 31 ++++++ web/plugins/perfometer/check_mk.py | 1 - web/plugins/views/perfometer.py | 80 ++++++++++++--- 6 files changed, 394 insertions(+), 17 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=d2a8ad811a…

9 years, 4 months

Check_MK Git: check_mk: First experimental implementation of filesystem Perf-O-Meter

by Mathias Kettner

Module: check_mk Branch: master Commit: 6fdbc62cafa4ce4af8fd7568ae7c7376db6115cb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6fdbc62cafa4ce… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Feb 2 06:49:17 2015 +0100 First experimental implementation of filesystem Perf-O-Meter --- web/htdocs/lib.py | 54 +++++++++++++++ web/htdocs/metrics.py | 95 +++++++++++++++++++++++--- web/plugins/metrics/check_mk.py | 143 +++++++++++++++++++++++++-------------- web/plugins/views/perfometer.py | 75 ++++---------------- 4 files changed, 244 insertions(+), 123 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=6fdbc62caf…

9 years, 4 months

Check_MK Git: check_mk: Converted a few further Perf-O-Meters to new metrics style

by Mathias Kettner

Module: check_mk Branch: master Commit: 15a1e1ba828e7e46fc20eb15f8674972d11d6bad URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=15a1e1ba828e7e… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Feb 2 07:21:10 2015 +0100 Converted a few further Perf-O-Meters to new metrics style --- web/htdocs/lib.py | 18 ++- web/htdocs/metrics.py | 4 +- web/plugins/metrics/check_mk.py | 54 +++++++- web/plugins/perfometer/check_mk.py | 256 +++++++++++++++++++----------------- web/plugins/views/perfometer.py | 5 +- 5 files changed, 200 insertions(+), 137 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=15a1e1ba82…

9 years, 4 months

Check_MK Git: check_mk: Updated comment in code

by Mathias Kettner

Module: check_mk Branch: master Commit: 981d2b1d888352693f5de7d51fd888760b1ce776 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=981d2b1d888352… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Feb 2 10:42:30 2015 +0100 Updated comment in code --- web/htdocs/metrics.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/metrics.py b/web/htdocs/metrics.py index 5376571..35d8352 100644 --- a/web/htdocs/metrics.py +++ b/web/htdocs/metrics.py @@ -48,7 +48,7 @@ def load_plugins(): # into floating point numbers, do scaling if neccessary. # Simple example for perf_data: [(u'temp', u'48', u'', u'70', u'80', u'', u'')] # Result for this example: -# { "temp" : "value" : 48.0, "warn" : 70.0, "crit" : 80.0 } +# { "temp" : "value" : 48.0, "warn" : 70.0, "crit" : 80.0, "unit" : { ... } } def translate_metrics(check_command, perf_data): if check_command not in check_metrics: return None

9 years, 4 months

Check_MK Git: check_mk: Removed debug code

by Mathias Kettner

Module: check_mk Branch: master Commit: c66d66b6c1443df8aa8dcfdd7f14d8ebd46fc77d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c66d66b6c1443d… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Feb 3 11:44:03 2015 +0100 Removed debug code --- web/plugins/views/perfometer.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/web/plugins/views/perfometer.py b/web/plugins/views/perfometer.py index 133df90..c072711 100644 --- a/web/plugins/views/perfometer.py +++ b/web/plugins/views/perfometer.py @@ -149,7 +149,8 @@ def paint_perfometer(row): return "", "" title, h = perf_painter(row, check_command, perf_data) - title = '{ ' + title + ' }' # TODO: Remove this + # Test code for optically detecting old-style Perf-O-Meters + # title = '{ ' + title + ' }' except Exception, e: if config.debug:

9 years, 4 months

Check_MK Git: check_mk: Minor code cleanup

by Mathias Kettner

Module: check_mk Branch: master Commit: 3320d106072e0e9195a47c9bfc93ef44b5c3e080 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3320d106072e0e… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Feb 2 10:42:45 2015 +0100 Minor code cleanup --- web/plugins/metrics/check_mk.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/web/plugins/metrics/check_mk.py b/web/plugins/metrics/check_mk.py index e0e27e8..338e90f 100644 --- a/web/plugins/metrics/check_mk.py +++ b/web/plugins/metrics/check_mk.py @@ -90,7 +90,7 @@ unit_info["c"] = { metric_info["execution_time"] = { "title" : _("Execution time"), - "unit" : "s", + "unit" : "s", "color" : "#22dd33", } @@ -268,4 +268,4 @@ perfometer_info.append(("logarithmic", ( "pgmajfault", 1000.0, 2.0))) perfometer_info.append(("logarithmic", ( "proc_creat", 1000.0, 2.0))) perfometer_info.append(("logarithmic", ( "threads", 400.0, 2.0))) perfometer_info.append(("stacked", ( [ "user", "system", "io_wait" ], 100.0))) -perfometer_info.append(("stacked", ( [ "fs_used(%)" ], 100.0 ))), +perfometer_info.append(("stacked", ( [ "fs_used(%)" ], 100.0 )))

9 years, 4 months

Check_MK Git: check_mk: Dymamic creation of PNP templates works prototypically

by Mathias Kettner

Module: check_mk Branch: master Commit: 5cf466eba576da7c73199ee66280aadcc1b98abf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5cf466eba576da… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Tue Feb 3 11:42:37 2015 +0100 Dymamic creation of PNP templates works prototypically --- pnp-templates/.f12 | 2 +- pnp-templates/check_mk-df.php | 179 --------------------------------- pnp-templates/default.php | 125 +++++++++++++++++++++++ scripts/setup.sh | 8 ++ web/htdocs/index.py | 24 ++--- web/htdocs/lib.py | 4 + web/htdocs/metrics.py | 207 ++++++++++++++++++++++++++++++++++++--- web/plugins/metrics/check_mk.py | 53 ++++++++-- web/plugins/pages/cron.py | 2 +- web/plugins/pages/metrics.py | 2 +- web/plugins/pages/wato.py | 2 +- web/plugins/views/perfometer.py | 43 +------- 12 files changed, 396 insertions(+), 255 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=5cf466eba5…

9 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits February 2015