Checkmk git commits January 2015

checkmk-commits@lists.checkmk.com

8 participants
297 discussions

Check_MK Git: check_mk: Updated bug entries #2292

by Goetz Golla

Module: check_mk Branch: master Commit: 0c264758cbc02e7800fb21ad07d9b5c5757d5f30 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=0c264758cbc02e… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Thu Jan 29 19:37:38 2015 +0100 Updated bug entries #2292 --- .bugs/2292 | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.bugs/2292 b/.bugs/2292 new file mode 100644 index 0000000..372d125 --- /dev/null +++ b/.bugs/2292 @@ -0,0 +1,17 @@ +Title: omd_status agent section disappears when omd status has RC != 0 +Component: checks +State: open +Date: 2015-01-29 19:31:35 +Targetversion: 1.2.5i1 +Class: bug + +check_mk_agent calls + +run_cached 60 "omd status --bare --auto" + +to get the status of all omd site in mode AUTOSTART = on. + +If a site is not running, "omd status" gives a return code of 2. + +run_cached cannot handle this, and no longer produces any results, so that +the omd_status section disappears from the agent output.

9 years, 7 months

Check_MK Git: check_mk: Reserved 10 bug IDS

by Goetz Golla

Module: check_mk Branch: master Commit: b089caa9b0c8ca6a812c52e16af54f1e3ef40e2b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b089caa9b0c8ca… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Thu Jan 29 19:31:19 2015 +0100 Reserved 10 bug IDS --- .bugs/first_free | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.bugs/first_free b/.bugs/first_free index fa6d7f0..122d34e 100644 --- a/.bugs/first_free +++ b/.bugs/first_free @@ -1 +1 @@ -2292 +2302

9 years, 7 months

Check_MK Git: check_mk: z_os: Added missing agent wrapper

by Bastian Kuhn

Module: check_mk Branch: master Commit: 6b985f3006e9c32989d9e64085da104ed9adfafb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=6b985f3006e9c3… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Jan 29 17:18:16 2015 +0100 z_os: Added missing agent wrapper --- agents/z_os/check_mk_agent_wrapper | 1 + 1 file changed, 1 insertion(+) diff --git a/agents/z_os/check_mk_agent_wrapper b/agents/z_os/check_mk_agent_wrapper new file mode 100644 index 0000000..b39eb51 --- /dev/null +++ b/agents/z_os/check_mk_agent_wrapper @@ -0,0 +1 @@ +{Zaa¢@@@@@@@@@@@@{§@ònP`{§£§£@mÅÄÃmÁÄÄmÅÙÙÕÖò~ñ§£@×ÁãÈ~a¢£@`@€£@[M@[ð]aK@Kamm£@O@¥@`ÉÂÔñðô÷@`£äãÆø@O@£@@@@@@@@@@ \ No newline at end of file

9 years, 7 months

Check_MK Git: check_mk: jolokia_metrics: Minor fix in itemname

by Bastian Kuhn

Module: check_mk Branch: master Commit: b946ded33a59fc68a1413184fda95be1cca51e61 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b946ded33a59fc… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Jan 29 15:37:48 2015 +0100 jolokia_metrics: Minor fix in itemname --- checks/jolokia_metrics | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/jolokia_metrics b/checks/jolokia_metrics index 3485144..d568a71 100644 --- a/checks/jolokia_metrics +++ b/checks/jolokia_metrics @@ -70,7 +70,7 @@ def jolokia_metrics_parse(info): continue inst = part1[0] part2 = part1[1].split(',type=') - tp = part2[0] + tp = part2[0].replace('"','') elif len(parts) == 3: inst, app, servlet = parts else:

9 years, 7 months

Check_MK Git: check_mk: df_zos: fixed exception newly introduced check

by Andreas Boesl

Module: check_mk Branch: master Commit: d97a386132c5103b810996989e79a9770389cb55 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d97a386132c510… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Thu Jan 29 15:26:22 2015 +0100 df_zos: fixed exception newly introduced check --- checks/df_zos | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/checks/df_zos b/checks/df_zos index e66a6ed..0ee26ee 100644 --- a/checks/df_zos +++ b/checks/df_zos @@ -77,7 +77,7 @@ def check_df_zos(item, params, info): for fs, size, used, avail, used_perc, mount_point, fs_type, fs_state in info_convert: size_mb = float(size) / 1024 avail_mb = float(avail) / 1024 - fslist.append((mount_point, size_mb, avail_mb)) + fslist.append((mount_point, size_mb, avail_mb, 0)) return df_check_filesystem_list(item, params, fslist) check_info['df_zos'] = {

9 years, 7 months

Check_MK Git: check_mk: Added missing manpage for df_zos

by Bastian Kuhn

Module: check_mk Branch: master Commit: b93ef8c744b5499256d680767e1c140267a35ac1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b93ef8c744b549… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Jan 29 15:02:13 2015 +0100 Added missing manpage for df_zos --- checkman/df_zos | 25 +++++++++++++++++++++++++ modules/catalog.py | 1 + 2 files changed, 26 insertions(+) diff --git a/checkman/df_zos b/checkman/df_zos new file mode 100644 index 0000000..60a504b --- /dev/null +++ b/checkman/df_zos @@ -0,0 +1,25 @@ +title: zOS Mainframes: Used Space in Filesystems +agents: z_os +catalog: os/storage +license: GPL +distribution: check_mk +description: + This check monitors the filesystem usage on IBM zOS Mainframes. + + The check makes use of the general check framework of the {df} check. Please + refer to the man page of the {df} check for the detailed description of + the check and its numerous features. + +inventory: + All filesystems found will be inventorized except mount points listed + in {inventory_df_exclude_mountpoints} and filesystems with zero size. + +item: + The mount point of the filesystem + +perfdata: + See the man page of the {df} check + +[parameters] +parameters (dict): See the man page of the {df} check + diff --git a/modules/catalog.py b/modules/catalog.py index b67f46a..8db56f1 100644 --- a/modules/catalog.py +++ b/modules/catalog.py @@ -120,6 +120,7 @@ manpage_catalog_titles = { "solaris" : "Solaris", "vsphere" : "VMWare ESX (via vSphere)", "windows" : "Microsoft Windows", + "z_os" : "IBM zOS Mainframes", "hardware" : "Hardware Sensors", "kernel" : "CPU, Memory and Kernel Performance",

9 years, 7 months

Check_MK Git: check_mk: Fixed some English texsts

by Mathias Kettner

Module: check_mk Branch: master Commit: acb87e2b53dbdf738a5fece4509f8823974b08bd URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=acb87e2b53dbdf… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Jan 29 13:37:04 2015 +0100 Fixed some English texsts Conflicts: web/plugins/wato/check_parameters.py --- web/plugins/wato/check_mk_configuration.py | 2 +- web/plugins/wato/check_parameters.py | 6 +++--- web/plugins/wato/inventory.py | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py index 9c3cdca..ce8c924 100644 --- a/web/plugins/wato/check_mk_configuration.py +++ b/web/plugins/wato/check_mk_configuration.py @@ -1103,7 +1103,7 @@ register_configvar(group, ( "zfsget", _("Used space in ZFS pools and filesystems")), ( "ps", _("State and Count of Processes") ), ( "ps.perf", _("State and Count of Processes (with additional performance data)")), - ( "wmic_process", _("Ressource consumption of windows processes")), + ( "wmic_process", _("Resource consumption of windows processes")), ( "logwatch", _("Check logfiles for relevant new messages")), ( "cmk-inventory", _("Monitor hosts for unchecked services (Check_MK Discovery)")), ( "hyperv_vms", _("Hyper-V Server: State of VMs")), diff --git a/web/plugins/wato/check_parameters.py b/web/plugins/wato/check_parameters.py index 13ce361..b2d33fd 100644 --- a/web/plugins/wato/check_parameters.py +++ b/web/plugins/wato/check_parameters.py @@ -4766,9 +4766,9 @@ register_rule(group + '/' + subgroup_networking, register_rule(group + '/' + subgroup_inventory, varname = "winperf_msx_queues_inventory", title = _('MS Exchange Message Queues Inventory'), - help = _('Per default all Counters a preconfigured in the check. ' - 'It needed it is possible to overwrite that with this rule. ' - 'To do that, knowledge about the Agent Output is needed. '), + help = _('Per default the offsets of all Windows performance counters are preconfigured in the check. ' + 'If the format of your counters object is not compatible then you can adapt the counter ' + 'offsets manually.'), valuespec = ListOf( Tuple( orientation = "horizontal", diff --git a/web/plugins/wato/inventory.py b/web/plugins/wato/inventory.py index a56afe1..da14ca6 100644 --- a/web/plugins/wato/inventory.py +++ b/web/plugins/wato/inventory.py @@ -70,7 +70,7 @@ register_rule(group, title = _("Export file to create, containing <tt><HOST></tt> for the hostname"), help = _("Please specify the path to the export file. The text <tt><HOST></tt> " "will be replaced with the host name the inventory has been done for. " - "If you use a relative path then that will be replative to Check_MK's directory " + "If you use a relative path then that will be relative to Check_MK's directory " "for variable data, which is <tt>%s</tt>.") % defaults.var_dir, allow_empty = False, size = 64,

9 years, 7 months

Check_MK Git: check_mk: websphere_mq_channels: Check now handles sopped state as warning instead of critical

by Bastian Kuhn

Module: check_mk Branch: master Commit: 45c52c546d293f40696bde1358265521dc442238 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=45c52c546d293f… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Thu Jan 29 12:31:24 2015 +0100 websphere_mq_channels: Check now handles sopped state as warning instead of critical --- checks/websphere_mq_channels | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/checks/websphere_mq_channels b/checks/websphere_mq_channels index 87667fc..ed51dca 100644 --- a/checks/websphere_mq_channels +++ b/checks/websphere_mq_channels @@ -56,7 +56,10 @@ def check_websphere_mq_channels(item, params, info): message += "(!)" message += ", Channel State: %s" % status - if status not in [ 'RUNNING' ]: + if status == 'STOPPED': + state = 1 + message += "(!)" + elif status not in [ 'RUNNING' ]: state = 2 message += "(!!)" perf = [ ('messages', messages, warn, crit, 0, max_messages) ]

9 years, 7 months

Check_MK Git: check_mk: kentix_temp, lnx_thermal: Fixed formatting error in manpage

by Konstantin Büttner

Module: check_mk Branch: master Commit: a7374687838cbfa823dc8a333200329b15904fc9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a7374687838cbf… Author: Konstantin Büttner <kb(a)mathias-kettner.de> Date: Thu Jan 29 11:27:21 2015 +0100 kentix_temp, lnx_thermal: Fixed formatting error in manpage --- checkman/kentix_temp | 2 +- checkman/lnx_thermal | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/checkman/kentix_temp b/checkman/kentix_temp index 8d8a308..faca9af 100644 --- a/checkman/kentix_temp +++ b/checkman/kentix_temp @@ -31,7 +31,7 @@ according to the unit sent by the device. This key allows to override that. Trea lightly, as this may lead to a misinterpreted temperature. Should only be used if the device reports its unit incorrectly. - {"device_levels_handling"]: How the check treats the device's internal levels + {"device_levels_handling"}: How the check treats the device's internal levels versus the ones you specify yourself. The following options are supported: "best" results in the best status between yours and the device's levels, "worst" in the worst, "usr" ignore's the device's levels, "dev" ignores yours, usrdefault and diff --git a/checkman/lnx_thermal b/checkman/lnx_thermal index 390f013..6b4a1c1 100644 --- a/checkman/lnx_thermal +++ b/checkman/lnx_thermal @@ -32,7 +32,7 @@ according to the unit sent by the device. This key allows to override that. Trea lightly, as this may lead to a misinterpreted temperature. Should only be used if the device reports its unit incorrectly. - {"device_levels_handling"]: How the check treats the device's internal levels + {"device_levels_handling"}: How the check treats the device's internal levels versus the ones you specify yourself. The following options are supported: "best" results in the best status between yours and the device's levels, "worst" in the worst, "usr" ignore's the device's levels, "dev" ignores yours, usrdefault and

9 years, 7 months

Check_MK Git: check_mk: Removed several ugly } elses

by Mathias Kettner

Module: check_mk Branch: master Commit: b0e4d47fb32f5f57b0c537a1b0c196a6fe7b65e0 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=b0e4d47fb32f5f… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Jan 29 10:47:45 2015 +0100 Removed several ugly } elses --- agents/windows/check_mk_agent.cc | 30 ++++++++++++++++++++---------- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/agents/windows/check_mk_agent.cc b/agents/windows/check_mk_agent.cc index f1a89ff..7ef9b17 100755 --- a/agents/windows/check_mk_agent.cc +++ b/agents/windows/check_mk_agent.cc @@ -852,7 +852,8 @@ void dump_performance_counters(SOCKET &out, unsigned counter_base_number, const verbose("Buffer for RegQueryValueEx too small. Resizing..."); delete [] data; data = new BYTE [size]; - } else { + } + else { // Es ist ein anderer Fehler aufgetreten. Abbrechen. delete [] data; return; @@ -1554,7 +1555,8 @@ process_entry_t get_process_perfdata() size += DEFAULT_BUFFER_SIZE; delete [] data; data = new BYTE [size]; - } else { + } + else { // Es ist ein anderer Fehler aufgetreten. Abbrechen. delete [] data; return process_info; @@ -2028,7 +2030,8 @@ void update_or_create_logwatch_textfile(const char *full_filename, glob_token* t verbose(" to %s\n", llu_to_string(file_id)); textfile->offset = 0; textfile->file_id = file_id; - } else if (textfile->file_size < textfile->offset) { // file has been truncated + } + else if (textfile->file_size < textfile->offset) { // file has been truncated verbose("File %s: file has been truncated\n", full_filename); textfile->offset = 0; } @@ -2036,7 +2039,8 @@ void update_or_create_logwatch_textfile(const char *full_filename, glob_token* t textfile->missing = false; } CloseHandle(hFile); - } else { + } + else { verbose("Cant open file with CreateFile %s\n", full_filename); } } @@ -2147,7 +2151,8 @@ void cleanup_logwatch_textfiles() // remove this file from the list free((*it_tf)->path); it_tf = g_logwatch_textfiles.erase(it_tf); - } else + } + else it_tf++; } } @@ -2649,7 +2654,8 @@ bool handle_script_config_variable(char *var, char *value, script_type type) cache_configs_plugin.push_back(entry); else cache_configs_local.push_back(entry); - } else if (!strncmp(var, "retry_count ", 12)) { + } + else if (!strncmp(var, "retry_count ", 12)) { char *plugin_pattern = lstrip(var + 12); retry_config *entry = new retry_config(); entry->pattern = strdup(plugin_pattern); @@ -2658,7 +2664,8 @@ bool handle_script_config_variable(char *var, char *value, script_type type) retry_configs_plugin.push_back(entry); else retry_configs_local.push_back(entry); - } else if (!strncmp(var, "execution ", 10)) { + } + else if (!strncmp(var, "execution ", 10)) { char *plugin_pattern = lstrip(var + 10); execution_mode_config *entry = new execution_mode_config(); entry->pattern = strdup(plugin_pattern); @@ -2667,7 +2674,8 @@ bool handle_script_config_variable(char *var, char *value, script_type type) execution_mode_configs_plugin.push_back(entry); else execution_mode_configs_local.push_back(entry); - } else if (!strncmp(var, "include", 7)) { + } + else if (!strncmp(var, "include", 7)) { char *user = NULL; if (strlen(var) > 7) user = lstrip(var + 7); @@ -3034,7 +3042,8 @@ void output_external_programs(SOCKET &out, script_type type) cont->buffer = cont->buffer_work; cont->buffer_work = NULL; cont->status = SCRIPT_IDLE; - } else if (cont->retry_count < 0 && cont->buffer != NULL) { + } + else if (cont->retry_count < 0 && cont->buffer != NULL) { // Remove outdated cache entries HeapFree(GetProcessHeap(), 0, cont->buffer); cont->buffer = NULL; @@ -4401,7 +4410,8 @@ void listen_tcp_loop() ip = remote_addr.sin_addr.s_addr; snprintf(ip_hr, sizeof(ip_hr), "%u.%u.%u.%u", ip & 0xff, (ip >> 8) & 0xff, (ip >> 16) & 0xff, (ip >> 24) & 0xff); - } else + } + else snprintf(ip_hr, sizeof(ip_hr), "None"); if (check_only_from(ip)) { open_crash_log();

9 years, 7 months

← Newer
1
2
3
4
5
6
7
8
9
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2015