Checkmk git commits January 2015

checkmk-commits@lists.checkmk.com

8 participants
297 discussions

Check_MK Git: check_mk: Updated bug entries #2293

by Goetz Golla

Module: check_mk Branch: master Commit: 91ce8a8303fec88bc5e097f700796f23a81b423e URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=91ce8a8303fec8… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Fri Jan 30 10:09:24 2015 +0100 Updated bug entries #2293 --- .bugs/2293 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.bugs/2293 b/.bugs/2293 index ae72053..20c5692 100644 --- a/.bugs/2293 +++ b/.bugs/2293 @@ -1,9 +1,9 @@ Title: datasource and service discovery check Component: checks -State: open +Class: bug +State: closed Date: 2015-01-30 09:10:34 Targetversion: 1.2.5i1 -Class: bug When selecting a different datasource for a host (a shell script), the service discovery check for the host complains about a missing snmp_info @@ -13,3 +13,7 @@ and snmp_uptime service, even thought the host is not configured to use snmp In the cache directory of the host, there are two files <hostname>.snmp_info and <hostname>.snmp_uptime, They contain empty lists. Doing a tabula rasa service discovery gives us the two additional services with empty check output. + +2015-01-30 10:09:20: changed state open -> closed +solved, was a configuration issue with a tag group +at the customer

9 years, 7 months

Check_MK Git: check_mk: esx_vsphere_objects.count:

by Bastian Kuhn

re-implantation of previously removed Message-ID: <54cb49e2.ixh7cG+G7iOpy4NZ%bk(a)mathias-kettner.de> User-Agent: Heirloom mailx 12.5 6/20/10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: cf463f31eaac2d850cb7c9ae7c3d930136b8404f URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cf463f31eaac2d… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Fri Jan 30 09:58:37 2015 +0100 esx_vsphere_objects.count: re-implantation of previously removed --- checkman/esx_vsphere_objects.count | 16 ++++++++++++++++ checks/esx_vsphere_objects | 25 +++++++++++++++++++++++++ 2 files changed, 41 insertions(+) diff --git a/checkman/esx_vsphere_objects.count b/checkman/esx_vsphere_objects.count new file mode 100644 index 0000000..7784bb3 --- /dev/null +++ b/checkman/esx_vsphere_objects.count @@ -0,0 +1,16 @@ +title: VMWare ESX: Number of Virtualmachnies and Hostssystems +agents: vsphere +catalog: os/misc +license: GPL +distribution: check_mk +description: + This Check only counts the nubmer of Virtualmachines on a Hostsystem, or the number of + Virtualmachines and Hostsystems on a vCenter. + It's always {OK} + +inventory: + One service will be created + +perfdata: + One graph for vms and one for hosts + diff --git a/checks/esx_vsphere_objects b/checks/esx_vsphere_objects index 8dfba7a..d53f777 100644 --- a/checks/esx_vsphere_objects +++ b/checks/esx_vsphere_objects @@ -110,6 +110,31 @@ check_info['esx_vsphere_objects'] = { "group" : "esx_vsphere_objects", } +def inventory_esx_vsphere_objects_count(info): + return [(None, None)] + +def check_esx_vsphere_objects_count(_no_item, _no_params, info): + virtualmachines = 0 + hostsystems = 0 + for line in info: + if line[0] == 'hostsystem': + hostsystems += 1 + elif line[0] == 'virtualmachine': + virtualmachines += 1 + messages = "Virtualmachines: %d" % virtualmachines + perfdata = [('vms', virtualmachines)] + if hostsystems > 1: + messages += ", Hostsystems: %d" % hostsystems + perfdata.append(('hosts', hostsystems)) + return 0, messages, perfdata + + +check_info['esx_vsphere_objects.count'] = { + "inventory_function" : inventory_esx_vsphere_objects_count, + "check_function" : check_esx_vsphere_objects_count, + "service_description" : "Object count", + "has_perfdata" : True, +} # .--Cluster-------------------------------------------------------------. # | ____ _ _ | # | / ___| |_ _ ___| |_ ___ _ __ |

9 years, 7 months

Check_MK Git: check_mk: Updated bug entries #2293

by Lars Michelsen

Module: check_mk Branch: master Commit: 593b93f3f10c4d8b67bb0b2ae535f5685b885125 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=593b93f3f10c4d… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 30 09:56:59 2015 +0100 Updated bug entries #2293 --- .bugs/2293 | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/.bugs/2293 b/.bugs/2293 index ae72053..183765a 100644 --- a/.bugs/2293 +++ b/.bugs/2293 @@ -1,9 +1,9 @@ Title: datasource and service discovery check Component: checks -State: open +Class: bug +State: works4me Date: 2015-01-30 09:10:34 Targetversion: 1.2.5i1 -Class: bug When selecting a different datasource for a host (a shell script), the service discovery check for the host complains about a missing snmp_info @@ -13,3 +13,9 @@ and snmp_uptime service, even thought the host is not configured to use snmp In the cache directory of the host, there are two files <hostname>.snmp_info and <hostname>.snmp_uptime, They contain empty lists. Doing a tabula rasa service discovery gives us the two additional services with empty check output. + +2015-01-30 09:56:56: changed state open -> works4me +Tried to reproduce with current 1.2.6 code with both, nagios and cmc, but was +unable to reproduce the problem. Please re-check configuration, is the +host really not configured to use SNMP? cmk -D [hostname]. Does it really +use the datasource program?

9 years, 7 months

Check_MK Git: check_mk: Updated bug entries #2292

by Lars Michelsen

Module: check_mk Branch: master Commit: 3aa81b71cc3b27d9d90101db5668ebd7dc4799c5 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=3aa81b71cc3b27… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 30 09:38:25 2015 +0100 Updated bug entries #2292 --- .bugs/2292 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/2292 b/.bugs/2292 index 372d125..8dff222 100644 --- a/.bugs/2292 +++ b/.bugs/2292 @@ -1,9 +1,9 @@ Title: omd_status agent section disappears when omd status has RC != 0 Component: checks -State: open +Class: bug +State: done Date: 2015-01-29 19:31:35 Targetversion: 1.2.5i1 -Class: bug check_mk_agent calls @@ -15,3 +15,6 @@ If a site is not running, "omd status" gives a return code of 2. run_cached cannot handle this, and no longer produces any results, so that the omd_status section disappears from the agent output. + +2015-01-30 09:29:42: changed state open -> done +Fixed.

9 years, 7 months

Check_MK Git: check_mk: #1882 FIX Fixed exception "filesystem_levels" not defined when compiling config for nagios

by Lars Michelsen

Module: check_mk Branch: master Commit: 9ce270e616cee7f095009fc14c9ce9f2904fae6d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=9ce270e616cee7… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 30 09:45:30 2015 +0100 #1882 FIX Fixed exception "filesystem_levels" not defined when compiling config for nagios --- .werks/1882 | 10 ++++++++++ ChangeLog | 1 + modules/check_mk.py | 6 ------ 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/.werks/1882 b/.werks/1882 new file mode 100644 index 0000000..a823be3 --- /dev/null +++ b/.werks/1882 @@ -0,0 +1,10 @@ +Title: Fixed exception "filesystem_levels" not defined when compiling config for nagios +Level: 1 +Component: core +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i1 +Date: 1422607495 + + diff --git a/ChangeLog b/ChangeLog index 6519cb6..ee3ea26 100644 --- a/ChangeLog +++ b/ChangeLog @@ -10,6 +10,7 @@ * 1869 FIX: Deleting outdated persisted agent sections now * 1919 FIX: cmk --snmpwalk: continue if one of the OIDs to walk fails * 1880 FIX: inventory_processes rules can now be configured without setting levels... + * 1882 FIX: Fixed exception "filesystem_levels" not defined when compiling config for nagios Checks & Agents: * 1665 agent_netapp: New special agent for NetApp monitoring via Web-API... diff --git a/modules/check_mk.py b/modules/check_mk.py index 08a4295..9743053 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -1796,12 +1796,6 @@ def create_nagios_config(outfile = sys.stdout, hostnames = None): extra_service_conf["_SERVICE_PERIOD"] = extra_service_conf["service_period"] del extra_service_conf["service_period"] - if filesystem_levels != []: - raise MKGeneralException("filesystem_levels is not longer supported.\n" - "Please use check_parameters instead.\n" - "Please refer to documentation:\n" - " --> http://mathias-kettner.de/checkmk_check_parameters.html\n") - output_conf_header(outfile) if hostnames == None: hostnames = all_hosts_untagged + all_active_clusters()

9 years, 7 months

Check_MK Git: check_mk: #1922 FIX Fix exception in saving of hosttags if hosttag has at least one auxiliary tag

by Mathias Kettner

Module: check_mk Branch: master Commit: c0e29f13e798e15d0ee33b0d9dca68547417c812 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c0e29f13e798e1… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Jan 30 09:36:02 2015 +0100 #1922 FIX Fix exception in saving of hosttags if hosttag has at least one auxiliary tag --- .werks/1922 | 10 ++++++++++ ChangeLog | 1 + web/htdocs/wato.py | 4 ++-- 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/.werks/1922 b/.werks/1922 new file mode 100644 index 0000000..225d696 --- /dev/null +++ b/.werks/1922 @@ -0,0 +1,10 @@ +Title: Fix exception in saving of hosttags if hosttag has at least one auxiliary tag +Level: 2 +Component: wato +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i1 +Date: 1422606938 + + diff --git a/ChangeLog b/ChangeLog index e3f5ea9..6519cb6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -166,6 +166,7 @@ * 1212 FIX: Fixed default value in wato parameter page for timeperiods... * 1816 FIX: Fixed garbled output on "rename host" result page * 1879 FIX: Not showing "only show permitted hosts/services" option for users not having "see all" permissions... + * 1922 FIX: Fix exception in saving of hosttags if hosttag has at least one auxiliary tag Notifications: * 1662 notification plugin spectrum: finalized script. now able to handle host notications diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index f97e830..7c74f62 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -13297,8 +13297,8 @@ def export_hosttags(hosttags, auxtags): hosttags_dict = {} for id, title, choices in hosttags: tags = {} - for tag_id, tag_title, auxtags in choices: - tags[tag_id] = tag_title, auxtags + for tag_id, tag_title, tag_auxtags in choices: + tags[tag_id] = tag_title, tag_auxtags topic, title = parse_hosttag_title(title) hosttags_dict[id] = topic, title, tags auxtags_dict = dict(auxtags)

9 years, 7 months

Check_MK Git: check_mk: Updated bug entries #2293

by Goetz Golla

Module: check_mk Branch: master Commit: 79884fdda832797157b9a83ef677da95f0b8598b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=79884fdda83279… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Fri Jan 30 09:35:15 2015 +0100 Updated bug entries #2293 --- .bugs/2293 | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.bugs/2293 b/.bugs/2293 index 29b928e..ae72053 100644 --- a/.bugs/2293 +++ b/.bugs/2293 @@ -5,7 +5,11 @@ Date: 2015-01-30 09:10:34 Targetversion: 1.2.5i1 Class: bug -When selecting a different datasource for a host, the service discovery check -for the host complains about a missing snmp_info service, even thought the host -is not configured to use snmp (but check_mk_agent with a different datasource). -Version is 1.2.6b7. Doing a service discovery doesnt help. +When selecting a different datasource for a host (a shell script), the +service discovery check for the host complains about a missing snmp_info +and snmp_uptime service, even thought the host is not configured to use snmp +(but check_mk_agent with a different datasource). Version is 1.2.6b7. + +In the cache directory of the host, there are two files <hostname>.snmp_info +and <hostname>.snmp_uptime, They contain empty lists. Doing a tabula rasa +service discovery gives us the two additional services with empty check output.

9 years, 7 months

Check_MK Git: check_mk: #1881 FIX omd_status: Check works now event when a site is reported as not OK

by Lars Michelsen

Module: check_mk Branch: master Commit: cb80e8eeb9b0947694a036471f359ab804631617 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=cb80e8eeb9b094… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Jan 30 09:29:15 2015 +0100 #1881 FIX omd_status: Check works now event when a site is reported as not OK The check resulted in state UNKNOWN because the agent section was missing when at least one site had a problem. --- .werks/1881 | 11 +++++++++++ ChangeLog | 1 + agents/check_mk_agent.linux | 3 ++- 3 files changed, 14 insertions(+), 1 deletion(-) diff --git a/.werks/1881 b/.werks/1881 new file mode 100644 index 0000000..e634fc3 --- /dev/null +++ b/.werks/1881 @@ -0,0 +1,11 @@ +Title: omd_status: Check works now event when a site is reported as not OK +Level: 1 +Component: checks +Class: fix +Compatible: compat +State: unknown +Version: 1.2.7i1 +Date: 1422606490 + +The check resulted in state UNKNOWN because the agent section was missing +when at least one site had a problem. diff --git a/ChangeLog b/ChangeLog index 6f80e71..e3f5ea9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -119,6 +119,7 @@ * 1877 FIX: printer_input/printer_output: Check can now handle non reported capacity unit * 1921 FIX: kemp_loadmaster_realserver: reimplementation, now use vendor specific information * 1859 FIX: cups_queues: linux agent now runs section cups_queues in cached mode... + * 1881 FIX: omd_status: Check works now event when a site is reported as not OK... Multisite: * 1758 Improved exception hander: Shows details without additional debug request, added mailto link for error report... diff --git a/agents/check_mk_agent.linux b/agents/check_mk_agent.linux index 6a35472..a067ed7 100755 --- a/agents/check_mk_agent.linux +++ b/agents/check_mk_agent.linux @@ -101,6 +101,7 @@ function run_cached () { # Cache file outdated and new job not yet running? Start it if [ -z "$USE_CACHEFILE" -a ! -e "$CACHEFILE.new" ] ; then + # When the command fails, the output is throws away ignored echo "set -o noclobber ; exec > \"$CACHEFILE.new\" || exit 1 ; $CMDLINE && mv \"$CACHEFILE.new\" \"$CACHEFILE\" || rm -f \"$CACHEFILE\" \"$CACHEFILE.new\"" | nohup bash >/dev/null 2>&1 & fi } @@ -513,7 +514,7 @@ fi # Check status of OMD sites if type omd >/dev/null then - run_cached -s omd_status 60 "omd status --bare --auto" + run_cached -s omd_status 60 "omd status --bare --auto || true" fi

9 years, 7 months

Check_MK Git: check_mk: Updated bug entries #2293

by Goetz Golla

Module: check_mk Branch: master Commit: c0a18786904bd3ed9226f4d7d67e2ef6fa9871e9 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c0a18786904bd3… Author: Goetz Golla <gg(a)mathias-kettner.de> Date: Fri Jan 30 09:16:01 2015 +0100 Updated bug entries #2293 --- .bugs/2293 | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.bugs/2293 b/.bugs/2293 new file mode 100644 index 0000000..29b928e --- /dev/null +++ b/.bugs/2293 @@ -0,0 +1,11 @@ +Title: datasource and service discovery check +Component: checks +State: open +Date: 2015-01-30 09:10:34 +Targetversion: 1.2.5i1 +Class: bug + +When selecting a different datasource for a host, the service discovery check +for the host complains about a missing snmp_info service, even thought the host +is not configured to use snmp (but check_mk_agent with a different datasource). +Version is 1.2.6b7. Doing a service discovery doesnt help.

9 years, 7 months

Check_MK Git: check_mk: Edited werk wording

by Bastian Kuhn

Module: check_mk Branch: master Commit: deba22e2cfcc7cb7f22b8c443efebea10428f59c URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=deba22e2cfcc7c… Author: Bastian Kuhn <bk(a)mathias-kettner.de> Date: Fri Jan 30 08:58:52 2015 +0100 Edited werk wording --- .werks/1217 | 4 ++-- ChangeLog | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.werks/1217 b/.werks/1217 index 81d4b3f..f9f219e 100644 --- a/.werks/1217 +++ b/.werks/1217 @@ -1,4 +1,4 @@ -Title: dell_om_sensors: Check now uses generic temperature template +Title: dell_om_sensors: Check now uses generic temperature features Level: 1 Component: checks Compatible: incomp @@ -7,5 +7,5 @@ Date: 1422451362 Class: feature The Check now uses the Wato Temperature Rule who provides more configuration options. -If you used the Wato Room Temeperature Rule before you have to migrate the levels. +If you used the Wato Room Temeperature Rule before, you have to migrate the levels. diff --git a/ChangeLog b/ChangeLog index 19e7dd2..6f80e71 100644 --- a/ChangeLog +++ b/ChangeLog @@ -59,7 +59,7 @@ * 1216 hp_procurve_cpu: Can now be configured with Wato * 1676 if.include: now able to detect grouped interfaces... * 1928 netapp_api_if: Improved handling and check output of virtual interfaces... - * 1217 dell_om_sensors: Check now uses generic temperature template... + * 1217 dell_om_sensors: Check now uses generic temperature features... NOTE: Please refer to the migration notes! * 1929 netapp_api_if: improved inventory and check output of virtual interfaces... * 1218 Inital Agent Version for zOS (IBM Mainframes)...

9 years, 7 months

← Newer
1
2
3
4
5
6
7
8
...
30
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits January 2015