Checkmk git commits October 2013

checkmk-commits@lists.checkmk.com

6 participants
384 discussions

Check_MK Git: check_mk: Again, trying to prevent race conditions in auth. php generating hook

by Lars Michelsen

Module: check_mk Branch: master Commit: 2f3f9446930c2fa4bad1a811142fc0b37c46f99a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=2f3f9446930c2f… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Oct 11 14:11:41 2013 +0200 Again, trying to prevent race conditions in auth.php generating hook --- web/plugins/userdb/hook_auth.py | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/web/plugins/userdb/hook_auth.py b/web/plugins/userdb/hook_auth.py index a1c36ec..15392c6 100644 --- a/web/plugins/userdb/hook_auth.py +++ b/web/plugins/userdb/hook_auth.py @@ -90,9 +90,17 @@ def create_php_file(callee, users, role_permissions, folder_permissions): for username in users: users[username].setdefault('language', config.default_language) + # need an extra lock file, since we move the auth.php.tmp file later + # to auth.php. This move is needed for not having loaded incomplete + # files into php. + tempfile = g_auth_base_dir + '/auth.php.tmp' + lockfile = g_auth_base_dir + '/auth.php.state' + file(lockfile, "a") + aquire_lock(lockfile) + # First write a temp file and then do a move to prevent syntax errors # when reading half written files during creating that new file - file(g_auth_base_dir + '/auth.php.tmp', 'w').write('''<?php + file(tempfile, 'w').write('''<?php // Created by Multisite UserDB Hook (%s) global $mk_users, $mk_roles, $mk_folders; $mk_users = %s; @@ -186,7 +194,9 @@ function may($username, $need_permission) { ?> ''' % (callee, format_php(users), format_php(role_permissions), format_php(folder_permissions))) # Now really replace the file - os.rename(g_auth_base_dir + '/auth.php.tmp', g_auth_base_dir + '/auth.php'); + os.rename(tempfile, g_auth_base_dir + '/auth.php') + + release_lock(lockfile) def create_auth_file(callee, users): make_nagios_directory(g_auth_base_dir)

10 years, 11 months

Check_MK Git: check_mk: WATO: Fixed some input validation problems in snapshot module

by Lars Michelsen

Module: check_mk Branch: master Commit: 053b7cd7a52c0c482c5bf45f9caabb6e72738716 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=053b7cd7a52c0c… Author: Lars Michelsen <lm(a)mathias-kettner.de> Date: Fri Oct 11 11:32:42 2013 +0200 WATO: Fixed some input validation problems in snapshot module * FIX: Fixed some output encoding problem in snapshot restore / deletion code * FIX: Improved user provided variable validation in snapshot handling code Conflicts: web/htdocs/wato.py --- ChangeLog | 2 ++ web/htdocs/wato.py | 35 ++++++++++++++++++++--------------- 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/ChangeLog b/ChangeLog index 0a841b6..d5d8e10 100644 --- a/ChangeLog +++ b/ChangeLog @@ -465,6 +465,8 @@ of a distributed WATO setup * FIX: avoid Python exception for invalid parameters even in debug mode * FIX: check_ldap: Removed duplicate "-H" definition + * FIX: Fixed some output encoding problem in snapshot restore / deletion code + * FIX: Improved user provided variable validation in snapshot handling code Event Console: * FIX: apply rewriting of application/hostname also when cancelling events diff --git a/web/htdocs/wato.py b/web/htdocs/wato.py index 208afaf..14a4dc1 100644 --- a/web/htdocs/wato.py +++ b/web/htdocs/wato.py @@ -5197,19 +5197,23 @@ def mode_snapshot(phase): make_action_link([("mode", "snapshot"),("_factory_reset","Yes")]), "factoryreset") return - elif phase == "action": + snapshots = [] + if os.path.exists(snapshot_dir): + for f in os.listdir(snapshot_dir): + snapshots.append(f) + snapshots.sort(reverse=True) + + if phase == "action": if html.has_var("_download_file"): download_file = html.var("_download_file") - if not download_file.startswith('wato-snapshot') and download_file != 'latest': - raise MKUserError(None, _("Invalid download file specified.")) # Find the latest snapshot file if download_file == 'latest': - snapshots = os.listdir(snapshot_dir) - snapshots.sort() if not snapshots: return False download_file = snapshots[-1] + elif download_file not in snapshots: + raise MKUserError(None, _("Invalid download file specified.")) download_path = os.path.join(snapshot_dir, download_file) if os.path.exists(download_path): @@ -5238,9 +5242,13 @@ def mode_snapshot(phase): # delete file elif html.has_var("_delete_file"): delete_file = html.var("_delete_file") + + if delete_file not in snapshots: + raise MKUserError(None, _("Invalid file specified.")) + c = wato_confirm(_("Confirm deletion of snapshot"), _("Are you sure you want to delete the snapshot <br><br>%s?") % - delete_file + htmllib.attrencode(delete_file) ) if c: os.remove(os.path.join(snapshot_dir, delete_file)) @@ -5251,14 +5259,18 @@ def mode_snapshot(phase): # restore snapshot elif html.has_var("_restore_snapshot"): snapshot_file = html.var("_restore_snapshot") + + if snapshot_file not in snapshots: + raise MKUserError(None, _("Invalid file specified.")) + c = wato_confirm(_("Confirm restore snapshot"), _("Are you sure you want to restore the snapshot <br><br>%s ?") % - snapshot_file + htmllib.attrencode(snapshot_file) ) if c: multitar.extract_from_file(snapshot_dir + snapshot_file, backup_paths) log_pending(SYNCRESTART, None, "snapshot-restored", - _("Restored snapshot %s") % snapshot_file) + _("Restored snapshot %s") % htmllib.attrencode(snapshot_file)) return None, _("Successfully restored snapshot.") elif c == False: # not yet confirmed return "" @@ -5278,13 +5290,6 @@ def mode_snapshot(phase): return None else: - snapshots = [] - if os.path.exists(snapshot_dir): - for f in os.listdir(snapshot_dir): - snapshots.append(f) - snapshots.sort(reverse=True) - - table.begin("snapshots", _("Snapshots"), empty_text=_("There are no snapshots available.")) for name in snapshots: table.row()

10 years, 11 months

Check_MK Git: check_mk: agent_vsphere: new option --tracefile,

by Andreas Boesl

minor code cleanup and new TODOs Message-ID: <5257e16c.PqcYHeM/KZaSktGd%ab(a)mathias-kettner.de> User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: a71a1e27c7883602a030dd4a4e0ede07e9987e26 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=a71a1e27c78836… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Oct 11 13:30:49 2013 +0200 agent_vsphere: new option --tracefile, minor code cleanup and new TODOs --- ChangeLog | 1 + agents/special/agent_vsphere | 76 ++++++++++++++++++++++++------------------ 2 files changed, 44 insertions(+), 33 deletions(-) diff --git a/ChangeLog b/ChangeLog index e2a1920..7a2b1e2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -24,6 +24,7 @@ * cpu_netapp: added Perf-O-Meter and PNP template * cisco_cpu: added Perf-O-Meter and PNP template * apc_symmetra: add input voltage to informational output + * agent_vsphere: new debug option --tracefile * FIX: windows_agent: fixed bug in cleanup of open thread handles * FIX: cups default printer is now monitored again in linux agent * FIX: host notification email in html format: fixed formating error diff --git a/agents/special/agent_vsphere b/agents/special/agent_vsphere index 4580645..949bcaa 100755 --- a/agents/special/agent_vsphere +++ b/agents/special/agent_vsphere @@ -35,7 +35,7 @@ # Note: This agent is still in development -import httplib, pprint, sys, os, getopt, socket, time +import httplib, pprint, sys, os, getopt, socket, time, datetime, re #execfile("soap_commands.py", globals(), globals()) @@ -144,27 +144,30 @@ OPTIONS: subquery. --debug Debug mode: let Python exceptions come through + --tracefile FILENAME Log all outgoing and incoming data into the given tracefile -i MODULES, --modules MODULES Modules to query. This is a comma separated list of hostsystem, virtualmachine and storage. Default is to query all modules. - -c, --dump-counters Simply dumping out all available counters and their values. - This mode is meant for debugging and diagnostic purposes. """) +# TODO: implement +# -c, --dump-counters Simply dumping out all available counters and their values. +# This mode is meant for debugging and diagnostic purposes. short_options = 'hi:u:s:Dat:H:c' long_options = [ 'help', 'user=', 'secret=', 'direct', 'agent', 'debug', 'modules=', 'timeout=', 'hostname=', - 'dump-counters', + 'dump-counters', 'tracefile=', ] opt_debug = False opt_direct = False opt_agent = False -opt_dump_counters = False +opt_dump_counters = False # TODO: implement opt_timeout = 60 opt_hostname = None +opt_tracefile = None error = None error_exit = 1 @@ -172,6 +175,7 @@ error_exit = 1 host_address = None user = None secret = None +tracefile = None query_objects = [ 'hostsystem', 'virtualmachine', 'datastore', 'counters', 'required' ] try: @@ -183,6 +187,8 @@ except getopt.GetoptError, err: for o,a in opts: if o in [ '--debug' ]: opt_debug = True + elif o in [ '--tracefile' ]: + opt_tracefile = a elif o in [ '-D', '--direct' ]: opt_direct = True elif o in [ '-a', '--agent' ]: @@ -268,19 +274,26 @@ if opt_agent: results = {} -# Debugging stuff -query_duration = 0 -query_start = 0 esx_version_num = None -esx_name = "" +esx_name = "" + +if opt_tracefile: + if os.path.exists(os.path.dirname(opt_tracefile)): + tracefile = file(opt_tracefile, "w") + elif opt_debug: + sys.stderr.write("Path for tracefile %s does not exist" % opt_tracefile) + sys.stderr.flush() -import re def get_pattern(pattern, line): if not line: return [] p = re.compile(pattern) return p.findall(line) +if tracefile: + tracefile.write("Tracefile %s Host address: %s\n" % + (datetime.datetime.now().strftime("%Y-%m-%d %H:%M"), host_address)) + try: my_cookie = None netloc = host_address @@ -294,26 +307,31 @@ try: sys.stderr.write("Connecting to %s..." % host_address) sys.stderr.flush() - start = time.time() - def query_server(soapdata): handle.putrequest("POST", request_uri) handle.putheader("Content-Length", "%d" % len(soapdata)) handle.putheader("Content-Type", 'text/xml; charset="utf-8"') handle.putheader("SOAPAction", "urn:vim25/5.0") - handle.putheader("User-Agent", "VMware VI Client/5.0.0") + handle.putheader("User-Agent", "VMware VI Client/5.0.0") # TODO: set client version? if my_cookie: handle.putheader("Cookie", my_cookie) - handle.endheaders() + handle.send(soapdata) + time_sent = time.time() response = handle.getresponse() - return response.status, response.reason, response.msg, response.read() + time_response = time.time() - def get_counter_instances(): + body = response.read() + if tracefile: + tracefile.write("#### Sent ####\n%s" % soapdata) + timing_info = "Response took: %f" % (time_response - time_sent) + tracefile.write("\n#### Received #### %s\n%s" % (timing_info, body)) - import re + return response.status, response.reason, response.msg, body + + def get_counter_instances(): p = re.compile("<counterId>([0-9]*)</counterId><instance>([^<]*)") m = p.findall( results["7_query_avail_perf_metric"] ) @@ -324,10 +342,10 @@ try: return counters_avail - for (used_by, name, soapdata) in soapdata_list: + for (objects, name, soapdata) in soapdata_list: # Only sent queries we actually need - for item in used_by: - if item in query_objects: + for entry in objects: + if entry in query_objects: break else: continue @@ -359,6 +377,8 @@ try: soapdata = soapdata.replace("###counters###", "".join(counter_data)) # Query data + if tracefile: + tracefile.write("\n\nStart query: %s\n" % name) reply_code, reply_msg, reply_headers, reply_data = query_server(soapdata) results[name] = reply_data @@ -379,16 +399,6 @@ except Exception, e: "credentials. Please check your connection settings and try " \ "again." -# Debugging -#try: -# os.mkdir("results") -#except: -# pass -# -#for name, value in results.items(): -# file("results/%s.%s" % (host, name), "w").write(value) - - if not error: try: @@ -521,7 +531,6 @@ if not error: if "virtualmachine" in query_objects: vms = {} - start = time.time() elements = get_pattern("<objects>(.*?)</objects>", results["11_virtualmachine"]) for entry in elements: vm_data = get_pattern("<name>(.*?)</name><val.*?>(.*?)</val>", entry) @@ -560,13 +569,14 @@ if not error: running_on = hostsystem_name.get(data.get("runtime.host"), data.get("runtime.host")) print "virtualmachine\t%s\t%s\t%s" % (data.get("name").replace(" ","_"), running_on, data.get("runtime.powerState")) - #print "query", query_duration - #print "processing", time.time() - start - query_duration except Exception, e: if opt_debug: raise error = "Error while processing received data" +if tracefile: + tracefile.close() + if error: sys.stderr.write(error + "\n") sys.exit(error_exit)

10 years, 11 months

Check_MK Git: check_mk: livestatus: fixed incorrect staleness value for

by Andreas Boesl

Module: check_mk Branch: master Commit: bc80ce8588dab35b9726fcb737d70aac81403039 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=bc80ce8588dab3… Author: Andreas Boesl <ab(a)mathias-kettner.de> Date: Fri Oct 11 12:29:21 2013 +0200 livestatus: fixed incorrect staleness value for check_mk snmp checks with custom check interval --- ChangeLog | 4 ++++ livestatus/src/ServiceSpecialDoubleColumn.cc | 17 +++++++++-------- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index d439fee..e2a1920 100644 --- a/ChangeLog +++ b/ChangeLog @@ -4,6 +4,10 @@ * FIX: livestatus table statehist: fixed rubbish entries whenever logfile instances got unloaded + Livestatus: + * FIX: check_mk snmp checks with a custom check interval no longer + have an incorrect staleness value + Notifications: * mkeventd: new notification plugin for forwarding notifications to the Event Console. See inline docu in share/check_mk/notification/mkeventd diff --git a/livestatus/src/ServiceSpecialDoubleColumn.cc b/livestatus/src/ServiceSpecialDoubleColumn.cc index 952a152..62804ab 100644 --- a/livestatus/src/ServiceSpecialDoubleColumn.cc +++ b/livestatus/src/ServiceSpecialDoubleColumn.cc @@ -38,16 +38,17 @@ double ServiceSpecialDoubleColumn::getValue(void *data) switch (_type) { case SSDC_STALENESS: { - bool is_cmk_passive = !strncmp(svc->check_command_ptr->name, "check_mk-", 9); - time_t check_result_age = time(0) - svc->last_check; - service *tmp_svc; + if (svc->check_interval != 0) + return check_result_age / (svc->check_interval * interval_length); - // check_mk PASSIVE CHECK: Find check-mk service and get its check interval + // check_mk PASSIVE CHECK without check interval uses + // the check interval of its check-mk service + bool is_cmk_passive = !strncmp(svc->check_command_ptr->name, "check_mk-", 9); if (is_cmk_passive) { host *host = svc->host_ptr; + service *tmp_svc; servicesmember *svc_member = host->services; - double check_interval = 1; while (svc_member != 0) { tmp_svc = svc_member->service_ptr; if (!strncmp(tmp_svc->check_command_ptr->name, "check-mk", 9)) { @@ -55,11 +56,11 @@ double ServiceSpecialDoubleColumn::getValue(void *data) } svc_member = svc_member->next; } - return 1; // Shouldnt happen! We always except check-mk service + return 1; // Shouldnt happen! We always expect a check-mk service } - else // Other non-cmk passive and active checks + else // Other non-cmk passive and active checks without check_interval { - return check_result_age / ((svc->check_interval == 0 ? 1 : svc->check_interval) * interval_length); + return check_result_age / interval_length; } } }

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #0983

by Mathias Kettner

Module: check_mk Branch: master Commit: 35e3a9a139f6627ca2963ed74dd3e0bb38d4d145 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=35e3a9a139f662… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 11 03:59:22 2013 +0200 Updated bug entries #0983 --- .bugs/983 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/983 b/.bugs/983 index b939259..6282a6f 100644 --- a/.bugs/983 +++ b/.bugs/983 @@ -1,9 +1,9 @@ Title: Multisite: cut down number of Livestatus queries Component: multisite -State: open +Class: nastiness +State: done Date: 2013-10-10 23:24:22 Targetversion: 1.2.3i3 -Class: nastiness Currently for each page one query of SET status is being done. On low-latency connections this hurts. We could either do without @@ -29,3 +29,6 @@ if "\nCache:" in request: Cache: 500 --> Sekunden Cache: reload --> Bis config reload + +2013-10-11 03:59:21: changed state open -> done +Done.

10 years, 11 months

Check_MK Git: check_mk: Enable Caching for Sidebar search

by Mathias Kettner

Module: check_mk Branch: master Commit: 42963b3b460d6a9572fe31dbb6b2aadc0c43b7bb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=42963b3b460d6a… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 11 03:55:27 2013 +0200 Enable Caching for Sidebar search --- web/htdocs/sidebar.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/web/htdocs/sidebar.py b/web/htdocs/sidebar.py index 31d5bdd..e8eece5 100644 --- a/web/htdocs/sidebar.py +++ b/web/htdocs/sidebar.py @@ -668,7 +668,7 @@ def search_livestatus(ty, q): filt.append('Or: %d\n' % (len(filt))) column = ty == 'service' and 'description' or 'name' - lq = "GET %ss\nColumns: %s\n%sLimit: %d\n" % \ + lq = "GET %ss\nCache: reload\nColumns: %s\n%sLimit: %d\n" % \ (ty, column, ''.join(filt), limit) html.live.set_prepend_site(True) data = html.live.query(lq)

10 years, 11 months

Check_MK Git: check_mk: liveproxyd: Implement caching of non-status requests (together with Multisite)

by Mathias Kettner

Module: check_mk Branch: master Commit: 5bea0156b549a701f49aa18cad9762f385ce281d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=5bea0156b549a7… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 11 03:49:35 2013 +0200 liveproxyd: Implement caching of non-status requests (together with Multisite) --- ChangeLog | 1 + doc/treasures/liveproxy/liveproxyd | 101 ++++++++++++++++++++++------ web/htdocs/config.py | 2 + web/htdocs/index.py | 5 ++ web/htdocs/livestatus.py | 28 ++++++-- web/htdocs/wato.py | 11 ++- web/plugins/views/filters.py | 10 +-- web/plugins/wato/check_mk_configuration.py | 1 + 8 files changed, 125 insertions(+), 34 deletions(-) Diff: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commitdiff;h=5bea0156b5…

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #0983

by Mathias Kettner

Module: check_mk Branch: master Commit: c66a942015572b64edef23933b45c5bba8cd0c32 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c66a942015572b… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Fri Oct 11 01:17:11 2013 +0200 Updated bug entries #0983 --- .bugs/983 | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.bugs/983 b/.bugs/983 index 6e8d41d..b939259 100644 --- a/.bugs/983 +++ b/.bugs/983 @@ -15,3 +15,17 @@ with a cached result. Also we should cache queries needed for the search filters that are contained in many views. The caching could be done by the livproxyd. + +The caching should take into account if the core has been +changed its configuration. For example the list of check +commands, host groups and stuff can only change due to +a configuration reload. So we can safely cache such a query. + +Question is, how the proxy could know that it should cache. +A new Cache: header? But then the proxy would need to parse +the headers completely. Or we simply make a: +if "\nCache:" in request: + .... + +Cache: 500 --> Sekunden +Cache: reload --> Bis config reload

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #0983

by Mathias Kettner

Module: check_mk Branch: master Commit: 15c8820707bbab924e8c21472de4287d214d5e12 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=15c8820707bbab… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Oct 10 23:32:34 2013 +0200 Updated bug entries #0983 --- .bugs/983 | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/.bugs/983 b/.bugs/983 new file mode 100644 index 0000000..6e8d41d --- /dev/null +++ b/.bugs/983 @@ -0,0 +1,17 @@ +Title: Multisite: cut down number of Livestatus queries +Component: multisite +State: open +Date: 2013-10-10 23:24:22 +Targetversion: 1.2.3i3 +Class: nastiness + +Currently for each page one query of SET status is being done. +On low-latency connections this hurts. We could either do without +that or let liveproxyd cache that kind of query. We could make +the Heartbeat of the liveproxyd query exactly the same columns +as Multisite needs for its status-query and then simply answer +with a cached result. + +Also we should cache queries needed for the search filters that +are contained in many views. The caching could be done by +the livproxyd.

10 years, 11 months

Check_MK Git: check_mk: Updated draft for rule based notifications

by Mathias Kettner

Module: check_mk Branch: master Commit: 875f48ee6d52eeee5b2fdc5d8a86040380cb032a URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=875f48ee6d52ee… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Thu Oct 10 21:46:37 2013 +0200 Updated draft for rule based notifications --- doc/drafts/LIESMICH.rule_based_notifications | 2 + doc/drafts/README.rule_based_notifications | 74 ++++++++++++++++++++++++++ 2 files changed, 76 insertions(+) diff --git a/doc/drafts/LIESMICH.rule_based_notifications b/doc/drafts/LIESMICH.rule_based_notifications index 89d3254..ca2c751 100644 --- a/doc/drafts/LIESMICH.rule_based_notifications +++ b/doc/drafts/LIESMICH.rule_based_notifications @@ -178,3 +178,5 @@ wurde. Bei der Konfigerzeugung für Nagios/CMC muss man einen speziellen Benutzer anlegen, der für alles Kontakt ist. +===> ACHTUNG: Es gibt jetzt ein englisches Dokument, das etwas aktueller +ist und auch noch etwas zu den Bulk-Notifications schreibt. diff --git a/doc/drafts/README.rule_based_notifications b/doc/drafts/README.rule_based_notifications index 49f5775..169a81e 100644 --- a/doc/drafts/README.rule_based_notifications +++ b/doc/drafts/README.rule_based_notifications @@ -187,3 +187,77 @@ or not (presumed you have a high enough log level). During the configuration generation for Nagios/CMC a special user needs to be created who is contact for everything. + + +BULK NOTIFICATIONS +------------------ +The idea of "bulk notifications" or "notification aggregation" is to cut +down the number of notifications in cases where some general problem causes +hundreds or thousands of similar alerts at the same time. In some cases this +problem can be tackled with Nagios "service dependencies". The problem is +that this is very tedious to configure and includes the risk of blocking +critical notification per mistake. + +The bulk notification feature would collect all notifications of the same +channel and target user for a certain time into a pool and then send *one* +notification email/sms/whatever that contains all those notifications. A +typical time frame of such a pooling could be 1 minute. Assuming that your +check period is one minute, that would mean that all alerts that origin from +the same problem would be packed into one single notification. + +In order to make you not blind to *other* problems that happen during such a +burst of alerts the pooling could be done on a per-checktype or per-hostgroup +or per-whatever base. It also could take the service level of objects into +account so that e.g. all alerts of the level "Tier 3" is bulked by 5 minutes, +the alerts of "Tier 1" would not be bulked by sent independently. + +The configuration of the notification aggregation could be done as a parameter +to the notification rules. Example: + +Condition: +- Service Level <= 10 (Tier 3) + +Notification: +- Send to all configured monitoring contacts +- Send via Email + +Aggregation: +- Aggregate up to 2 minutes +- Aggregate by check type + +Possible options for the aggregation: + - time range (e.g. collect notifications up to 2 minutes) + - force separate notifications for different + [ ] hosts + [ ] check types + [ ] states (WARN, CRIT, etc.) + [ ] service descriptions + [ ] service levels + + +OVERRIDING +---------- +If there is a global rule that configures a notification without aggregation, +then a later rule can override that and add an aggregation. That way a user +can enable bulk notifications for otherwise un-bulked ones. + +Vice versa: if in a rule notifications are aggregated and a later rule +(e.g. one of a user) has aggregation disabled, that setting has precedence. + +IMPLEMENTATION +-------------- +In order to send bulk notifications the notification plugin +API needs to be extended. Currently each plugin expects information +about *one* alert only in environment varibles like +NOTIFY_HOSTNAME and NOTIFY_HOSTSTATE. A plugin supporting +bulk notifications would need another API allowing to handle +a *list* of such alerts. Instead of environment variable we +could have the plugin reading lines like +NOTIFY_HOSTNAME=foo +NOTIFY_HOSTATE=2 + +A plugin should tell Check_MK that is using that new API by +putting some information into its first or second comment line. +That way the notification configurator can make sure that the +user can only select those plugins for bulk notification that +support it.

10 years, 11 months

← Newer
1
...
25
26
27
28
29
30
31
...
39
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2013