Checkmk git commits October 2013

checkmk-commits@lists.checkmk.com

6 participants
384 discussions

Check_MK Git: check_mk: FIX: continue inventory, if one check does not support it

by Mathias Kettner

Module: check_mk Branch: master Commit: d3922e17d08c714b903ee649eae47db15c0c1650 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d3922e17d08c71… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Oct 14 01:01:01 2013 +0200 FIX: continue inventory, if one check does not support it --- ChangeLog | 1 + modules/check_mk.py | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index fcf96ea..bd166d5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -2,6 +2,7 @@ Core: * FIX: inventory check now honors settings for exit code * FIX: avoid exception nodes of cluster have different agent type + * FIX: continue inventory, if one check does not support it Multisite: * Speed-O-Meter: now measure only service checks. Host checks diff --git a/modules/check_mk.py b/modules/check_mk.py index 990303f..9602144 100755 --- a/modules/check_mk.py +++ b/modules/check_mk.py @@ -381,8 +381,9 @@ except Exception, e: # those checks that do not support inventory. It must be known before # we read in all the checks def no_inventory_possible(checkname, info): - sys.stderr.write("Sorry. No inventory possible for check type %s.\n" % checkname) - sys.exit(3) + if opt_verbose: + sys.stdout.write("%s does not support inventory. Skipping it.\n" % checkname) + return [] # +----------------------------------------------------------------------+

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #0896

by Mathias Kettner

Module: check_mk Branch: master Commit: 59f4c6e2ad93a269c7b372cf7a8b3ebaa1d157bf URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=59f4c6e2ad93a2… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Oct 13 21:45:53 2013 +0200 Updated bug entries #0896 --- .bugs/896 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.bugs/896 b/.bugs/896 index 51934e3..8fe5b41 100644 --- a/.bugs/896 +++ b/.bugs/896 @@ -1,10 +1,14 @@ Title: Perf-O-Meter of oracle_tablespaces broken Component: checks -State: open +Class: bug +State: works4me Date: 2013-06-26 11:59:45 Targetversion: 1.2.3 -Class: bug Perfdata is e.g. size=709911117824;652298158080;688536944640;; used=663243390976;;;; max_size=724775731200;;;; Checkouput look OK (size 661.16GB, used 617.69GB, max 675.00GB) Perfometer show 709911117824% + +2013-10-13 21:42:58: changed state open -> works4me +Everything seems to be in perfect order here. Also +tests are flawless.

10 years, 11 months

Check_MK Git: check_mk: Speed-O-Meter: now measure only service checks.

by Mathias Kettner

Module: check_mk Branch: master Commit: 1160d132e254f076a0afb6157b3fa9ad76690f4d URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=1160d132e254f0… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Oct 13 18:44:35 2013 +0200 Speed-O-Meter: now measure only service checks. --- ChangeLog | 5 +++++ web/htdocs/sidebar.py | 17 ++++++----------- web/plugins/sidebar/shipped.py | 8 ++++---- 3 files changed, 15 insertions(+), 15 deletions(-) diff --git a/ChangeLog b/ChangeLog index 521484e..7d15bf5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,9 @@ 1.2.3i5: + Multisite: + * Speed-O-Meter: now measure only service checks. Host checks + are omitted, since they do not really matter and make the + results less useful when using CMC. + WATO: * You can now have site-specific global settings when using distributed WATO (available in the "Distributed Monitoring") diff --git a/web/htdocs/sidebar.py b/web/htdocs/sidebar.py index e8eece5..e134dc9 100644 --- a/web/htdocs/sidebar.py +++ b/web/htdocs/sidebar.py @@ -440,9 +440,9 @@ def ajax_speedometer(): # Get the current rates and the program start time. If there # are more than one site, we simply add the start times. data = html.live.query_summed_stats("GET status\n" - "Columns: service_checks_rate host_checks_rate program_start") - current_rate = data[0] + data[1] - program_start = data[2] + "Columns: service_checks_rate program_start") + current_rate = data[0] + program_start = data[1] # Recompute the scheduled_rate only if it is not known (first call) # or if one of the sites has been restarted. The computed value cannot @@ -451,16 +451,11 @@ def ajax_speedometer(): # scheduled checks rate needs to loop over all hosts and services. if last_program_start != program_start: - # 1. First compute number of expected host checks per second - scheduled_rate = html.live.query_summed_stats( - "GET hosts\n" - "Stats: suminv check_interval\n")[0] / 60.0 - - # 2. Now get data of all active services and of passive/non-check_mk-services. + # 1. Get data of all active services and of passive/non-check_mk-services. # For passive services we assume that they are scheduled with the rate the # is configured via "check_interval". Nagios does not use this setting for i # passive checks, but we have no other option. - scheduled_rate += html.live.query_summed_stats( + scheduled_rate = html.live.query_summed_stats( "GET services\n" "Stats: suminv check_interval\n" "Filter: active_checks_enabled = 1\n" @@ -490,7 +485,7 @@ def ajax_speedometer(): scheduled_rate += float(num_services) / check_interval / 60.0 percentage = 100.0 * current_rate / scheduled_rate; - title = _("Scheduled check rate: %.1f/s, current rate: %.1f/s, that is " + title = _("Scheduled service check rate: %.1f/s, current rate: %.1f/s, that is " "%.0f%% of the scheduled rate" % (scheduled_rate, current_rate, percentage)) diff --git a/web/plugins/sidebar/shipped.py b/web/plugins/sidebar/shipped.py index 26adfc6..63287be 100644 --- a/web/plugins/sidebar/shipped.py +++ b/web/plugins/sidebar/shipped.py @@ -743,11 +743,11 @@ speedometer_show_speed(0, 0, 0); sidebar_snapins["speedometer"] = { - "title" : _("Speed-O-Meter"), - "description" : _("A gadget that shows your current check rate in relation to " + "title" : _("Service Speed-O-Meter"), + "description" : _("A gadget that shows your current service check rate in relation to " "the scheduled check rate. If the Speed-O-Meter shows a speed " - "of 100 percent, then all checks are being executed in exactly " - "the rate that is configured (via check_interval)"), + "of 100 percent, all service checks are being executed in exactly " + "the rate that is desired."), "render" : render_speedometer, "allowed" : [ "admin", ], "styles" : """

10 years, 11 months

Check_MK Git: check_mk: diskstat: removed (ever incorrect)

by Mathias Kettner

latency computation for Linux Message-ID: <525b46f7.xGv0qQPZ//xWH7FK%mk(a)mathias-kettner.de> User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Module: check_mk Branch: master Commit: f840e6dc9beeae219daddc0487a2898d94447437 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=f840e6dc9beeae… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Oct 13 22:18:35 2013 +0200 diskstat: removed (ever incorrect) latency computation for Linux --- ChangeLog | 3 +++ checks/.f12 | 2 +- checks/diskstat | 2 +- checks/diskstat.include | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 0dc4ccd..407761d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -4,6 +4,9 @@ are omitted, since they do not really matter and make the results less useful when using CMC. + Checks & Agents: + * diskstat: removed (ever incorrect) latency computation for Linux + WATO: * You can now have site-specific global settings when using distributed WATO (available in the "Distributed Monitoring") diff --git a/checks/.f12 b/checks/.f12 index 5e1a7fa..57202fb 100644 --- a/checks/.f12 +++ b/checks/.f12 @@ -1,5 +1,5 @@ #!/bin/bash -SITE=${SITE:-$(cat ../.site)} +SITE=${SITE:-$(cat ../.site 2>/dev/null || true)} SITE=${SITE:-$(omd sites --bare | head -n 1)} sudo rsync -ar --delete-after ./ /omd/sites/$SITE/share/check_mk/checks/ diff --git a/checks/diskstat b/checks/diskstat index 84d3039..41f4d3a 100644 --- a/checks/diskstat +++ b/checks/diskstat @@ -131,7 +131,7 @@ def linux_diskstat_convert(info): int(l[9]), int(l[3]), int(l[7]), - int(l[12]) + # int(l[12]) ) for l in info[1:] if len(l) >= 13 ] diff --git a/checks/diskstat.include b/checks/diskstat.include index 5f68c3b..0afe294 100644 --- a/checks/diskstat.include +++ b/checks/diskstat.include @@ -30,7 +30,7 @@ diskstat_default_levels = { # "read" : (10, 20), # MB/sec # "write" : (20, 40), # MB/sec # "average" : 15, # min -# "latency" : (10, 20), # ms +# "latency" : (10, 20), # ms # "latency_perfdata" : True, }

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #0889

by Mathias Kettner

Module: check_mk Branch: master Commit: d1737ae555fe9e6ddcc948686f349443166f51c1 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d1737ae555fe9e… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Oct 14 00:19:58 2013 +0200 Updated bug entries #0889 --- .bugs/889 | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.bugs/889 b/.bugs/889 index e8d43d6..1d627f9 100644 --- a/.bugs/889 +++ b/.bugs/889 @@ -1,6 +1,6 @@ Title: unify CPU load checks, avoid incompatible check parameters Component: checks -State: open +State: done Date: 2013-03-25 11:23:06 Targetversion: 1.4.0 Class: bug @@ -8,3 +8,9 @@ Class: bug Several checks are in the group "cpu_load". All these checks need to support predecitve levels by using get_levels(). Resolution: work with an include file that does the actual checking. + +2013-10-13 23:48:43: changed state open -> done +All three CPU load checks now use a new include file. + +2013-10-14 00:19:48: changed state done -> done +Found yet more of those and fixed them.

10 years, 11 months

Check_MK Git: check_mk: Fix WATO rule for inventory checks

by Mathias Kettner

Module: check_mk Branch: master Commit: ac5470af22264a6ec3f190cd4014512b2e196e2b URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=ac5470af22264a… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Mon Oct 14 00:23:56 2013 +0200 Fix WATO rule for inventory checks Add missing default value, fix label --- web/plugins/wato/check_mk_configuration.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/web/plugins/wato/check_mk_configuration.py b/web/plugins/wato/check_mk_configuration.py index 1cfdebf..88b360a 100644 --- a/web/plugins/wato/check_mk_configuration.py +++ b/web/plugins/wato/check_mk_configuration.py @@ -991,8 +991,9 @@ register_configvar(group, "inventory_check_interval", Optional( Integer(title = _("Do inventory check every"), - label = _("minutes"), - min_value = 1), + unit = _("minutes"), + min_value = 1, + default_value = 120), title = _("Enable regular inventory checks"), help = _("If enabled, Check_MK will create one additional check per host " "that does a regular check, if the inventory would find new services "

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #0902

by Mathias Kettner

Module: check_mk Branch: master Commit: 8e23bcae3ad5c367291827c75c042b109d3f6231 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8e23bcae3ad5c3… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Oct 13 21:48:07 2013 +0200 Updated bug entries #0902 --- .bugs/902 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.bugs/902 b/.bugs/902 index 6947328..f607ed2 100644 --- a/.bugs/902 +++ b/.bugs/902 @@ -1,9 +1,9 @@ Title: Problem with check_mk notify in manually setup check_mk Component: core -State: open +Class: bug +State: done Date: 2013-03-01 12:42:36 Targetversion: 1.2.3i2 -Class: bug When enable "Debug notifications" from wato (Global settings/Noificatoins) no notification email are sent, and no debug info is written. @@ -22,3 +22,7 @@ directory needs to be created in setup.sh 2013-09-23 bs: should be fixed, added creation of directory to setup.sh but TEST IS STILL OPEN, needs to wait for 1055 to be fixed + +2013-10-13 21:48:05: changed state open -> done +We assume that it is fixed. Just the fix was not ported +to the master branch! I've done that now.

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #0795

by Mathias Kettner

Module: check_mk Branch: master Commit: c7cdea5d93499863916716970bc9c5a5440a9070 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=c7cdea5d934998… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Oct 13 21:59:39 2013 +0200 Updated bug entries #0795 --- .bugs/795 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.bugs/795 b/.bugs/795 index 654deb8..73b8f92 100644 --- a/.bugs/795 +++ b/.bugs/795 @@ -1,8 +1,12 @@ Title: mysql-Check: kleine Datenbanken immer kritisch Component: checks -State: open +Class: bug +State: done Date: 2012-10-18 16:39:13 Targetversion: future -Class: bug aber nichtsdestotrotz laufen kleine MySQL DB's mit 0.00GB auf Fehler. + +2013-10-13 21:59:36: changed state open -> done +Kann ich nicht nachvollziehen. Scheint inzwischen durch einen generellen +Umbau des Checks behoben sein.

10 years, 11 months

Check_MK Git: check_mk: fixing notifications: /var/lib/check_mk/ notify directory is now created correctly during setup from tgz file. ( Without it notifications did not get sent out.)

by Bernd Stroessenreuther

Module: check_mk Branch: master Commit: 8d8c609a146b8c4748ae82eb74059792da249776 URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=8d8c609a146b8c… Author: Bernd Stroessenreuther <bs(a)mathias-kettner.de> Date: Mon Sep 23 15:07:54 2013 +0200 fixing notifications: /var/lib/check_mk/notify directory is now created correctly during setup from tgz file. (Without it notifications did not get sent out.) --- ChangeLog | 3 +++ scripts/setup.sh | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7d15bf5..0dc4ccd 100644 --- a/ChangeLog +++ b/ChangeLog @@ -485,6 +485,9 @@ * FIX: check_dns: parameter -A does not get an additional string * FIX: diskstat: Fixed wrong values for IO/s computation on linux hosts * FIX: blade_healts: Fixed wrong index checking resulting in exceptions + * FIX: notifications: /var/lib/check_mk/notify directory is now created + correctly during setup from tgz file. (Without it notifications + did not get sent out.) Multisite: * FIX: LDAP: Disabling use of referrals in active directory configuration diff --git a/scripts/setup.sh b/scripts/setup.sh index 696f62e..76d8392 100755 --- a/scripts/setup.sh +++ b/scripts/setup.sh @@ -812,9 +812,9 @@ do sed -ri 's@^export MK_LIBDIR="(.*)"@export MK_LIBDIR="'"$agentslibdir"'"@' $agent sed -ri 's@^export MK_CONFDIR="(.*)"@export MK_CONFDIR="'"$agentsconfdir"'"@' $agent done && - mkdir -p $DESTDIR$vardir/{autochecks,counters,precompiled,cache,logwatch,web,wato} && + mkdir -p $DESTDIR$vardir/{autochecks,counters,precompiled,cache,logwatch,web,wato,notify} && if [ -z "$DESTDIR" ] && id "$nagiosuser" > /dev/null 2>&1 && [ $UID = 0 ] ; then - chown -R $nagiosuser $DESTDIR$vardir/{counters,cache,logwatch} + chown -R $nagiosuser $DESTDIR$vardir/{counters,cache,logwatch,notify} chown $nagiosuser $DESTDIR$vardir/web fi && mkdir -p $DESTDIR$confdir/conf.d &&

10 years, 11 months

Check_MK Git: check_mk: Updated bug entries #0829

by Mathias Kettner

Module: check_mk Branch: master Commit: 207e68c8723336349e309c8f9fcf10cf6f5251bb URL: http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=207e68c8723336… Author: Mathias Kettner <mk(a)mathias-kettner.de> Date: Sun Oct 13 22:19:00 2013 +0200 Updated bug entries #0829 --- .bugs/829 | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.bugs/829 b/.bugs/829 index ee785b3..1b23478 100644 --- a/.bugs/829 +++ b/.bugs/829 @@ -1,10 +1,13 @@ Title: Diskstat latency at many times on 1.0ms Component: checks -State: open +Class: bug +State: done Date: 2013-08-20 12:48:52 Targetversion: future -Class: bug The graph for diskstat latency show on many times a latency from 1.0ms. But this is the wrong value. Compared to the ios graph, it seems possible that 1.0ms really is 0ms. There is a screenshot in owncloud://Technik/BUGs + +2013-10-13 22:18:58: changed state open -> done +Removed latency computation for Linux diskstat. It was ever incorrect.

10 years, 11 months

← Newer
1
...
22
23
24
25
26
27
28
...
39
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Checkmk git commits October 2013