Branch: refs/heads/master
Home:
https://github.com/Checkmk/checkmk
Commit: 8489158ef33935efe34176a839b0d4f6cd7cfd13
https://github.com/Checkmk/checkmk/commit/8489158ef33935efe34176a839b0d4f6c…
Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M cmk/base/config.py
M cmk/utils/caching.py
M tests/unit/cmk/base/test_automations_check_mk.py
M tests/unit/cmk/base/test_core_config.py
M tests/unit/cmk/base/test_core_nagios.py
M tests/unit/cmk/base/test_ip_lookup.py
Log Message:
-----------
replace partly get_config_cache with _create_config_cache
- pure function _create_config_cache is separated from the
original get_config_cache.
- pure function reset_config_cache is mandatory to create clean
environment( for testing, for example, to avoid flakiness).
This is only initial part of the fix to do things more clear and
explicit.
Reasoning: get_config_cache mutates config implicitly.
Change-Id: Ic26f7061fa72078ff6880f85e0d58c76c416da21
Commit: baa26c35e882505bd4b62b80fe70ae5f457569e0
https://github.com/Checkmk/checkmk/commit/baa26c35e882505bd4b62b80fe70ae5f4…
Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M tests/unit/cmk/base/test_discovered_labels.py
Log Message:
-----------
remove excessive config cache resetting
We do not need to reset config cache for this test
TEST: manual using custom function
Change-Id: I092a50175fd2fd1a99d1a50a37a0461f263e7490
Commit: 1a0990d4356150d12664a3d202e3c1b208d46c35
https://github.com/Checkmk/checkmk/commit/1a0990d4356150d12664a3d202e3c1b20…
Author: Sergey Kipnis <sergey.kipnis(a)checkmk.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M tests/unit/cmk/base/test_config.py
Log Message:
-----------
remove mutating get_config_cache
- use existing config_cache in Scenario
- reset existing config_cache as an expliciti and predictable action
We should not mutate config if it is not mandatory
Change-Id: I58ca8273f0b28d4809e0409c95772a0813b40aeb
Commit: 74cc0dbf08283dc6bfbd4f92787261ae86ed6f62
https://github.com/Checkmk/checkmk/commit/74cc0dbf08283dc6bfbd4f92787261ae8…
Author: Simon Jess <simon.jess(a)checkmk.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M cmk/gui/graphing/_graph_specification.py
M cmk/gui/graphing/_graph_templates.py
M cmk/gui/graphing/_utils.py
M tests/unit/cmk/gui/graphing/test_metrics_graph_template.py
Log Message:
-----------
Normalize metric definition
Change-Id: Ie41512f27698b267493c967be1308969d424ef83
Commit: e1916fe15cb1e8e998851ed4a642660390eb82bb
https://github.com/Checkmk/checkmk/commit/e1916fe15cb1e8e998851ed4a64266039…
Author: Simon Jess <simon.jess(a)checkmk.com>
Date: 2023-08-30 (Wed, 30 Aug 2023)
Changed paths:
M cmk/gui/graphing/_graph_specification.py
M cmk/gui/graphing/_utils.py
M tests/unit/cmk/gui/graphing/test_metrics_graph_template.py
Log Message:
-----------
Make MetricDefinition a dataclass
Change-Id: I2770989e6d71f108fa4a50b0125283e3f3096ace
Compare:
https://github.com/Checkmk/checkmk/compare/142eb6d5d820...e1916fe15cb1