Module: check_mk
Branch: master
Commit: e84c0d1e20f68eccb9031e7a6db2f7a76c7f3ad9
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=e84c0d1e20f68e…
Author: Konstantin Büttner <kb(a)mathias-kettner.de>
Date: Thu Sep 20 13:25:27 2018 +0200
6467 FIX jolokia_metrics.tp: Only discover services which can be checked
In some circumstances, Check_MK would discover services for which the maxThreads
value of the thread pool was missing, leading to permanently unknown services.
This has been fixed.
Change-Id: I4ac30ba799eb67bc6ed450df8ada4c2cee73aed8
---
.werks/6467 | 13 +++++++++++++
checks/jolokia_metrics | 5 +++--
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/.werks/6467 b/.werks/6467
new file mode 100644
index 0000000..6d683d6
--- /dev/null
+++ b/.werks/6467
@@ -0,0 +1,13 @@
+Title: jolokia_metrics.tp: Only discover services which can be checked
+Level: 1
+Component: checks
+Class: fix
+Compatible: compat
+Edition: cre
+State: unknown
+Version: 1.6.0i1
+Date: 1537442631
+
+In some circumstances, Check_MK would discover services for which the maxThreads
+value of the thread pool was missing, leading to permanently unknown services.
+This has been fixed.
diff --git a/checks/jolokia_metrics b/checks/jolokia_metrics
index 4709cea..c3ff118 100644
--- a/checks/jolokia_metrics
+++ b/checks/jolokia_metrics
@@ -460,8 +460,9 @@ def inventory_jolokia_metrics_tp(info):
for inst, vals in parsed.iteritems():
if vals is None:
continue # no data from agent
- for threadpool_name, _threadpool_info in vals.get('tp', {}).iteritems():
- inv.append(("%s ThreadPool %s" % (inst, threadpool_name) , {}))
+ for threadpool_name, threadpool_info in vals.get('tp', {}).iteritems():
+ if "maxThreads" in threadpool_info:
+ inv.append(("%s ThreadPool %s" % (inst, threadpool_name) ,
{}))
return inv