Module: check_mk
Branch: master
Commit: d8a11eb4a26e25217afe2d7523eef1a6d02d1d2f
URL:
http://git.mathias-kettner.de/git/?p=check_mk.git;a=commit;h=d8a11eb4a26e25…
Author: Sven Panne <sp(a)mathias-kettner.de>
Date: Tue Jun 5 09:19:16 2018 +0200
Be explicit about which pylint checks to disable, part 3.
Once again, explicit is better than implicit: Although we have an epic list
(86 entries!) of disabled checks now, we can easily tackle them step by step
now. Formerly, this was basically impossible due to a confusing mix of a
flag + some disablings + some enablings, so nobody knew exactly which checks
were actually enabled.
Next steps:
* Pick the disabled checks one by one, fixing the code on the way.
* Next best measure: Convert global disablings into local suppressions.
* Try to figure out how to parallelize pylint in our setting.
Change-Id: I138ce131bb05899dfe76222747adb1b825fa574c
---
tests/pylint/pylintrc | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/tests/pylint/pylintrc b/tests/pylint/pylintrc
index d2c1320..f4a32f0 100644
--- a/tests/pylint/pylintrc
+++ b/tests/pylint/pylintrc
@@ -12,50 +12,72 @@ persistent=yes
[MESSAGES CONTROL]
disable=
+ abstract-method,
anomalous-backslash-in-string,
+ arguments-differ,
+ attribute-defined-outside-init,
+ bad-classmethod-argument,
bad-continuation,
bad-indentation,
bad-whitespace,
bare-except,
+ blacklisted-name,
broad-except,
+ c-extension-no-member,
cell-var-from-loop,
consider-iterating-dictionary,
+ consider-merging-isinstance,
consider-using-enumerate,
consider-using-ternary,
+ cyclic-import,
deprecated-lambda,
+ duplicate-code,
+ eval-used,
+ exec-used,
expression-not-assigned,
fixme,
+ global-statement,
+ global-variable-undefined,
inconsistent-return-statements,
invalid-encoded-data,
invalid-name,
+ keyword-arg-before-vararg,
len-as-condition,
line-too-long,
+ logging-not-lazy,
misplaced-comparison-constant,
missing-docstring,
mixed-indentation,
+ multiple-imports,
multiple-statements,
no-else-return,
no-self-use,
old-style-class,
pointless-statement,
pointless-string-statement,
+ protected-access,
redefine-in-handler,
redefined-argument-from-local,
redefined-builtin,
redefined-outer-name,
reimported,
+ relative-import,
simplifiable-if-statement,
singleton-comparison,
superfluous-parens,
too-few-public-methods,
+ too-many-ancestors,
too-many-arguments,
too-many-boolean-expressions,
too-many-branches,
+ too-many-instance-attributes,
too-many-lines,
too-many-locals,
too-many-nested-blocks,
+ too-many-public-methods,
too-many-return-statements,
too-many-statements,
+ trailing-newlines,
trailing-whitespace,
ungrouped-imports,
unidiomatic-typecheck,
@@ -68,7 +90,10 @@ disable=
unused-argument,
unused-import,
unused-variable,
+ unused-wildcard-import,
useless-else-on-loop,
+ useless-super-delegation,
+ wildcard-import,
wrong-import-order,
wrong-import-position,
wrong-spelling-in-comment,